Re: [ovs-dev] [PATCH ovn v2 0/3] Arbitrary match for NAT

Thanks for the updated series Ales. After thinking about it more, I agree that we can do without the priority in the output of `ovn-nbctl lr-nat-list` on patch 2. Therefore, for the whole series: Acked-by: Mark Michelson On 5/29/24 11:56, Ales Musil wrote: This series adds the ability

Re: [ovs-dev] [PATCH ovn 3/3] northd: Use the NAT match column.

Hi Ales, I have some nitpicky findings on this. I think they can be fixed when the patch is merged, so Acked-by: Mark Michelson See below for my findings/questions. On 5/3/24 03:26, Ales Musil wrote: Use the newly added NAT match and priority column in logical flows. This allows

Re: [ovs-dev] [PATCH ovn 2/3] nb: Add support for match and priority in NAT.

Thanks Ales, I have just one question about this. I noticed that you have updated the output of `ovn-nbctl lr-nat-list` to include the match if it is configured. I'm curious if there is any utility in printing the priority as well? On 5/3/24 03:26, Ales Musil wrote: Add support for match

Re: [ovs-dev] [PATCH ovn 1/3] nothd: Unify the priority calculation for NAT flows.

Thanks Ales, it looks good to me. Acked-by: Mark Michelson On 5/3/24 03:26, Ales Musil wrote: The priority calculation was scattered in multiple places which could result in errors when the code is being updated. Move it to common function that makes it very clear how is the priority

[ovs-dev] [PATCH ovn branch-23.06 1/2] Set release date for 23.06.4.

Signed-off-by: Mark Michelson --- NEWS | 3 ++- debian/changelog | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/NEWS b/NEWS index a87cfd7ec..e98c2102c 100644 --- a/NEWS +++ b/NEWS @@ -1,5 +1,6 @@ -OVN v23.06.4 - xx xxx +OVN v23.06.4 - 09 May 2024

[ovs-dev] [PATCH ovn branch-23.09 0/2] Release patches for v23.09.4.

Mark Michelson (2): Set release date for 23.09.4. Prepare for 23.09.5. NEWS | 6 +- configure.ac | 2 +- debian/changelog | 8 +++- 3 files changed, 13 insertions(+), 3 deletions(-) -- 2.44.0 ___ dev mailing list d

[ovs-dev] [PATCH ovn branch-24.03 1/2] Set release date for 24.03.2.

Signed-off-by: Mark Michelson --- NEWS | 3 ++- debian/changelog | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/NEWS b/NEWS index ca3562425..4d16d97ff 100644 --- a/NEWS +++ b/NEWS @@ -1,5 +1,6 @@ -OVN v24.03.2 - xx xxx +OVN v24.03.2 - 09 May 2024

[ovs-dev] [PATCH ovn branch-23.09 1/2] Set release date for 23.09.4.

Signed-off-by: Mark Michelson --- NEWS | 3 ++- debian/changelog | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/NEWS b/NEWS index 97e1c41d5..5c80fa482 100644 --- a/NEWS +++ b/NEWS @@ -1,5 +1,6 @@ -OVN v23.09.4 - xx xxx +OVN v23.09.4 - 09 May 2024

[ovs-dev] [PATCH ovn branch-23.06 0/2] Release patches for v23.06.4.

Mark Michelson (2): Set release date for 23.06.4. Prepare for 23.06.5. NEWS | 6 +- configure.ac | 2 +- debian/changelog | 8 +++- 3 files changed, 13 insertions(+), 3 deletions(-) -- 2.44.0 ___ dev mailing list d

[ovs-dev] [PATCH ovn branch-23.06 2/2] Prepare for 23.06.5.

Signed-off-by: Mark Michelson --- NEWS | 3 +++ configure.ac | 2 +- debian/changelog | 6 ++ 3 files changed, 10 insertions(+), 1 deletion(-) diff --git a/NEWS b/NEWS index e98c2102c..115db073a 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,6 @@ +OVN v23.06.5 - xx xxx

[ovs-dev] [PATCH ovn branch-23.09 2/2] Prepare for 23.09.5.

Signed-off-by: Mark Michelson --- NEWS | 3 +++ configure.ac | 2 +- debian/changelog | 6 ++ 3 files changed, 10 insertions(+), 1 deletion(-) diff --git a/NEWS b/NEWS index 5c80fa482..472594d16 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,6 @@ +OVN v23.09.5 - xx xxx

[ovs-dev] [PATCH ovn branch-24.03 2/2] Prepare for 24.03.3.

Signed-off-by: Mark Michelson --- NEWS | 3 +++ configure.ac | 2 +- debian/changelog | 6 ++ 3 files changed, 10 insertions(+), 1 deletion(-) diff --git a/NEWS b/NEWS index 4d16d97ff..9e4a52f46 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,6 @@ +OVN v24.03.3 - xx xxx

[ovs-dev] [PATCH ovn branch-24.03 0/2] Release patches for v24.03.2.

Mark Michelson (2): Set release date for 24.03.2. Prepare for 24.03.3. NEWS | 6 +- configure.ac | 2 +- debian/changelog | 8 +++- 3 files changed, 13 insertions(+), 3 deletions(-) -- 2.44.0 ___ dev mailing list d

Re: [ovs-dev] [PATCH ovn v4] controller: Track individual address set constants.

On 5/7/24 02:12, Han Zhou wrote: On Mon, May 6, 2024 at 10:37 PM Ales Musil > wrote: > > > > On Mon, May 6, 2024 at 8:41 PM Han Zhou > wrote: >> >> >> >> On Thu, May 2, 2024 at 10:35 PM Ales Musil > wrote: >>

Re: [ovs-dev] [PATCH ovn v1 2/2] Add support for overlay provider networks.

Hi Numan, If you were waiting no further comments, I've now reviewed the full patch and have no comments beyond what I initially gave. On 4/23/24 12:43, num...@ovn.org wrote: From: Numan Siddique It is expected that a provider network logical switch has a localnet logical switch port in

[ovs-dev] [PATCH ovn 1/4] Inclusive language substitutions: "abort".

ages to use the new terminology. Signed-off-by: Mark Michelson --- .ci/dpdk-prepare.sh | 2 +- controller/chassis.c| 2 +- controller/ovn-controller.8.xml | 4 +-- controller/ovn-controller.c | 6 ++-- lib/inc-proc-eng.c | 38 +++-

[ovs-dev] [PATCH ovn 0/4] Inclusive language changes for OVN code.

y, as far as I could find. Mark Michelson (4): Inclusive language substitutions: "abort". Inclusive language substitutions: "master". Inclusive language substitutions: "blacklist/whitelist". Inclusive language substitutions: "sanity-check". .ci/d

[ovs-dev] [PATCH ovn 3/4] Inclusive language substitutions: "blacklist/whitelist".

te-denylist", but the old option name is still accepted in order to maintain backwards compatibility. The old option name is no longer documented, however. Signed-off-by: Mark Michelson --- NEWS | 4 ic/ovn-ic.c | 23 +---

[ovs-dev] [PATCH ovn 2/4] Inclusive language substitutions: "master".

e word "master". The text also refers to both "masters" and "slaves". In this case, changing the text could cause confusion if pacemaker uses "master" and "slave" in its user-facing options/documentation. Signed-off-by: Mark Michelson

[ovs-dev] [PATCH ovn 4/4] Inclusive language substitutions: "sanity-check".

e files. Signed-off-by: Mark Michelson --- lib/inc-proc-eng.h| 2 +- tests/ovn-northd.at | 4 ++-- utilities/ovn-nbctl.c | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/inc-proc-eng.h b/lib/inc-proc-eng.h index 68bbd8266..5bb3b8f3e 100644 --- a/lib/inc-proc-eng.h +++

Re: [ovs-dev] [PATCH ovn v3] ci: Keep the container version pinned.

Acked-by: Mark Michelson I pushed this to main and branch-24.03. On 4/30/24 10:44, Ales Musil wrote: The Ubuntu 24.04 brought some issues that are not really straight forward to fix. Keep the Ubuntu version on 22.04 for now to keep the CI working. At the same time Fedora updated Clang

Re: [ovs-dev] [PATCH ovn] lflow: Add missing sample flow.

Thank you for this Xavier, I have one minor suggestion below. It can be fixed when this is merged. Acked-by: Mark Michelson On 4/26/24 06:52, Xavier Simonart wrote: If lflow inode had to be recomputed (e.g. due to non_vif_data change), then there could be some missing sample actions

Re: [ovs-dev] [PATCH ovn v7 0/6] Correct tunnel ids exhaustion scenario.

Thanks for the update, Ihar. For the series, Acked-by: Mark Michelson On 4/26/24 13:54, Ihar Hrachyshka wrote: v2+ of the original test patch exposed a ubsan failure in port tunnel id allocation code when tunnel id space is exhausted. This series fixes the ubsan failure (patches 1-2

Re: [ovs-dev] [PATCH ovn v1 2/2] Add support for overlay provider networks.

Hi Numan, I haven't done a full review of this yet, but I figured I'd give some initial feedback from what I had looked at. At a high level, this is missing documentation in ovn-nb.xml for the new "overlay_provider_network" option. There should also be a NEWS entry for the new

Re: [ovs-dev] [PATCH ovn v6 4/6] northd: Delete pb if tunnel is not allocated.

On 4/11/24 21:57, Ihar Hrachyshka wrote: This allows callers to avoid cleanup of the record in case the function fails. Signed-off-by: Ihar Hrachyshka --- northd/northd.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/northd/northd.c b/northd/northd.c index

Re: [ovs-dev] [PATCH ovn 0/4] Mac cache handling refactor

Hi Ales, thanks for this. I always like a change that results in a net loss of lines of code :) For the series, Acked-by: Mark Michelson On 4/22/24 03:35, Ales Musil wrote: There were two modules in controller mac_cache and mac-learn, both of them did very similar thing with pretty big

Re: [ovs-dev] [PATCH ovn v3 1/2] ci: Make sure that multinode test runs on correct branch.

This looks good to me. Thanks Ales. Acked-by: Mark Michelson On 4/10/24 09:29, Ales Musil wrote: The ovn-fake-multinode workflow can be triggered manually, however the definition didn't respect the branch for the manual run and always used main branch. Make sure that the correct branch

Re: [ovs-dev] [PATCH ovn v3 2/2] northd, controller: Use paused controller action for packet buffering.

Hi Ales, I have a couple of notes below. On 4/10/24 09:29, Ales Musil wrote: The current packet injection loses ct_state in the process. When the ct_state is lost we might commit to DNAT zone and perform zero SNAT after the packet injection. This causes the first session to be wrong as the

[ovs-dev] [PATCH ovn] ovn-nbctl: Document "--portrange" in the manpage.

The --portrange option was added in commit [0]. The option appears in the help text for ovn-nbctl, but it is not documented in the manpage at all. This commit adds documentation to the manpage for the --portrange option. Reported-at: https://issues.redhat.com/browse/FDP-537 Signed-off-by: Mark

Re: [ovs-dev] [PATCH ovn] northd: Fix BFD for policy routing.

Hi Lorenzo, This looks good to me. Thanks for fixing this! Acked-by: Mark Michelson On 4/6/24 06:32, Lorenzo Bianconi wrote: Fix the following ovn-controller error when bfd policy routing has just one available next-hop. lflow|WARN|error parsing actions "reg8[0..15] = 1; reg8[1

Re: [ovs-dev] [PATCH ovn v2 2/2] missed during test simplification.

Thanks Jacob and Ales. I fixed the subject line and fixed the typo below (as well as s/referances/references/) and pushed both patches in the series to main. On 3/28/24 05:04, Ales Musil wrote: On Tue, Mar 26, 2024 at 5:32 PM Jacob Tanenbaum wrote: Hi Jacob, thank you for the v2. As 0-day

Re: [ovs-dev] [PATCH ovn v2] acl-log: Properly log the "pass" verdict.

Thanks for the review Ales. I merged this to main and all branches down to 23.06. On 3/26/24 02:26, Ales Musil wrote: On Mon, Mar 25, 2024 at 6:48 PM Mark Michelson <mailto:mmich...@redhat.com>> wrote: The "pass" verdict was not explicitly defined in the list of v

Re: [ovs-dev] [PATCH ovn] tests: Add macro for checking flows after recompute.

Hi Xavier, the patch looks good, but I have one question down below. On 3/26/24 07:56, Xavier Simonart wrote: The macro CHECK_FLOWS_AFTER_RECOMPUTE dumps the Openflows, then recomputes, then dumps again the Openflows, and finally compares both sets of flows. The test fails if flows are

Re: [ovs-dev] [PATCH ovn] automake: Make system tests dependent of ovn-macro.

Thank you Xavier and Ales. I pushed this change to main and all branches back to 23.06. On 3/28/24 04:37, Ales Musil wrote: On Tue, Mar 26, 2024 at 12:56 PM Xavier Simonart wrote: So system testsuite will be recompiled when ovn-macro is changed. Signed-off-by: Xavier Simonart ---

Re: [ovs-dev] [PATCH ovn] controller: change dns resolution to async.

Thanks Naveen, Aside from what 0-day robot pointed out, Acked-by: Mark Michelson On 4/3/24 07:29, Naveen Yerramneni wrote: Currently DNS resolution is a blocking call in OVN controller. If DNS server is not reachable for any reason then, ovn-controller thread blocks for longer time and other

Re: [ovs-dev] [PATCH ovn] ovn-ctl: Use the current user for default file permissions.

Thanks Ales, Acked-by: Mark Michelson On 3/25/24 06:40, Ales Musil wrote: The ovn-ctl utility was assuming that the user/group is always root, when not specified otherwise by the --ovn-user/--ovn-group options. This has the consequence of trying to change permissions of OVN directories

Re: [ovs-dev] [PATCH ovn v2] controller: Allow br-int connection via other methods.

Hi Ales, The patch looks good to me except for one problem. On 4/3/24 04:53, Ales Musil wrote: The br-int connection is hardcoded to use unix socket, which requires for the socket to be visible for ovn-controller. This is achievable in container by mounting the socket, but in turn the

Re: [ovs-dev] [PATCH ovn] northd: fix infinite loop in ovn_allocate_tnlid()

to 22.03. Regards, Dumitru On 4 Apr 2024, at 18:26, Dumitru Ceara wrote: On 4/1/24 16:27, Mark Michelson wrote: Thanks Vladislav, Acked-by: Mark Michelson mailto:mmich...@redhat.com>> Thanks, Vladislav and Mark! Applied to main and backported down to 23.06 with a minor test change,

Re: [ovs-dev] [PATCH ovn v2 3/3] ofctrl: Introduce ecmp_nexthop_monitor.

Hi Lorenzo, The code looks fine to me, but I'm a bit confused by the new test. My understanding of the new feature is that each ECMP nexthop has an ID associated with it. This ID gets placed in the ct.label. If the ECMP route is removed, then we can find the associated ID, and remove the

Re: [ovs-dev] [PATCH ovn] ovn-controller.at: Fix flaky test "ofctrl wait before clearing flows".

Thanks for the fix, Han. Acked-by: Mark Michelson On 4/4/24 02:47, Han Zhou wrote: Fixes: bbf2f941965a ("ofctrl: Wait at S_WAIT_BEFORE_CLEAR only once.") Signed-off-by: Han Zhou --- tests/ovn-controller.at | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-)

Re: [ovs-dev] [PATCH ovn v2 3/3] pinctrl: Fixed 100% cpu on ovs connection loss.

Thanks Xavier and Ales. I pushed this to main and all branches back to branch-23.06. On 3/28/24 04:50, Ales Musil wrote: On Tue, Mar 26, 2024 at 12:55 PM Xavier Simonart wrote: This issue is happening for instance when running test "ovn-controller - Chassis other_config". Signed-off-by:

Re: [ovs-dev] [PATCH ovn v2 2/3] pinctrl: Fix missing MAC_Bindings.

Thanks Xavier and Ales. I addresed Ales's finding and pushed this to main and all branches back to branch-23.06. On 3/28/24 04:48, Ales Musil wrote: On Tue, Mar 26, 2024 at 12:55 PM Xavier Simonart wrote: Pinctrl is responsible of creating MAC_Bindings on peer router datapaths. However,

Re: [ovs-dev] [PATCH ovn v2 1/3] tests: Add macros to pause controller updates.

Thanks Xavier and Ales. I addresed Ales's finding and pushed this to main and all branches back to branch-23.06. On 3/28/24 04:48, Ales Musil wrote: On Tue, Mar 26, 2024 at 12:55 PM Xavier Simonart wrote: Such macros can then be used for instance to create condition where sb is seen as

Re: [ovs-dev] [PATCH ovn] controller: Allow br-int connection via other methods.

On 4/2/24 01:50, Ales Musil wrote: On Mon, Apr 1, 2024 at 10:36 PM Mark Michelson <mailto:mmich...@redhat.com>> wrote: Hi Ales, I have some high-level suggestions/questions. Hi Mark, thank you for the discussion. 1) The units for the probe interval should be mil

Re: [ovs-dev] [PATCH ovn] controller: Allow br-int connection via other methods.

Hi Ales, I have some high-level suggestions/questions. 1) The units for the probe interval should be milliseconds. All other configurable probe intervals use milliseconds, as far as I can tell. I realize the rconn API in OVS uses seconds, but all *configuration* I could find uses

Re: [ovs-dev] [PATCH ovn] northd, controller: Use paused controller action for packet buffering.

Thanks Ales, This looks good to me. Acked-by: Mark Michelson On 3/28/24 03:54, Ales Musil wrote: The current packet injection loses ct_state in the process. When the ct_state is lost we might commit to DNAT zone and perform zero SNAT after the packet injection. This causes the first session

Re: [ovs-dev] [PATCH ovn] northd: fix infinite loop in ovn_allocate_tnlid()

Thanks Vladislav, Acked-by: Mark Michelson On 4/1/24 08:15, Vladislav Odintsov wrote: In case if all tunnel ids are exhausted, ovn_allocate_tnlid() function iterates over tnlids indefinitely when *hint is outside of [min, max]. This is because when tnlid reaches max, next tnlid is min

Re: [ovs-dev] [PATCH ovn v2] ofctrl: Wait at S_WAIT_BEFORE_CLEAR only once.

Thanks Han, Acked-by: Mark Michelson On 3/28/24 02:58, Han Zhou wrote: The ovn-ofctrl-wait-before-clear setting is designed to minimize downtime during the initial start-up of the ovn-controller. For this purpose, the ovn-controller should wait only once upon entering the S_WAIT_BEFORE_CLEAR

Re: [ovs-dev] [PATCH ovn v3 6/8] utilities/docker: Fix up container build.

On 3/25/24 05:09, Ales Musil wrote: On Mon, Mar 25, 2024 at 9:47 AM Dumitru Ceara <mailto:dce...@redhat.com>> wrote: On 3/22/24 19:34, Mark Michelson wrote: > On 3/21/24 19:15, Dumitru Ceara wrote: >> Most of the steps were inaccurate.  Instead, use

[ovs-dev] [PATCH ovn v2] acl-log: Properly log the "pass" verdict.

ontroller. Reported-at: https://issues.redhat.com/browse/FDP-442 Signed-off-by: Mark Michelson --- lib/acl-log.c | 4 +++- lib/acl-log.h | 1 + lib/actions.c | 2 ++ tests/ovn.at | 3 +++ 4 files changed, 9 insertions(+), 1 deletion(-) diff --git a/lib/acl-log.c b/lib/acl-log.c index 9530dd763..b3eb4bbd0 100644

Re: [ovs-dev] [PATCH ovn v3 6/8] utilities/docker: Fix up container build.

On 3/21/24 19:15, Dumitru Ceara wrote: Most of the steps were inaccurate. Instead, use latest Ubuntu, use OVS from the submodule inside the OVN repo. Signed-off-by: Dumitru Ceara --- utilities/docker/Makefile | 4 ++-- utilities/docker/debian/Dockerfile | 2 +-

Re: [ovs-dev] [PATCH ovn v3 0/8] Various treewide fixes.

I had a look through all the patches. For the entire series: Acked-by: Mark Michelson I also have a question on patch 6 if you don't mind having a look there. On 3/21/24 19:15, Dumitru Ceara wrote: Some of these have been missed when: - splitting from OVS - moving to using OVS as a submodule

Re: [ovs-dev] [PATCH ovn] controller: Fix ofctrl memory usage underflow.

Thanks Ales, looks good to me. Acked-by: Mark Michelson On 3/19/24 11:57, Ales Musil wrote: The memory usage would be increased for size of sb_addrset_ref struct, but decreased for the size of the struct + the name. That would slowly lead to underflows in some cases. Reported-at: https

Re: [ovs-dev] [Patch ovn] docs: Remove ref. to "ovn-sbctl --no-wait".

On 3/20/24 06:23, Ales Musil wrote: On Wed, Mar 13, 2024 at 5:40 PM Martin Kalcok wrote: Couple places in the documentation reference "--wait" and "--no-wait" options for "ovn-sbctl" but it doesn't support these options [0]. Trying, for example, "ovn-sbctl --no-wait init" exits with:

Re: [ovs-dev] [PATCH ovn branch-22.03] tests: Add helper for tcpdump.

Hi Ales, thanks for providing this patch. However, branch-22.03 is now in maintenance mode. It only is receiving patches for security issues and other high-severity issues. I'm not planning to merge this, but if there is a good reason that we should, I'm willing to hear it. On 3/20/24 06:13,

Re: [ovs-dev] [PATCH ovn branch-23.09 1/2] tests: Add helper for tcpdump.

Thanks Ales, I pushed this and patch 2 to branch-23.09. On 3/20/24 06:16, Ales Musil wrote: The way how tcpdump was called in tests was inconsistent, a lot fo the tests didn't even wait for the tcpdump to properly start, some of them didn't redirect the stderr which could cause leak into the

Re: [ovs-dev] [PATCH ovn branch-23.06 1/2] tests: Add helper for tcpdump.

Thanks Ales, I pushed this and patch 2 to branch-23.06. On 3/20/24 06:59, Ales Musil wrote: The way how tcpdump was called in tests was inconsistent, a lot fo the tests didn't even wait for the tcpdump to properly start, some of them didn't redirect the stderr which could cause leak into the

Re: [ovs-dev] [PATCH ovn] Fix broken link for LTS release.

I pushed this change to main and all branches back to 23.06. On 3/18/24 13:14, Mark Michelson wrote: Thanks for finding and fixing this! Acked-by: Mark Michelson On 3/4/24 23:54, Igor Zhukov wrote: I found the broken link at https://docs.ovn.org/en/latest/internals/release-process.html. I

Re: [ovs-dev] [PATCH ovn] northd: Fix population of ipv6_ra_prefixes from IPv6 PD.

Thanks Frode, looks good to me. Acked-by: Mark Michelson On 3/18/24 07:43, Frode Nordahl wrote: The current code puts the contents of the ``ipb6_ra_pd_list`` option verbatim into the ``ipv6_ra_prefixes`` option. This does not work, because the ``ipv6_ra_pd_list`` is not an IPv6 prefix

Re: [ovs-dev] [PATCH ovn] controller: Use multicast for IPv6 Prefix Delegation.

Thanks Frode, looks good to me. Acked-by: Mark Michelson On 3/18/24 07:42, Frode Nordahl wrote: The OVN Controller currently uses unicast messages when communicating with the DHCPv6 server. This is at odds with RFC 3315 paragraph 1 in each of the sections 18.2.1, 18.2.3, 18.2.6, and 18.2.7

Re: [ovs-dev] [PATCH ovn v3 2/2] tests: Remove table numbers from "action parsing".

Thanks Xavier and Ales, I pushed both patches to main. On 3/15/24 14:07, Xavier Simonart wrote: This patch uses the recently introduced macros defining openflow table numbers. Signed-off-by: Xavier Simonart --- v2: - Handled Ales' comments (i.e. fix few remaining hard-coded numbers) -

Re: [ovs-dev] [PATCH ovn v5 0/4] Remove most of the hardcoded table numbers

Thanks for the rebase Ales. I merged the entire series to main. On 3/15/24 13:38, Ales Musil wrote: This series has the remaing patches that weren't yet accepted with addition that fixes table numbers in comments. A lot of tests were relying on exact table numbers for flow comparison either

Re: [ovs-dev] [PATCH ovn] ofctrl: Wait at S_WAIT_BEFORE_CLEAR only once.

Hi Han, I have a comment below On 3/5/24 01:27, Han Zhou wrote: The ovn-ofctrl-wait-before-clear setting is designed to minimize downtime during the initial start-up of the ovn-controller. For this purpose, the ovn-controller should wait only once upon entering the S_WAIT_BEFORE_CLEAR state

Re: [ovs-dev] [PATCH ovn] utilities: Make database connection optional for ovn-detrace.

I merged this change to main. I then evaluated about whether this should be backported to other branches and decided that yes, this should be. So I backported it to all branches back to 23.06. On 3/8/24 10:30, Mark Michelson wrote: Thanks Ales, it looks good to me. Acked-by: Mark Michelson

Re: [ovs-dev] [PATCH ovn] Fix broken link for LTS release.

Thanks for finding and fixing this! Acked-by: Mark Michelson On 3/4/24 23:54, Igor Zhukov wrote: I found the broken link at https://docs.ovn.org/en/latest/internals/release-process.html. I believe the correct link is https://www.ovn.org/en/releases/#long-term-support Signed-off-by: Igor

Re: [ovs-dev] [PATCH ovn v4] ovn-ctl: Add ssl-ciphers and protocols support.

Thanks! Acked-by: Mark Michelson I went ahead and pushed this to main. On 2/29/24 17:40, amgin...@gmail.com wrote: From: Aliasgar Ginwala Setting up OVN on new kernel bumps openssl version. Since OVS PKI infrastructure that generated older ssl certs based on old openssl version, raft fails

Re: [ovs-dev] [PATCH ovn] Update copyright year to 2024.

Thank you Igor and Ales, I pushed this to main. On 3/6/24 01:28, Ales Musil wrote: On Thu, Feb 29, 2024 at 5:43 PM Igor Zhukov wrote: I noticed the copyright year at the bottom of https://docs.ovn.org/en/latest/contents.html Signed-off-by: Igor Zhukov --- Documentation/conf.py | 2 +- 1

Re: [ovs-dev] [PATCH ovn v2] ovn-controller: Stop dropping bind_vport requests immediately after handling.

Thank you Mohammad and Ales, I pushed this to main, and all branches back to branch-23.06. On 3/6/24 01:24, Ales Musil wrote: On Mon, Feb 26, 2024 at 2:55 PM Mohammad Heib wrote: ovn-controller immediately removes the vport_bindings requests that were generated by VIFs after handling them

Re: [ovs-dev] [PATCH ovn v3] OVN-SB: Exposes igmp group protocol version through IGMP table.

Thank you Mohammad and Ales. I pushed this change to main. On 2/28/24 01:36, Ales Musil wrote: On Mon, Feb 26, 2024 at 2:11 PM Mohammad Heib wrote: Expose the igmp/mld group protocol version through the IGMP_GROUP table in SBDB. This patch can be used by ovn consumer for debuggability

Re: [ovs-dev] [PATCH ovn] northd: Fix logical router load-balancer nat rules when using DGP.

Hi Roberto, I have some concerns about this patch. Let's use the test case you added as an example network. Let's bind the vms and DGPs to hypervisors: * vm1 and lr1-ts1 are bound to hypervisor hv1 * vm2 and lr1-ts2 are bound to hypervisor hv2 Now imagine a packet arrives on lr1-ts1. The

Re: [ovs-dev] [PATCH ovn] northd: Fix NAT configuration with --add-route option for gw-router.

Thanks for this Lorenzo, looks good to me. Acked-by: Mark Michelson On 2/16/24 09:23, Lorenzo Bianconi wrote: Enable automatic static route configuration when NAT is created with --ad-route option for gw routers similar to what is currently supported for distributed routers

Re: [ovs-dev] [PATCH ovn] northd: Fix pmtud for non routed traffic.

Hi Lorenzo, Thanks for the fix. Acked-by: Mark Michelson When this is merged, the following should also be folded in: --- diff --git a/northd/ovn-northd.8.xml b/northd/ovn-northd.8.xml index 17b414144..0cf1c2bb5 100644 --- a/northd/ovn-northd.8.xml +++ b/northd/ovn-northd.8.xml @@ -338,7

Re: [ovs-dev] [PATCH ovn] tests: Fix flaky "lr multiple gw ports" test.

On 2/13/24 02:15, Ales Musil wrote: On Mon, Feb 12, 2024 at 5:27 PM Xavier Simonart wrote: The test was confused as 192.168.0.1 was configured for DR-S3 port (configured as a gateway-chassis hv4) as well as the encap_ip for hv1. Hence packets which were supposed to be sent towards hv1 got

Re: [ovs-dev] [PATCH ovn] pinctrl: Fix prefix delegation.

On 2/13/24 02:21, Ales Musil wrote: On Mon, Feb 12, 2024 at 5:12 PM Xavier Simonart wrote: Prefix delegation suffered from potential issues: - An unicast SOLICIT message was sometimes sent instead of a RENEW. - Pînctrl was sometimes not waking up as expected when timers such as T1 or T2

Re: [ovs-dev] [PATCH ovn v4 4/4] tests: Use the ovn-debug binary to determine table numbers.

Thanks Ales, Acked-by: Mark Michelson This is probably not a huge surprise given how long it has been, but this series no longer applies cleanly to main. Can you please post a rebased version of the series as a v5? Thanks! On 2/12/24 10:55, Ales Musil wrote: Use the ovn-debug commands

Re: [ovs-dev] [PATCH ovn v2 2/2] tests: Remove table numbers from "action parsing".

I tried to apply this series just now, but patch 2 fails to apply due to recent changes in tests/ovn.at in OVN main. Xavier, could you rebase and post a v3 of this series? I will merge this as soon as possible afterwards. On 2/13/24 02:39, Ales Musil wrote: On Mon, Feb 12, 2024 at 3:48 PM

Re: [ovs-dev] [PATCH ovn v3] controller: Avoid double controller action for ICMP errors.

On 2/12/24 07:00, Dumitru Ceara wrote: On 2/6/24 10:15, Ales Musil wrote: The fields that are not directly supported by OvS were encoded via additional controller action that changed the required value. This was most notably needed for ICMP need frag messages. Encode the field value loads as

[ovs-dev] [PATCH ovn branch-23.09 2/2] Prepare for 23.09.4.

Signed-off-by: Mark Michelson --- NEWS | 3 +++ configure.ac | 2 +- debian/changelog | 6 ++ 3 files changed, 10 insertions(+), 1 deletion(-) diff --git a/NEWS b/NEWS index 31c069aea..97e1c41d5 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,6 @@ +OVN v23.09.4 - xx xxx

[ovs-dev] [PATCH ovn branch-22.03 1/2] Set release date for 22.03.7.

Signed-off-by: Mark Michelson --- NEWS | 4 +++- debian/changelog | 2 +- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/NEWS b/NEWS index 6087f91d8..a28249bff 100644 --- a/NEWS +++ b/NEWS @@ -1,5 +1,7 @@ -OVN v22.03.7 - xx xxx +OVN v22.03.7 - 12 Mar 2024

[ovs-dev] [PATCH ovn branch-22.03 0/2] Release patches for v22.03.7.

Mark Michelson (2): Set release date for 22.03.7. Prepare for 22.03.8. NEWS | 7 ++- configure.ac | 2 +- debian/changelog | 8 +++- 3 files changed, 14 insertions(+), 3 deletions(-) -- 2.44.0 ___ dev mailing list d

[ovs-dev] [PATCH ovn branch-22.03 2/2] Prepare for 22.03.8.

Signed-off-by: Mark Michelson --- NEWS | 3 +++ configure.ac | 2 +- debian/changelog | 6 ++ 3 files changed, 10 insertions(+), 1 deletion(-) diff --git a/NEWS b/NEWS index a28249bff..8d92161bb 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,6 @@ +OVN v22.03.8 - xx xxx

[ovs-dev] [PATCH ovn branch-23.03 2/2] Prepare for 23.03.4.

Signed-off-by: Mark Michelson --- NEWS | 3 +++ configure.ac | 2 +- debian/changelog | 6 ++ 3 files changed, 10 insertions(+), 1 deletion(-) diff --git a/NEWS b/NEWS index b36fa42a4..9f93953db 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,6 @@ +OVN v23.03.4 - xx xxx

[ovs-dev] [PATCH ovn branch-23.06 1/2] Set release date for 23.06.3.

Signed-off-by: Mark Michelson --- NEWS | 4 +++- debian/changelog | 2 +- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/NEWS b/NEWS index 12c5e9efd..9c73ad4ec 100644 --- a/NEWS +++ b/NEWS @@ -1,7 +1,9 @@ -OVN v23.06.3 - xx xxx +OVN v23.06.3 - 12 Mar 2024

[ovs-dev] [PATCH ovn branch-23.03 1/2] Set release date for 23.03.3.

Signed-off-by: Mark Michelson --- NEWS | 4 +++- debian/changelog | 2 +- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/NEWS b/NEWS index 6caaeead1..b36fa42a4 100644 --- a/NEWS +++ b/NEWS @@ -1,7 +1,9 @@ -OVN v23.03.3 - xx xxx +OVN v23.03.3 - 12 Mar 2024

[ovs-dev] [PATCH ovn branch-23.06 2/2] Prepare for 23.06.4.

Signed-off-by: Mark Michelson --- NEWS | 3 +++ configure.ac | 2 +- debian/changelog | 6 ++ 3 files changed, 10 insertions(+), 1 deletion(-) diff --git a/NEWS b/NEWS index 9c73ad4ec..a87cfd7ec 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,6 @@ +OVN v23.06.4 - xx xxx

[ovs-dev] [PATCH ovn branch-23.03 0/2] Release patches for v23.03.3.

Mark Michelson (2): Set release date for 23.03.3. Prepare for 23.03.4. NEWS | 7 ++- configure.ac | 2 +- debian/changelog | 8 +++- 3 files changed, 14 insertions(+), 3 deletions(-) -- 2.44.0 ___ dev mailing list d

[ovs-dev] [PATCH ovn branch-23.09 0/2] Release patches for v23.09.3.

Mark Michelson (2): Set release date for 23.09.3. Prepare for 23.09.4. NEWS | 7 ++- configure.ac | 2 +- debian/changelog | 8 +++- 3 files changed, 14 insertions(+), 3 deletions(-) -- 2.44.0 ___ dev mailing list d

[ovs-dev] [PATCH ovn branch-23.06 0/2] Release patches for v23.06.3.

Mark Michelson (2): Set release date for 23.06.3. Prepare for 23.06.4. NEWS | 7 ++- configure.ac | 2 +- debian/changelog | 8 +++- 3 files changed, 14 insertions(+), 3 deletions(-) -- 2.44.0 ___ dev mailing list d

[ovs-dev] [PATCH ovn branch-24.03 2/2] Prepare for 24.03.2.

Signed-off-by: Mark Michelson --- NEWS | 3 +++ configure.ac | 2 +- debian/changelog | 6 ++ 3 files changed, 10 insertions(+), 1 deletion(-) diff --git a/NEWS b/NEWS index e91cbe43f..ca3562425 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,6 @@ +OVN v24.03.2 - xx xxx

[ovs-dev] [PATCH ovn branch-23.09 1/2] Set release date for 23.09.3.

Signed-off-by: Mark Michelson --- NEWS | 4 +++- debian/changelog | 2 +- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/NEWS b/NEWS index 58b1c9066..31c069aea 100644 --- a/NEWS +++ b/NEWS @@ -1,5 +1,7 @@ -OVN v23.09.3 - xx xxx +OVN v23.09.3 - 12 Mar 2024

[ovs-dev] [PATCH ovn branch-24.03 0/2] Release patches for v24.03.1.

Mark Michelson (2): Set release date for 24.03.1. Prepare for 24.03.2. NEWS | 7 ++- configure.ac | 2 +- debian/changelog | 8 +++- 3 files changed, 14 insertions(+), 3 deletions(-) -- 2.44.0 ___ dev mailing list d

[ovs-dev] [PATCH ovn branch-24.03 1/2] Set release date for 24.03.1.

Signed-off-by: Mark Michelson --- NEWS | 4 +++- debian/changelog | 2 +- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/NEWS b/NEWS index c66a2bc50..e91cbe43f 100644 --- a/NEWS +++ b/NEWS @@ -1,5 +1,7 @@ -OVN v24.03.1 - xx xxx +OVN v24.03.1 - 12 Mar 2024

Re: [ovs-dev] [PATCH ovn] northd: Fix NULL pointer deref within build_bfd_table.

I pushed this to main and branch-24.03. On 3/11/24 11:02, Mark Michelson wrote: Thanks for fixing the crash, and thanks for taking the extra effort to ensure BFD tests are run by CI. Acked-by: Mark Michelson On 3/11/24 10:48, Ales Musil wrote: The cb_bt pointer was pointing to different

Re: [ovs-dev] [PATCH ovn] northd: Fix NULL pointer deref within build_bfd_table.

Thanks for fixing the crash, and thanks for taking the extra effort to ensure BFD tests are run by CI. Acked-by: Mark Michelson On 3/11/24 10:48, Ales Musil wrote: The cb_bt pointer was pointing to different struct and might have been NULL at this point. Make sure we are using the correct

Re: [ovs-dev] [PATCH ovn 2/3] northd: Add nexhop id in ct_label.label.

Hi Lorenzo, Just a couple of small comments below. On 3/7/24 08:19, Lorenzo Bianconi wrote: Introduce the nexthop identifier in the ct_label.label field for ecmp-symmetric replies connections. This field will be used by ovn-controller to track ct entries and to flush them if requested by the

Re: [ovs-dev] [PATCH ovn 2/3] northd: Add nexhop id in ct_label.label.

Hi Lorenzo, Just a couple of small comments below. On 3/7/24 08:19, Lorenzo Bianconi wrote: Introduce the nexthop identifier in the ct_label.label field for ecmp-symmetric replies connections. This field will be used by ovn-controller to track ct entries and to flush them if requested by the

Re: [ovs-dev] [PATCH ovn 1/3] northd: Introduce ECMP_Nexthop table in SB db.

Hi Lorenzo, I have some comments below. On 3/7/24 08:19, Lorenzo Bianconi wrote: Introduce ECMP_Nexthop table in the SB db in order to track active ecmp-symmetric-reply connections and flush stale ones. Signed-off-by: Lorenzo Bianconi --- northd/en-northd.c | 4 ++

Re: [ovs-dev] [PATCH ovn 0/3] Introduce ECMP_nexthop monitor in ovn-controller

Hi Lorenzo, I haven't had time to review patch 3 yet, but I have made some comments on patches 1 and 2 for now. On 3/7/24 08:19, Lorenzo Bianconi wrote: Reported-at: https://issues.redhat.com/browse/FDP-56 Lorenzo Bianconi (3): northd: Introduce ECMP_Nexthop table in SB db. northd:

Re: [ovs-dev] [PATCH ovn] utilities: Make database connection optional for ovn-detrace.

Thanks Ales, it looks good to me. Acked-by: Mark Michelson On 3/5/24 01:21, Ales Musil wrote: The ovn-detrace required both connections (SB and NB) to provide some output. However, it is a valid scenario to have only one database available, usually the SB. With that in mind make

[ovs-dev] [PATCH ovn] acl-log: Properly log the "pass" verdict.

ontroller. Reported-at: https://issues.redhat.com/browse/FDP-442 Signed-off-by: Mark Michelson --- lib/acl-log.c | 4 +++- lib/acl-log.h | 1 + lib/actions.c | 2 ++ 3 files changed, 6 insertions(+), 1 deletion(-) diff --git a/lib/acl-log.c b/lib/acl-log.c index 9530dd763..b3eb4bbd0 100644 --- a/lib/acl-log.

  1   2   3   4   5   6   7   8   9   10   >