Re: [ovs-dev] [PATCH ovn branch-22.03] tests: Add helper for tcpdump.

On 3/21/24 07:15, Ales Musil wrote: > On Wed, Mar 20, 2024 at 8:37 PM Mark Michelson wrote: > >> Hi Ales, thanks for providing this patch. However, branch-22.03 is now >> in maintenance mode. It only is receiving patches for security issues >> and other high-severity issues. I'm not planning to

Re: [ovs-dev] [PATCH v3] ofproto-dpif-upcall: Try lock for udpif_key map during sweep.

ACK Thanks, Ilya. For now, update such lock movement code to the test hosts, no cores at sweep__ for 10 days. LIU Yulong On Wed, Mar 20, 2024 at 5:42 AM Ilya Maximets wrote: > > On 3/15/24 11:04, LIU Yulong wrote: > > A potential race condition happened with the following 3 threads: > > * PMD

Re: [ovs-dev] [PATCH] Rename primary development branch as main.

Bleep bloop. Greetings Simon Horman, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 110 characters long (recommended limit is 79) #377 FILE: README.rst:11: ..

[ovs-dev] [PATCH] Rename primary development branch as main.

Recently OVS adopted a policy of using the inclusive naming word list v1 [1, 2]. In keeping with this policy rename the primary development branch from 'master' to 'main'. This patch does not actually make that change, but rather updates references to the branch in the source tree. It is intended

Re: [ovs-dev] [PATCH ovn branch-22.03] tests: Add helper for tcpdump.

On Wed, Mar 20, 2024 at 8:37 PM Mark Michelson wrote: > Hi Ales, thanks for providing this patch. However, branch-22.03 is now > in maintenance mode. It only is receiving patches for security issues > and other high-severity issues. I'm not planning to merge this, but if > there is a good reason

[ovs-dev] [PATCH] Documentation: Remove references to kernel datapath in OVS tree.

The Kernel datapath is no longer present in the primary development branch of the OVS tree. Remove references to this in the documentation. Signed-off-by: Simon Horman --- Documentation/faq/releases.rst | 3 ---

Re: [ovs-dev] [PATCH] Rename primary development branch as main.

On Thu, Mar 21, 2024 at 10:09:20AM +, Simon Horman wrote: ... > diff --git a/appveyor.yml b/appveyor.yml ... > @@ -23,7 +23,7 @@ install: > New-Item -ItemType Directory -Force -Path C:\ovs-build-downloads > > # Find and download the latest stable OpenSSl 3.0. > -$URL = >

[ovs-dev] [PATCH v3] ovs-monitor-ipsec: LibreSwan autodetect paths.

In v4.0, LibreSwan changed a default paths that had been hardcoded in ovs-monitor-ipsec, breaking some uses of this script. This patch adds support for both old and newer versions by auto detecting the version of LibreSwan and then choosing the correct path. Reported-at:

Re: [ovs-dev] [PATCH] ovs-tcpdump:Solve the problem of residual mirror port

Bleep bloop. Greetings yangchang, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: The subject summary should start with a capital. WARNING: The subject summary should end

Re: [ovs-dev] [PATCH] Rename primary development branch as main.

On 3/21/24 13:32, Ilya Maximets wrote: > CC: ovs-discuss for visibility. > Thanks for the heads up, Ilya! > It seems like this change will affect ovn-fake-multinode project > and ovn-heater as they are cloning 'master' branch by default. I opened draft PRs for ovn-fake-multinode and

Re: [ovs-dev] [PATCH] Rename primary development branch as main.

CC: ovs-discuss for visibility. It seems like this change will affect ovn-fake-multinode project and ovn-heater as they are cloning 'master' branch by default. Also the OVN project itself is cloning OVS master branch in one of the CI workflows. On 3/21/24 11:09, Simon Horman wrote: > Recently

Re: [ovs-dev] [PATCH v2] route-table: Avoid routes from non-standard routing tables.

Ilya Maximets writes: > Currently, ovs-vswitchd is subscribed to all the routing changes in the > kernel. On each change, it marks the internal routing table cache as > invalid, then resets it and dumps all the routes from the kernel from > scratch. The reason for that is kernel routing

[ovs-dev] [PATCH] ovs-tcpdump:Solve the problem of residual mirror port

Before creating an mirror port, it is necessary to first check whether the original port exists. Otherwise, when the original port does not exist, the created mirror port will remain. Signed-off-by: yangchang --- utilities/ovs-tcpdump.in | 6 +++--- 1 file changed, 3 insertions(+), 3

Re: [ovs-dev] [PATCH] Documentation: Remove references to kernel datapath in OVS tree.

On 3/21/24 11:03, Simon Horman wrote: > The Kernel datapath is no longer present in the primary development > branch of the OVS tree. Remove references to this in the documentation. > > Signed-off-by: Simon Horman > --- > Documentation/faq/releases.rst | 3 --- >

Re: [ovs-dev] [PATCH ovn 2/5] Remove TODO-SPLIT.rst.

On 3/21/24 17:09, Dumitru Ceara wrote: > All the TODO items listed in it have been addressed (for a while). That's a bold statement. And I disagree. :) > OVN includes OVS as a submodule nowadays and there's a documented way > of bumping the OVS submodule version when needed. > > Signed-off-by:

Re: [ovs-dev] [PATCH v2] netdev-offload: make netdev-offload-tc work with flow-restore-wait

On 3/14/24 06:23, Han Zhou wrote: > > > On Fri, Apr 22, 2022 at 1:41 AM Eelco Chaudron > wrote: >> >> >> >> On 15 Apr 2022, at 13:25, wenx05124...@163.com >> wrote: >> >> > From: wenxu mailto:we...@chinatelecom.cn>> >> > >> > The

Re: [ovs-dev] [PATCH ovn 3/5] Documentation: Use links to OVN documentation when applicable.

On 3/21/24 17:09, Dumitru Ceara wrote: > Some of the links were still pointing to OVS although we have > OVN counterparts. > > Signed-off-by: Dumitru Ceara > --- > Documentation/intro/install/fedora.rst | 2 +- > Documentation/intro/install/rhel.rst | 2 +- > 2 files changed, 2 insertions(+),

Re: [ovs-dev] [PATCH ovn 3/5] Documentation: Use links to OVN documentation when applicable.

On 3/21/24 18:34, Ilya Maximets wrote: > On 3/21/24 17:09, Dumitru Ceara wrote: >> Some of the links were still pointing to OVS although we have >> OVN counterparts. >> >> Signed-off-by: Dumitru Ceara >> --- >> Documentation/intro/install/fedora.rst | 2 +- >>

[ovs-dev] [PATCH ovn 3/5] Documentation: Use links to OVN documentation when applicable.

Some of the links were still pointing to OVS although we have OVN counterparts. Signed-off-by: Dumitru Ceara --- Documentation/intro/install/fedora.rst | 2 +- Documentation/intro/install/rhel.rst | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git

[ovs-dev] [PATCH ovn 1/5] Documentation: Fix reference to the default branch.

Signed-off-by: Dumitru Ceara --- Documentation/intro/install/general.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/intro/install/general.rst b/Documentation/intro/install/general.rst index ab62094828..e8c312b5cb 100644 ---

[ovs-dev] [PATCH ovn 0/5] Various treewide fixes.

Some of these have been missed when: - splitting from OVS - moving to using OVS as a submodule - changing the default branch name to "main" Dumitru Ceara (5): Documentation: Fix reference to the default branch. Remove TODO-SPLIT.rst. Documentation: Use links to OVN documentation when

[ovs-dev] [PATCH ovn 2/5] Remove TODO-SPLIT.rst.

All the TODO items listed in it have been addressed (for a while). OVN includes OVS as a submodule nowadays and there's a documented way of bumping the OVS submodule version when needed. Signed-off-by: Dumitru Ceara --- Makefile.am| 1 - README.rst | 3 +- TODO_SPLIT.rst | 116

[ovs-dev] [PATCH ovn 4/5] utilities/docker: Fix up container build.

Most of the steps were inaccurate. Instead, use latest Ubuntu, use OVS from the submodule inside the OVN repo. Signed-off-by: Dumitru Ceara --- utilities/docker/Makefile | 4 ++-- utilities/docker/debian/Dockerfile | 2 +- utilities/docker/debian/build.sh | 2 ++

[ovs-dev] [PATCH ovn 5/5] tests: Add multinode-testsuite to .gitinore.

Signed-off-by: Dumitru Ceara --- tests/.gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/.gitignore b/tests/.gitignore index 65cb1c6e4f..6971b426e9 100644 --- a/tests/.gitignore +++ b/tests/.gitignore @@ -6,6 +6,7 @@ /idltest.c /idltest.h /idltest.ovsidl

Re: [ovs-dev] [PATCH ovn 2/5] Remove TODO-SPLIT.rst.

On 3/21/24 18:40, Dumitru Ceara wrote: > On 3/21/24 18:30, Ilya Maximets wrote: >> On 3/21/24 17:09, Dumitru Ceara wrote: >>> All the TODO items listed in it have been addressed (for a while). >> >> That's a bold statement. And I disagree. :) >> > > It's the only type of statements I make. :) >

Re: [ovs-dev] [PATCH ovn 2/5] Remove TODO-SPLIT.rst.

On 3/21/24 18:30, Ilya Maximets wrote: > On 3/21/24 17:09, Dumitru Ceara wrote: >> All the TODO items listed in it have been addressed (for a while). > > That's a bold statement. And I disagree. :) > It's the only type of statements I make. :) >> OVN includes OVS as a submodule nowadays and

[ovs-dev] [PATCH ovn v2 3/8] rhel: Update docs.

Remove openvswitch related left overs. Remove documentation about installation on older RHEL versions. RHEL 6.x will reach the end of its ELS, Extended Life Cycle Support on July 1st: https://access.redhat.com/articles/4665701#1-can-you-describe-the-red-hat-enterprise-linux-6-life-cycle-1

[ovs-dev] [PATCH ovn v2 4/8] treewide: Remove some of the post OVS-OVN split leftovers.

A few still remain and need to be addressed in the future. Signed-off-by: Dumitru Ceara --- Documentation/automake.mk | 1 - Documentation/index.rst | 4 +- .../internals/contributing/coding-style.rst | 6 - .../internals/contributing/index.rst

[ovs-dev] [PATCH ovn v2 6/8] Update post OVS-OVN split TODO list.

As Ilya commented in the review of the V1 of this series the statement that "all the TODO items listed in it have been addressed" is indeed "a bold statement". However quite a few don't seem applicable anymore. Signed-off-by: Dumitru Ceara --- TODO_SPLIT.rst | 73

[ovs-dev] [PATCH ovn v2 5/8] Documentation: Remove references to TravisCI.

OVN doesn't use TravisCI for a while. Instead GitHub Actions are preferred. Signed-off-by: Dumitru Ceara --- .../contributing/submitting-patches.rst | 8 ++-- Documentation/topics/testing.rst | 40 --- 2 files changed, 3 insertions(+), 45 deletions(-) diff

[ovs-dev] [PATCH ovn v2 6/8] utilities/docker: Fix up container build.

Most of the steps were inaccurate. Instead, use latest Ubuntu, use OVS from the submodule inside the OVN repo. Signed-off-by: Dumitru Ceara --- utilities/docker/Makefile | 4 ++-- utilities/docker/debian/Dockerfile | 2 +- utilities/docker/debian/build.sh | 2 ++

[ovs-dev] [PATCH ovn v2 7/8] utilities/docker: Fix up container build.

Most of the steps were inaccurate. Instead, use latest Ubuntu, use OVS from the submodule inside the OVN repo. Signed-off-by: Dumitru Ceara --- utilities/docker/Makefile | 4 ++-- utilities/docker/debian/Dockerfile | 2 +- utilities/docker/debian/build.sh | 2 ++

[ovs-dev] [PATCH ovn v2 0/8] Various treewide fixes.

Some of these have been missed when: - splitting from OVS - moving to using OVS as a submodule - changing the default branch name to "main" Changes in v2: - added more fixes - was less bold :) Dumitru Ceara (8): Documentation: Fix reference to the default branch. ovn-sandbox: Rename script

[ovs-dev] [PATCH ovn v2 1/8] Documentation: Fix reference to the default branch.

Signed-off-by: Dumitru Ceara --- Documentation/intro/install/general.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/intro/install/general.rst b/Documentation/intro/install/general.rst index ab62094828..e8c312b5cb 100644 ---

[ovs-dev] [PATCH ovn v2 7/8] tests: Add multinode-testsuite to .gitinore.

Signed-off-by: Dumitru Ceara --- tests/.gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/.gitignore b/tests/.gitignore index 65cb1c6e4f..6971b426e9 100644 --- a/tests/.gitignore +++ b/tests/.gitignore @@ -6,6 +6,7 @@ /idltest.c /idltest.h /idltest.ovsidl

Re: [ovs-dev] [PATCH] Rename primary development branch as main.

Hi, On 3/21/24 6:09 AM, Simon Horman wrote: Recently OVS adopted a policy of using the inclusive naming word list v1 [1, 2]. In keeping with this policy rename the primary development branch from 'master' to 'main'. This patch does not actually make that change, but rather updates references

Re: [ovs-dev] [PATCH ovn v2 0/8] Various treewide fixes.

On 3/22/24 00:03, Dumitru Ceara wrote: > Some of these have been missed when: > - splitting from OVS > - moving to using OVS as a submodule > - changing the default branch name to "main" > > Changes in v2: > - added more fixes > - was less bold :) > Oops, sorry for the noise, I messed up this

[ovs-dev] [PATCH ovn v3 7/8] tests: Add multinode-testsuite to .gitinore.

Signed-off-by: Dumitru Ceara --- tests/.gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/.gitignore b/tests/.gitignore index 65cb1c6e4f..6971b426e9 100644 --- a/tests/.gitignore +++ b/tests/.gitignore @@ -6,6 +6,7 @@ /idltest.c /idltest.h /idltest.ovsidl

[ovs-dev] [PATCH ovn v3 3/8] rhel: Update docs.

Remove openvswitch related left overs. Remove documentation about installation on older RHEL versions. RHEL 6.x will reach the end of its ELS, Extended Life Cycle Support on July 1st: https://access.redhat.com/articles/4665701#1-can-you-describe-the-red-hat-enterprise-linux-6-life-cycle-1

[ovs-dev] [PATCH ovn v3 4/8] treewide: Remove some of the post OVS-OVN split leftovers.

A few still remain and need to be addressed in the future. Signed-off-by: Dumitru Ceara --- Documentation/automake.mk | 1 - Documentation/index.rst | 4 +- .../internals/contributing/coding-style.rst | 6 - .../internals/contributing/index.rst

[ovs-dev] [PATCH ovn v3 8/8] Update post OVS-OVN split TODO list.

As Ilya commented in the review of the V1 of this series [0] the statement that "all the TODO items listed in it have been addressed" is indeed "a bold statement". However quite a few don't seem applicable anymore. [0] https://mail.openvswitch.org/pipermail/ovs-dev/2024-March/412704.html

[ovs-dev] [PATCH ovn v3 1/8] Documentation: Fix reference to the default branch.

Signed-off-by: Dumitru Ceara --- Documentation/intro/install/general.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/intro/install/general.rst b/Documentation/intro/install/general.rst index ab62094828..e8c312b5cb 100644 ---

[ovs-dev] [PATCH ovn v3 2/8] ovn-sandbox: Rename script from ovs-sandbox to ovn-sandbox.

Update documentation. To avoid completely duplicating the contents of the OVS repo sandbox documentation point to it instead where applicable (similar links already existed). It's probably simpler to keep a (renamed) copy of the OVS ovs-sandbox script in our repo than to use the one from the OVS

[ovs-dev] [PATCH ovn v3 0/8] Various treewide fixes.

Some of these have been missed when: - splitting from OVS - moving to using OVS as a submodule - changing the default branch name to "main" Changes in v3: - properly formatted series Changes in v2: - added more fixes - was less bold :) Dumitru Ceara (8): Documentation: Fix reference to the

[ovs-dev] [PATCH ovn v3 5/8] Documentation: Remove references to TravisCI.

OVN doesn't use TravisCI for a while. Instead GitHub Actions are preferred. Signed-off-by: Dumitru Ceara --- .../contributing/submitting-patches.rst | 8 ++-- Documentation/topics/testing.rst | 40 --- 2 files changed, 3 insertions(+), 45 deletions(-) diff

[ovs-dev] [PATCH ovn v3 6/8] utilities/docker: Fix up container build.

Most of the steps were inaccurate. Instead, use latest Ubuntu, use OVS from the submodule inside the OVN repo. Signed-off-by: Dumitru Ceara --- utilities/docker/Makefile | 4 ++-- utilities/docker/debian/Dockerfile | 2 +- utilities/docker/debian/build.sh | 2 ++

Re: [ovs-dev] [PATCH v4] netdev-dpdk: Disable outer udp checksum offload for ice driver.

On 3/21/24 04:17, Jun Wang wrote: > Fixing the issue of incorrect outer UDP checksum in packets sent by E810. > > Fixes: 084c8087292c ("userspace: Support VXLAN and GENEVE TSO.") > Reported-at: https://github.com/openvswitch/ovs-issues/issues/321 > > Signed-off-by: Jun Wang > --- >

[ovs-dev] [PATCH ovn v2 0/8] Various treewide fixes.

Some of these have been missed when: - splitting from OVS - moving to using OVS as a submodule - changing the default branch name to "main" Changes in v2: - added more fixes - was less bold :) Dumitru Ceara (8): Documentation: Fix reference to the default branch. ovn-sandbox: Rename script

[ovs-dev] [PATCH ovn v2 2/8] ovn-sandbox: Rename script from ovs-sandbox to ovn-sandbox.

Update documentation. To avoid completely duplicating the contents of the OVS repo sandbox documentation point to it instead where applicable (similar links already existed). It's probably simpler to keep a (renamed) copy of the OVS ovs-sandbox script in our repo than to use the one from the OVS

[ovs-dev] [PATCH v4] tunnel: Allow UDP zero checksum with IPv6 tunnels.

This patch adopts the proposed RFC 6935 by allowing null UDP checksums even if the tunnel protocol is IPv6. This is already supported by Linux through the udp6zerocsumtx tunnel option. It is disabled by default and IPv6 tunnels are flagged as requiring a checksum, but this patch enables the user