[ovs-dev] [PATCH] ofproto: fix stack-buffer-overflow

2019-11-28 Thread Linhaifeng
Should use flow->actions not >actions. here is ASAN report: = ==57189==ERROR: AddressSanitizer: stack-buffer-overflow on address 0x428fa0e8 at pc 0x7f61a520 bp 0x428f9420 sp 0x428f9498 READ of size 196 at

Re: [ovs-dev] [PATCH] ofproto: fix stack-buffer-overflow

2019-11-28 Thread 0-day Robot
Bleep bloop. Greetings Linhaifeng, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Author Linhaifeng needs to sign off. Lines checked: 104, Warnings: 0, Errors: 1 Please

[ovs-dev] (no subject)

2019-11-28 Thread Mavis
Herzlichen Glückwunsch, Ihre E-Mail hat 3.000.000 € gewonnen Kontakt: maviswancy...@gmail.com für Informationen / Ansprüche -- "Independencia y Patria Socialista, Viviremos y Venceremos" ___ dev mailing list d...@openvswitch.org

[ovs-dev] [PATCH] ofproto: fix stack-buffer-overflow

2019-11-28 Thread Linhaifeng
Should use flow->actions not >actions. Here is some print info for debug: @@@ flow->actions=0xb5e48844 len=196 @@@ stub=[0x7eefa120,0x7eefa918] actions->data=0x7eefa0a0 actions->size=196 actions->data != flow->actions and actions->data + 196 is in the range of stub . here is

Re: [ovs-dev] [PATCH v1 4/4] travis: Enable OVS Travis CI for arm

2019-11-28 Thread Lance Yang (Arm Technology China)
> -Original Message- > From: Ilya Maximets > Sent: Friday, November 29, 2019 3:06 AM > To: Lance Yang (Arm Technology China) ; Ilya Maximets > ; ovs-dev@openvswitch.org > Cc: Jieqiang Wang (Arm Technology China) ; Gavin Hu > (Arm > Technology China) ; Jingzhao Ni (Arm Technology

[ovs-dev] Planificación estratégica para RRHH

2019-11-28 Thread Selección y organización del talento
17 de Enero | Horario de 10:00 a 17:00 hrs. | (hora del centro de México) - Planificación estratégica del departamento de Recursos Humanos. - ¿De qué hablaremos? A través de este webinar se revisarán todas aquellas funciones y responsabilidades del área de Recursos Humanos desde un enfoque

[ovs-dev] Detección de Necesidades de Capacitación

2019-11-28 Thread Implementación y seguimiento al plan
16 de Enero | Horario de 10:00 a 17:00 hrs. | (hora del centro de México) - ¿Cómo realizar una Detección de Necesidades de Capacitación de manera efectiva? - El Diagnóstico de las Necesidades de Capacitación (DNC) es un proceso de suma importancia durante la planeación de la capacitación

Re: [ovs-dev] [PATCH v1 4/4] travis: Enable OVS Travis CI for arm

2019-11-28 Thread Ilya Maximets
On 27.11.2019 8:11, Lance Yang (Arm Technology China) wrote: > >> -Original Message- >> From: Ilya Maximets >> Sent: Friday, November 22, 2019 6:36 PM >> To: Lance Yang (Arm Technology China) ; Ilya Maximets >> ; ovs-dev@openvswitch.org >> Cc: Jieqiang Wang (Arm Technology China) ; Gavin

Re: [ovs-dev] [PATCH v1 2/4] travis: Move x86-only addon packages

2019-11-28 Thread Ilya Maximets
On 22.11.2019 10:23, Yanqin Wei (Arm Technology China) wrote: > Hi Ilya, > > Reply inline. > > Best Regards, > Wei Yanqin > >> -Original Message- >> From: dev On Behalf Of Ilya Maximets >> Sent: Friday, November 22, 2019 3:30 AM >> To: Lance Yang (Arm Technology China) ; >>

Re: [ovs-dev] [PATCH v1 4/4] travis: Enable OVS Travis CI for arm

2019-11-28 Thread Ilya Maximets
On 27.11.2019 8:49, Lance Yang (Arm Technology China) wrote: > > >> -Original Message- >> From: Ilya Maximets >> Sent: Tuesday, November 26, 2019 8:48 PM >> To: Ilya Maximets ; Lance Yang (Arm Technology China) >> ; ovs-dev@openvswitch.org >> Cc: Jieqiang Wang (Arm Technology China) ;

Re: [ovs-dev] [PATCH] dpif-netdev-perf: aarch64 support for accurate timing update of TSC cycle counter

2019-11-28 Thread Ilya Maximets
On 27.11.2019 8:38, Yanqin Wei (Arm Technology China) wrote: > Hi Ilya, > > No, we didn't test this patch based on OVS-AF_XDP, but made a black build to > enable this in OVS-DPDK and test it. > Currently DPDK-AF_XDP has been tested in latest kernel (not released). So I > think OVS-AF_XDP is

Re: [ovs-dev] [PATCH] dp-packet: Fix clearing/copying of memory layout flags.

2019-11-28 Thread Ilya Maximets
On 28.11.2019 14:42, Kevin Traynor wrote: > On 27/11/2019 20:33, David Marchand wrote: >> On Thu, Nov 21, 2019 at 3:35 PM Ilya Maximets wrote: >>> >>> On 21.11.2019 14:58, Ilya Maximets wrote: 'ol_flags' of DPDK mbuf could contain bits responsible for external or indirect buffers which

Re: [ovs-dev] [PATCH] netdev-dpdk: Deprecate ring ports.

2019-11-28 Thread Ilya Maximets
On 26.11.2019 12:31, Ilya Maximets wrote: > 'dpdkr' a.k.a. DPDK ring ports has really poor support in OVS and not > tested on a regular basis. These ports are intended to work via > shared memory with another DPDK secondary process, but there are lots > of limitations for using this functionality

Re: [ovs-dev] [PATCH] ofproto-provider: Move datapath capabilities callback to correct section.

2019-11-28 Thread Ilya Maximets
On 26.11.2019 21:35, William Tu wrote: > On Tue, Nov 26, 2019 at 12:25 PM Ilya Maximets wrote: >> >> 'get_datapath_cap' callback was mistakenly placed in >> 'Connection tracking' section of the 'struct dpif_class' >> while belongs to the 'Datapath information'. >> >> CC: William Tu >> Fixes:

Re: [ovs-dev] [PATCH v2 ovn 0/2] Add support for PRF and Route Info Option in RA (RFC 4191)

2019-11-28 Thread Numan Siddique
On Thu, Nov 28, 2019 at 6:19 PM Lorenzo Bianconi wrote: > > Changes since v1: > - rename prf in router_preference in OVN NB DB > - allocate space for ovs_nd_route_info in ovs packet after data validation > > Lorenzo Bianconi (2): > Add support to Default Router Preference (PRF) - RFC 4191 >

Re: [ovs-dev] [PATCH ovn] ovn-controller: Consider non-virtual ports first when updating bindings.

2019-11-28 Thread Dumitru Ceara
On Thu, Nov 28, 2019 at 2:36 PM Numan Siddique wrote: > > On Sat, Nov 23, 2019 at 3:51 AM Mark Michelson wrote: > > > > Acked-by: Mark Michelson > > > > On 11/22/19 9:22 AM, Dumitru Ceara wrote: > > > There's no guarantee SBREC_PORT_BINDING_TABLE_FOR_EACH will first > > > return the non-virtual

Re: [ovs-dev] [PATCH] dp-packet: Fix clearing/copying of memory layout flags.

2019-11-28 Thread Kevin Traynor
On 27/11/2019 20:33, David Marchand wrote: > On Thu, Nov 21, 2019 at 3:35 PM Ilya Maximets wrote: >> >> On 21.11.2019 14:58, Ilya Maximets wrote: >>> 'ol_flags' of DPDK mbuf could contain bits responsible for external >>> or indirect buffers which are not actually offload flags in a common >>>

Re: [ovs-dev] [PATCH ovn] ovn-controller: Consider non-virtual ports first when updating bindings.

2019-11-28 Thread Numan Siddique
On Sat, Nov 23, 2019 at 3:51 AM Mark Michelson wrote: > > Acked-by: Mark Michelson > > On 11/22/19 9:22 AM, Dumitru Ceara wrote: > > There's no guarantee SBREC_PORT_BINDING_TABLE_FOR_EACH will first > > return the non-virtual ports and then virtual ports. In the case when a > > virtual port is

Re: [ovs-dev] [PATCH ovn 2/2] Add support for Route Info Option in RA - RFC 4191

2019-11-28 Thread Lorenzo Bianconi
> On Thu, Nov 14, 2019 at 5:10 PM Lorenzo Bianconi > wrote: > > > > Introduce support for Route Info Option sent in Router > > Advertisement according to RFC 4191. Route Info Option are > > configured providing route_info in ipv6_ra_configs column of > > Logical_Router_Port table. route_info is a

Re: [ovs-dev] [PATCH ovn 1/2] Add support to Default Router Preference (PRF) - RFC 4191

2019-11-28 Thread Lorenzo Bianconi
> On Thu, Nov 14, 2019 at 5:10 PM Lorenzo Bianconi > wrote: > > > > Introduce support for Default Router Preference (PRF) in IPv6 Router > > Advertisement according to RFC 4191 > > > > Signed-off-by: Lorenzo Bianconi > > Thanks Lorenzo for the patches. > > The patch LGTM. Just one comment >

[ovs-dev] [PATCH v2 ovn 1/2] Add support to Default Router Preference (PRF) - RFC 4191

2019-11-28 Thread Lorenzo Bianconi
Introduce support for Default Router Preference (PRF) in IPv6 Router Advertisement according to RFC 4191 Signed-off-by: Lorenzo Bianconi --- controller/pinctrl.c | 20 +--- lib/ovn-l7.h | 4 northd/ovn-northd.c | 8 ovn-nb.xml | 12

[ovs-dev] [PATCH v2 ovn 2/2] Add support for Route Info Option in RA - RFC 4191

2019-11-28 Thread Lorenzo Bianconi
Introduce support for Route Info Option sent in Router Advertisement according to RFC 4191. Route Info Option are configured providing route_info in ipv6_ra_configs column of Logical_Router_Port table. route_info is a comma separated string where each field provides PRF and prefix for a given

[ovs-dev] [PATCH v2 ovn 0/2] Add support for PRF and Route Info Option in RA (RFC 4191)

2019-11-28 Thread Lorenzo Bianconi
Changes since v1: - rename prf in router_preference in OVN NB DB - allocate space for ovs_nd_route_info in ovs packet after data validation Lorenzo Bianconi (2): Add support to Default Router Preference (PRF) - RFC 4191 Add support for Route Info Option in RA - RFC 4191 controller/pinctrl.c

[ovs-dev] Weekly build of dpdk-latest branch on TravisCI.

2019-11-28 Thread Ilya Maximets
Hi. As discussed on OVS-DPDK public meeting I enabled weekly cron job on TravisCI for a dpdk-latest branch. For now it will happen on Thursdays since I enabled it today, but we could change the day if needed. Suggestions are welcome. I'm personally thinking about moving it to Saturdays to

Re: [ovs-dev] OVS-DPDK public meeting

2019-11-28 Thread Kevin Traynor
Next meeting Jan 8th 1700 UTC November 27th minutes Attendees: Aaron, David, Oz, Ilya, Johann, Simon, Roni, Ian, Thomas, Kevin. - DPDK 19.11 Release -- OVS validation complete to date -- Ian presented tests performed with OVS and Intel NICs -- Summary was sent to dpdk-dev

Re: [ovs-dev] [PATCH ovn 2/2] Add support for Route Info Option in RA - RFC 4191

2019-11-28 Thread Numan Siddique
On Thu, Nov 14, 2019 at 5:10 PM Lorenzo Bianconi wrote: > > Introduce support for Route Info Option sent in Router > Advertisement according to RFC 4191. Route Info Option are > configured providing route_info in ipv6_ra_configs column of > Logical_Router_Port table. route_info is a comma

Re: [ovs-dev] [PATCH ovn 1/2] Add support to Default Router Preference (PRF) - RFC 4191

2019-11-28 Thread Numan Siddique
On Thu, Nov 14, 2019 at 5:10 PM Lorenzo Bianconi wrote: > > Introduce support for Default Router Preference (PRF) in IPv6 Router > Advertisement according to RFC 4191 > > Signed-off-by: Lorenzo Bianconi Thanks Lorenzo for the patches. The patch LGTM. Just one comment 1. Can you please

Re: [ovs-dev] [PATCH v2 ovn 1/2] controller: add ipv6 prefix delegation state machine

2019-11-28 Thread Numan Siddique
On Thu, Nov 28, 2019 at 3:53 PM Numan Siddique wrote: > > On Tue, Nov 26, 2019 at 5:21 PM Lorenzo Bianconi > wrote: > > > > Introduce IPv6 Prefix delegation state machine according to RFC 3633 > > https://tools.ietf.org/html/rfc3633. > > Add handle_dhcpv6_reply controller action to parse

Re: [ovs-dev] [PATCH v2 ovn 1/2] controller: add ipv6 prefix delegation state machine

2019-11-28 Thread Numan Siddique
On Tue, Nov 26, 2019 at 5:21 PM Lorenzo Bianconi wrote: > > Introduce IPv6 Prefix delegation state machine according to RFC 3633 > https://tools.ietf.org/html/rfc3633. > Add handle_dhcpv6_reply controller action to parse advertise/reply from > IPv6 delegation server. Advertise/reply are parsed

Re: [ovs-dev] [PATCH net 1/2] openvswitch: support asymmetric conntrack

2019-11-28 Thread Nicolas Dichtel
Le 18/11/2019 à 22:19, Aaron Conole a écrit : > Nicolas Dichtel writes: > >> Le 08/11/2019 à 22:07, Aaron Conole a écrit : >>> The openvswitch module shares a common conntrack and NAT infrastructure >>> exposed via netfilter. It's possible that a packet needs both SNAT and >>> DNAT

Re: [ovs-dev] [OVN][RAFT] Follower refusing new entries from leader

2019-11-28 Thread taoyunupt
Hi,Han Another question. NO COMPACT. If restart a follower , leader sender some entries during the break time, when it has started, if it also happend to this problem? What is the difference between simply restart and COMPACT with restart ? Thanks, Yun 在 2019-11-28