On Tue, Apr 23, 2024 at 2:50 AM Martin Kalcok
wrote:
>
> Signed-off-by: Martin Kalcok
> ---
> ovn-sb.xml | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/ovn-sb.xml b/ovn-sb.xml
> index f9fb6c304..bf4689f12 100644
> --- a/ovn-sb.xml
> +++ b/ovn-sb.xml
> @@ -1456,7
On 4/11/24 15:43, Chris Riches wrote:
> On 11/04/2024 14:24, Ilya Maximets wrote:
>> On 4/11/24 10:59, Chris Riches wrote:
>>> From what we know so far, the DB was full of stale connection-tracking
>>> information such as the following:
>>>
>>> [...]
>>>
>>> Once the host was recovered by putting
On 4/23/24 13:10, Ilya Maximets wrote:
> On 4/23/24 12:35, Simon Horman wrote:
>> On Thu, Apr 18, 2024 at 03:35:06PM +0100, Chris Riches wrote:
>>> On 15/04/2024 14:39, Jon Kohler wrote:
> On Apr 11, 2024, at 9:43 AM, Chris Riches
> wrote:
>
> On 11/04/2024 14:24, Ilya Maximets
On 4/12/24 01:45, Ilya Maximets wrote:
> A couple of fixes related to corner cases with probe intervals
> on RAFT connections between servers.
>
> Ilya Maximets (2):
> ovsdb: raft: Fix inability to join a cluster with a large database.
> ovsdb: raft: Fix probe intervals after install snapshot
On 4/11/24 21:57, Ihar Hrachyshka wrote:
This allows callers to avoid cleanup of the record in case the function
fails.
Signed-off-by: Ihar Hrachyshka
---
northd/northd.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/northd/northd.c b/northd/northd.c
index
Hi Ales, thanks for this. I always like a change that results in a net
loss of lines of code :)
For the series,
Acked-by: Mark Michelson
On 4/22/24 03:35, Ales Musil wrote:
There were two modules in controller mac_cache and mac-learn, both of
them did very similar thing with pretty big
Chris Riches writes:
> On 15/04/2024 14:39, Jon Kohler wrote:
>>> On Apr 11, 2024, at 9:43 AM, Chris Riches wrote:
>>>
>>> On 11/04/2024 14:24, Ilya Maximets wrote:
On 4/11/24 10:59, Chris Riches wrote:
> From what we know so far, the DB was full of stale connection-tracking
>
Hi:
Data plane restores when cleaning up flows using ovs-dpctl del-flows and
eventually all the flows catch up as flows added by ovn are intact.
However, not sure what flow caused this as the issue pops up on
ovs-vswitchd restarts and needs to be workaround by dpctl del-flows. Not
sure if it's
Bleep bloop. Greetings Vladislav Odintsov, I am a robot and I have tried out
your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Line is 80 characters long (recommended limit is 79)
#140 FILE:
From: Numan Siddique
It is expected that a provider network logical switch has a localnet logical
switch port in order to bridge the overlay traffic to the underlay traffic.
There can be some usecases where a overlay logical switch (without
a localnet port) can act as a provider network and
From: Numan Siddique
The addresses are already parsed and stored in the "struct ovn_port"'s
lsp_addrs field.
Signed-off-by: Numan Siddique
---
northd/northd.c | 165 +---
1 file changed, 59 insertions(+), 106 deletions(-)
diff --git
Since OVS 3.3.0 ovsdb-server accepts databases and remotes configuration
via JSON text file. This patch adds support for such option.
Signed-off-by: Vladislav Odintsov
---
NEWS | 1 +
utilities/ovn-ctl | 39 +++
2 files changed, 36
On Mon, Apr 22, 2024 at 11:14 AM Ales Musil wrote:
> On Fri, Apr 19, 2024 at 6:38 PM Numan Siddique wrote:
>
> >
> >
> > On Fri, Apr 19, 2024 at 7:09 AM Ales Musil wrote:
> >
> >> The current packet injection loses ct_state in the process. When
> >> the ct_state is lost we might commit to DNAT
After ovn-appctl resume was issued for northd or ovn-ic, there was no
guarantee that northd or ovn-ic were waking up, potentially handling
changes received while they were paused..
Usually, poll_block would be woken up by POLLHUP, but race conditions could
cause this not to happen.
ovn-controller
Flows were not properly removed when parent port of a container port
was deleted.
Signed-off-by: Xavier Simonart
---
controller/binding.c | 1 +
controller/physical.c | 3 ++-
tests/ovn.at | 34 ++
3 files changed, 37 insertions(+), 1 deletion(-)
This patches fixes flows not properly deleted in scenarios similar to:
foo1 (hv1) - foo - R1 - join - R2 (chassis = hv2) - alice - alice1 (hv2).
When R2 is deleted, alice_R2 changed from l3gateway to patch, and, on hv1,
alice_R2 was added to related ports.
When R2 was added back (together with
If iface-id-ver was wrong and modified to a correct value,
the port was correctly claimed, but the flows were not installed
by I+P.
Signed-off-by: Xavier Simonart
---
controller/binding.c | 14 ++
tests/ovn.at | 2 ++
2 files changed, 16 insertions(+)
diff --git
When a port was claimed by two chassis, both chassis were fighting for the port;
a claim was postponed if the port was claimed recently.
However, there were two issues:
- Not all the flows were properly removed when the remote chassis was claiming
the port.
- A port was not properly released if
Reported-at: https://mail.openvswitch.org/pipermail/ovs-dev/2023-May/405107.html
Suggested-by: Priyankar Jain
Signed-off-by: Xavier Simonart
---
controller/binding.c | 12 +-
tests/ovn.at | 57
2 files changed, 68 insertions(+), 1
Comparing I+P flows versus flows after recompute highlighted a few
issues.
Xavier Simonart (5):
controller: Fix iface-id-ver handling.
controller: Nonvif related lports handling.
controller: Fix deletion of container parent port.
controller: Handle postponed ports claims.
controller:
On 23 Apr 2024, at 9:37, Jun Gu wrote:
> dev_get_by_name will provide a reference on the netdev. So ensure that
> the reference of netdev is released after completed.
>
> Fixes: 2540088b836f ("net: openvswitch: Check vport netdev name")
> Signed-off-by: Jun Gu
Thanks Jun for the follow-up!
+ David Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni, Eelco Chaudron
On Tue, Apr 23, 2024 at 03:37:51PM +0800, Jun Gu wrote:
> dev_get_by_name will provide a reference on the netdev. So ensure that
> the reference of netdev is released after completed.
>
> Fixes: 2540088b836f ("net:
On 4/23/24 12:35, Simon Horman wrote:
> On Thu, Apr 18, 2024 at 03:35:06PM +0100, Chris Riches wrote:
>> On 15/04/2024 14:39, Jon Kohler wrote:
On Apr 11, 2024, at 9:43 AM, Chris Riches wrote:
On 11/04/2024 14:24, Ilya Maximets wrote:
> On 4/11/24 10:59, Chris Riches wrote:
On Thu, Apr 11, 2024 at 11:46:01AM +0100, Simon Horman wrote:
> On Wed, Apr 10, 2024 at 04:38:24PM -0500, Terry Wilson wrote:
> > The Python persistent UUID tests should have the keyword "python"
> > added so that TESTSUITEFLAGS="-k python" will not miss testing
> > them.
> >
> > Fixes:
On Fri, Apr 12, 2024 at 10:33:18AM +0100, Simon Horman wrote:
> On Fri, Apr 12, 2024 at 02:45:17AM +, Ihar Hrachyshka wrote:
> > Before the patch, the size of the backlog depended on the type of socket
> > (UNIX vs INET) as well as on the language (C vs Python), specifically:
> >
> > - python
On Mon, Apr 22, 2024 at 02:37:41PM +0200, Paolo Valerio wrote:
> When no parameters other than the datapath are specified a segfault
> occurs.
>
> Fix it by checking the argument access is inside the bounds.
>
> Signed-off-by: Paolo Valerio
Acked-by: Simon Horman
On Thu, Apr 18, 2024 at 03:35:06PM +0100, Chris Riches wrote:
> On 15/04/2024 14:39, Jon Kohler wrote:
> > > On Apr 11, 2024, at 9:43 AM, Chris Riches
> > > wrote:
> > >
> > > On 11/04/2024 14:24, Ilya Maximets wrote:
> > > > On 4/11/24 10:59, Chris Riches wrote:
> > > > > From what we know so
On Wed, Apr 17, 2024 at 10:43:11AM +0300, Roi Dayan wrote:
>
>
> On 16/04/2024 18:48, Simon Horman wrote:
> > On Tue, Apr 16, 2024 at 04:21:48PM +0300, Roi Dayan via dev wrote:
> >> VLOG_WARN_BUF() is allocating memory for the error string and should
> >> e used if the configuration cannot
On Wed, Apr 17, 2024 at 10:54:14AM +0300, Roi Dayan wrote:
> When failing to get flow control parameters use VLOG_WARN_BUF()
> to expose the error string in ovs-vsctl show.
>
> Signed-off-by: Roi Dayan
> Suggested-by: Simon Horman
> Acked-by: Eli Britstein
Acked-by: Simon Horman
On Tue, Apr 23, 2024 at 11:26 AM wrote:
> Thanks Dumitru,
> I didn't noticed that the patch was applied while I was typing my
> message :D
>
> Overall I think it's fine if it stays as it was proposed by Ales. I
> just wanted to raise a very fringe concern that perhaps using two
> separate UDP
Signed-off-by: Martin Kalcok
---
ovn-sb.xml | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/ovn-sb.xml b/ovn-sb.xml
index f9fb6c304..bf4689f12 100644
--- a/ovn-sb.xml
+++ b/ovn-sb.xml
@@ -1456,7 +1456,7 @@
ct_dnat sends the packet through the DNAT
Thanks Dumitru,
I didn't noticed that the patch was applied while I was typing my
message :D
Overall I think it's fine if it stays as it was proposed by Ales. I
just wanted to raise a very fringe concern that perhaps using two
separate UDP servers could mask some underlying issue and if there's
On 4/23/24 11:12, martin.kal...@canonical.com wrote:
> Hi Ales,
> Sorry that these new tests are causing problems. Just out of curiosity,
> do you have link to some failing test runs? I'll add few thoughts
> below.
>
> On Tue, 2024-04-23 at 09:41 +0200, Ales Musil wrote:
>> The netcat 7.94 allows
Hi Ales,
Sorry that these new tests are causing problems. Just out of curiosity,
do you have link to some failing test runs? I'll add few thoughts
below.
On Tue, 2024-04-23 at 09:41 +0200, Ales Musil wrote:
> The netcat 7.94 allows multiple connections over udp (-k/--keep-open)
> [0],
> without
On 4/23/24 09:41, Ales Musil wrote:
> The netcat 7.94 allows multiple connections over udp (-k/--keep-open) [0],
> without this option the connection can be closed "unexpctedly". This
> to keep the test backward compatible make new servers for every UDP
> connection.
>
> The second issue is that
dev_get_by_name will provide a reference on the netdev. So ensure that
the reference of netdev is released after completed.
Fixes: 2540088b836f ("net: openvswitch: Check vport netdev name")
Signed-off-by: Jun Gu
---
net/openvswitch/vport-netdev.c | 8 ++--
1 file changed, 6 insertions(+), 2
The netcat 7.94 allows multiple connections over udp (-k/--keep-open) [0],
without this option the connection can be closed "unexpctedly". This
to keep the test backward compatible make new servers for every UDP
connection.
The second issue is that netcat is attempting to listen on IPv4 when
the
37 matches
Mail list logo
