>
> Let's say we add this static route - "prefix = 172.168.0.0/24,
> nexthop = aef0::4"
> and lets assume OVN doesn't know the next hop "aef0::4" mac address.
> So with your patch, the original packet will be dropped because
> pinctrl.c is not handling it properly.
>
> I see 2 approaches here :
Hello:
This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski :
On Mon, 6 May 2024 12:02:04 -0700 you wrote:
> When building with clang, via:
>
> make LLVM=1 -C tools/testing/selftest
>
> ...clang warns about three variables that are not initialized in all
> cases:
>
>
From: Numan Siddique
Although these util functions are correct in their implementation,
they are confusing to the reader. Add proper documentation
and make the is_l3dgw_port() more clearer by checking if the
gateway chassis or ha chassis group is set or not.
Signed-off-by: Numan Siddique
---
On Tue, May 7, 2024 at 12:51 PM Ales Musil wrote:
>
> On Tue, May 7, 2024 at 6:49 PM Numan Siddique wrote:
>
> > On Tue, May 7, 2024 at 2:25 AM Ales Musil wrote:
> > >
> > > There were two modules in controller mac_cache and mac-learn, both of
> > > them did very similar thing with pretty big
Bleep bloop. Greetings Mark Michelson, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Line is 80 characters long (recommended limit is 79)
#36 FILE:
This commit replaces the word "abort" with alternatives when
possible.
Places where "abort" is not replaced:
* The "abort()" system call, as well as the "ovs_abort()" wrapper.
* Any references to SCTP abort. This is the name of the method in SCTP,
so referring to it as a different name would be
There is a growing movement to be more inclusive in the language used in
code and its documentation.
For this task, the following site was used to find a list of words that
should be avoided: https://inclusivenaming.org/word-lists/ .
Each of their tier 1, tier 2, and tier 3 words were searched
This commit changes the word "blacklist" to "denylist" throughout the
code. It also changes the word "whitelist" to "allowlist" throughout the
code.
The option "ic-route-blacklist" in the northbound global options has
been renamed to "ic-route-denylist", but the old option name is still
accepted
This commit replaces the word "master" with alternative words.
Places where "master" is not replaced:
* References to third-party URLs, option names, and code repositories.
* The "integration" documentation is unchanged. It references pacemaker
options which use the word "master". The text also
This change introduces alternatives for "sanity-check" (and its
variants) throughout the code.
Places where "sanity-check" is not replaced:
* Many libtool-related files are auto-generated and contain the phrase.
Since these files are auto-generated, I did not update these files.
Signed-off-by:
On Tue, May 7, 2024 at 6:49 PM Numan Siddique wrote:
> On Tue, May 7, 2024 at 2:25 AM Ales Musil wrote:
> >
> > There were two modules in controller mac_cache and mac-learn, both of
> > them did very similar thing with pretty big overlap. The goal of the
> > series is to consolidate and merge
On Tue, May 7, 2024 at 2:25 AM Ales Musil wrote:
>
> There were two modules in controller mac_cache and mac-learn, both of
> them did very similar thing with pretty big overlap. The goal of the
> series is to consolidate and merge both of those modules into single
> one. That will reduce the
On Tue, May 7, 2024 at 11:10 AM Felix Huettner via dev
wrote:
>
> On Tue, May 07, 2024 at 10:06:07AM -0400, Numan Siddique wrote:
> > On Tue, May 7, 2024 at 5:24 AM Felix Huettner via dev
> > wrote:
> > >
> > > On Mon, May 06, 2024 at 11:03:42PM -0400, Numan Siddique wrote:
> > > > On Mon, Apr
On Tue, May 07, 2024 at 05:04:34PM +0200, David Marchand wrote:
> This change has no impact, since -Dmachine=default gets converted by
> DPDK into -Dplatform=generic (since v21.08, see the link to DPDK commit
> below). Yet, switch to explicitly setting -Dplatform and avoid the
> following warning:
On Tue, May 07, 2024 at 03:16:25PM +0100, Simon Horman wrote:
> On Fri, May 03, 2024 at 02:22:27PM +0200, martin.kal...@canonical.com wrote:
...
> Thanks,
>
> Sorry for the confusion on my part.
> Now that I can see it again I have applied it to main.
>
> - ovsdb-client: Add missing arg to
The AVX implementation for calcualting checksum was not
handling carry-over addition correctly in some cases.
This patch adds an additional shuffle to add 16-bit padding
to the final part of the calculation to handle such cases.
Fixes: 92eb03f7b03a ("odp-execute: Add ISA implementation of
On Tue, May 07, 2024 at 10:06:07AM -0400, Numan Siddique wrote:
> On Tue, May 7, 2024 at 5:24 AM Felix Huettner via dev
> wrote:
> >
> > On Mon, May 06, 2024 at 11:03:42PM -0400, Numan Siddique wrote:
> > > On Mon, Apr 22, 2024 at 9:02 AM Felix Huettner via dev
> > > wrote:
> > > >
> > > > In
Bleep bloop. Greetings Adrian Moreno, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Line is 81 characters long (recommended limit is 79)
#546 FILE:
This change has no impact, since -Dmachine=default gets converted by
DPDK into -Dplatform=generic (since v21.08, see the link to DPDK commit
below). Yet, switch to explicitly setting -Dplatform and avoid the
following warning:
2024-04-18T14:50:16.8001092Z config/meson.build:113: WARNING: The
Add a man page for ovs-flowviz as well as a topic page with some more
detailed examples.
Signed-off-by: Adrian Moreno
---
Documentation/automake.mk | 4 +-
Documentation/conf.py | 2 +
Documentation/ref/index.rst | 1 +
In order to support dark style in html outputs, allow the config file to
express the background color and set it in a top style object.
Acked-by: Eelco Chaudron
Signed-off-by: Adrian Moreno
---
python/ovs/flowviz/html_format.py | 4 +++-
python/ovs/flowviz/odp/html.py | 30
Using the existing FlowTree and HTMLFormatter, create an HTML tree
visualization that also supports collapsing and expanding entire flow
trees and subtrees.
Examples:
$ ovs-appcl dpctl/dump-flows | ovs-flowviz --highlight drop datapath
html > /tmp/flows.html
$ ovs-appcl dpctl/dump-flows |
Graph view leverages the tree format (specially the tree-based
filtering) and uses graphviz library to build a visual graph of the
datapath in graphviz format.
Conntrack zones are shown in random colors to help visualize connection
tracking interdependencies.
An html flag builds an HTML page
Add a flow formatting framework and one implementation for console
printing using rich.
The flow formatting framework is a simple set of classes that can be
used to write different flow formatting implementations. It supports
styles to be described by any class, highlighting and config-file based
This view is interesting for debugging the logical pipeline. It arranges
the flows in "logical" groups (not to be confused with OVN's
Logical_Flows). A logical group of flows is a set of flows that:
- Have the same table number and priority
- Match on the same fields (regardless of the value they
Datapath flows can be arranged into a "tree"-like structure based on
recirculation ids, e.g:
recirc(0),eth(...),ipv4(...) actions=ct,recirc(0x42)
\-> recirc(42),ct_state(0/0),eth(...),ipv4(...) actions=1
\-> recirc(42),ct_state(1/0),eth(...),ipv4(...) actions=userspace(...)
This patch
When anaylizing OVN issues, it might be useful to see what OpenFlow
flows were generated from each logical flow. In order to make it simpler
to visualize this, add a cookie format that simply sorts the flows first
by cookie, then by table.
Example:
$ export OVN_NB_DB=...
$ export OVN_SB_DB=...
$
process.py contains a useful base class that processes files
odp.py and ofp.py: contain datapath and openflow subcommand definitions
as well as the first formatting option: json.
Also, this patch adds basic filtering support.
Examples:
$ ovs-ofctl dump-flows br-int | ovs-flowviz openflow json
$
It has two basic styles defined: "dark" and "light" intended for
dark and light terminals.
Examples:
$ ovs-flowviz -i /tmp/dpflows --style=dark datapath console
$ ovs-flowviz -i /tmp/ofpflows --style=light openflow console
Acked-by: Eelco Chaudron
Signed-off-by: Adrian Moreno
---
Add a HTML Formatter and use it to print OpenFlow flows in an HTML list
with table links.
Examples
$ ovs-flowviz -i offlows.txt --highlight "drop" openflow html >
/tmp/flows.html
$ ovs-flowviz -i offlows.txt --filter "n_packets > 0" openflow html >
/tmp/flows.html
Acked-by: Eelco Chaudron
Add a new python package (just the scheleton for now) to hold a flow
visualization tool based on the flow parsing library.
flowviz dependencies are installed via "extras_require", so a user must
run:
$ pip install .[flowviz]
or
$ pip install ovs[flowviz]
Acked-by: Eelco Chaudron
Signed-off-by:
The goal of this utility is to read both datapath and Openflow flows
(using the flow library already available) and print them in different
formats and styles to make it easier to understand them and troubleshoot
issues.
The formats are quite opinionated and so are the colors chosen so I'm
eager
On 5/3/24 11:43 AM, Eelco Chaudron wrote:
On 24 Apr 2024, at 15:50, Adrian Moreno wrote:
Add support for psample sampling via two new attributes to the
OVS_ACTION_ATTR_SAMPLE action.
OVS_SAMPLE_ATTR_PSAMPLE_GROUP used to pass an integer psample group_id.
OVS_SAMPLE_ATTR_PSAMPLE_COOKIE
On Fri, May 03, 2024 at 02:22:27PM +0200, martin.kal...@canonical.com wrote:
> Hi Simon,
>
> It seems that it[0] got archived, not sure how. I unticked the
> 'archived' box and it should again appear in the the list in OVS
> patchwork.
>
> Thanks for the review.
> Martin.
>
> [0]
>
On Tue, May 7, 2024 at 5:24 AM Felix Huettner via dev
wrote:
>
> On Mon, May 06, 2024 at 11:03:42PM -0400, Numan Siddique wrote:
> > On Mon, Apr 22, 2024 at 9:02 AM Felix Huettner via dev
> > wrote:
> > >
> > > In most cases IPv4 packets are routed only over other IPv4 networks and
> > > IPv6
While offloading header modifications to TC, OVS is using {TCA_PEDIT} +
{TCA_CSUM} combination as that it the only way to represent header
rewrite. However, {TCA_CSUM} is unable to calculate L4 checksums for
IP fragments.
Since TC already applies fragmentation bit masking, this patch simply
On 2 May 2024, at 14:46, Ilya Maximets wrote:
> On 4/29/24 16:48, Eelco Chaudron wrote:
>> While offloading header modifications to TC, OVS is using {TCA_PEDIT} +
>> {TCA_CSUM} combination as that it the only way to represent header
>> rewrite. However, {TCA_CSUM} is unable to calculate L4
On Mon, May 06, 2024 at 11:03:42PM -0400, Numan Siddique wrote:
> On Mon, Apr 22, 2024 at 9:02 AM Felix Huettner via dev
> wrote:
> >
> > In most cases IPv4 packets are routed only over other IPv4 networks and
> > IPv6 packets are routed only over IPv6 networks. However there is no
> > inherent
On Mon, 6 May 2024, John Hubbard wrote:
When building with clang, via:
make LLVM=1 -C tools/testing/selftest
...clang warns about three variables that are not initialized in all
cases:
1) The opt_ipproto_off variable is used uninitialized if "testname" is
not "ip". Willem de Bruijn
Hi Ilya,
Thank you for the review and feedback.
Please find my reply in-line.
Thanks,
Amit Shukla
> -Original Message-
> From: Ilya Maximets
> Sent: Friday, May 3, 2024 4:41 PM
> To: Amit Prakash Shukla ; ovs-
> d...@openvswitch.org
> Cc: Harman Kalra ; Jerin Jacob ;
>
Merge mac-cache and mac-learn into single module. Both of those
modules contained very similar functionality with some small
differences. By merging those we have unified interface to deal
with FDB and MAC binding.
Acked-by: Mark Michelson
Signed-off-by: Ales Musil
---
v2: Rebase on top of
Use datapath tunnel key instead of UUID for the mac cache threshold
handling. At the same time simplify the thresholds into single hmap.
The tunnel key is unique so there shouldn't be any overlap. Having
two thresholds per datapath is currently invalid configuration anyway.
The switch to
For consistency rename the mac_cache.c/.h to mac-cache.c/.h.
Acked-by: Mark Michelson
Signed-off-by: Ales Musil
---
v2: Rebase on top of main.
---
controller/automake.mk | 4 ++--
controller/{mac_cache.c => mac-cache.c} | 2 +-
controller/{mac_cache.h => mac-cache.h} | 2 +-
Currently the tunnel_key change for either LS/LR/LSP/LRP wasn't
consistent. That would lead to a situations when some old would still
be present, breaking the connection especially for already existing
FDBs and MAC bindings.
Make sure the FDB entries are up to date by removing them from DB
when
There were two modules in controller mac_cache and mac-learn, both of
them did very similar thing with pretty big overlap. The goal of the
series is to consolidate and merge both of those modules into single
one. That will reduce the duplication and should make it easier for
future updates to MAC
On Mon, May 6, 2024 at 10:37 PM Ales Musil wrote:
>
>
>
> On Mon, May 6, 2024 at 8:41 PM Han Zhou wrote:
>>
>>
>>
>> On Thu, May 2, 2024 at 10:35 PM Ales Musil wrote:
>> >
>> > On Thu, May 2, 2024 at 6:23 PM Han Zhou wrote:
>> > >
>> > >
>> > >
>> > > On Thu, May 2, 2024 at 6:29 AM Ales Musil
46 matches
Mail list logo
