Re: [HACKERS] proposal - Default namespaces for XPath expressions (PostgreSQL 11)

2018-09-16 Thread Pavel Stehule
po 17. 9. 2018 v 2:05 odesílatel Thomas Munro napsal: > On Fri, Aug 10, 2018 at 6:26 AM Andrew Dunstan > wrote: > > On 01/24/2018 04:30 AM, Pavel Stehule wrote: > > > > > > I am sending updated version. > > > > > > Very much thanks for very precious review > > > > Thomas, > > > > I am unable to

Re: XMLNAMESPACES (was Re: Clarification of nodeToString() use cases)

2018-09-16 Thread Tom Lane
Andrew Dunstan writes: > On 09/16/2018 02:05 PM, Tom Lane wrote: >> The change the attached patch makes is to represent a DEFAULT namespace >> as a NULL list entry, rather than a T_String Value node containing a >> null. > Seems related to this CF item that's been around for a year: >

Re: [PATCH] Add support for ON UPDATE/DELETE actions on ALTER CONSTRAINT

2018-09-16 Thread Matheus de Oliveira
Hi all. Sorry about the long delay. On Tue, Jul 10, 2018 at 10:17 AM Ashutosh Bapat < ashutosh.ba...@enterprisedb.com> wrote: > On Wed, Mar 7, 2018 at 11:49 PM, Matheus de Oliveira > wrote: > > > > > > Em 3 de mar de 2018 19:32, "Peter Eisentraut" > > escreveu: > > > > On 2/20/18 10:10,

Re: [HACKERS] proposal - Default namespaces for XPath expressions (PostgreSQL 11)

2018-09-16 Thread Thomas Munro
On Fri, Aug 10, 2018 at 6:26 AM Andrew Dunstan wrote: > On 01/24/2018 04:30 AM, Pavel Stehule wrote: > > > > I am sending updated version. > > > > Very much thanks for very precious review > > Thomas, > > I am unable to replicate the Linux failure seen in the cfbot on my > Fedora machine. Both

More deficiencies in outfuncs/readfuncs processing

2018-09-16 Thread Tom Lane
The report in https://www.postgresql.org/message-id/flat/3690074f-abd2-56a9-144a-aa5545d7a291%40postgrespro.ru set off substantial alarm bells for me about whether outfuncs/readfuncs processing had any additional problems we'd failed to notice. I thought that to investigate that, it'd be a good

Re: infinite loop in parallel hash joins / DSA / get_best_segment

2018-09-16 Thread Thomas Munro
On Mon, Sep 17, 2018 at 10:38 AM Tomas Vondra wrote: > While performing some benchmarks on REL_11_STABLE (at 55c2d9), I've > repeatedly hit an apparent infinite loop on TPC-H query 4. I don't know > what exactly are the triggering conditions, but the symptoms are these: > > 1) A parallel

infinite loop in parallel hash joins / DSA / get_best_segment

2018-09-16 Thread Tomas Vondra
Hi, While performing some benchmarks on REL_11_STABLE (at 55c2d9), I've repeatedly hit an apparent infinite loop on TPC-H query 4. I don't know what exactly are the triggering conditions, but the symptoms are these: 1) A parallel worker" process is consuming 100% CPU, with per for reporting

Re: Collation versioning

2018-09-16 Thread Thomas Munro
On Mon, Sep 17, 2018 at 9:02 AM Stephen Frost wrote: > * Thomas Munro (thomas.mu...@enterprisedb.com) wrote: > > Once you get into downstream effects of changes (whether they are > > recorded in the database or elsewhere), I think it's basically beyond > > our event horizon. Why and when did the

Re: XMLNAMESPACES (was Re: Clarification of nodeToString() use cases)

2018-09-16 Thread Andrew Dunstan
On 09/16/2018 02:05 PM, Tom Lane wrote: I wrote: Andrey Lepikhov writes: The reason is: parse tree node for XMLNAMESPACES clause has null pointer in the case of DEFAULT namespace (the pointer will be initialized at executor on the first call). My immediate reaction is that somebody made a

Re: [HACKERS] [PATCH] kNN for SP-GiST

2018-09-16 Thread Alexander Korotkov
On Thu, Aug 30, 2018 at 3:57 PM Alexander Korotkov < a.korot...@postgrespro.ru> wrote: > Generally patch looks close to committable shape for me. I'm going to > revise code and documentation again, split it up, and then propose to > commit. > I've revised this patch again. This revision

Re: Collation versioning

2018-09-16 Thread Stephen Frost
Greetings, * Thomas Munro (thomas.mu...@enterprisedb.com) wrote: > On Mon, Sep 17, 2018 at 6:13 AM Douglas Doole wrote: > > On Sun, Sep 16, 2018 at 1:20 AM Thomas Munro > > wrote: > >> 3. Fix the tracking of when reindexes need to be rebuilt, so that you > >> can't get it wrong (as you're

Re: ssl tests README and certs

2018-09-16 Thread Dave Cramer
On Sun, 16 Sep 2018 at 14:41, Heikki Linnakangas wrote: > On 14/09/18 18:49, Dave Cramer wrote: > > in src/test/ssl the README suggest that the Makefile can be used to > > recreate the ssl directory, however there are no rules to create > > *_ca.crt|key. Am I missing something ? > > The README

Re: Collation versioning

2018-09-16 Thread Thomas Munro
On Mon, Sep 17, 2018 at 6:13 AM Douglas Doole wrote: > > On Sun, Sep 16, 2018 at 1:20 AM Thomas Munro > wrote: >> >> 3. Fix the tracking of when reindexes need to be rebuilt, so that you >> can't get it wrong (as you're alluding to above). > > > I've mentioned this in the past, but didn't seem

Re: XMLNAMESPACES (was Re: Clarification of nodeToString() use cases)

2018-09-16 Thread Tom Lane
Andrew Gierth writes: > "Tom" == Tom Lane writes: > Tom> + Value*ns_node = (Value *) lfirst(lc2); > lfirst_node(Value, lc2) maybe? Unfortunately not: the node tag is not T_Value but T_String. regards, tom lane

Re: pgbench - add pseudo-random permutation function

2018-09-16 Thread Fabien COELHO
Hello Hironobu-san, Here is a v4, based on our out-of-list discussion: - the mask function is factored out - the popcount builtin is used if available Attached a v3, based on your fix, plus some additional changes: - explicitly declare unsigned variables where appropriate, to avoid casts -

Re: XMLNAMESPACES (was Re: Clarification of nodeToString() use cases)

2018-09-16 Thread Andrew Gierth
> "Tom" == Tom Lane writes: Tom> The change the attached patch makes is to represent a DEFAULT Tom> namespace as a NULL list entry, rather than a T_String Value node Tom> containing a null. This approach does work for all backend/nodes/ Tom> operations, but it could be argued that it's

Re: Collation versioning

2018-09-16 Thread Douglas Doole
Oh good. I'd missed that detail. So that eases the RI constraint concern. (In my previous job, we wanted case/accent insensitive collations, so equal did not mean binary equal which added a whole extra level of fun.) On Sun, Sep 16, 2018 at 11:39 AM Andrew Gierth wrote: > > "Douglas" ==

Re: ssl tests README and certs

2018-09-16 Thread Heikki Linnakangas
On 14/09/18 18:49, Dave Cramer wrote: in src/test/ssl the README suggest that the Makefile can be used to recreate the ssl directory, however there are no rules to create *_ca.crt|key. Am I missing something ? The README says: For convenience, all of these keypairs and certificates are

Re: Collation versioning

2018-09-16 Thread Andrew Gierth
> "Douglas" == Douglas Doole writes: Douglas> And constraints problems are even easier than triggers. Douglas> Consider a database with complex BI rules that are implemented Douglas> through triggers that fire when values are/are not equal. If Douglas> the equality of strings change,

Re: XMLNAMESPACES (was Re: Clarification of nodeToString() use cases)

2018-09-16 Thread Tom Lane
I wrote: > Andrey Lepikhov writes: >> The reason is: parse tree node for XMLNAMESPACES clause has null pointer >> in the case of DEFAULT namespace (the pointer will be initialized at >> executor on the first call). > My immediate reaction is that somebody made a bad decision about how > to

Re: Postgres 11 release notes

2018-09-16 Thread Jonathan S. Katz
On 9/16/18 11:36 AM, Bruce Momjian wrote: > On Sat, Sep 15, 2018 at 11:06:04AM -0400, Jonathan Katz wrote: >> @@ -2414,12 +2408,8 @@ same commits as above >> The option --create-slot creates >> the named replication slot (--slot) >> when the WAL streaming method >> -

Re: Postgres 11 release notes

2018-09-16 Thread Bruce Momjian
On Sat, Sep 15, 2018 at 11:06:04AM -0400, Jonathan Katz wrote: > @@ -2414,12 +2408,8 @@ same commits as above > The option --create-slot creates > the named replication slot (--slot) > when the WAL streaming method > -(--wal-method=stream) is used. > - > -

XMLNAMESPACES (was Re: Clarification of nodeToString() use cases)

2018-09-16 Thread Tom Lane
Andrey Lepikhov writes: > In the AQO project (Adaptive Query Optimization) [1] the nodeToString() > function is used by the planner to convert an query parse tree into a > string to generate a hash value [2]. Hmm. Not sure that is a bright idea; in fact, I'm pretty sure it's a *bad* idea.

Re: Postgres 11 release notes

2018-09-16 Thread Jonathan S. Katz
On 9/16/18 11:14 AM, Bruce Momjian wrote: > On Sat, Sep 15, 2018 at 11:06:04AM -0400, Jonathan Katz wrote: >> >> >> - Partitioning by a hash key >> + Partitioning by a hash key (a.k.a. "hash partitioning") > > I question whether a.k.a (also known as) is familiar

Re: Postgres 11 release notes

2018-09-16 Thread Bruce Momjian
On Sat, Sep 15, 2018 at 11:06:04AM -0400, Jonathan Katz wrote: > > > - Partitioning by a hash key > + Partitioning by a hash key (a.k.a. "hash partitioning") I question whether a.k.a (also known as) is familiar enough to our readers to appear in the releaes

Re: Code of Conduct plan

2018-09-16 Thread Martin Mueller
As long as subscribers to the list or attendants at a conference do not violate explicit or implicit house rules, what business does Postgres have worrying about what they do or say elsewhere? Some version of an 'all-of-life' clause may be appropriate to the Marines or federal judges, but it

Code of Conduct plan

2018-09-16 Thread Stephen Cook
On 2018-09-16 00:00, Mark Kirkwood wrote: > On 15/09/18 08:17, Tom Lane wrote: >> Yeah, this.  The PG community is mostly nice people, AFAICT.  I'll be >> astonished (and worried) if the CoC committee finds much to do.  We're >> implementing this mostly to make newcomers to the project feel that

Clarification of nodeToString() use cases

2018-09-16 Thread Andrey Lepikhov
Hi, Hackers! In the AQO project (Adaptive Query Optimization) [1] the nodeToString() function is used by the planner to convert an query parse tree into a string to generate a hash value [2]. In PostgreSQL v.11 call nodeToString(parse) segfaulted. The reason is: parse tree node for

Re: Collation versioning

2018-09-16 Thread Thomas Munro
On Thu, Sep 13, 2018 at 7:03 PM Peter Eisentraut wrote: > On 12/09/2018 13:25, Christoph Berg wrote: > > Re: Peter Eisentraut 2018-09-12 > > <0447ec7b-cdb6-7252-7943-88a4664e7...@2ndquadrant.com> > >>> Naive idea: make that catalog shared? Collations are system-wide after > >>> all. > >> > >> By

Re: [patch] Support LLVM 7

2018-09-16 Thread Christoph Berg
Re: To Andres Freund 2018-09-12 <20180912210734.gb5...@msg.df7cb.de> > I plan to switch postgresql-11.deb to LLVM 7 over the next days > because of the support for non-x86 architectures I did an upload of postgresql-11 beta3 with llvm 7 enabled on the architectures where it is available (or