Re: Probable memory leak with ECPG and AIX

2021-12-11 Thread Noah Misch
On Fri, Dec 10, 2021 at 03:40:50PM +0100, Guillaume Lelarge wrote: > After some time, the client > crashes with a segfault error. According to him, it consumed around 256MB. > What's weird is that it works great on Linux, but crashed on AIX. That almost certainly means he's using a 32-bit binary

Re: pg_dump versus ancient server versions

2021-12-11 Thread Tom Lane
Andrew Dunstan writes: > 9.2 is how far back crake goes in testing pg_ugrade from old versions, > so that could well be a convenient stopping point. For older versions > there is still the possibility of building on older toolchains and > running on modern ones. Yes it's more cumbersome, but it

Re: Windows now has fdatasync()

2021-12-11 Thread Sascha Kuhl
Great. File sync is a Nice extension for me, as I don't know all file structures. Thomas Munro schrieb am So., 12. Dez. 2021, 03:48: > Hi, > > While porting some new IO code to lots of OSes I noticed in passing > that there is now a way to do synchronous fdatasync() on Windows. > This mechanism

Re: extended stats on partitioned tables

2021-12-11 Thread Tomas Vondra
On 12/12/21 05:38, Zhihong Yu wrote: > > > On Sat, Dec 11, 2021 at 8:17 PM Tomas Vondra > mailto:tomas.von...@enterprisedb.com>> > wrote: > > Hi, > > Attached is a rebased and cleaned-up version of these patches, with more > comments, refactorings etc. Justin and Zhihong, can

Re: extended stats on partitioned tables

2021-12-11 Thread Zhihong Yu
On Sat, Dec 11, 2021 at 8:17 PM Tomas Vondra wrote: > Hi, > > Attached is a rebased and cleaned-up version of these patches, with more > comments, refactorings etc. Justin and Zhihong, can you take a look? > > > 0001 - Ignore extended statistics for inheritance trees > > 0002 - Build inherited

Re: extended stats on partitioned tables

2021-12-11 Thread Tomas Vondra
Hi, Attached is a rebased and cleaned-up version of these patches, with more comments, refactorings etc. Justin and Zhihong, can you take a look? 0001 - Ignore extended statistics for inheritance trees 0002 - Build inherited extended stats on partitioned tables Those are mostly just Justin's

pg_upgrade should truncate/remove its logs before running

2021-12-11 Thread Justin Pryzby
I have seen this numerous times but had not dug into it, until now. If pg_upgrade fails and is re-run, it appends to its logfiles, which is confusing since, if it fails again, it then looks like the original error recurred and wasn't fixed. The "append" behavior dates back to 717f6d608. I think

Windows now has fdatasync()

2021-12-11 Thread Thomas Munro
Hi, While porting some new IO code to lots of OSes I noticed in passing that there is now a way to do synchronous fdatasync() on Windows. This mechanism doesn't have an async variant, which is what I was actually looking for (which turns out to doable with bleeding edge IoRings, more on that

Re: Unifying VACUUM VERBOSE and log_autovacuum_min_duration output

2021-12-11 Thread Peter Geoghegan
On Sat, Dec 11, 2021 at 2:52 PM Andres Freund wrote: > I feel one, or both, must be missing something here. My point was that you > said upthread that the patch doesn't change DEBUG2/non-verbose logging for > most messages. But the fact that those messages are only emitted inside and if >

Re: Unifying VACUUM VERBOSE and log_autovacuum_min_duration output

2021-12-11 Thread Andres Freund
Hi, On 2021-12-11 13:13:56 -0800, Peter Geoghegan wrote: > On Sat, Dec 11, 2021 at 12:24 PM Andres Freund wrote: > > But the ereport is inside an if (verbose), no? > > Yes -- in order to report aggressiveness in VACUUM VERBOSE. But the > autovacuum case still reports verbose-ness, in the same

Re: pg_upgrade failing for 200+ million Large Objects

2021-12-11 Thread Justin Pryzby
On Wed, Mar 24, 2021 at 12:05:27PM -0400, Jan Wieck wrote: > On 3/24/21 12:04 PM, Jan Wieck wrote: > > In any case I changed the options so that they behave the same way, the > > existing -o and -O (for old/new postmaster options) work. I don't think > > it would be wise to have option forwarding

Re: Building postgresql from sources, statically linked, linux

2021-12-11 Thread Tom Lane
Rob Gansevles writes: > I would like to have a statically linked linux x64 version of postgresql > 14.1 for creating a distributable sample database. If you are trying to make the server into a monolithic object, that's not something we support or have any particular interest in supporting.

Re: Unifying VACUUM VERBOSE and log_autovacuum_min_duration output

2021-12-11 Thread Peter Geoghegan
On Sat, Dec 11, 2021 at 1:13 PM Peter Geoghegan wrote: > Yes -- in order to report aggressiveness in VACUUM VERBOSE. But the > autovacuum case still reports verbose-ness, in the same way as it > always has -- in that same LOG entry. We don't want to repeat > ourselves in the VERBOSE case, which

Re: Unifying VACUUM VERBOSE and log_autovacuum_min_duration output

2021-12-11 Thread Peter Geoghegan
On Sat, Dec 11, 2021 at 12:24 PM Andres Freund wrote: > But the ereport is inside an if (verbose), no? Yes -- in order to report aggressiveness in VACUUM VERBOSE. But the autovacuum case still reports verbose-ness, in the same way as it always has -- in that same LOG entry. We don't want to

Re: Unifying VACUUM VERBOSE and log_autovacuum_min_duration output

2021-12-11 Thread Andres Freund
On 2021-12-11 09:52:29 -0800, Peter Geoghegan wrote: > On Fri, Dec 10, 2021 at 8:30 PM Andres Freund wrote: > > I think some actually ended up being omitted compared to the previous > > state. E.g. "aggressively vacuuming ...", but I think others as well. > > The "aggressive-ness" is reported by

Building postgresql from sources, statically linked, linux

2021-12-11 Thread Rob Gansevles
Hi, I would like to have a statically linked linux x64 version of postgresql 14.1 for creating a distributable sample database. I could not find it anywhere for downloading (someone has a link maybe?), so I tried to build one from the sources. I am following the instructions on

Re: Add spin_delay() implementation for Arm in s_lock.h

2021-12-11 Thread Tom Lane
"Blake, Geoff" writes: > Have a tiny patch to add an implementation of spin_delay() for Arm64 > processors to match behavior with x86's PAUSE instruction. See negligible > benefit on the pgbench tpcb-like workload so at worst it appears to do no > harm but should help some workloads that

Re: Dubious usage of TYPCATEGORY_STRING

2021-12-11 Thread Tom Lane
Peter Eisentraut writes: > On 07.12.21 21:24, Tom Lane wrote: >> Um, I definitely gave up too easily there. The one usage in \dp >> seems to be the*only* thing that breaks in describe.c, and pg_dump >> doesn't need any changes so far as check-world reveals. So let's >> just move "char" to

Re: Unifying VACUUM VERBOSE and log_autovacuum_min_duration output

2021-12-11 Thread Peter Geoghegan
On Fri, Dec 10, 2021 at 8:30 PM Andres Freund wrote: > I think some actually ended up being omitted compared to the previous > state. E.g. "aggressively vacuuming ...", but I think others as well. The "aggressive-ness" is reported by a distinct ereport() with the patch, so you'll still see that

Re: Re: 回复:Re: Is it worth pushing conditions to sublink/subplan?

2021-12-11 Thread Zhihong Yu
On Sat, Dec 11, 2021 at 7:31 AM 曾文旌(义从) wrote: > > > --原始邮件 -- > *发件人:*Tomas Vondra > *发送时间:*Wed Dec 8 11:26:35 2021 > *收件人:*曾文旌(义从) , shawn wang < > shawn.wang...@gmail.com>, ggys...@gmail.com , > PostgreSQL Hackers > *抄送:*wjzeng > *主题:*Re: 回复:Re: Is it worth

回复:Re: 回复:Re: Is it worth pushing conditions to sublink/subplan?

2021-12-11 Thread 曾文旌(义从)
--原始邮件 -- 发件人:Tomas Vondra 发送时间:Wed Dec 8 11:26:35 2021 收件人:曾文旌(义从) , shawn wang , ggys...@gmail.com , PostgreSQL Hackers 抄送:wjzeng 主题:Re: 回复:Re: Is it worth pushing conditions to sublink/subplan? Hi, On 12/7/21 10:44, 曾文旌(义从) wrote: > Hi Hackers > > For

Re: pg_dump versus ancient server versions

2021-12-11 Thread Andrew Dunstan
On 12/9/21 12:50, Tom Lane wrote: > > In short then, there is a really large gap between 9.1 and 9.2 in terms > of how hard they are to build on current toolchains. It's kind of > fortunate that Peter proposed 9.2 rather than some earlier cutoff. > In any case, I've completely lost interest in

Re: parallel vacuum comments

2021-12-11 Thread Masahiko Sawada
On Sat, Dec 11, 2021 at 2:32 PM Andres Freund wrote: > > Hi, > > On 2021-10-30 14:21:01 -0700, Andres Freund wrote: > > Due to bug #17245: [1] I spent a considerably amount of time looking at > > vacuum > > related code. And I found a few things that I think could stand improvement: Thank you

Re: isolationtester: add session name to application name

2021-12-11 Thread Andrew Dunstan
On 12/10/21 20:20, Andres Freund wrote: > The attached patch executes > SELECT set_config('application_name', current_setting('application_name') > || '/' || $1, false); > when establishing connections to deal with that. Sounds good > > As attached this appends "control connection" for