Re: [PoC] configurable out of disk space elog level

2022-11-17 Thread Maxim Orlov
On Wed, 16 Nov 2022 at 20:41, Andres Freund wrote: > Hi, > You can't do catalog access below the bufmgr.c layer. It could lead to all > kinds of nastiness, including potentially recursing back to md.c. Even > leaving > Yep, this is my biggest concern. It turns out, that the way to make such a

Re: logical decoding and replication of sequences, take 2

2022-11-17 Thread Tomas Vondra
On 11/17/22 03:43, Andres Freund wrote: > Hi, > > > On 2022-11-17 02:41:14 +0100, Tomas Vondra wrote: >> Well, yeah - we can either try to perform the stuff independently of the >> transactions that triggered it, or we can try making it part of some of >> the transactions. Each of those

Re: locale -a missing on Alpine Linux?

2022-11-17 Thread Peter Eisentraut
On 16.11.22 20:25, Tom Lane wrote: Christoph Moench-Tegeder writes: ## Peter Eisentraut (peter.eisentr...@enterprisedb.com): First of all, is this a standard installation of this OS, or is perhaps something incomplete, broken, or unusual about the current OS installation? Alpine uses musl

Re: [PoC] Reducing planning time when tables have many partitions

2022-11-17 Thread Thom Brown
On Thu, 17 Nov 2022 at 09:31, Alvaro Herrera wrote: > > On 2022-Nov-16, Thom Brown wrote: > > > Once the issue Tom identified has been resolved, I'd like to test > > drive newer patches. > > What issue? If you mean the one from the thread "Reducing > duplicativeness of EquivalenceClass-derived

Re: [PATCH] Compression dictionaries for JSONB

2022-11-17 Thread Aleksander Alekseev
Hi hackers, > 8272749e added a few more arguments to CastCreate(). Here is the rebased > patch. After merging afbfc029 [1] the patch needed a rebase. PFA v10. The patch is still in a PoC state and this is exactly why comments and suggestions from the community are most welcome! Particularly I

Re: TAP output format in pg_regress

2022-11-17 Thread Daniel Gustafsson
> On 10 Nov 2022, at 11:44, Nikolay Shaplov wrote: > I've checked new output, if is conform TAP specification. Checked that prove > consumes new pg_regress output well. Great! > Did not found quick way to include prove TAP harness right into Makefile, so > I > check dumped output, but it is

Re: [PATCH] Support % wildcard in extension upgrade filenames

2022-11-17 Thread Sandro Santilli
On Wed, Nov 16, 2022 at 05:25:07PM -0600, Justin Pryzby wrote: > Note that the patch is passing tests when using autoconf build but > failing for meson builds. Thanks for pointing me to the right direction. I'm attaching an updated patch, will keep an eye on cirrusCI --strk; >From

Typo in SH_LOOKUP and SH_LOOKUP_HASH comments

2022-11-17 Thread vignesh C
Hi, When I was reviewing one of the patches, I found a typo in the comments of SH_LOOKUP and SH_LOOKUP_HASH. I felt "lookup up" should have been "lookup". Attached a patch to modify it. Regards, Vignesh From 03feb3121dbd9a78547a15cf5998e44ffb65626e Mon Sep 17 00:00:00 2001 From: Vignesh C Date:

Re: [PoC] Reducing planning time when tables have many partitions

2022-11-17 Thread Alvaro Herrera
On 2022-Nov-16, Thom Brown wrote: > Once the issue Tom identified has been resolved, I'd like to test > drive newer patches. What issue? If you mean the one from the thread "Reducing duplicativeness of EquivalenceClass-derived clauses", that patch is already applied (commit a5fc46414deb), and

Re: Odd behavior with pg_stat_statements and queries called from SQL functions

2022-11-17 Thread Ashutosh Bapat
On Thu, Nov 17, 2022 at 2:44 PM Julien Rouhaud wrote: > > Hi, > > On Wed, Nov 16, 2022 at 11:26:09PM -0800, Maciek Sakrejda wrote: > > I noticed an odd behavior today in pg_stat_statements query > > normalization for queries called from SQL-language functions. If I > > have three functions that

Re: Odd behavior with pg_stat_statements and queries called from SQL functions

2022-11-17 Thread Julien Rouhaud
Hi, On Wed, Nov 16, 2022 at 11:26:09PM -0800, Maciek Sakrejda wrote: > I noticed an odd behavior today in pg_stat_statements query > normalization for queries called from SQL-language functions. If I > have three functions that call an essentially identical query (the > functions are only marked

Re: Fix the README file for MERGE command

2022-11-17 Thread Daniel Gustafsson
> On 17 Nov 2022, at 02:31, Richard Guo wrote: > On Wed, Nov 16, 2022 at 4:37 PM Waithant Myo (Fujitsu) > mailto:myo.waith...@fujitsu.com>> wrote: > Therefore, I attached the patch file which fix this word usage. > > It would be great if you could take a look at it. > > Apparently this is a

Re: Making Vars outer-join aware

2022-11-17 Thread Richard Guo
On Thu, Nov 17, 2022 at 4:46 AM Tom Lane wrote: > So we've marked the 4 and 7 joins as possibly commuting, but they > cannot commute according to 7's min_lefthand set. I don't think > the extra clone condition is terribly harmful --- it's useless > but shouldn't cause any problems. However, if

Re: Typo for xl_running_xacts

2022-11-17 Thread Japin Li
On Thu, 17 Nov 2022 at 16:22, Daniel Gustafsson wrote: >> On 17 Nov 2022, at 08:06, Japin Li wrote: > >> I find some typo about xl_running_xacts in comments. >> Attached a patch to fix those. > > Thanks, applied! > >> - * might look that we could use xl_running_xact's ->xids information to

Re: Typo for xl_running_xacts

2022-11-17 Thread Daniel Gustafsson
> On 17 Nov 2022, at 08:06, Japin Li wrote: > I find some typo about xl_running_xacts in comments. > Attached a patch to fix those. Thanks, applied! > - * might look that we could use xl_running_xact's ->xids information to > + * might look that we could use xl_running_xacts->xids

<    1   2