Re: PG_CATCH used without PG_RETHROW

2023-08-02 Thread
Hi, I think this is a bug because this function's CATCH clause does not restore memroycontext. Thus when leaving the function, the CurrentMemroyContext will be ErrorMemroyContext. I see this part of code is refactored in master branch, but in REL_16_STABLE, the code is still there. The following

Re: Don't treate IndexStmt like AlterTable when DefineIndex is called from ProcessUtilitySlow.

2022-11-17 Thread
Hi, thanks a lot for your reply! > Why do you think this is an improvement? I hit the issue in Greenplum Database (Massively Parallel Postgres), the MPP architecture is that coordinator dispatch statement to segments. The dispatch logic is quit different for AlterTable and CreateTableLike: *

Don't treate IndexStmt like AlterTable when DefineIndex is called from ProcessUtilitySlow.

2022-11-17 Thread
Hi, Recently read the code, I find that when calling DefineIndex from ProcessUtilitySlow, is_alter_table will be set true if this statement is came from expandTableLikeClause. I check the code of DefineIndex, there are only two places use is_alter_table: 1. the function