On Wed, 29 Mar 2023 at 00:57, samay sharma wrote:
>
> Hi,
>
> On Wed, Mar 15, 2023 at 4:28 AM Peter Eisentraut
> wrote:
>>
>> > [PATCH v8 1/5] Make minor additions and corrections to meson docs
>>
>> The last hunk revealed that there is some mixing up between meson setup
>> and meson
On 10.06.23 06:00, Andres Freund wrote:
From c5e637a54c2b83e5bd8c4155784d97e82937eb51 Mon Sep 17 00:00:00 2001
From: Samay Sharma
Date: Mon, 6 Feb 2023 16:09:42 -0800
Subject: [PATCH v9 2/5] Add data layout options sub-section in installation
docs
This commit separates out blocksize, segsize
Hi,
On 2023-03-28 12:27:26 -0700, samay sharma wrote:
> +
> +If you want to build the docs, you can type:
> +
> +ninja docs
> +
> +
To me 'you can type' sounds odd. To me even just "To build the docs:" would
sound better. But the make docs do it "your" way, so I'll just go along with
On Wed Apr 12, 2023 at 4:19 PM CDT, Peter Eisentraut wrote:
> On 11.04.23 19:18, Andres Freund wrote:
> >> Subject: [PATCH v9 2/5] Add data layout options sub-section in installation
> >> docs
> >>
> >> This commit separates out blocksize, segsize and wal_blocksize
> >> options into a separate
Hey!
Nice work organizing the docs. Looks pretty good. I had a single comment
regarding the Meson docs in general.
It seems like Postgres cares a bit about Windows/Mac development. Is
ninja the blessed way to build Postgres on Windows and Mac? Otherwise, I
would suggest just being more generic
On 11.04.23 19:18, Andres Freund wrote:
Subject: [PATCH v9 2/5] Add data layout options sub-section in installation
docs
This commit separates out blocksize, segsize and wal_blocksize
options into a separate Data layout options sub-section in both
the make and meson docs. They were earlier in
Hi,
On Tue, Apr 11, 2023 at 10:18 AM Andres Freund wrote:
> Hi,
>
> On 2023-03-28 12:27:26 -0700, samay sharma wrote:
> > Subject: [PATCH v9 1/5] Make minor additions and corrections to meson
> docs
> >
> > This commit makes a few corrections to the meson docs
> > and adds a few instructions
Hi,
On 2023-03-28 12:27:26 -0700, samay sharma wrote:
> Subject: [PATCH v9 1/5] Make minor additions and corrections to meson docs
>
> This commit makes a few corrections to the meson docs
> and adds a few instructions and links for better clarity.
> ---
> doc/src/sgml/installation.sgml | 24
Hi,
On Wed, Mar 15, 2023 at 4:28 AM Peter Eisentraut <
peter.eisentr...@enterprisedb.com> wrote:
> > [PATCH v8 1/5] Make minor additions and corrections to meson docs
>
> The last hunk revealed that there is some mixing up between meson setup
> and meson configure. This goes a bit further.
> [PATCH v8 1/5] Make minor additions and corrections to meson docs
The last hunk revealed that there is some mixing up between meson setup
and meson configure. This goes a bit further. For example, earlier it
says that to get a list of meson setup options, call meson configure
--help and
Hi,
On Thu, Dec 1, 2022 at 9:21 AM Andres Freund wrote:
> Hi,
>
> On 2022-12-01 15:58:39 +0100, Peter Eisentraut wrote:
> > On 23.11.22 22:24, samay sharma wrote:
> > > Thank you. Attaching v7 addressing most of the points below.
> >
> > I have committed this, after some editing and making some
Hi,
On 2022-12-01 15:58:39 +0100, Peter Eisentraut wrote:
> On 23.11.22 22:24, samay sharma wrote:
> > Thank you. Attaching v7 addressing most of the points below.
>
> I have committed this, after some editing and making some structural
> changes.
Thanks. I was working on that too, but somehow
On 23.11.22 22:24, samay sharma wrote:
Thank you. Attaching v7 addressing most of the points below.
I have committed this, after some editing and making some structural
changes. I moved the "Requirements" section back to the top level. It
did not look appealing to have to maintain two
Thanks; two more things I saw:
- In other docs, isn't used around { a | b } lists:
git grep '[^<]*|' doc
- I think this is(was) missing a word;
Setting this option allows you to override THE value of all 'auto' features
--
Justin
Hi,
On Wed, Nov 23, 2022 at 12:16 PM Justin Pryzby wrote:
> On Wed, Nov 23, 2022 at 11:30:54AM -0800, samay sharma wrote:
> > Thanks for the feedback. Addressed all and added markup at a few more
> > places in v6 (attached).
>
> Thanks. It looks good to me. A couple thoughts, maybe they're
On Wed, Nov 23, 2022 at 11:30:54AM -0800, samay sharma wrote:
> Thanks for the feedback. Addressed all and added markup at a few more
> places in v6 (attached).
Thanks. It looks good to me. A couple thoughts, maybe they're not
important.
- LZ4 and Zstd refer to wal_compression and
Hi,
On Tue, Nov 22, 2022 at 10:36 PM Justin Pryzby wrote:
> On Mon, Nov 14, 2022 at 10:41:21AM -0800, samay sharma wrote:
>
> > You need LZ4, if you want to support compression of data with that
> > method; see default_toast_compression and wal_compression.
>
> => The first comma is odd. Maybe
On Mon, Nov 14, 2022 at 10:41:21AM -0800, samay sharma wrote:
> You need LZ4, if you want to support compression of data with that
> method; see default_toast_compression and wal_compression.
=> The first comma is odd. Maybe it should say "LZ4 is needed to
support .."
> You need Zstandard, if
On Wed, Nov 16, 2022 at 10:52:35AM +0900, Ian Lawrence Barwick wrote:
> 2022年10月20日(木) 11:43 Justin Pryzby :
> >
> > On Wed, Oct 19, 2022 at 11:35:10AM -0700, samay sharma wrote:
> > > Creating a new thread focussed on adding docs for building Postgres with
> > > meson. This is a spinoff from the
2022年10月20日(木) 11:43 Justin Pryzby :
>
> On Wed, Oct 19, 2022 at 11:35:10AM -0700, samay sharma wrote:
> > Creating a new thread focussed on adding docs for building Postgres with
> > meson. This is a spinoff from the original thread [1] and I've attempted to
> > address all the feedback provided
Hi,
On Thu, Nov 10, 2022 at 4:46 AM Nazir Bilal Yavuz
wrote:
> Hi,
>
> I did some tests on windows. I used 'ninja' as a backend.
> On 11/8/2022 9:23 PM, samay sharma wrote:
>
> Hi,
>
> On Sat, Nov 5, 2022 at 2:39 PM Andres Freund wrote:
>
>> Hi,
>>
>> On 2022-10-30 20:51:59 -0700, samay sharma
Hi,
I did some tests on windows. I used 'ninja' as a backend.
On 11/8/2022 9:23 PM, samay sharma wrote:
Hi,
On Sat, Nov 5, 2022 at 2:39 PM Andres Freund wrote:
Hi,
On 2022-10-30 20:51:59 -0700, samay sharma wrote:
> +# setup and enter build directory (done only first time)
Hi,
On 2022-10-30 20:51:59 -0700, samay sharma wrote:
> +# setup and enter build directory (done only first time)
> +meson setup build src --prefix=$PWD/install
This command won't work on windows, I think.
> +
> + Configuring the build
> +
> +
> +The first step of the installation
Hi,
On Thu, Oct 27, 2022 at 1:04 AM John Naylor
wrote:
> +# Run the main pg_regress and isolation tests
> +meson test --suite main
>
> This does not work for me in a fresh install until running
>
> meson test --suite setup
>
> In fact, we see in
>
> https://wiki.postgresql.org/wiki/Meson
>
>
On Thu, Oct 27, 2022 at 4:03 PM Andres Freund wrote:
> Tests can have dependencies, and they're correctly built. The problem however
> is that, for historical reasons if I understand correctly, dependencies of
> tests are automatically included in the default 'all' target. Which means if
> you
Hi,
On 2022-10-27 14:15:32 -0700, Jacob Champion wrote:
> On Thu, Oct 27, 2022 at 1:04 AM John Naylor
> wrote:
> > This does not work for me in a fresh install until running
> >
> > meson test --suite setup
> >
> > In fact, we see in
> >
> > https://wiki.postgresql.org/wiki/Meson
> >
> > meson
On Thu, Oct 27, 2022 at 1:04 AM John Naylor
wrote:
> This does not work for me in a fresh install until running
>
> meson test --suite setup
>
> In fact, we see in
>
> https://wiki.postgresql.org/wiki/Meson
>
> meson test --suite setup --suite main
(Is there a way to declare a dependency on the
+# Run the main pg_regress and isolation tests
+meson test --suite main
This does not work for me in a fresh install until running
meson test --suite setup
In fact, we see in
https://wiki.postgresql.org/wiki/Meson
meson test --suite setup --suite main
That was just an eyeball check from a
Hi,
On Wed, Oct 19, 2022 at 7:43 PM Justin Pryzby wrote:
> On Wed, Oct 19, 2022 at 11:35:10AM -0700, samay sharma wrote:
> > Creating a new thread focussed on adding docs for building Postgres with
> > meson. This is a spinoff from the original thread [1] and I've attempted
> to
> > address all
On Wed, Oct 19, 2022 at 11:35:10AM -0700, samay sharma wrote:
> Creating a new thread focussed on adding docs for building Postgres with
> meson. This is a spinoff from the original thread [1] and I've attempted to
> address all the feedback provided there in the attached patch.
>
> Please let me
Hi,
Creating a new thread focussed on adding docs for building Postgres with
meson. This is a spinoff from the original thread [1] and I've attempted to
address all the feedback provided there in the attached patch.
Please let me know your thoughts.
[1]
31 matches
Mail list logo
