Re: Remove a FIXME and unused variables in Meson

2024-03-18 Thread Peter Eisentraut
On 14.03.24 06:13, Tristan Partin wrote: One of them adds version gates to two LLVM flags (-frwapv, -fno-strict-aliasing). I believe we moved the minimum LLVM version recently, so these might not be necessary, but maybe it helps for historictal reasons. If not, I'll just remove the comment in

Re: Remove a FIXME and unused variables in Meson

2024-03-13 Thread Tristan Partin
On Thu Mar 14, 2024 at 12:15 AM CDT, Michael Paquier wrote: On Thu, Mar 14, 2024 at 12:13:18AM -0500, Tristan Partin wrote: > One of them adds version gates to two LLVM flags (-frwapv, > -fno-strict-aliasing). I believe we moved the minimum LLVM version recently, > so these might not be

Re: Remove a FIXME and unused variables in Meson

2024-03-13 Thread Michael Paquier
On Thu, Mar 14, 2024 at 12:13:18AM -0500, Tristan Partin wrote: > One of them adds version gates to two LLVM flags (-frwapv, > -fno-strict-aliasing). I believe we moved the minimum LLVM version recently, > so these might not be necessary, but maybe it helps for historictal reasons. > If not, I'll

Remove a FIXME and unused variables in Meson

2024-03-13 Thread Tristan Partin
Two meson patches. One of them adds version gates to two LLVM flags (-frwapv, -fno-strict-aliasing). I believe we moved the minimum LLVM version recently, so these might not be necessary, but maybe it helps for historictal reasons. If not, I'll just remove the comment in a different patch.