Re: Strengthen pg_waldump's --save-fullpage tests

2023-01-11 Thread Drouvot, Bertrand
Hi, On 1/12/23 5:44 AM, Michael Paquier wrote: On Wed, Jan 11, 2023 at 07:17:47PM +0530, Bharath Rupireddy wrote: Note that the raw page on the table might differ not just in page LSN but also in other fields, for instance see heap_mask for instance. It masks lsn, checksum, hint bits, unused

Re: Strengthen pg_waldump's --save-fullpage tests

2023-01-11 Thread Bharath Rupireddy
On Thu, Jan 12, 2023 at 10:14 AM Michael Paquier wrote: > > On Wed, Jan 11, 2023 at 07:17:47PM +0530, Bharath Rupireddy wrote: > > Note that the raw page on the table might differ not just in page LSN > > but also in other fields, for instance see heap_mask for instance. It > > masks lsn,

Re: Strengthen pg_waldump's --save-fullpage tests

2023-01-11 Thread Michael Paquier
On Wed, Jan 11, 2023 at 07:17:47PM +0530, Bharath Rupireddy wrote: > Note that the raw page on the table might differ not just in page LSN > but also in other fields, for instance see heap_mask for instance. It > masks lsn, checksum, hint bits, unused space etc. before verifying FPI > consistency

Re: Strengthen pg_waldump's --save-fullpage tests

2023-01-11 Thread Bharath Rupireddy
On Wed, Jan 11, 2023 at 3:28 PM Drouvot, Bertrand wrote: > > Hi, > > On 1/11/23 5:17 AM, Bharath Rupireddy wrote: > > On Wed, Jan 11, 2023 at 6:32 AM Michael Paquier wrote: > >> > >> On Tue, Jan 10, 2023 at 05:25:44PM +0100, Drouvot, Bertrand wrote: > >>> I like the idea of comparing the full

Re: Strengthen pg_waldump's --save-fullpage tests

2023-01-11 Thread Drouvot, Bertrand
Hi, On 1/11/23 5:17 AM, Bharath Rupireddy wrote: On Wed, Jan 11, 2023 at 6:32 AM Michael Paquier wrote: On Tue, Jan 10, 2023 at 05:25:44PM +0100, Drouvot, Bertrand wrote: I like the idea of comparing the full page (and not just the LSN) but I'm not sure that adding the pageinspect

Re: Strengthen pg_waldump's --save-fullpage tests

2023-01-10 Thread Bharath Rupireddy
On Wed, Jan 11, 2023 at 6:32 AM Michael Paquier wrote: > > On Tue, Jan 10, 2023 at 05:25:44PM +0100, Drouvot, Bertrand wrote: > > I like the idea of comparing the full page (and not just the LSN) but > > I'm not sure that adding the pageinspect dependency is a good thing. > > > > What about

Re: Strengthen pg_waldump's --save-fullpage tests

2023-01-10 Thread Michael Paquier
On Tue, Jan 10, 2023 at 05:25:44PM +0100, Drouvot, Bertrand wrote: > I like the idea of comparing the full page (and not just the LSN) but > I'm not sure that adding the pageinspect dependency is a good thing. > > What about extracting the block directly from the relation file and > comparing it

Re: Strengthen pg_waldump's --save-fullpage tests

2023-01-10 Thread Drouvot, Bertrand
Hi, On 1/10/23 2:22 AM, Michael Paquier wrote: On Mon, Jan 09, 2023 at 08:30:00AM +0530, Bharath Rupireddy wrote: A recent commit [1] added --save-fullpage option to pg_waldump to extract full page images (FPI) from WAL records and save them into files (one file per FPI) under a specified

Re: Strengthen pg_waldump's --save-fullpage tests

2023-01-09 Thread Bharath Rupireddy
On Tue, Jan 10, 2023 at 6:52 AM Michael Paquier wrote: > > On Mon, Jan 09, 2023 at 08:30:00AM +0530, Bharath Rupireddy wrote: > > A recent commit [1] added --save-fullpage option to pg_waldump to > > extract full page images (FPI) from WAL records and save them into > > files (one file per FPI)

Re: Strengthen pg_waldump's --save-fullpage tests

2023-01-09 Thread Michael Paquier
On Mon, Jan 09, 2023 at 08:30:00AM +0530, Bharath Rupireddy wrote: > A recent commit [1] added --save-fullpage option to pg_waldump to > extract full page images (FPI) from WAL records and save them into > files (one file per FPI) under a specified directory. While it added > tests to check the

Strengthen pg_waldump's --save-fullpage tests

2023-01-08 Thread Bharath Rupireddy
Rupireddy PostgreSQL Contributors Team RDS Open Source Databases Amazon Web Services: https://aws.amazon.com From f714f13f47f98c7b9a4f88539c76862cacaffe49 Mon Sep 17 00:00:00 2001 From: Bharath Rupireddy Date: Sat, 7 Jan 2023 08:29:28 + Subject: [PATCH v1] Strengthen pg_waldump's --save