Re: add --no-sync to pg_upgrade's calls to pg_dump and pg_dumpall

2024-05-09 Thread Daniel Gustafsson
> On 9 May 2024, at 21:34, Nathan Bossart wrote: > > On Thu, May 09, 2024 at 09:03:56AM +0900, Michael Paquier wrote: >> +1. Could there be an argument in favor of a backpatch? This is a >> performance improvement, but one could also side that the addition of >> sync support in pg_dump[all]

Re: add --no-sync to pg_upgrade's calls to pg_dump and pg_dumpall

2024-05-09 Thread Nathan Bossart
On Thu, May 09, 2024 at 09:03:56AM +0900, Michael Paquier wrote: > +1. Could there be an argument in favor of a backpatch? This is a > performance improvement, but one could also side that the addition of > sync support in pg_dump[all] has made that a regression that we'd > better fix because

Re: add --no-sync to pg_upgrade's calls to pg_dump and pg_dumpall

2024-05-08 Thread Michael Paquier
On Wed, May 08, 2024 at 02:49:58PM -0400, Tom Lane wrote: > Nathan Bossart writes: >> Thanks for looking. I noticed that the version check is unnecessary since >> we always use the new binary's pg_dump[all], so I removed that in v2. > > +1 +1. Could there be an argument in favor of a

Re: add --no-sync to pg_upgrade's calls to pg_dump and pg_dumpall

2024-05-08 Thread Tom Lane
Nathan Bossart writes: > Thanks for looking. I noticed that the version check is unnecessary since > we always use the new binary's pg_dump[all], so I removed that in v2. +1 regards, tom lane

Re: add --no-sync to pg_upgrade's calls to pg_dump and pg_dumpall

2024-05-08 Thread Nathan Bossart
On Wed, May 08, 2024 at 10:09:46AM +0200, Peter Eisentraut wrote: > On 03.05.24 19:13, Nathan Bossart wrote: >> This is likely small potatoes compared to some of the other >> pg_upgrade-related improvements I've proposed [0] [1] or plan to propose, >> but this is easy enough, and I already wrote

Re: add --no-sync to pg_upgrade's calls to pg_dump and pg_dumpall

2024-05-08 Thread Peter Eisentraut
On 03.05.24 19:13, Nathan Bossart wrote: This is likely small potatoes compared to some of the other pg_upgrade-related improvements I've proposed [0] [1] or plan to propose, but this is easy enough, and I already wrote the patch, so here it is. AFAICT there's no reason to bother syncing these

add --no-sync to pg_upgrade's calls to pg_dump and pg_dumpall

2024-05-03 Thread Nathan Bossart
This is likely small potatoes compared to some of the other pg_upgrade-related improvements I've proposed [0] [1] or plan to propose, but this is easy enough, and I already wrote the patch, so here it is. AFAICT there's no reason to bother syncing these dump files to disk. If someone pulls the