Re: pg_rewind race condition just after promotion

2023-02-23 Thread Heikki Linnakangas
On 22/02/2023 16:00, Heikki Linnakangas wrote: On 11/12/2022 02:01, Ian Lawrence Barwick wrote: 2021年11月9日(火) 20:31 Daniel Gustafsson : On 14 Jul 2021, at 14:03, Aleksander Alekseev wrote: The following review has been posted through the commitfest application: make installcheck-world:

Re: pg_rewind race condition just after promotion

2023-02-22 Thread Heikki Linnakangas
On 11/12/2022 02:01, Ian Lawrence Barwick wrote: 2021年11月9日(火) 20:31 Daniel Gustafsson : On 14 Jul 2021, at 14:03, Aleksander Alekseev wrote: The following review has been posted through the commitfest application: make installcheck-world: tested, passed Implements feature: tested,

Re: pg_rewind race condition just after promotion

2022-12-10 Thread Ian Lawrence Barwick
2021年11月9日(火) 20:31 Daniel Gustafsson : > > > On 14 Jul 2021, at 14:03, Aleksander Alekseev > > wrote: > > > > The following review has been posted through the commitfest application: > > make installcheck-world: tested, passed > > Implements feature: tested, passed > > Spec compliant:

Re: pg_rewind race condition just after promotion

2021-11-09 Thread Daniel Gustafsson
> On 14 Jul 2021, at 14:03, Aleksander Alekseev > wrote: > > The following review has been posted through the commitfest application: > make installcheck-world: tested, passed > Implements feature: tested, passed > Spec compliant: tested, passed > Documentation:

Re: pg_rewind race condition just after promotion

2021-07-14 Thread Aleksander Alekseev
The following review has been posted through the commitfest application: make installcheck-world: tested, passed Implements feature: tested, passed Spec compliant: tested, passed Documentation:tested, passed The v3 patch LGTM. I wonder if we should explicitly say in

Re: pg_rewind race condition just after promotion

2021-03-08 Thread Ibrar Ahmed
On Wed, Dec 9, 2020 at 6:35 PM Heikki Linnakangas wrote: > On 08/12/2020 06:45, Kyotaro Horiguchi wrote: > > At Mon, 7 Dec 2020 20:13:25 +0200, Heikki Linnakangas > wrote in > >> I think we should fix this properly. I'm not sure if it can lead to a > >> broken cluster, but at least it can cause

Re: pg_rewind race condition just after promotion

2020-12-09 Thread Heikki Linnakangas
On 08/12/2020 06:45, Kyotaro Horiguchi wrote: At Mon, 7 Dec 2020 20:13:25 +0200, Heikki Linnakangas wrote in I think we should fix this properly. I'm not sure if it can lead to a broken cluster, but at least it can cause pg_rewind to fail unnecessarily and in a user-unfriendly way. But this is

Re: pg_rewind race condition just after promotion

2020-12-07 Thread Kyotaro Horiguchi
At Mon, 7 Dec 2020 20:13:25 +0200, Heikki Linnakangas wrote in > There's a race condition between the checkpoint at promotion and > pg_rewind. When a server is promoted, the startup process writes an > end-of-recovery checkpoint that includes the new TLI, and the server > is immediate opened

pg_rewind race condition just after promotion

2020-12-07 Thread Heikki Linnakangas
There's a race condition between the checkpoint at promotion and pg_rewind. When a server is promoted, the startup process writes an end-of-recovery checkpoint that includes the new TLI, and the server is immediate opened for business. The startup process requests the checkpointer process to