Re: [HACKERS] fixing Makefile.shlib for solaris/gcc with -m64 flag

2007-02-20 Thread Bruce Momjian
OK, I have made Solaris gcc the same as Linux in Makefile.shlib, patch attached. I am not backpatching this. We will get this tested for 8.3. --- Jignesh K. Shah wrote: I dont think we solved this.. But I think the way

Re: [HACKERS] fixing Makefile.shlib for solaris/gcc with -m64 flag

2007-02-01 Thread Jignesh K. Shah
I dont think we solved this.. But I think the way to put -m64 should be same as in Linux and Solaris and not different. Thanks. Regards, Jignesh Tom Lane wrote: Peter Eisentraut [EMAIL PROTECTED] writes: Am Mittwoch, 17. Januar 2007 17:12 schrieb Tom Lane: Jignesh K. Shah [EMAIL PROTECTED]

Re: [HACKERS] fixing Makefile.shlib for solaris/gcc with -m64 flag

2007-01-31 Thread Tom Lane
Peter Eisentraut [EMAIL PROTECTED] writes: Am Mittwoch, 17. Januar 2007 17:12 schrieb Tom Lane: Jignesh K. Shah [EMAIL PROTECTED] writes: simple if I use -m64 for 64 bit then all end binaries are generated 64-bit and the shared libraries are generated 32-bit and the compilation fails (ONLY ON

[HACKERS] fixing Makefile.shlib for solaris/gcc with -m64 flag

2007-01-17 Thread Jignesh K. Shah
Hello All, When I compile with gcc on Solaris with -m64 flags, all shared lbiraries fail. Can someone fix the following in Makefile.shlib ifeq ($(PORTNAME), solaris) ifeq ($(GCC), yes) LINK.shared = $(CC) -shared else LINK.shared = $(CC) -G $(CFLAGS)# CFLAGS

Re: [HACKERS] fixing Makefile.shlib for solaris/gcc with -m64 flag

2007-01-17 Thread Tom Lane
Jignesh K. Shah [EMAIL PROTECTED] writes: It should be LINK.shared = $(COMPILER) -shared Why? What's the difference, and why is it appropriate to fix it that way instead of by changing CFLAGS? regards, tom lane ---(end of

Re: [HACKERS] fixing Makefile.shlib for solaris/gcc with -m64 flag

2007-01-17 Thread Jignesh K. Shah
simple if I use -m64 for 64 bit then all end binaries are generated 64-bit and the shared libraries are generated 32-bit and the compilation fails (ONLY ON SOLARIS) since that particular line is only for the condition Solaris AND gcc. If I use the COMPILER which is CC + CFLAGS it passes -m64

Re: [HACKERS] fixing Makefile.shlib for solaris/gcc with -m64 flag

2007-01-17 Thread Tom Lane
Jignesh K. Shah [EMAIL PROTECTED] writes: simple if I use -m64 for 64 bit then all end binaries are generated 64-bit and the shared libraries are generated 32-bit and the compilation fails (ONLY ON SOLARIS) since that particular line is only for the condition Solaris AND gcc. If I use

Re: [HACKERS] fixing Makefile.shlib for solaris/gcc with -m64 flag

2007-01-17 Thread Peter Eisentraut
Am Mittwoch, 17. Januar 2007 17:12 schrieb Tom Lane: Jignesh K. Shah [EMAIL PROTECTED] writes: simple if I use -m64 for 64 bit then all end binaries are generated 64-bit and the shared libraries are generated 32-bit and the compilation fails (ONLY ON SOLARIS) since that particular line is

Re: [HACKERS] fixing Makefile.shlib for solaris/gcc with -m64 flag

2007-01-17 Thread Jignesh K. Shah
I tried that but it didn't work. Also on Solaris it typically uses the ld in /usr/ccs/bin/ld which uses -64 as its flag for 64 bit and if you put LDFLAGS out there it will fail as unrecognized unless gcc parses -64 to -m64. Putting -m64 in CC will do the workaround but then I guess that's