[issue36534] tarfile: handling Windows (path) illegal characters in archive member names

2020-10-07 Thread Cristi Fati
Cristi Fati added the comment: As I see things now, there are multiple things (not necessarily related to this issue) to deal with: 1. Update *tarfile* and add *\_sanitize\_windows\_name* (name can change), that uses *pathlib.\_WindowsFlavour.reserved\_names* (or some public wrapper

[issue36534] tarfile: handling Windows (path) illegal characters in archive member names

2019-04-05 Thread Cristi Fati
New submission from Cristi Fati : Although tar is a Nix based (and mostly used) format, it gains popularity on Win too. As tarfile is running on Win, I think it should handle (work around) path incompatibilities, as zipfile (`ZipFile._sanitize_windows_name`) does. Applies to all branches

[issue36247] zipfile - extract truncates (existing) file when bad password provided (zip encryption weakness)

2019-03-10 Thread Cristi Fati
Cristi Fati added the comment: Hm, I assumed that a bad password, will raise an exception (at some point). but, if it doesn't, the destination file will be overwritten (with the messed up content), which also happens now (so, no behavior change). This is trying to make wrong passwords

[issue36247] zipfile - extract truncates (existing) file when bad password provided (zip encryption weakness)

2019-03-08 Thread Cristi Fati
Cristi Fati added the comment: Submitted: https://github.com/python/cpython/pull/12242. As a note, it applies to any Python version. -- keywords: +patch pull_requests: +12230 stage: -> patch review ___ Python tracker <https://bugs.pyth

[issue36247] zipfile - extract truncates (existing) file when bad password provided (zip encryption weakness)

2019-03-08 Thread Cristi Fati
New submission from Cristi Fati : PKWARE encryption password pre check algorithm (relying on an 8 bits value to differentiate passwords) is insanely short. Most of the wrong passwords are filtered out by the check, but some of them aren't. For the ones in the latter category, when trying

[issue27592] FIPS_mode() and FIPS_mode_set() functions in Python (ssl)

2016-07-22 Thread Cristi Fati
Cristi Fati added the comment: Thank you all for chiming in (so quickly). I did this in 2013 (maybe back then the situation was different), and have successfully used it since. Regarding comments: - Alex: 1: I'm not an expert, so I'm not going to argue with it. However I thought

[issue27592] FIPS_mode() and FIPS_mode_set() functions in Python (ssl)

2016-07-22 Thread Cristi Fati
New submission from Cristi Fati: During last years, the FIPS mode, has become more and more popular, especially in US (probably because it was "promoted" by government institutions). All OpenSSL versions (didn't check 1.0.0 or lower since they're no longer supported), have the &

[issue25413] ctypes (libffi) fails to compile on Solaris X86

2016-06-13 Thread Cristi Fati
Cristi Fati added the comment: Hi, sorry for spamming everyone, I couldn't find a way to reply to the last message directly on #25413 (https://bugs.python.org/issue25413). Looked over the current version (from MASTER) of the file: https://github.com/libffi/libffi/blob/master/src/x86/ffi.c

[issue25413] ctypes (libffi) fails to compile on Solaris X86

2015-10-15 Thread Cristi Fati
New submission from Cristi Fati: 2.7.10 regression (at least compared to 2.7.3), not sure which exact version between the 2 first introduced it. Due to addition of `win32.S` in the list build on Solaris X86 (32bit which also identifies the platform as X86) fails. Attaching a patch. After

[issue23946] Invalid timestamps reported by os.stat() when Windows FILETIME structures are mistakenly reset.

2015-04-14 Thread Cristi Fati
New submission from Cristi Fati: In WinPE environment (at least this is where I found it, but there might be cases where this issue could be spotted in normal Windows), some folders might have some of the FILETIME structures reset (because of RAMDrive?). When the conversion between WIN style