[issue24692] types.coroutines() idempotence documentation

Antoine Pietri added the comment: I checked, the current doc gives a good explanation. I'm closing the issue. -- stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue24692] types.coroutines() idempotence documentation

Yury Selivanov added the comment: Is this still something that we need to address? I think that the current types.coroutine docs are pretty accurate and don't see where the proposed patch really improves them. -- nosy: +yselivanov ___ Python

[issue24692] types.coroutines() idempotence documentation

Martin Panter added the comment: I think you are right that it would be typically used as a decorator. Patch v2 changes it to be defined as a decorator. Not sure what the second part of your comment is referring to. The existing text about lack of __await__() maybe? You still have to have

[issue24692] types.coroutines() idempotence documentation

Stefan Behnel added the comment: Note that the expected usage is not as a function but as a decorator. That should be stated in the docs as well. IMHO, users should only do two things with whatever the result is: either use it as a Generator (as before), or pass it as an argument to await.

[issue24692] types.coroutines() idempotence documentation

Antoine Pietri added the comment: Lgtm! -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24692 ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue24692] types.coroutines() idempotence documentation

Martin Panter added the comment: Going by Yury’s tests and implementation, I think it is intended that: * An “async def” coroutine factory function is accepted and passed through unmodified * An generator–coroutine factory function that has already been transformed is also accepted * If a

[issue24692] types.coroutines() idempotence documentation

Martin Panter added the comment: Let me know if this patch works for you. -- keywords: +patch stage: - patch review versions: +Python 3.6 Added file: http://bugs.python.org/file40050/coro-idempotent.patch ___ Python tracker rep...@bugs.python.org

[issue24692] types.coroutines() idempotence documentation

New submission from Antoine Pietri: In the new types.coroutines() documentation, it is not clearly stated whether this function is idempotent or not: what happens when it is called on a function that is already a native coroutine? -- assignee: docs@python components: Documentation

[issue24692] types.coroutines() idempotence documentation

Roundup Robot added the comment: New changeset 636ce05ea8f6 by Yury Selivanov in branch '3.5': Issue #24692: Add more tests for types.coroutine https://hg.python.org/cpython/rev/636ce05ea8f6 New changeset 3f3e398bcd3e by Yury Selivanov in branch 'default': Merge 3.5 (Issue #24692)

[issue24692] types.coroutines() idempotence documentation

Changes by Yury Selivanov yseliva...@gmail.com: -- nosy: +vadmium ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24692 ___ ___ Python-bugs-list