[issue33604] HMAC default to MD5 marked as to be removed in 3.6

Gregory P. Smith added the comment: Noted, but making it a keyword only argument would break a lot of existing code that has always just been passing three positional args. Needless pain. -- stage: patch review -> resolved status: open -> closed

[issue33604] HMAC default to MD5 marked as to be removed in 3.6

Leandro Lima added the comment: IMV, the adopted solution creates a problem of a mismatch between the signature and the function behavior. I was just hit by this, as I never cared to specify digestmod trusting that Python defaults are usually sound choices. I agree that changing the

[issue33604] HMAC default to MD5 marked as to be removed in 3.6

miss-islington added the comment: New changeset c615db608dbb36a5d10188f7d265dcec7bfcc3cf by Miss Islington (bot) in branch '3.8': bpo-33604: Raise TypeError on missing hmac arg. (GH-16805) https://github.com/python/cpython/commit/c615db608dbb36a5d10188f7d265dcec7bfcc3cf --

[issue33604] HMAC default to MD5 marked as to be removed in 3.6

Gregory P. Smith added the comment: New changeset f33c57d5c780da1500619f548585792bb5b750ee by Gregory P. Smith in branch 'master': bpo-33604: Raise TypeError on missing hmac arg. (GH-16805) https://github.com/python/cpython/commit/f33c57d5c780da1500619f548585792bb5b750ee --

[issue33604] HMAC default to MD5 marked as to be removed in 3.6

Change by miss-islington : -- pull_requests: +16380 pull_request: https://github.com/python/cpython/pull/16833 ___ Python tracker ___

[issue33604] HMAC default to MD5 marked as to be removed in 3.6

Gregory P. Smith added the comment: BTW, if you want the type annotation that'd be used for this, 3.8 effectively removes the Optional[] from the one listed in: https://github.com/python/typeshed/blob/master/stdlib/2and3/hmac.pyi#L16 -- ___

[issue33604] HMAC default to MD5 marked as to be removed in 3.6

Change by Gregory P. Smith : -- assignee: -> gregory.p.smith ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue33604] HMAC default to MD5 marked as to be removed in 3.6

Gregory P. Smith added the comment: Thanks for the feedback. Better late than never. :) A default algorithm is a bad thing when it comes to authentication. Explicit is better than implicit. A default regularly becomes obsolete as math and cryptanalysis methods move forward and need to be

[issue33604] HMAC default to MD5 marked as to be removed in 3.6

Change by Gregory P. Smith : -- pull_requests: +16362 stage: commit review -> patch review pull_request: https://github.com/python/cpython/pull/16805 ___ Python tracker ___

[issue33604] HMAC default to MD5 marked as to be removed in 3.6

Christian Heimes added the comment: The weird argument style of a required digestmod with None as default is an unfortunate outcome of the old API. The msg and digestmod argument can be passed in as keyword and as positional argument. I studied existing code and have considered to make

[issue33604] HMAC default to MD5 marked as to be removed in 3.6

Raymond Hettinger added the comment: The docs still make it look like *digestmod* is an optional argument: https://docs.python.org/3/library/hmac.html#hmac.new The help output does as well: >>> help(hmac.new) Help on function new in module hmac: new(key, msg=None,

[issue33604] HMAC default to MD5 marked as to be removed in 3.6

Change by Gregory P. Smith : -- resolution: -> fixed stage: patch review -> commit review status: open -> closed type: -> behavior versions: -Python 3.6 ___ Python tracker

[issue33604] HMAC default to MD5 marked as to be removed in 3.6

Gregory P. Smith added the comment: New changeset 51a4743d19abd016f0772a57fb31df7af9220e18 by Gregory P. Smith (Matthias Bussonnier) in branch 'master': bpo-33604: Remove deprecated HMAC default value marked for removal in 3.8 (GH-7063)

[issue33604] HMAC default to MD5 marked as to be removed in 3.6

miss-islington added the comment: New changeset 2751dccca4098b799ea575bb35cec9959c74684a by Miss Islington (bot) in branch '3.7': bpo-33604: Remove Pending from hmac Deprecation warning. (GH-7062)

[issue33604] HMAC default to MD5 marked as to be removed in 3.6

Change by miss-islington : -- pull_requests: +6695 ___ Python tracker ___

[issue33604] HMAC default to MD5 marked as to be removed in 3.6

Gregory P. Smith added the comment: New changeset 8bb0b5b03cffa2a2e74f248ef479a9e7fbe95cf4 by Gregory P. Smith (Matthias Bussonnier) in branch 'master': bpo-33604: Remove Pending from hmac Deprecation warning. (GH-7062)

[issue33604] HMAC default to MD5 marked as to be removed in 3.6

Change by Serhiy Storchaka : -- nosy: +christian.heimes, gregory.p.smith ___ Python tracker ___

[issue33604] HMAC default to MD5 marked as to be removed in 3.6

Matthias Bussonnier added the comment: I've sent two PRs, one that updates the deprecation from PendingDeprecationWarning to DeprecationWarning that likely should get applied to 3.6, and 3.7 ? And a PR to actually remove the default in 3.8. --

[issue33604] HMAC default to MD5 marked as to be removed in 3.6

Change by Matthias Bussonnier : -- pull_requests: +6693 ___ Python tracker ___

[issue33604] HMAC default to MD5 marked as to be removed in 3.6

Change by Matthias Bussonnier : -- keywords: +patch pull_requests: +6692 stage: -> patch review ___ Python tracker ___

[issue33604] HMAC default to MD5 marked as to be removed in 3.6

New submission from Matthias Bussonnier : HMAC docs says digestmod=md5 default will be removed in 3.6, but was not. We should likely bumpt that to 3.8 in the documentation, and actually remove it in 3.8 -- messages: 317322 nosy: mbussonn priority: normal