Change by Georg Brandl :
--
nosy: -georg.brandl
___
Python tracker
<https://bugs.python.org/issue12029>
___
___
Python-bugs-list mailing list
Unsubscribe:
Georg Brandl added the comment:
Looks good. I should have rights automatically for everything in that org.
--
___
Python tracker
<https://bugs.python.org/issue42
Georg Brandl added the comment:
Sure!
--
___
Python tracker
<https://bugs.python.org/issue42238>
___
___
Python-bugs-list mailing list
Unsubscribe:
Georg Brandl added the comment:
> I was not here 21 years ago when it was introduced
You gave me a small shock, but I checked and it was only 11/12 years ago :D
I'm fine with moving this out of tree; please coordinate with the Sphinx
maintainers whether it should be an "official&qu
Change by Georg Brandl :
--
nosy: -georg.brandl
___
Python tracker
<https://bugs.python.org/issue19479>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Georg Brandl :
--
nosy: -georg.brandl
___
Python tracker
<https://bugs.python.org/issue32696>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Georg Brandl :
--
nosy: -georg.brandl
___
Python tracker
<https://bugs.python.org/issue25927>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Georg Brandl :
--
status: open -> closed
___
Python tracker
<https://bugs.python.org/issue45855>
___
___
Python-bugs-list mailing list
Unsubscrib
Georg Brandl added the comment:
New changeset f4095e53ab708d95e019c909d5928502775ba68f by Georg Brandl in
branch 'main':
bpo-45855: document that `no_block` has no use anymore in PyCapsule_Import
(#29665)
https://github.com/python/cpython/commit/f4095e53ab708d95e019c909d5928502775ba68f
Change by Georg Brandl :
--
status: closed -> open
___
Python tracker
<https://bugs.python.org/issue45855>
___
___
Python-bugs-list mailing list
Unsubscrib
Change by Georg Brandl :
--
keywords: +patch
pull_requests: +27907
stage: needs patch -> patch review
pull_request: https://github.com/python/cpython/pull/29665
___
Python tracker
<https://bugs.python.org/issu
Georg Brandl added the comment:
PR is underway.
--
___
Python tracker
<https://bugs.python.org/issue45855>
___
___
Python-bugs-list mailing list
Unsubscribe:
New submission from Georg Brandl :
PyImport_ImportModuleNoBlock is the same as PyImport_ImportModule since 3.3,
according to the docs.
PyCapsule_Import has a no_block parameter to choose, is still documented as if
it is relevant, and the implementation also still uses
Change by Georg Brandl :
--
nosy: +georg.brandl
___
Python tracker
<https://bugs.python.org/issue45025>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Georg Brandl :
--
nosy: +vstinner
___
Python tracker
<https://bugs.python.org/issue45025>
___
___
Python-bugs-list mailing list
Unsubscribe:
Georg Brandl added the comment:
To be clear, this has nothing to do with the amount of indentation, but that
the directive below (the versionadded) has 4 spaces, and the paragraph above
had 5 before the change. Therefore the further-indented paragraph is taken as a
blockquote
Georg Brandl added the comment:
It doesn't make sense to include the archive link, the documentation it refers
to is available in the GitHub repository under docs/.
--
nosy: +georg.brandl
___
Python tracker
<https://bugs.python.org/issue42
Georg Brandl added the comment:
This grammar specification doesn't contain a full specification of code that
won't raise SyntaxError. There are several conditions that aren't checked by
the generated parser, but at a later stage in the compilation process.
While probably possible to express
Change by Georg Brandl :
--
keywords: +patch
pull_requests: +21394
stage: needs patch -> patch review
pull_request: https://github.com/python/cpython/pull/22356
___
Python tracker
<https://bugs.python.org/issu
New submission from Georg Brandl :
There are a few points where `os.waitid()` docs need improvement. Current text:
Wait for the completion of one or more child processes. idtype can be P_PID,
P_PGID or P_ALL. id specifies the pid to wait on. options is constructed from
the ORing of one
Change by Georg Brandl :
--
nosy: -georg.brandl
___
Python tracker
<https://bugs.python.org/issue1678077>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Georg Brandl :
--
nosy: -georg.brandl
___
Python tracker
<https://bugs.python.org/issue19915>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Georg Brandl :
--
nosy: -georg.brandl
___
Python tracker
<https://bugs.python.org/issue1249749>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Georg Brandl :
--
nosy: -georg.brandl
___
Python tracker
<https://bugs.python.org/issue1105770>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Georg Brandl :
--
nosy: -georg.brandl
___
Python tracker
<https://bugs.python.org/issue1611944>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Georg Brandl :
--
nosy: -georg.brandl
___
Python tracker
<https://bugs.python.org/issue919238>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Georg Brandl :
--
nosy: -georg.brandl
___
Python tracker
<https://bugs.python.org/issue11105>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Georg Brandl :
--
nosy: -georg.brandl
___
Python tracker
<https://bugs.python.org/issue26053>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Georg Brandl :
--
nosy: -georg.brandl
___
Python tracker
<https://bugs.python.org/issue22107>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Georg Brandl :
--
nosy: -georg.brandl
___
Python tracker
<https://bugs.python.org/issue25467>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Georg Brandl :
--
nosy: -georg.brandl
___
Python tracker
<https://bugs.python.org/issue22577>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Georg Brandl :
--
nosy: -georg.brandl
___
Python tracker
<https://bugs.python.org/issue1823>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Georg Brandl :
--
nosy: -georg.brandl
___
Python tracker
<https://bugs.python.org/issue20119>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Georg Brandl :
--
nosy: -georg.brandl
___
Python tracker
<https://bugs.python.org/issue18280>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Georg Brandl :
--
nosy: -georg.brandl
___
Python tracker
<https://bugs.python.org/issue26794>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Georg Brandl :
--
nosy: -georg.brandl
___
Python tracker
<https://bugs.python.org/issue24160>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Georg Brandl :
--
nosy: -georg.brandl
___
Python tracker
<https://bugs.python.org/issue23163>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Georg Brandl :
--
nosy: -georg.brandl
___
Python tracker
<https://bugs.python.org/issue19081>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Georg Brandl :
--
nosy: -georg.brandl
___
Python tracker
<https://bugs.python.org/issue26214>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Georg Brandl :
--
nosy: -georg.brandl
___
Python tracker
<https://bugs.python.org/issue28850>
___
___
Python-bugs-list mailing list
Unsubscribe:
Georg Brandl added the comment:
FWIW, I think Sydney's right. Shared entries should only be used for closely
related, or interdependent, APIs, which those here are not.
--
nosy: +georg.brandl
___
Python tracker
<https://bugs.python.org/issue40
Georg Brandl added the comment:
Don't hesitate to send requests back to the Sphinx tracker if any changes
appear to be too restrictive to you. It is a documentation tool, not a compiler.
--
nosy: +georg.brandl
___
Python tracker
<ht
Georg Brandl added the comment:
Sorry, it seems that was far too long ago for me to remember anything :)
--
___
Python tracker
<https://bugs.python.org/issue40
Georg Brandl added the comment:
> In particular, we must have at least one digit following `0[xXbBoO]` and must
> be before any underscores.
This is not true (but your test file does the right thing).
--
___
Python tracker <rep...@bugs.p
Georg Brandl added the comment:
I don't remember anything specific about this, sorry.
--
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/i
Georg Brandl added the comment:
Thanks Brett!
--
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue26331>
___
___
Python-bugs-list
Georg Brandl added the comment:
Please go ahead. Thanks for taking care of this!
--
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/i
Georg Brandl added the comment:
@Serhiy/anyone: can I get another review, so that we can commit this in time
for beta? Thanks!
--
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/i
Georg Brandl added the comment:
Please folks. Stop taking this so seriously and remember that this is the
language where you can type in
>>> import antigravity
and it actually works. (Sort of.)
--
___
Python tracker <rep...@bugs.pytho
Georg Brandl added the comment:
`os.path` does not handle URIs of any type, so this behavior is correct as
Steven says.
--
nosy: +georg.brandl
resolution: -> not a bug
status: open -> closed
___
Python tracker <rep...@bugs.python.o
Georg Brandl added the comment:
Thanks for the detailed review, Serhiy! Next try incoming.
--
Added file: http://bugs.python.org/file42939/numeric_underscores_final_v8.diff
___
Python tracker <rep...@bugs.python.org>
<http://bugs.p
Changes by Georg Brandl <ge...@python.org>:
--
nosy: +michael.foord
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue27060>
___
_
Georg Brandl added the comment:
Thanks Eric!
Serhiy, do you want to do a review? The v6/v7 patches are based on your
"strict" patch with the constructor changes adapted from v4.
New version v7 addresses the review comments from Stefan and Martin.
--
Added file: http://bugs.
Georg Brandl added the comment:
Not really, no. You have to add a :ref: target label for the function. If it's
only a few instances, that should be manageable.
--
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/i
Georg Brandl added the comment:
Note: the changes for format()ting ("_" as thousands separator) are still
missing. Eric, would you consider doing this part?
--
nosy: +eric.smith
___
Python tracker <rep...@bugs.python.org>
<htt
Changes by Georg Brandl <ge...@python.org>:
Removed file: http://bugs.python.org/file41892/numeric_underscores_v2.diff
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python
Changes by Georg Brandl <ge...@python.org>:
Removed file: http://bugs.python.org/file42852/numeric_underscores_final_v5.diff
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python
Changes by Georg Brandl <ge...@python.org>:
Removed file: http://bugs.python.org/file41888/numeric_underscores.diff
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python
Changes by Georg Brandl <ge...@python.org>:
Removed file: http://bugs.python.org/file41894/numeric_underscores_v3_full.diff
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python
Changes by Georg Brandl <ge...@python.org>:
Added file: http://bugs.python.org/file42854/numeric_underscores_final_v6.diff
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python
Georg Brandl added the comment:
New patch; implements the accepted version of the PEP. I added the additional
tests, thanks Stefan!
--
Added file: http://bugs.python.org/file42852/numeric_underscores_final_v5.diff
___
Python tracker <
Georg Brandl added the comment:
Serhiy, feel free to go ahead and commit, I don't have my keys with me ATM.
--
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/i
Georg Brandl added the comment:
Newer Sphinx versions already redefine docutils' RFC and PEP URLs to use https.
--
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/i
Georg Brandl added the comment:
Yep, they should all be gone. I tried to make sure by running the sources
through docutils and finding nested nodes.
--
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/i
Georg Brandl added the comment:
Also LGTM. It's easy to spot PEPs written by French people :)
--
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/i
Georg Brandl added the comment:
LGTM.
--
nosy: +georg.brandl
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue26916>
___
___
Pyth
Changes by Georg Brandl <ge...@python.org>:
--
resolution: -> fixed
status: open -> closed
___
Python tracker <rep...@bugs.python.org>
<http://bugs.
Georg Brandl added the comment:
Looks pretty rampant to me :)
Anyway, +1 for fixing, you can just do it without review if you have the time.
--
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/i
Georg Brandl added the comment:
You didn't test your examples:
>>> [] == False
False
False is not equal to the "empty value" of any other type than other numeric
types. (This is mostly because of how booleans were originally introduced to
Python.)
"is f
Georg Brandl added the comment:
Agreed.
--
resolution: -> not a bug
status: open -> closed
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python
Georg Brandl added the comment:
Indeed, I don't think the `array` module is much used anymore.
If you're looking to serialize or deserialize fixed-size formats, you'll
probably want the `struct` module. It has both native and fixed-size modes.
For anything else involving arrays (mostly
Georg Brandl added the comment:
Now that "added" doesn't mention the second argument, the "This one *must* have
the second argument (explanation of the change)." should be changed. Otherwise
+1.
--
___
Python tracker <rep...
Georg Brandl added the comment:
+1
--
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue26736>
___
___
Python-bugs-list mailing list
Georg Brandl added the comment:
(Also, toggled your "is committer" bit so you get the Python logo next to your
name.)
--
___
Python tracker <rep...@bugs.python.org>
<http://bugs.py
Georg Brandl added the comment:
The last patch isn't up to date with the PEP; Serhiy's patch is the closest one.
--
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/i
Georg Brandl added the comment:
The patch is definitely an improvement.
What about a remark like ", except that `deco` is evaluated before the function
`f` is created"? That should cover the remaining difference.
--
nosy: +georg.brandl
Georg Brandl added the comment:
That is definitely supported. Whether it's actually useful to document, I'm
not sure.
"except that the original function is not temporarily bound to the name `f`"
could work.
--
___
Python tr
Georg Brandl added the comment:
That sounds good to me. Maybe without so many parentheses :)
--
nosy: +georg.brandl
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/i
Georg Brandl added the comment:
Sure!
--
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue26525>
___
___
Python-bugs-list mailing list
Georg Brandl added the comment:
There's two different uses here:
The one use in "truncated to Integral" means that you get an integer type out.
It is not specified to be `int` because `__trunc__` may return other types. It
could be made into a link like the other use of Integral.
Georg Brandl added the comment:
I had no idea we had so many cases of wonky indentation :)
This looks good to me, apart from a few comments I left on rietveld.
--
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/i
Georg Brandl added the comment:
Looks good now! I left a few comments on Rietveld.
--
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/i
Georg Brandl added the comment:
Thanks for the patch!
Most "bash" blocks should be "console" (since the prompt is shown). "pycon"
should not be needed, since it is detected automatically.
--
___
Python tracker
Georg Brandl added the comment:
I think rephrasing with "... can only be read" would keep the intended meaning,
but avoid the problematic "the namespaces are readonly" meaning.
--
nosy: +georg.brandl
___
Python tracker <rep...
Georg Brandl added the comment:
Reopening, for fixing the rest of the broken ones.
--
nosy: +georg.brandl
resolution: fixed ->
status: closed -> open
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python
Changes by Georg Brandl <ge...@python.org>:
--
status: languishing -> open
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue25910>
___
_
Georg Brandl added the comment:
Thanks!
--
nosy: +georg.brandl
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue26442>
___
___
Pyth
Georg Brandl added the comment:
Reflow is kinda bad for patch review :)
--
nosy: +georg.brandl
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/i
Georg Brandl added the comment:
Ok, that was a bug in rstlint. Fixed now - and now I can find quite a few
instances, will fix them (most of them are in this patch).
--
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/i
Georg Brandl added the comment:
These are interpreted as comments by docutils. "make suspicious" only checks
for markup erroneously remaining in the output. "make check", which runs
tools/rstlint.py, should pick them up though.
--
Georg Brandl added the comment:
You need to call `x.__len__()` explicitly.
--
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/i
Georg Brandl added the comment:
-Consistency within one module or function is most important.
+Consistency within one module or function is the most important.
You left out "thing" from the patch; is that intended?
--
___
Python tr
Georg Brandl added the comment:
I can't really comment on the grammar changes, but the rest looks good to me.
This is not very smooth, in both versions:
-Consistency within one module or function is most important.
+Consistency within one module or function is the most important thing
Georg Brandl added the comment:
> Well then, if this is the sort of place where the status quo is sacred,
> then there is nothing more to discuss.
That wasn't my intention when quoting the old documenting guide, it was just
to show what the intent was (and still is), and that I didn'
Changes by Georg Brandl <ge...@python.org>:
--
nosy: -georg.brandl
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue26385>
___
_
Georg Brandl added the comment:
Thanks for the report!
--
nosy: +georg.brandl
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/i
Georg Brandl added the comment:
The devguide should be updated, yes.
And probably someone should look at the remaining versionadded's...
--
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/i
Georg Brandl added the comment:
Hi Tony,
thanks for the patch, and for the will to contribute. I'm not sure this patch
should be merged though; the original intention was to use "versionadded" where
the API item is completely new. So "The parameter x was added" in
Georg Brandl added the comment:
It's mostly for consistency. For example, ``int(x, 0)`` is defined by the docs
as "interpret x as in a literal". Other bases have special cases as well, e.g.
"0x" is accepted by base 16.
In the current version of the conversions, t
Georg Brandl added the comment:
Thanks, I hadn't looked at cdecimal yet - I was planning to ask you to do the
necessary changes there :)
But there are a few versions of this (e.g. converting unicode digits to ASCII)
scattered throughout the codebase, it would make sense to consolidate
1 - 100 of 5083 matches
Mail list logo
