Re: [R-pkg-devel] Testing on old R versions

2021-02-01 Thread Gábor Csárdi
On Sun, Jan 31, 2021 at 6:52 PM Duncan Murdoch wrote: > > On 31/01/2021 12:35 p.m., Duncan Murdoch wrote: > > On 31/01/2021 10:57 a.m., Gábor Csárdi wrote: > >> Do you actually experience any problems, if you don't treat this case > >> specially? > > > > Yes, what was happening was that

Re: [R-pkg-devel] Testing on old R versions

2021-01-31 Thread Duncan Murdoch
On 31/01/2021 12:35 p.m., Duncan Murdoch wrote: On 31/01/2021 10:57 a.m., Gábor Csárdi wrote: Do you actually experience any problems, if you don't treat this case specially? Yes, what was happening was that remotes::install_deps skipped installing rgl from CRAN because the local copy had a

Re: [R-pkg-devel] Testing on old R versions

2021-01-31 Thread Duncan Murdoch
On 31/01/2021 10:57 a.m., Gábor Csárdi wrote: Do you actually experience any problems, if you don't treat this case specially? Yes, what was happening was that remotes::install_deps skipped installing rgl from CRAN because the local copy had a later version number. Sorry, I deleted most of

Re: [R-pkg-devel] Testing on old R versions

2021-01-31 Thread Gábor Csárdi
Do you actually experience any problems, if you don't treat this case specially? AFAIR, in most cases this is not a problem in practice. remotes might install the CRAN version of rgl as the dependency of alphashape3d, but `R CMD check` will install and use the local copy of the rgl package for

Re: [R-pkg-devel] Testing on old R versions

2021-01-31 Thread Hadley Wickham
On Sun, Jan 31, 2021 at 4:32 AM Duncan Murdoch wrote: > > I am trying out a modified version of the tidyverse actions, and it does > seem to be going well. Just one question: > > rgl has a soft dependency on alphashape3d, and alphashape3d has a hard > dependency on rgl. This means that I need

Re: [R-pkg-devel] Testing on old R versions

2021-01-31 Thread Duncan Murdoch
I am trying out a modified version of the tidyverse actions, and it does seem to be going well. Just one question: rgl has a soft dependency on alphashape3d, and alphashape3d has a hard dependency on rgl. This means that I need to install in the order rgl hard dependencies rgl rgl

Re: [R-pkg-devel] Testing on old R versions

2021-01-29 Thread Duncan Murdoch
Thanks, I'll try Singularity out. (I tried it, but got some weird game playing when I tried to do my first build. Strange.) By the way, I've been thinking of downgrading the magrittr dependency to Suggests. The only reason it is currently Imports is so that rgl can re-export the pipe

Re: [R-pkg-devel] Testing on old R versions

2021-01-28 Thread Henrik Bengtsson
Hi, you're probably already aware of it, but 'rgl' depends on 'magrittr' which depends on 'rlang', and the latter requires R (>= 3.3.0). BTW, I find Singularity (https://github.com/hpcng/singularity/) more convenient to work with than Docker, e.g. you run as host $USER also "inside" the

Re: [R-pkg-devel] Testing on old R versions

2021-01-28 Thread Dirk Eddelbuettel
On 28 January 2021 at 16:50, Duncan Murdoch wrote: | Thanks Dirk, Neal and Nathan. I ended up going with Dirk's suggestion. | | So far I haven't got it to work in 3.2.0; I probably won't put much | effort into supporting that old version. But it's fine in 3.4.0 and | 3.5.0, and I'm trying

Re: [R-pkg-devel] Testing on old R versions

2021-01-28 Thread Duncan Murdoch
Thanks Dirk, Neal and Nathan. I ended up going with Dirk's suggestion. So far I haven't got it to work in 3.2.0; I probably won't put much effort into supporting that old version. But it's fine in 3.4.0 and 3.5.0, and I'm trying 3.3.0 now. Rocker rocks! P.S. rgl now installs in the basic

Re: [R-pkg-devel] Testing on old R versions

2021-01-28 Thread Nathan Watson-Haigh
-devel on behalf of Duncan Murdoch Sent: Friday, January 29, 2021 1:35:40 AM To: r-package-devel@r-project.org Subject: [R-pkg-devel] Testing on old R versions I just received a bug report about the rgl package: it claims to depend on R >= 3.2.0, but actually uses the hcl.colors()

Re: [R-pkg-devel] Testing on old R versions

2021-01-28 Thread Dirk Eddelbuettel
The Rocker Project provides both rocker/r-ver (with package snapshotting) as well as the (much smaller, just R) rocker/r-base images which are then passed on to the Docker team to become the official r-base image. These go back to 3.1.3 with (almost if not all) interim releases, see

Re: [R-pkg-devel] Testing on old R versions

2021-01-28 Thread Neal Richardson
I've used the https://hub.docker.com/r/rstudio/r-base images for this, and they appear to go back to R 3.1. Likewise https://hub.docker.com/r/rocker/r-ver. The latter uses MRAN to install packages from a CRAN snapshot corresponding to the release, so that should also help with dependencies. Neal

[R-pkg-devel] Testing on old R versions

2021-01-28 Thread Duncan Murdoch
I just received a bug report about the rgl package: it claims to depend on R >= 3.2.0, but actually uses the hcl.colors() function that was introduced in R 3.6.0, so fails to install. (This dependence was introduced while I had the dependence stated as R >= 4.0.0 for a while, until I tried