Re: [R-pkg-devel] winUCRT failures

2021-04-26 Thread Duncan Murdoch
On 26/04/2021 9:20 a.m., Ott Toomet wrote: I think part of the problem is that the corresponding section in "Writing R extensions" is not very clear for newcomers.  I admit I have read it several times as I have been confused about the difference between suggest, imports and depends, and so

Re: [R-pkg-devel] winUCRT failures

2021-04-26 Thread Ott Toomet
I think part of the problem is that the corresponding section in "Writing R extensions" is not very clear for newcomers. I admit I have read it several times as I have been confused about the difference between suggest, imports and depends, and so combed section 1.1.3 repeatedly. But from this

Re: [R-pkg-devel] winUCRT failures

2021-04-26 Thread Tomas Kalibera
On 4/25/21 2:49 PM, Duncan Murdoch wrote: The current CRAN release of rgl fails on winUCRT because of missing dependencies: 'htmlwidgets', 'htmltools', 'knitr', 'jsonlite', 'shiny', 'magrittr', 'crosstalk', 'manipulateWidget'. Tracing `htmlwidgets` shows it also fails because of missing

Re: [R-pkg-devel] winUCRT failures

2021-04-25 Thread Hadley Wickham
Who is responsible for the winUCRT checks? Perhaps that person could provide us with a list of root causes behind the testthat failures, and we could look into resolving them. Hadley On Sun, Apr 25, 2021 at 7:50 AM Duncan Murdoch wrote: > > The current CRAN release of rgl fails on winUCRT

Re: [R-pkg-devel] winUCRT failures

2021-04-25 Thread Hadley Wickham
> One additional thought: > > If the testing package (i.e. testthat in this case) had been available > but other suggested packages were not, it would be worth running tests > with just testthat present: that might be why you called the decision > defensible. I'd agree with that. > > However,

Re: [R-pkg-devel] winUCRT failures

2021-04-25 Thread Duncan Murdoch
On 25/04/2021 12:56 p.m., Duncan Murdoch wrote: On 25/04/2021 12:46 p.m., Dirk Eddelbuettel wrote: ... It has long been true that the main test runners (RUnit, testthat, now also tinytest) are automagically included, which is a defensible (if undocumented) special rule. It's a bad rule.

Re: [R-pkg-devel] winUCRT failures

2021-04-25 Thread Duncan Murdoch
On 25/04/2021 12:46 p.m., Dirk Eddelbuettel wrote: On 25 April 2021 at 12:27, Duncan Murdoch wrote: | On 25/04/2021 11:35 a.m., Dirk Eddelbuettel wrote: | > I last wrote about that four years ago under the title "Suggests != Depends" | >

Re: [R-pkg-devel] winUCRT failures

2021-04-25 Thread Dirk Eddelbuettel
On 25 April 2021 at 11:46, Dirk Eddelbuettel wrote: | So yes, it is technically easy, and we could pool the resources. But nobody | is driving it so (as has been the case for years) nothing changes. Ever. Sorry, "nothing changes" is too harsh. We have in the last year or two gotten a new test

Re: [R-pkg-devel] winUCRT failures

2021-04-25 Thread Dirk Eddelbuettel
On 25 April 2021 at 12:27, Duncan Murdoch wrote: | On 25/04/2021 11:35 a.m., Dirk Eddelbuettel wrote: | > I last wrote about that four years ago under the title "Suggests != Depends" | > http://dirk.eddelbuettel.com/blog/2017/03/22#suggests_is_not_depends | > | > Of course, nothing changed. | >

Re: [R-pkg-devel] winUCRT failures

2021-04-25 Thread Duncan Murdoch
On 25/04/2021 11:35 a.m., Dirk Eddelbuettel wrote: On 25 April 2021 at 11:14, Duncan Murdoch wrote: | What I haven't tried to do is check any of them if *none* of the | suggested packages is available. Packages should still build and check | without ERRORs in this case, though I'd expect NOTEs

Re: [R-pkg-devel] winUCRT failures

2021-04-25 Thread Dirk Eddelbuettel
On 25 April 2021 at 11:14, Duncan Murdoch wrote: | What I haven't tried to do is check any of them if *none* of the | suggested packages is available. Packages should still build and check | without ERRORs in this case, though I'd expect NOTEs and/or WARNINGs. | | This is an old issue: what

Re: [R-pkg-devel] winUCRT failures

2021-04-25 Thread Duncan Murdoch
On 25/04/2021 8:49 a.m., Duncan Murdoch wrote: The current CRAN release of rgl fails on winUCRT because of missing dependencies: 'htmlwidgets', 'htmltools', 'knitr', 'jsonlite', 'shiny', 'magrittr', 'crosstalk', 'manipulateWidget'. Tracing `htmlwidgets` shows it also fails because of missing

[R-pkg-devel] winUCRT failures

2021-04-25 Thread Duncan Murdoch
The current CRAN release of rgl fails on winUCRT because of missing dependencies: 'htmlwidgets', 'htmltools', 'knitr', 'jsonlite', 'shiny', 'magrittr', 'crosstalk', 'manipulateWidget'. Tracing `htmlwidgets` shows it also fails because of missing dependencies: 'htmltools', 'jsonlite', 'yaml'