[kudu-CR] iwyu: codebase-wide fixes based on libcpp

2020-03-26 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15543 ) Change subject: iwyu: codebase-wide fixes based on libcpp .. Patch Set 5: Code-Review+2 -- To view, visit

[kudu-CR] iwyu: standardize on libc++

2020-03-26 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15492 ) Change subject: iwyu: standardize on libc++ .. Patch Set 11: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/15492

[kudu-CR] Add functionality to serialize a RowBlock into columnar format

2020-03-26 Thread Todd Lipcon (Code Review)
Hello Tidy Bot, Andrew Wong, Kudu Jenkins, Andrew Wong, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15560 to look at the new patch set (#5). Change subject: Add functionality to serialize a RowBlock into columnar format

[kudu-CR] iwyu: codebase-wide fixes based on libcpp

2020-03-26 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15543 ) Change subject: iwyu: codebase-wide fixes based on libcpp .. Patch Set 4: (1 comment)

[kudu-CR] iwyu: codebase-wide fixes based on libcpp

2020-03-26 Thread Adar Dembo (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15543 to look at the new patch set (#5). Change subject: iwyu: codebase-wide fixes based on libcpp

[kudu-CR] rowblock: improve GetSelectedRows API

2020-03-26 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15559 ) Change subject: rowblock: improve GetSelectedRows API .. rowblock: improve GetSelectedRows API The earlier commit used a

[kudu-CR] rowblock: improve GetSelectedRows API

2020-03-26 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15559 ) Change subject: rowblock: improve GetSelectedRows API .. Patch Set 3: (1 comment)

[kudu-CR] Add core algorithms for columnar serialization

2020-03-26 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15556 ) Change subject: Add core algorithms for columnar serialization .. Add core algorithms for columnar serialization This adds the

[kudu-CR] KUDU-3007. Support building Kudu on aarch64 platform

2020-03-26 Thread liusheng (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Adar Dembo, huangtianhua...@gmail.com, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14964 to look at the new patch set (#10). Change subject: KUDU-3007. Support building Kudu on aarch64 platform

[kudu-CR] KUDU-3007. Support building Kudu on aarch64 platform

2020-03-26 Thread liusheng (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Adar Dembo, huangtianhua...@gmail.com, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14964 to look at the new patch set (#9). Change subject: KUDU-3007. Support building Kudu on aarch64 platform

[kudu-CR] rowblock: improve GetSelectedRows API

2020-03-26 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15559 ) Change subject: rowblock: improve GetSelectedRows API .. Patch Set 3: (1 comment)

[kudu-CR] Add core algorithms for columnar serialization

2020-03-26 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15556 ) Change subject: Add core algorithms for columnar serialization .. Patch Set 5: Code-Review+2 (1 comment)

[kudu-CR] [ranger] add more comments for Ranger privilege model

2020-03-26 Thread Hao Hao (Code Review)
Hao Hao has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15566 Change subject: [ranger] add more comments for Ranger privilege model .. [ranger] add more comments for Ranger privilege model Change-Id:

[kudu-CR] Add functionality to serialize a RowBlock into columnar format

2020-03-26 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15560 ) Change subject: Add functionality to serialize a RowBlock into columnar format .. Patch Set 4: Code-Review+2 (2 comments)

[kudu-CR] rowblock: improve GetSelectedRows API

2020-03-26 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15559 ) Change subject: rowblock: improve GetSelectedRows API .. Patch Set 3: Code-Review+2 -- To view, visit

[kudu-CR] Add core algorithms for columnar serialization

2020-03-26 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15556 ) Change subject: Add core algorithms for columnar serialization .. Patch Set 5: Code-Review+2 -- To view, visit

[kudu-CR] gutil: bump up linux-syscall-support.h

2020-03-26 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15557 ) Change subject: gutil: bump up linux-syscall-support.h .. gutil: bump up linux-syscall-support.h Bump up

[kudu-CR] Add functionality to serialize a RowBlock into columnar format

2020-03-26 Thread Todd Lipcon (Code Review)
Hello Andrew Wong, Kudu Jenkins, Andrew Wong, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15560 to look at the new patch set (#4). Change subject: Add functionality to serialize a RowBlock into columnar format

[kudu-CR] Add core algorithms for columnar serialization

2020-03-26 Thread Todd Lipcon (Code Review)
Hello Tidy Bot, Alexey Serbin, Andrew Wong, Kudu Jenkins, Andrew Wong, Adar Dembo, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15556 to look at the new patch set (#5). Change subject: Add core algorithms for columnar serialization

[kudu-CR] Add functionality to serialize a RowBlock into columnar format

2020-03-26 Thread Todd Lipcon (Code Review)
Hello Andrew Wong, Kudu Jenkins, Andrew Wong, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15560 to look at the new patch set (#3). Change subject: Add functionality to serialize a RowBlock into columnar format

[kudu-CR] Add functionality to serialize a RowBlock into columnar format

2020-03-26 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15560 ) Change subject: Add functionality to serialize a RowBlock into columnar format .. Patch Set 2: (3 comments)

[kudu-CR] Add core algorithms for columnar serialization

2020-03-26 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15556 ) Change subject: Add core algorithms for columnar serialization .. Patch Set 4: (7 comments)

[kudu-CR] [subprocess] remove conflict Jersey dependencies

2020-03-26 Thread Hao Hao (Code Review)
Hao Hao has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15565 Change subject: [subprocess] remove conflict Jersey dependencies .. [subprocess] remove conflict Jersey dependencies In kudu-subprocess

[kudu-CR] Add core algorithms for columnar serialization

2020-03-26 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15556 ) Change subject: Add core algorithms for columnar serialization .. Patch Set 4: (5 comments)

[kudu-CR] iwyu: codebase-wide fixes based on libcpp

2020-03-26 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15543 ) Change subject: iwyu: codebase-wide fixes based on libcpp .. Patch Set 4: (2 comments) IWYU reports that some additional inclusion

[kudu-CR] KUDU-3085: Create Scala/SBT integration test example.

2020-03-26 Thread Brian McDevitt (Code Review)
Hello Kudu Jenkins, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15535 to look at the new patch set (#3). Change subject: KUDU-3085: Create Scala/SBT integration test example.

[kudu-CR] rowblock: improve GetSelectedRows API

2020-03-26 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/15559 ) Change subject: rowblock: improve GetSelectedRows API .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR] iwyu: codebase-wide fixes based on libcpp

2020-03-26 Thread Adar Dembo (Code Review)
Hello Tidy Bot, Alexey Serbin, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15543 to look at the new patch set (#4). Change subject: iwyu: codebase-wide fixes based on libcpp

[kudu-CR] status callback: replace Bind usage with lambdas

2020-03-26 Thread Adar Dembo (Code Review)
Hello Alexey Serbin, Andrew Wong, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/15562 to review the following change. Change subject: status_callback: replace Bind usage with lambdas ..

[kudu-CR] iwyu: codebase-wide fixes based on libcpp

2020-03-26 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15543 ) Change subject: iwyu: codebase-wide fixes based on libcpp .. Patch Set 3: (21 comments)