[kudu-CR] KUDU-2612 p4: mechanism to create a transaction status table

2020-07-16 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Attila Bukor, Kudu Jenkins, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16124 to look at the new patch set (#6). Change subject: KUDU-2612 p4: mechanism to create a transaction status table

[kudu-CR] KUDU-1422 resize ErrorCollector

2020-07-16 Thread Anonymous Coward (Code Review)
Hello Attila Bukor, Kudu Jenkins, Andrew Wong, Grant Henke, Greg Solovyev, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16201 to look at the new patch set (#3). Change subject: KUDU-1422 resize ErrorCollector

[kudu-CR] KUDU-2612 p4: mechanism to create a transaction status table

2020-07-16 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Attila Bukor, Kudu Jenkins, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16124 to look at the new patch set (#5). Change subject: KUDU-2612 p4: mechanism to create a transaction status table

[kudu-CR] KUDU-2612 p4: mechanism to create a transaction status table

2020-07-16 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16124 ) Change subject: KUDU-2612 p4: mechanism to create a transaction status table .. Patch Set 5: (5 comments)

[kudu-CR] KUDU-1422 resize ErrorCollector

2020-07-16 Thread Anonymous Coward (Code Review)
guanwen...@taptap.com has posted comments on this change. ( http://gerrit.cloudera.org:8080/16201 ) Change subject: KUDU-1422 resize ErrorCollector .. Patch Set 3: (4 comments)

[kudu-CR] KUDU-3090 Restrict changing ownership of a table

2020-07-16 Thread Attila Bukor (Code Review)
Attila Bukor has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16113 ) Change subject: KUDU-3090 Restrict changing ownership of a table .. KUDU-3090 Restrict changing ownership of a table Before

[kudu-CR] KUDU-1422 resize ErrorCollector

2020-07-16 Thread Anonymous Coward (Code Review)
guanwen...@taptap.com has posted comments on this change. ( http://gerrit.cloudera.org:8080/16201 ) Change subject: KUDU-1422 resize ErrorCollector .. Patch Set 3: > (1 comment) > > just did a quick first pass at this. Is

[kudu-CR] KUDU-1422 resize ErrorCollector

2020-07-16 Thread Anonymous Coward (Code Review)
guanwen...@taptap.com has posted comments on this change. ( http://gerrit.cloudera.org:8080/16201 ) Change subject: KUDU-1422 resize ErrorCollector .. Patch Set 3: (1 comment)

[kudu-CR] KUDU-1422 resize ErrorCollector

2020-07-16 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/16201 ) Change subject: KUDU-1422 resize ErrorCollector .. Patch Set 3: (3 comments) > Patch Set 3: > > > (1 comment) > > > > just did a

[kudu-CR] KUDU-1422 resize ErrorCollector

2020-07-16 Thread Anonymous Coward (Code Review)
guanwen...@taptap.com has posted comments on this change. ( http://gerrit.cloudera.org:8080/16201 ) Change subject: KUDU-1422 resize ErrorCollector .. Patch Set 3: (2 comments)

[kudu-CR] add setErrorCollectorSpace method to change ErrorCollector size, in case errors are dropped in manual flush mode

2020-07-16 Thread Anonymous Coward (Code Review)
guanwen...@taptap.com has posted comments on this change. ( http://gerrit.cloudera.org:8080/16200 ) Change subject: add setErrorCollectorSpace method to change ErrorCollector size, in case errors are dropped in manual flush mode

[kudu-CR] [hms] Reduce noisy logging on non-leader masters.

2020-07-16 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/16203 ) Change subject: [hms] Reduce noisy logging on non-leader masters. .. Patch Set 2: Code-Review+2 (1 comment)

[kudu-CR] KUDU-2612 p4: mechanism to create a transaction status table

2020-07-16 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Attila Bukor, Kudu Jenkins, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16124 to look at the new patch set (#7). Change subject: KUDU-2612 p4: mechanism to create a transaction status table

[kudu-CR] [maintenance] use workload statistics to scale perf improvement

2020-07-16 Thread Yifan Zhang (Code Review)
Hello Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15995 to look at the new patch set (#7). Change subject: [maintenance] use workload statistics to scale perf_improvement

[kudu-CR] KUDU-2612 p4: mechanism to create a transaction status table

2020-07-16 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Attila Bukor, Kudu Jenkins, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16124 to look at the new patch set (#8). Change subject: KUDU-2612 p4: mechanism to create a transaction status table

[kudu-CR] [maintenance] use workload statistics to scale perf improvement

2020-07-16 Thread Yifan Zhang (Code Review)
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/15995 ) Change subject: [maintenance] use workload statistics to scale perf_improvement .. Patch Set 7: (6 comments)

[kudu-CR] [hms] Reduce noisy logging on non-leader masters.

2020-07-16 Thread Grant Henke (Code Review)
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16203 ) Change subject: [hms] Reduce noisy logging on non-leader masters. .. [hms] Reduce noisy logging on non-leader masters. Recently

[kudu-CR] [hms] Reduce noisy logging on non-leader masters.

2020-07-16 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16203 ) Change subject: [hms] Reduce noisy logging on non-leader masters. .. Patch Set 2: (1 comment)

[kudu-CR] [docker] Use ccache and Gradle cache across builds

2020-07-16 Thread Grant Henke (Code Review)
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16181 ) Change subject: [docker] Use ccache and Gradle cache across builds .. [docker] Use ccache and Gradle cache across builds This

[kudu-CR] [docker] Use ccache and Gradle cache across builds

2020-07-16 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/16181 ) Change subject: [docker] Use ccache and Gradle cache across builds .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR] tablet: acquire/release locks in batches

2020-07-16 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/16169 ) Change subject: tablet: acquire/release locks in batches .. Patch Set 5: (1 comment)

[kudu-CR] tablet: acquire/release locks in batches

2020-07-16 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16169 ) Change subject: tablet: acquire/release locks in batches .. tablet: acquire/release locks in batches Prior to this patch, each

[kudu-CR] KUDU-1422 resize ErrorCollector

2020-07-16 Thread Greg Solovyev (Code Review)
Greg Solovyev has posted comments on this change. ( http://gerrit.cloudera.org:8080/16201 ) Change subject: KUDU-1422 resize ErrorCollector .. Patch Set 3: Code-Review+1 > (1 comment) I see your point. Given the current

[kudu-CR] loadgen: use multiple KuduClient instances

2020-07-16 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16184 ) Change subject: loadgen: use multiple KuduClient instances .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR] loadgen: use multiple KuduClient instances

2020-07-16 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16184 ) Change subject: loadgen: use multiple KuduClient instances .. loadgen: use multiple KuduClient instances KuduClient is

[kudu-CR] tls socket: avoid cork/uncork dance for small writevs

2020-07-16 Thread Todd Lipcon (Code Review)
Hello Alexey Serbin, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/16209 to review the following change. Change subject: tls_socket: avoid cork/uncork dance for small writevs ..

[kudu-CR] tls socket: avoid cork/uncork dance for small writevs

2020-07-16 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/16209 ) Change subject: tls_socket: avoid cork/uncork dance for small writevs .. Patch Set 1: Code-Review+1 (1 comment)

[kudu-CR] tls socket: avoid cork/uncork dance for small writevs

2020-07-16 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16209 ) Change subject: tls_socket: avoid cork/uncork dance for small writevs .. Patch Set 1: (2 comments) The test failures look relevant.

[kudu-CR] tls socket: avoid cork/uncork dance for small writevs

2020-07-16 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16209 ) Change subject: tls_socket: avoid cork/uncork dance for small writevs .. Patch Set 1: (1 comment)