[kudu-CR] add setErrorCollectorSpace method to change ErrorCollector size, in case errors are dropped in manual flush mode

2020-07-15 Thread Anonymous Coward (Code Review)
guanwen...@taptap.com has abandoned this change. ( http://gerrit.cloudera.org:8080/16200 ) Change subject: add setErrorCollectorSpace method to change ErrorCollector size, in case errors are dropped in manual flush mode ..

[kudu-CR] tablet: acquire/release locks in batches

2020-07-15 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16169 ) Change subject: tablet: acquire/release locks in batches .. Patch Set 5: Code-Review+2 -- To view, visit

[kudu-CR] [hms] Reduce noisy logging on non-leader masters.

2020-07-15 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16203 ) Change subject: [hms] Reduce noisy logging on non-leader masters. .. Patch Set 2: (1 comment)

[kudu-CR] KUDU-1422 resize ErrorCollector

2020-07-15 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16201 ) Change subject: KUDU-1422 resize ErrorCollector .. Patch Set 2: (1 comment) Didn't do a full review, but it's worth taking a look at

[kudu-CR] KUDU-1422 resize ErrorCollector

2020-07-15 Thread Greg Solovyev (Code Review)
Greg Solovyev has posted comments on this change. ( http://gerrit.cloudera.org:8080/16201 ) Change subject: KUDU-1422 resize ErrorCollector .. Patch Set 2: (1 comment)

[kudu-CR] KUDU-3090 Restrict changing ownership of a table

2020-07-15 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16113 ) Change subject: KUDU-3090 Restrict changing ownership of a table .. Patch Set 20: Code-Review+2 -- To view, visit

[kudu-CR] tablet: acquire/release locks in batches

2020-07-15 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16169 ) Change subject: tablet: acquire/release locks in batches .. Patch Set 5: Code-Review+1 (2 comments)

[kudu-CR] KUDU-3090 Restrict changing ownership of a table

2020-07-15 Thread Attila Bukor (Code Review)
Hello Tidy Bot, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16113 to look at the new patch set (#20). Change subject: KUDU-3090 Restrict changing ownership of a table

[kudu-CR] [WIP] [tools] KUDU-2461 Add election metrics to ksck

2020-07-15 Thread Attila Bukor (Code Review)
Attila Bukor has abandoned this change. ( http://gerrit.cloudera.org:8080/10588 ) Change subject: [WIP] [tools] KUDU-2461 Add election metrics to ksck .. Abandoned doesn't seem all that important and ksck changed a lot since

[kudu-CR] KUDU-3090 Restrict changing ownership of a table

2020-07-15 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/16113 ) Change subject: KUDU-3090 Restrict changing ownership of a table .. Patch Set 19: (1 comment)

[kudu-CR] KUDU-3090 Restrict changing ownership of a table

2020-07-15 Thread Attila Bukor (Code Review)
Hello Tidy Bot, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16113 to look at the new patch set (#19). Change subject: KUDU-3090 Restrict changing ownership of a table

[kudu-CR] KUDU-1422 resize ErrorCollector

2020-07-15 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/16201 ) Change subject: KUDU-1422 resize ErrorCollector .. Patch Set 2: (1 comment) just did a quick first pass at this. Is this the same as

[kudu-CR] tablet: acquire/release locks in batches

2020-07-15 Thread Todd Lipcon (Code Review)
Todd Lipcon has removed a vote on this change. Change subject: tablet: acquire/release locks in batches .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/16169 To unsubscribe, visit

[kudu-CR] tablet: acquire/release locks in batches

2020-07-15 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/16169 ) Change subject: tablet: acquire/release locks in batches .. Patch Set 5: Verified+1 Failure looks unrelated. This should be ready for a

[kudu-CR] [hms] Reduce noisy logging on non-leader masters.

2020-07-15 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/16203 ) Change subject: [hms] Reduce noisy logging on non-leader masters. .. Patch Set 2: (1 comment)

[kudu-CR] KUDU-3090 Add ownership privileges

2020-07-15 Thread Attila Bukor (Code Review)
Attila Bukor has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16072 ) Change subject: KUDU-3090 Add ownership privileges .. KUDU-3090 Add ownership privileges Apache Ranger supports granting

[kudu-CR] [hms] Reduce noisy logging on non-leader masters.

2020-07-15 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16203 ) Change subject: [hms] Reduce noisy logging on non-leader masters. .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR] [hms] Reduce noisy logging on non-leader masters.

2020-07-15 Thread Grant Henke (Code Review)
Hello Attila Bukor, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16203 to look at the new patch set (#2). Change subject: [hms] Reduce noisy logging on non-leader masters.

[kudu-CR] [hms] Reduce noisy logging on non-leader masters.

2020-07-15 Thread Grant Henke (Code Review)
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16203 Change subject: [hms] Reduce noisy logging on non-leader masters. .. [hms] Reduce noisy logging on non-leader masters. Recently while

[kudu-CR] KUDU-3090 Restrict changing ownership of a table

2020-07-15 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16113 ) Change subject: KUDU-3090 Restrict changing ownership of a table .. Patch Set 18: Code-Review+1 (1 comment)

[kudu-CR] KUDU-3090 Add ownership privileges

2020-07-15 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16072 ) Change subject: KUDU-3090 Add ownership privileges .. Patch Set 24: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-1422 resize ErrorCollector

2020-07-15 Thread Greg Solovyev (Code Review)
Greg Solovyev has posted comments on this change. ( http://gerrit.cloudera.org:8080/16201 ) Change subject: KUDU-1422 resize ErrorCollector .. Patch Set 2: (3 comments)

[kudu-CR] KUDU-1422 resize ErrorCollector

2020-07-15 Thread Anonymous Coward (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16201 to look at the new patch set (#2). Change subject: KUDU-1422 resize ErrorCollector .. KUDU-1422 resize

[kudu-CR] KUDU-1422 resize ErrorCollector

2020-07-15 Thread Anonymous Coward (Code Review)
guanwen...@taptap.com has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16201 Change subject: KUDU-1422 resize ErrorCollector .. KUDU-1422 resize ErrorCollector Change-Id:

[kudu-CR] [tests] add same tablet concurrent writes test

2020-07-15 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16060 ) Change subject: [tests] add same_tablet_concurrent_writes test .. Patch Set 6: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-3090 Add ownership privileges

2020-07-15 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16072 ) Change subject: KUDU-3090 Add ownership privileges .. Patch Set 24: Code-Review+1 -- To view, visit

[kudu-CR] KUDU-2612 p4: mechanism to create a transaction status table

2020-07-15 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16124 ) Change subject: KUDU-2612 p4: mechanism to create a transaction status table .. Patch Set 4: (4 comments)

[kudu-CR] add setErrorCollectorSpace method to change ErrorCollector size, in case errors are dropped in manual flush mode

2020-07-15 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/16200 ) Change subject: add setErrorCollectorSpace method to change ErrorCollector size, in case errors are dropped in manual flush mode ..

[kudu-CR] add setErrorCollectorSpace method to change ErrorCollector size, in case errors are dropped in manual flush mode

2020-07-15 Thread Anonymous Coward (Code Review)
guanwen...@taptap.com has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16200 Change subject: add setErrorCollectorSpace method to change ErrorCollector size, in case errors are dropped in manual flush mode

[kudu-CR] KUDU-3090 Restrict changing ownership of a table

2020-07-15 Thread Attila Bukor (Code Review)
Hello Tidy Bot, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16113 to look at the new patch set (#18). Change subject: KUDU-3090 Restrict changing ownership of a table