[GitHub] spark pull request: [SPARK-15638][SQL] Audit Dataset, SparkSession...

2016-05-30 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/13370 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [MINOR][CORE][DOCS] Fix description of FilterF...

2016-05-30 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13404#issuecomment-222597618 **[Test build #59639 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59639/consoleFull)** for PR 13404 at commit

[GitHub] spark pull request: [SPARK-15638][SQL] Audit Dataset, SparkSession...

2016-05-30 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/13370#issuecomment-222597634 Thanks - merging in master/2.0. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-15638][SQL] Audit Dataset, SparkSession...

2016-05-30 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/13370#discussion_r65126050 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/KeyValueGroupedDataset.scala --- @@ -204,8 +205,8 @@ class KeyValueGroupedDataset[K, V] private[sql](

[GitHub] spark pull request: [MINOR][CORE][DOCS] Fix description of FilterF...

2016-05-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13404#issuecomment-222597423 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [MINOR][CORE][DOCS] Fix description of FilterF...

2016-05-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13404#issuecomment-222597425 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [MINOR][CORE][DOCS] Fix description of FilterF...

2016-05-30 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13404#issuecomment-222597411 **[Test build #59638 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59638/consoleFull)** for PR 13404 at commit

[GitHub] spark pull request: [MINOR][CORE][DOCS] Fix description of FilterF...

2016-05-30 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/13404#discussion_r65125923 --- Diff: core/src/main/java/org/apache/spark/api/java/function/package.scala --- @@ -22,4 +22,5 @@ package org.apache.spark.api.java * these

[GitHub] spark pull request: [MINOR][CORE][DOCS] Fix description of FilterF...

2016-05-30 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13404#issuecomment-222596540 **[Test build #59638 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59638/consoleFull)** for PR 13404 at commit

[GitHub] spark pull request: [SPARK-12922][SparkR][WIP] Implement gapply() ...

2016-05-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12836#issuecomment-222596477 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12922][SparkR][WIP] Implement gapply() ...

2016-05-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12836#issuecomment-222596478 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [MINOR][CORE][DOC Fix description of FilterFun...

2016-05-30 Thread dongjoon-hyun
GitHub user dongjoon-hyun opened a pull request: https://github.com/apache/spark/pull/13404 [MINOR][CORE][DOC Fix description of FilterFunction ## What changes were proposed in this pull request? This PR fixes the wrong description of `FilterFunction`. ``` - * If

[GitHub] spark pull request: [SPARK-12922][SparkR][WIP] Implement gapply() ...

2016-05-30 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12836#issuecomment-222596375 **[Test build #59631 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59631/consoleFull)** for PR 12836 at commit

[GitHub] spark pull request: [SPARK-15557][SQL] expressi[on ((cast(99 as de...

2016-05-30 Thread cloud-fan
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/13368#issuecomment-222596139 cc @yhuai @davies , do you still remember why we promote string to decimal(38, 18) instead of double? --- If your project is set up for it, you can reply to this

[GitHub] spark pull request: [SPARK-12922][SparkR][WIP] Implement gapply() ...

2016-05-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12836#issuecomment-222595900 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12922][SparkR][WIP] Implement gapply() ...

2016-05-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12836#issuecomment-222595899 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12922][SparkR][WIP] Implement gapply() ...

2016-05-30 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12836#issuecomment-222595798 **[Test build #59630 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59630/consoleFull)** for PR 12836 at commit

[GitHub] spark pull request: [SPARK-15638][SQL] Audit Dataset, SparkSession...

2016-05-30 Thread cloud-fan
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/13370#issuecomment-222595668 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-15638][SQL] Audit Dataset, SparkSession...

2016-05-30 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/13370#discussion_r65125196 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/KeyValueGroupedDataset.scala --- @@ -204,8 +205,8 @@ class KeyValueGroupedDataset[K, V]

[GitHub] spark pull request: [SPARK-15660][CORE] RDD and Dataset should sho...

2016-05-30 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13403#issuecomment-222595435 **[Test build #59637 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59637/consoleFull)** for PR 13403 at commit

[GitHub] spark pull request: [SPARK-15638][SQL] Audit Dataset, SparkSession...

2016-05-30 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/13370#discussion_r65125156 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Column.scala --- @@ -132,6 +130,15 @@ class Column(protected[sql] val expr: Expression) extends

[GitHub] spark pull request: [SPARK-15638][SQL] Audit Dataset, SparkSession...

2016-05-30 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/13370#discussion_r65125096 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Column.scala --- @@ -132,6 +130,15 @@ class Column(protected[sql] val expr: Expression) extends

[GitHub] spark pull request: [SPARK-15660][CORE] RDD and Dataset should sho...

2016-05-30 Thread dongjoon-hyun
GitHub user dongjoon-hyun opened a pull request: https://github.com/apache/spark/pull/13403 [SPARK-15660][CORE] RDD and Dataset should show the consistent values for variance/stdev. ## What changes were proposed in this pull request? In Spark-11490, `variance/stdev` are

[GitHub] spark pull request: [SPARK-15647] [SQL] Fix Boundary Cases in Opti...

2016-05-30 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13392#issuecomment-22259 **[Test build #59636 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59636/consoleFull)** for PR 13392 at commit

[GitHub] spark pull request: [SPARK-15647] [SQL] Fix Boundary Cases in Opti...

2016-05-30 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/13392#discussion_r65124178 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/internal/SQLConfSuite.scala --- @@ -219,4 +220,41 @@ class SQLConfSuite extends QueryTest with

[GitHub] spark pull request: [SPARK-15647] [SQL] Fix Boundary Cases in Opti...

2016-05-30 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/13392#discussion_r65124192 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/internal/SQLConfSuite.scala --- @@ -219,4 +220,41 @@ class SQLConfSuite extends QueryTest with

[GitHub] spark pull request: [SPARK-15657][SQL] RowEncoder should validate ...

2016-05-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13401#issuecomment-222593249 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-15657][SQL] RowEncoder should validate ...

2016-05-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13401#issuecomment-222593250 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-15657][SQL] RowEncoder should validate ...

2016-05-30 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13401#issuecomment-222593159 **[Test build #59629 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59629/consoleFull)** for PR 13401 at commit

[GitHub] spark pull request: [SPARK-15269][SQL] Removes unexpected empty ta...

2016-05-30 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13270#issuecomment-222592978 **[Test build #59635 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59635/consoleFull)** for PR 13270 at commit

[GitHub] spark pull request: [SPARK-15601][CORE] CircularBuffer's toString(...

2016-05-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13351#issuecomment-222592731 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-15601][CORE] CircularBuffer's toString(...

2016-05-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13351#issuecomment-222592730 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-15601][CORE] CircularBuffer's toString(...

2016-05-30 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13351#issuecomment-222592645 **[Test build #59628 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59628/consoleFull)** for PR 13351 at commit

[GitHub] spark pull request: [SPARK-15647] [SQL] Fix Boundary Cases in Opti...

2016-05-30 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/13392#discussion_r65123693 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/internal/SQLConfSuite.scala --- @@ -219,4 +220,41 @@ class SQLConfSuite extends QueryTest with

[GitHub] spark pull request: [SPARK-15647] [SQL] Fix Boundary Cases in Opti...

2016-05-30 Thread cloud-fan
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/13392#issuecomment-222592448 LGTM except some style comments --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-15269][SQL] Removes unexpected empty ta...

2016-05-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13270#issuecomment-222592244 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-15269][SQL] Removes unexpected empty ta...

2016-05-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13270#issuecomment-222592243 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-15647] [SQL] Fix Boundary Cases in Opti...

2016-05-30 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/13392#discussion_r65123624 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/internal/SQLConfSuite.scala --- @@ -219,4 +220,41 @@ class SQLConfSuite extends QueryTest with

[GitHub] spark pull request: [SPARK-15269][SQL] Removes unexpected empty ta...

2016-05-30 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13270#issuecomment-222592234 **[Test build #59632 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59632/consoleFull)** for PR 13270 at commit

[GitHub] spark pull request: [SPARK-15658][SQL] UDT serializer should decla...

2016-05-30 Thread cloud-fan
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/13402#issuecomment-222592066 cc @yhuai @zsxwing --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-15647] [SQL] Fix Boundary Cases in Opti...

2016-05-30 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13392#issuecomment-222592083 **[Test build #59634 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59634/consoleFull)** for PR 13392 at commit

[GitHub] spark pull request: [SPARK-15658][SQL] UDT serializer should decla...

2016-05-30 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13402#issuecomment-222592077 **[Test build #59633 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59633/consoleFull)** for PR 13402 at commit

[GitHub] spark pull request: [SPARK-15658][SQL] UDT serializer should decla...

2016-05-30 Thread cloud-fan
GitHub user cloud-fan opened a pull request: https://github.com/apache/spark/pull/13402 [SPARK-15658][SQL] UDT serializer should declare its data type as udt instead of udt.sqlType ## What changes were proposed in this pull request? When we build serializer for UDT object,

[GitHub] spark pull request: [SPARK-15269][SQL] Removes unexpected empty ta...

2016-05-30 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13270#issuecomment-222591642 **[Test build #59632 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59632/consoleFull)** for PR 13270 at commit

[GitHub] spark pull request: [SPARK-15269][SQL] Removes unexpected empty ta...

2016-05-30 Thread liancheng
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/13270#discussion_r65123201 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala --- @@ -212,11 +212,46 @@ class SessionCatalog(

[GitHub] spark pull request: [SPARK-15647] [SQL] Fix Boundary Cases in Opti...

2016-05-30 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/13392#discussion_r65122900 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/internal/SQLConfSuite.scala --- @@ -17,13 +17,36 @@ package

[GitHub] spark pull request: [SPARK-14649][CORE] DagScheduler should not ru...

2016-05-30 Thread sitalkedia
Github user sitalkedia commented on the pull request: https://github.com/apache/spark/pull/12436#issuecomment-222590636 @kayousterhout - Sure, I will resolve the conflicts. Can you take a cursory look at the diff and let me know if the approach is reasonable? --- If your project is

[GitHub] spark pull request: [SPARK-15647] [SQL] Fix Boundary Cases in Opti...

2016-05-30 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/13392#discussion_r65122821 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/internal/SQLConfSuite.scala --- @@ -17,13 +17,36 @@ package

[GitHub] spark pull request: [SPARK-10530] [CORE] Kill other task attempts ...

2016-05-30 Thread devaraj-kavali
Github user devaraj-kavali commented on the pull request: https://github.com/apache/spark/pull/11996#issuecomment-222589679 Thanks @kayousterhout. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-15655] [SQL] Fix Wrong Partition Column...

2016-05-30 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/13400#discussion_r65122095 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/SQLQuerySuite.scala --- @@ -1537,6 +1537,35 @@ class SQLQuerySuite extends

[GitHub] spark pull request: [SPARK-15647] [SQL] Fix Boundary Cases in Opti...

2016-05-30 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/13392#discussion_r65121914 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -937,9 +937,14 @@ object SimplifyConditionals

[GitHub] spark pull request: [SPARK-15647] [SQL] Fix Boundary Cases in Opti...

2016-05-30 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/13392#discussion_r65121902 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/internal/SQLConfSuite.scala --- @@ -17,13 +17,36 @@ package

[GitHub] spark pull request: [SPARK-12922][SparkR][WIP] Implement gapply() ...

2016-05-30 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12836#issuecomment-222586936 **[Test build #59631 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59631/consoleFull)** for PR 12836 at commit

[GitHub] spark pull request: [SPARK-12922][SparkR][WIP] Implement gapply() ...

2016-05-30 Thread NarineK
Github user NarineK commented on a diff in the pull request: https://github.com/apache/spark/pull/12836#discussion_r65120888 --- Diff: R/pkg/R/DataFrame.R --- @@ -1268,6 +1268,82 @@ setMethod("dapplyCollect", ldf }) +#' gapply +#'

[GitHub] spark pull request: [SPARK-15655] [SQL] Fix Wrong Partition Column...

2016-05-30 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/13400#discussion_r65120902 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/SQLQuerySuite.scala --- @@ -1537,6 +1537,35 @@ class SQLQuerySuite extends

[GitHub] spark pull request: [SPARK-12922][SparkR][WIP] Implement gapply() ...

2016-05-30 Thread NarineK
Github user NarineK commented on a diff in the pull request: https://github.com/apache/spark/pull/12836#discussion_r65120891 --- Diff: R/pkg/R/DataFrame.R --- @@ -1268,6 +1268,82 @@ setMethod("dapplyCollect", ldf }) +#' gapply +#'

[GitHub] spark pull request: [SPARK-15647] [SQL] Fix Boundary Cases in Opti...

2016-05-30 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/13392#discussion_r65120800 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/internal/SQLConfSuite.scala --- @@ -17,13 +17,36 @@ package

[GitHub] spark pull request: [SPARK-12922][SparkR][WIP] Implement gapply() ...

2016-05-30 Thread NarineK
Github user NarineK commented on a diff in the pull request: https://github.com/apache/spark/pull/12836#discussion_r65120675 --- Diff: R/pkg/R/DataFrame.R --- @@ -1268,6 +1268,82 @@ setMethod("dapplyCollect", ldf }) +#' gapply +#'

[GitHub] spark pull request: [SPARK-12922][SparkR][WIP] Implement gapply() ...

2016-05-30 Thread NarineK
Github user NarineK commented on a diff in the pull request: https://github.com/apache/spark/pull/12836#discussion_r65120665 --- Diff: R/pkg/R/deserialize.R --- @@ -197,6 +197,31 @@ readMultipleObjects <- function(inputCon) { data # this is a list of named lists now }

[GitHub] spark pull request: [SPARK-12922][SparkR][WIP] Implement gapply() ...

2016-05-30 Thread NarineK
Github user NarineK commented on a diff in the pull request: https://github.com/apache/spark/pull/12836#discussion_r65120671 --- Diff: R/pkg/R/DataFrame.R --- @@ -1268,6 +1268,82 @@ setMethod("dapplyCollect", ldf }) +#' gapply +#'

[GitHub] spark pull request: [SPARK-12922][SparkR][WIP] Implement gapply() ...

2016-05-30 Thread NarineK
Github user NarineK commented on a diff in the pull request: https://github.com/apache/spark/pull/12836#discussion_r65120653 --- Diff: R/pkg/R/group.R --- @@ -142,3 +142,54 @@ createMethods <- function() { } createMethods() + +#' gapply +#' +#'

[GitHub] spark pull request: [SPARK-12922][SparkR][WIP] Implement gapply() ...

2016-05-30 Thread NarineK
Github user NarineK commented on a diff in the pull request: https://github.com/apache/spark/pull/12836#discussion_r65120620 --- Diff: R/pkg/R/group.R --- @@ -142,3 +142,54 @@ createMethods <- function() { } createMethods() + +#' gapply +#' +#'

[GitHub] spark pull request: [SPARK-12922][SparkR][WIP] Implement gapply() ...

2016-05-30 Thread NarineK
Github user NarineK commented on a diff in the pull request: https://github.com/apache/spark/pull/12836#discussion_r65120599 --- Diff: R/pkg/inst/worker/worker.R --- @@ -84,67 +84,78 @@ broadcastElap <- elapsedSecs() # as number of partitions to create. numPartitions <-

[GitHub] spark pull request: [SPARK-12922][SparkR][WIP] Implement gapply() ...

2016-05-30 Thread NarineK
Github user NarineK commented on a diff in the pull request: https://github.com/apache/spark/pull/12836#discussion_r65120565 --- Diff: R/pkg/inst/worker/worker.R --- @@ -84,67 +84,78 @@ broadcastElap <- elapsedSecs() # as number of partitions to create. numPartitions <-

[GitHub] spark pull request: [SPARK-12922][SparkR][WIP] Implement gapply() ...

2016-05-30 Thread NarineK
Github user NarineK commented on a diff in the pull request: https://github.com/apache/spark/pull/12836#discussion_r65120461 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala --- @@ -2011,6 +2011,25 @@ class Dataset[T] private[sql]( } /**

[GitHub] spark pull request: [SPARK-12922][SparkR][WIP] Implement gapply() ...

2016-05-30 Thread NarineK
Github user NarineK commented on a diff in the pull request: https://github.com/apache/spark/pull/12836#discussion_r65120457 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/RelationalGroupedDataset.scala --- @@ -379,6 +383,50 @@ class RelationalGroupedDataset

[GitHub] spark pull request: [SPARK-15647] [SQL] Fix Boundary Cases in Opti...

2016-05-30 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/13392#discussion_r65120442 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -937,9 +937,14 @@ object SimplifyConditionals

[GitHub] spark pull request: [SPARK-12922][SparkR][WIP] Implement gapply() ...

2016-05-30 Thread NarineK
Github user NarineK commented on a diff in the pull request: https://github.com/apache/spark/pull/12836#discussion_r65120450 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/objects.scala --- @@ -325,6 +330,80 @@ case class MapGroupsExec( } /**

[GitHub] spark pull request: [SPARK-15657][SQL] RowEncoder should validate ...

2016-05-30 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13401#issuecomment-222586062 **[Test build #59629 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59629/consoleFull)** for PR 13401 at commit

[GitHub] spark pull request: [SPARK-12922][SparkR][WIP] Implement gapply() ...

2016-05-30 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12836#issuecomment-222586065 **[Test build #59630 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59630/consoleFull)** for PR 12836 at commit

[GitHub] spark pull request: [SPARK-12922][SparkR][WIP] Implement gapply() ...

2016-05-30 Thread NarineK
Github user NarineK commented on a diff in the pull request: https://github.com/apache/spark/pull/12836#discussion_r65120403 --- Diff: R/pkg/R/DataFrame.R --- @@ -1268,6 +1268,82 @@ setMethod("dapplyCollect", ldf }) +#' gapply +#'

[GitHub] spark pull request: [SPARK-12922][SparkR][WIP] Implement gapply() ...

2016-05-30 Thread NarineK
Github user NarineK commented on a diff in the pull request: https://github.com/apache/spark/pull/12836#discussion_r65120399 --- Diff: R/pkg/R/DataFrame.R --- @@ -1268,6 +1268,82 @@ setMethod("dapplyCollect", ldf }) +#' gapply +#'

[GitHub] spark pull request: [SPARK-15657][SQL] RowEncoder should validate ...

2016-05-30 Thread cloud-fan
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/13401#issuecomment-222585795 cc @marmbrus @yhuai @viirya --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-15657][SQL] RowEncoder should validate ...

2016-05-30 Thread cloud-fan
GitHub user cloud-fan opened a pull request: https://github.com/apache/spark/pull/13401 [SPARK-15657][SQL] RowEncoder should validate the data type of input object ## What changes were proposed in this pull request? This PR improves the error handling of `RowEncoder`. When

[GitHub] spark pull request: [SPARK-6320][SQL] Move planLater method into G...

2016-05-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13147#issuecomment-222585528 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-6320][SQL] Move planLater method into G...

2016-05-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13147#issuecomment-222585527 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-6320][SQL] Move planLater method into G...

2016-05-30 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13147#issuecomment-222585447 **[Test build #59627 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59627/consoleFull)** for PR 13147 at commit

[GitHub] spark pull request: [SPARK-15601][CORE] CircularBuffer's toString(...

2016-05-30 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13351#issuecomment-222583398 **[Test build #59628 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59628/consoleFull)** for PR 13351 at commit

[GitHub] spark pull request: [SPARK-15601][CORE] CircularBuffer's toString(...

2016-05-30 Thread tejasapatil
Github user tejasapatil commented on the pull request: https://github.com/apache/spark/pull/13351#issuecomment-222583109 Jenkins, retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-6320][SQL] Move planLater method into G...

2016-05-30 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13147#issuecomment-222577825 **[Test build #59627 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59627/consoleFull)** for PR 13147 at commit

[GitHub] spark pull request: [SPARK-15647] [SQL] Fix Boundary Cases in Opti...

2016-05-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13392#issuecomment-222574008 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-15647] [SQL] Fix Boundary Cases in Opti...

2016-05-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13392#issuecomment-222574005 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-15647] [SQL] Fix Boundary Cases in Opti...

2016-05-30 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13392#issuecomment-222573920 **[Test build #59626 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59626/consoleFull)** for PR 13392 at commit

[GitHub] spark pull request: [SPARK-6320][SQL] Move planLater method into G...

2016-05-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13147#issuecomment-222573545 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-15601][CORE] CircularBuffer's toString(...

2016-05-30 Thread tejasapatil
Github user tejasapatil commented on the pull request: https://github.com/apache/spark/pull/13351#issuecomment-222573544 ok to test. I ran `sbt core/test:test` locally and it worked. Not sure what failed over Jenkins because it says `[info] Passed: Total 1832, Failed 0,

[GitHub] spark pull request: [SPARK-6320][SQL] Move planLater method into G...

2016-05-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13147#issuecomment-222573548 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-6320][SQL] Move planLater method into G...

2016-05-30 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13147#issuecomment-222573444 **[Test build #59625 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59625/consoleFull)** for PR 13147 at commit

[GitHub] spark pull request: [SPARK-15655] [SQL] Fix Wrong Partition Column...

2016-05-30 Thread gatorsmile
Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/13400#issuecomment-222573349 cc @liancheng @andrewor14 @cloud-fan Could you please review this? Thanks! --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark pull request: [SPARK-15490][R][DOC] SparkR 2.0 QA: New R API...

2016-05-30 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/13394#discussion_r65113954 --- Diff: R/pkg/R/stats.R --- @@ -19,12 +19,11 @@ setOldClass("jobj") -#' crosstab -#' #' Computes a pair-wise frequency

[GitHub] spark pull request: [SPARK-15490][R][DOC] SparkR 2.0 QA: New R API...

2016-05-30 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/13394#discussion_r65113870 --- Diff: R/pkg/R/DataFrame.R --- @@ -1069,7 +1080,10 @@ setMethod("first", #' #' @param x A SparkDataFrame #' -#' @noRd +#'

[GitHub] spark pull request: [SPARK-15490][R][DOC] SparkR 2.0 QA: New R API...

2016-05-30 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/13394#discussion_r65113846 --- Diff: R/pkg/R/DataFrame.R --- @@ -629,8 +629,9 @@ setMethod("repartition", #' @param x A SparkDataFrame #' @return A StringRRDD of JSON

[GitHub] spark pull request: [SPARK-15490][R][DOC] SparkR 2.0 QA: New R API...

2016-05-30 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/spark/pull/13394#issuecomment-222572865 > (c) the change to not require sqlContext This was in the earlier PR, under the migration guide session. --- If your project is set up for it, you can reply

[GitHub] spark pull request: [SPARK-15647] [SQL] Fix Boundary Cases in Opti...

2016-05-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13392#issuecomment-222571769 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-15647] [SQL] Fix Boundary Cases in Opti...

2016-05-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13392#issuecomment-222571771 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-15647] [SQL] Fix Boundary Cases in Opti...

2016-05-30 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13392#issuecomment-222571690 **[Test build #59623 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59623/consoleFull)** for PR 13392 at commit

[GitHub] spark pull request: [SPARK-15655] [SQL] Fix Wrong Partition Column...

2016-05-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13400#issuecomment-222571192 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-15655] [SQL] Fix Wrong Partition Column...

2016-05-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13400#issuecomment-222571193 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-15655] [SQL] Fix Wrong Partition Column...

2016-05-30 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13400#issuecomment-222571127 **[Test build #59624 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59624/consoleFull)** for PR 13400 at commit

[GitHub] spark pull request: [SPARK-15601][CORE] CircularBuffer's toString(...

2016-05-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13351#issuecomment-222570792 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-15601][CORE] CircularBuffer's toString(...

2016-05-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13351#issuecomment-222570790 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

  1   2   3   >