[GitHub] spark issue #14517: [SPARK-16931][PYTHON] PySpark APIS for bucketBy and sort...

2016-08-13 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14517 **[Test build #63739 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63739/consoleFull)** for PR 14517 at commit

[GitHub] spark issue #14517: [SPARK-16931][PYTHON] PySpark APIS for bucketBy and sort...

2016-08-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14517 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63739/ Test FAILed. ---

[GitHub] spark issue #14517: [SPARK-16931][PYTHON] PySpark APIS for bucketBy and sort...

2016-08-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14517 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14517: [SPARK-16931][PYTHON] PySpark APIS for bucketBy and sort...

2016-08-13 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14517 **[Test build #63739 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63739/consoleFull)** for PR 14517 at commit

[GitHub] spark issue #14623: [SPARK-17044][SQL] Make test files for window functions ...

2016-08-13 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/14623 Hi, @rxin . If you think the direction of PR is not appropriate to your initial intention, please let me know. --- If your project is set up for it, you can reply to this email and have

[GitHub] spark issue #14517: [SPARK-16931][PYTHON] PySpark APIS for bucketBy and sort...

2016-08-13 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14517 **[Test build #63738 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63738/consoleFull)** for PR 14517 at commit

[GitHub] spark issue #14517: [SPARK-16931][PYTHON] PySpark APIS for bucketBy and sort...

2016-08-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14517 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14517: [SPARK-16931][PYTHON] PySpark APIS for bucketBy and sort...

2016-08-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14517 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63738/ Test FAILed. ---

[GitHub] spark issue #14517: [SPARK-16931][PYTHON] PySpark APIS for bucketBy and sort...

2016-08-13 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14517 **[Test build #63738 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63738/consoleFull)** for PR 14517 at commit

[GitHub] spark issue #14625: [SPARK-17045] [SQL] Moving Auto_Joins from HiveCompatibi...

2016-08-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14625 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63737/ Test PASSed. ---

[GitHub] spark issue #14625: [SPARK-17045] [SQL] Moving Auto_Joins from HiveCompatibi...

2016-08-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14625 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14625: [SPARK-17045] [SQL] Moving Auto_Joins from HiveCompatibi...

2016-08-13 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14625 **[Test build #63737 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63737/consoleFull)** for PR 14625 at commit

[GitHub] spark issue #13690: [SPARK-15767][R][ML] Decision Tree Regression wrapper in...

2016-08-13 Thread vectorijk
Github user vectorijk commented on the issue: https://github.com/apache/spark/pull/13690 Yes, sure. But I'm in a vacation this week. I will keep working on this and update as soon as possible when I get back next week. On Thu, Aug 11, 2016, 19:46 Felix Cheung

[GitHub] spark pull request #14558: [SPARK-16508][SparkR] Fix warnings on undocumente...

2016-08-13 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/14558#discussion_r74694116 --- Diff: R/pkg/R/functions.R --- @@ -1143,7 +1139,7 @@ setMethod("minute", #' @export #' @examples \dontrun{select(df,

[GitHub] spark issue #14625: [SPARK-17045] [SQL] Moving Auto_Joins from HiveCompatibi...

2016-08-13 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/14625 Sure. The scope is a little bit large, but let me try to go over the existing join-related test cases in the test suites. We might not be able to cover all of them in a single ticket. Will try

[GitHub] spark issue #14625: [SPARK-17045] [SQL] Moving Auto_Joins from HiveCompatibi...

2016-08-13 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14625 **[Test build #63737 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63737/consoleFull)** for PR 14625 at commit

[GitHub] spark pull request #14558: [SPARK-16508][SparkR] Fix warnings on undocumente...

2016-08-13 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/14558#discussion_r74693897 --- Diff: R/pkg/R/SQLContext.R --- @@ -181,7 +181,7 @@ getDefaultSqlSource <- function() { #' @method createDataFrame default #' @note

[GitHub] spark pull request #14558: [SPARK-16508][SparkR] Fix warnings on undocumente...

2016-08-13 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/14558#discussion_r74693887 --- Diff: R/pkg/R/DataFrame.R --- @@ -2461,8 +2473,9 @@ setMethod("unionAll", #' Union two or more SparkDataFrames. This is equivalent to `UNION

[GitHub] spark pull request #14558: [SPARK-16508][SparkR] Fix warnings on undocumente...

2016-08-13 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/14558#discussion_r74693856 --- Diff: R/pkg/R/DataFrame.R --- @@ -1146,7 +1147,7 @@ setMethod("head", #' Return the first row of a SparkDataFrame #' -#' @param x

[GitHub] spark pull request #14558: [SPARK-16508][SparkR] Fix warnings on undocumente...

2016-08-13 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/14558#discussion_r74693823 --- Diff: R/pkg/R/DataFrame.R --- @@ -510,9 +510,7 @@ setMethod("registerTempTable", #' #' Insert the contents of a SparkDataFrame into a table

[GitHub] spark issue #14625: [SPARK-17045] [SQL] Moving Auto_Joins from HiveCompatibi...

2016-08-13 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/14625 Can we repurpose this ticket to just create test cases for joins in general? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark issue #14625: [SPARK-17045] [SQL] Moving Auto_Joins from HiveCompatibi...

2016-08-13 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/14625 Below is the output of Hive for the same queries. They are the same. [outputHive.txt](https://github.com/apache/spark/files/416810/outputHive.txt) --- If your project is set up for

[GitHub] spark issue #14556: [SPARK-16966][Core] Make App Name to the valid name inst...

2016-08-13 Thread Sherry302
Github user Sherry302 commented on the issue: https://github.com/apache/spark/pull/14556 @srowen Thanks for the new PR and the review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark issue #14631: [SPARK-17035][SQL][PYSPARK] Timestamp should preserve mi...

2016-08-13 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/14631 Hi, @davies . Could you review this PR when you have some time? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request #14558: [SPARK-16508][SparkR] Fix warnings on undocumente...

2016-08-13 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/14558#discussion_r74693204 --- Diff: R/pkg/R/functions.R --- @@ -1497,7 +1493,7 @@ setMethod("soundex", #' \dontrun{select(df, spark_partition_id())} #' @note

[GitHub] spark pull request #14558: [SPARK-16508][SparkR] Fix warnings on undocumente...

2016-08-13 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/14558#discussion_r74693197 --- Diff: R/pkg/R/generics.R --- @@ -1251,10 +1311,57 @@ setGeneric("year", function(x) { standardGeneric("year") }) #' @export

[GitHub] spark pull request #14558: [SPARK-16508][SparkR] Fix warnings on undocumente...

2016-08-13 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/14558#discussion_r74693174 --- Diff: R/pkg/R/generics.R --- @@ -1277,8 +1384,11 @@ setGeneric("spark.naiveBayes", function(data, formula, ...) { standardGeneric("s #'

[GitHub] spark pull request #14558: [SPARK-16508][SparkR] Fix warnings on undocumente...

2016-08-13 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/14558#discussion_r74693158 --- Diff: R/pkg/R/mllib.R --- @@ -142,15 +143,6 @@ setMethod("spark.glm", signature(data = "SparkDataFrame", formula = "formula"), #' Generalized

[GitHub] spark pull request #14558: [SPARK-16508][SparkR] Fix warnings on undocumente...

2016-08-13 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/14558#discussion_r74693142 --- Diff: R/pkg/R/mllib.R --- @@ -298,14 +304,15 @@ setMethod("summary", signature(object = "NaiveBayesModel"), #' Users can call \code{summary} to

[GitHub] spark pull request #14630: [SPARK-16966] [SQL] [CORE] App Name is a randomUU...

2016-08-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/14630 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request #14558: [SPARK-16508][SparkR] Fix warnings on undocumente...

2016-08-13 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/14558#discussion_r74693106 --- Diff: R/pkg/R/mllib.R --- @@ -346,8 +339,11 @@ setMethod("spark.kmeans", signature(data = "SparkDataFrame", formula = "formula" #' Get fitted

[GitHub] spark issue #14630: [SPARK-16966] [SQL] [CORE] App Name is a randomUUID even...

2016-08-13 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/14630 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] spark pull request #14558: [SPARK-16508][SparkR] Fix warnings on undocumente...

2016-08-13 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/14558#discussion_r74693097 --- Diff: R/pkg/R/mllib.R --- @@ -414,11 +411,12 @@ setMethod("predict", signature(object = "KMeansModel"), #' predictions on new data, and

[GitHub] spark issue #14630: [SPARK-16966] [SQL] [CORE] App Name is a randomUUID even...

2016-08-13 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/14630 Merging in master/2.0. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark pull request #14558: [SPARK-16508][SparkR] Fix warnings on undocumente...

2016-08-13 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/14558#discussion_r74693087 --- Diff: .gitignore --- @@ -77,3 +77,8 @@ spark-warehouse/ # For R session data .RData .RHistory +.Rhistory --- End diff --

[GitHub] spark pull request #14558: [SPARK-16508][SparkR] Fix warnings on undocumente...

2016-08-13 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/14558#discussion_r74693053 --- Diff: R/pkg/R/mllib.R --- @@ -602,14 +599,14 @@ setMethod("spark.survreg", signature(data = "SparkDataFrame", formula = "formula # Returns a

[GitHub] spark pull request #14558: [SPARK-16508][SparkR] Fix warnings on undocumente...

2016-08-13 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/14558#discussion_r74692979 --- Diff: R/pkg/R/DataFrame.R --- @@ -3184,6 +3200,7 @@ setMethod("histogram", #' @param x A SparkDataFrame #' @param url JDBC database url of

[GitHub] spark issue #14631: [SPARK-17035][SQL][PYSPARK] Timestamp should preserve mi...

2016-08-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14631 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63736/ Test PASSed. ---

[GitHub] spark issue #14631: [SPARK-17035][SQL][PYSPARK] Timestamp should preserve mi...

2016-08-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14631 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14631: [SPARK-17035][SQL][PYSPARK] Timestamp should preserve mi...

2016-08-13 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14631 **[Test build #63736 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63736/consoleFull)** for PR 14631 at commit

[GitHub] spark issue #14625: [SPARK-17045] [SQL] Moving Auto_Joins from HiveCompatibi...

2016-08-13 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/14625 FYI, found the original JIRA who delivered the first 25 auto_join test cases to Hive: https://issues.apache.org/jira/browse/HIVE-1642 --- If your project is set up for it, you can reply to this

[GitHub] spark issue #14625: [SPARK-17045] [SQL] Moving Auto_Joins from HiveCompatibi...

2016-08-13 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/14625 @rxin Sure, will do it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #14631: [SPARK-17035][SQL][PYSPARK] Timestamp should preserve mi...

2016-08-13 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14631 **[Test build #63736 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63736/consoleFull)** for PR 14631 at commit

[GitHub] spark issue #14631: [SPARK-17035][SQL][PYSPARK] Timestamp should preserve mi...

2016-08-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14631 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14631: [SPARK-17035][SQL][PYSPARK] Timestamp should preserve mi...

2016-08-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14631 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63735/ Test FAILed. ---

[GitHub] spark issue #14631: [SPARK-17035][SQL][PYSPARK] Timestamp should preserve mi...

2016-08-13 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14631 **[Test build #63735 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63735/consoleFull)** for PR 14631 at commit

[GitHub] spark issue #14631: [SPARK-17035][SQL][PYSPARK] Timestamp should preserve mi...

2016-08-13 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14631 **[Test build #63735 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63735/consoleFull)** for PR 14631 at commit

[GitHub] spark pull request #14631: [SPARK-17035][SQL][PYSPARK] Timestamp should pres...

2016-08-13 Thread dongjoon-hyun
GitHub user dongjoon-hyun opened a pull request: https://github.com/apache/spark/pull/14631 [SPARK-17035][SQL][PYSPARK] Timestamp should preserve microseconds part ## What changes were proposed in this pull request? **Before** ``` >>> from datetime import datetime

[GitHub] spark issue #14580: [SPARK-16991][SQL] Fix `EliminateOuterJoin` optimizer to...

2016-08-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14580 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14580: [SPARK-16991][SQL] Fix `EliminateOuterJoin` optimizer to...

2016-08-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14580 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63733/ Test PASSed. ---

[GitHub] spark issue #14583: [SPARK-16994][SQL] PushDownPredicate should not ignore l...

2016-08-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14583 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14580: [SPARK-16991][SQL] Fix `EliminateOuterJoin` optimizer to...

2016-08-13 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14580 **[Test build #63733 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63733/consoleFull)** for PR 14580 at commit

[GitHub] spark issue #14583: [SPARK-16994][SQL] PushDownPredicate should not ignore l...

2016-08-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14583 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63732/ Test PASSed. ---

[GitHub] spark issue #14583: [SPARK-16994][SQL] PushDownPredicate should not ignore l...

2016-08-13 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14583 **[Test build #63732 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63732/consoleFull)** for PR 14583 at commit

[GitHub] spark issue #14447: [SPARK-16445][MLlib][SparkR] Multilayer Perceptron Class...

2016-08-13 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/14447 These are the last few comments. @shivaram what do you think - with those fixed we are good to merge this? --- If your project is set up for it, you can reply to this email and have your

[GitHub] spark pull request #14447: [SPARK-16445][MLlib][SparkR] Multilayer Perceptro...

2016-08-13 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/14447#discussion_r74692317 --- Diff: R/pkg/R/mllib.R --- @@ -533,6 +628,27 @@ setMethod("write.ml", signature(object = "KMeansModel", path = "character"),

[GitHub] spark pull request #14447: [SPARK-16445][MLlib][SparkR] Multilayer Perceptro...

2016-08-13 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/14447#discussion_r74692309 --- Diff: R/pkg/R/mllib.R --- @@ -533,6 +628,27 @@ setMethod("write.ml", signature(object = "KMeansModel", path = "character"),

[GitHub] spark issue #14527: [SPARK-16938][SQL] `drop/dropDuplicate` should handle th...

2016-08-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14527 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63734/ Test PASSed. ---

[GitHub] spark issue #14527: [SPARK-16938][SQL] `drop/dropDuplicate` should handle th...

2016-08-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14527 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14527: [SPARK-16938][SQL] `drop/dropDuplicate` should handle th...

2016-08-13 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14527 **[Test build #63734 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63734/consoleFull)** for PR 14527 at commit

[GitHub] spark pull request #14447: [SPARK-16445][MLlib][SparkR] Multilayer Perceptro...

2016-08-13 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/14447#discussion_r74692263 --- Diff: R/pkg/R/mllib.R --- @@ -414,6 +421,94 @@ setMethod("predict", signature(object = "KMeansModel"),

[GitHub] spark pull request #14447: [SPARK-16445][MLlib][SparkR] Multilayer Perceptro...

2016-08-13 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/14447#discussion_r74692255 --- Diff: R/pkg/R/mllib.R --- @@ -414,6 +421,94 @@ setMethod("predict", signature(object = "KMeansModel"),

[GitHub] spark pull request #14447: [SPARK-16445][MLlib][SparkR] Multilayer Perceptro...

2016-08-13 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/14447#discussion_r74692228 --- Diff: R/pkg/R/mllib.R --- @@ -414,6 +421,94 @@ setMethod("predict", signature(object = "KMeansModel"),

[GitHub] spark issue #13950: [SPARK-15487] [Web UI] Spark Master UI to reverse proxy ...

2016-08-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13950 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #13950: [SPARK-15487] [Web UI] Spark Master UI to reverse proxy ...

2016-08-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13950 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63731/ Test PASSed. ---

[GitHub] spark issue #13950: [SPARK-15487] [Web UI] Spark Master UI to reverse proxy ...

2016-08-13 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13950 **[Test build #63731 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63731/consoleFull)** for PR 13950 at commit

[GitHub] spark issue #14625: [SPARK-17045] [SQL] Moving Auto_Joins from HiveCompatibi...

2016-08-13 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/14625 @gatorsmile the comment should apply not only to data, but also query (e.g. what case we are testing ...) --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] spark issue #14629: [WIP][SPARK-17046][SQL] prevent user using dataframe.sel...

2016-08-13 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/14629 Yes that's a good question. A 0-column DataFrame is valid, though that's a little different from being able to select 0 columns from a DataFrame. I don't have a database handy, but can you select no

[GitHub] spark issue #14559: [SPARK-16968]Add additional options in jdbc when creatin...

2016-08-13 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/14559 Oh... good point. I see the existing `truncate` option isn't documented either. Yes that should be done in `sql-programming-guide.md`. We can follow up on this one or make a new small issue for it.

[GitHub] spark issue #14607: [SPARK-16905] SQL DDL: MSCK REPAIR TABLE (follow-up)

2016-08-13 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/14607 @davies Can you create a new JIRA ticket for this change? It is a non-trivial follow-up. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark issue #14629: [WIP][SPARK-17046][SQL] prevent user using dataframe.sel...

2016-08-13 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/14629 Why do we want to enforce this? It is valid to have a DataFrame without any columns. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] spark issue #14559: [SPARK-16968]Add additional options in jdbc when creatin...

2016-08-13 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/14559 Are the options here documented anywhere? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14527: [SPARK-16938][SQL] `drop/dropDuplicate` should handle th...

2016-08-13 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14527 **[Test build #63734 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63734/consoleFull)** for PR 14527 at commit

[GitHub] spark issue #14583: [SPARK-16994][SQL] PushDownPredicate should not ignore l...

2016-08-13 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14583 **[Test build #63732 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63732/consoleFull)** for PR 14583 at commit

[GitHub] spark issue #14580: [SPARK-16991][SQL] Fix `EliminateOuterJoin` optimizer to...

2016-08-13 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14580 **[Test build #63733 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63733/consoleFull)** for PR 14580 at commit

[GitHub] spark issue #13950: [SPARK-15487] [Web UI] Spark Master UI to reverse proxy ...

2016-08-13 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13950 **[Test build #63731 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63731/consoleFull)** for PR 13950 at commit

[GitHub] spark issue #13950: [SPARK-15487] [Web UI] Spark Master UI to reverse proxy ...

2016-08-13 Thread gurvindersingh
Github user gurvindersingh commented on the issue: https://github.com/apache/spark/pull/13950 @vanzin addressed most of your comments. Wondering if the test for location header is really needed, as it is a very simple two if checks. Let me know if you feel strongly about that or any

[GitHub] spark pull request #13950: [SPARK-15487] [Web UI] Spark Master UI to reverse...

2016-08-13 Thread gurvindersingh
Github user gurvindersingh commented on a diff in the pull request: https://github.com/apache/spark/pull/13950#discussion_r74690638 --- Diff: core/src/main/scala/org/apache/spark/ui/JettyUtils.scala --- @@ -186,6 +188,67 @@ private[spark] object JettyUtils extends Logging {

[GitHub] spark issue #14625: [SPARK-17045] [SQL] Moving Auto_Joins from HiveCompatibi...

2016-08-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14625 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63730/ Test PASSed. ---

[GitHub] spark issue #14625: [SPARK-17045] [SQL] Moving Auto_Joins from HiveCompatibi...

2016-08-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14625 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14625: [SPARK-17045] [SQL] Moving Auto_Joins from HiveCompatibi...

2016-08-13 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14625 **[Test build #63730 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63730/consoleFull)** for PR 14625 at commit

[GitHub] spark pull request #14182: [SPARK-16444][SparkR]: Isotonic Regression wrappe...

2016-08-13 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/14182#discussion_r74689929 --- Diff: R/pkg/R/mllib.R --- @@ -299,6 +308,91 @@ setMethod("summary", signature(object = "NaiveBayesModel"), return(list(apriori =

[GitHub] spark pull request #14613: [SPARK-16883][SparkR]:SQL decimal type is not pro...

2016-08-13 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/14613#discussion_r74689825 --- Diff: R/pkg/R/DataFrame.R --- @@ -354,6 +354,24 @@ setMethod("colnames<-", dataFrame(sdf) })

[GitHub] spark issue #14522: [Spark-16508][SparkR] Split docs for arrange and orderBy...

2016-08-13 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/14522 Since this fixes some CRAN check warnings, let's merge this? @shivaram what do you think? --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark issue #14614: [SPARK-17027][ML] Avoid integer overflow in PolynomialEx...

2016-08-13 Thread zero323
Github user zero323 commented on the issue: https://github.com/apache/spark/pull/14614 @srowen By all means. Here you are. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14630: [SPARK-16966] [SQL] [CORE] App Name is a randomUUID even...

2016-08-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14630 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63727/ Test PASSed. ---

[GitHub] spark issue #14630: [SPARK-16966] [SQL] [CORE] App Name is a randomUUID even...

2016-08-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14630 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14630: [SPARK-16966] [SQL] [CORE] App Name is a randomUUID even...

2016-08-13 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14630 **[Test build #63727 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63727/consoleFull)** for PR 14630 at commit

[GitHub] spark issue #14614: [SPARK-17027][ML] Avoid integer overflow in PolynomialEx...

2016-08-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14614 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14614: [SPARK-17027][ML] Avoid integer overflow in PolynomialEx...

2016-08-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14614 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63729/ Test PASSed. ---

[GitHub] spark issue #14614: [SPARK-17027][ML] Avoid integer overflow in PolynomialEx...

2016-08-13 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14614 **[Test build #63729 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63729/consoleFull)** for PR 14614 at commit

[GitHub] spark issue #14625: [SPARK-17045] [SQL] Moving Auto_Joins from HiveCompatibi...

2016-08-13 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14625 **[Test build #63730 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63730/consoleFull)** for PR 14625 at commit

[GitHub] spark issue #14614: [SPARK-17027][ML] Avoid integer overflow in PolynomialEx...

2016-08-13 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14614 **[Test build #63729 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63729/consoleFull)** for PR 14614 at commit

[GitHub] spark issue #14614: [SPARK-17027][ML] Avoid integer overflow in PolynomialEx...

2016-08-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14614 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63728/ Test FAILed. ---

[GitHub] spark issue #14614: [SPARK-17027][ML] Avoid integer overflow in PolynomialEx...

2016-08-13 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14614 **[Test build #63728 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63728/consoleFull)** for PR 14614 at commit

[GitHub] spark issue #14614: [SPARK-17027][ML] Avoid integer overflow in PolynomialEx...

2016-08-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14614 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14614: [SPARK-17027][ML] Avoid integer overflow in PolynomialEx...

2016-08-13 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14614 **[Test build #63728 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63728/consoleFull)** for PR 14614 at commit

[GitHub] spark pull request #14557: [SPARK-16709][CORE] Kill the running task if stag...

2016-08-13 Thread jaceklaskowski
Github user jaceklaskowski commented on a diff in the pull request: https://github.com/apache/spark/pull/14557#discussion_r74688576 --- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala --- @@ -798,6 +798,19 @@ private[spark] class TaskSetManager(

[GitHub] spark pull request #14557: [SPARK-16709][CORE] Kill the running task if stag...

2016-08-13 Thread jaceklaskowski
Github user jaceklaskowski commented on a diff in the pull request: https://github.com/apache/spark/pull/14557#discussion_r74688557 --- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala --- @@ -798,6 +798,19 @@ private[spark] class TaskSetManager(

[GitHub] spark pull request #14557: [SPARK-16709][CORE] Kill the running task if stag...

2016-08-13 Thread jaceklaskowski
Github user jaceklaskowski commented on a diff in the pull request: https://github.com/apache/spark/pull/14557#discussion_r74688550 --- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala --- @@ -798,6 +798,19 @@ private[spark] class TaskSetManager(

  1   2   >