Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/18447
Which systems have such function calls? Could you give some examples?
---
-
To unsubscribe, e-mail:
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18666#discussion_r147546947
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala
---
@@ -201,6 +201,16 @@ private[hive] class HiveClientImpl(
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/18410
cc @zsxwing Could you check whether we should continue or close this PR?
---
-
To unsubscribe, e-mail:
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/18349
cc @zsxwing Could you check whether we should continue or close this PR?
---
-
To unsubscribe, e-mail:
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/18113
@setjet Are you still working on this PR?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/18014
What is the latest status of this PR?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/18194
@kiszk Could we close this PR?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/18542
We always need more test cases for these changes.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/17899#discussion_r147546887
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -610,6 +611,25 @@ object CollapseWindow extends
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/18139
cc @ueshin
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19592
**[Test build #83152 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83152/testReport)**
for PR 19592 at commit
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/17899
@ptkool Can you address the conflicts? We will review it.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/18423
I can see the issue, but adding all these APIs might not be worthy.
---
-
To unsubscribe, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19570
**[Test build #83151 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83151/testReport)**
for PR 19570 at commit
Github user holdenk commented on the issue:
https://github.com/apache/spark/pull/19359
We could switch this to an || so it can be either lsofs? Would you want to
do that or should I?
---
-
To unsubscribe, e-mail:
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/19592
A large part of the change is refactoring. IMHO, if possibly, it is better
to allow Python UDFs running with conditional expressions normally. Thanks.
---
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/14083
Close it? @hvanhovell
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/14180
ping @ueshin Should we continue this PR?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/11336
ping @olarayej
cc @felixcheung
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/16735
ping @sergey-rubtsov
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19592
**[Test build #83150 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83150/testReport)**
for PR 19592 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19594
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19594
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83146/
Test PASSed.
---
Github user xynny commented on the issue:
https://github.com/apache/spark/pull/19359
Looks like some of the snapshot builds are having lsof issues:
https://amplab.cs.berkeley.edu/jenkins/view/Spark%20Packaging/job/spark-branch-2.1-maven-snapshots/182/console
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19594
**[Test build #83146 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83146/testReport)**
for PR 19594 at commit
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/18106
R has `trunc` in master/2.3 as well
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/19469
sure, @zsxwing please beaware of
https://github.com/apache-spark-on-k8s/spark/pull/516 and
https://github.com/apache/spark/pull/19427
---
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/11956
@kiszk Is this still the issue? I knew you are working on the related part
now.
---
-
To unsubscribe, e-mail:
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/17176
@windpiger If you do not have a bandwidth to continue it, how about closing
it now?
---
-
To unsubscribe, e-mail:
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/16910
Should we just close it now?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/19589#discussion_r147545176
--- Diff: R/pkg/tests/run-all.R ---
@@ -38,6 +38,10 @@ sparkRFilesBefore <- list.files(path = sparkRDir,
all.files = TRUE)
sparkRTestMaster <-
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/19589#discussion_r147545114
--- Diff: R/pkg/inst/tests/testthat/test_basic.R ---
@@ -18,7 +18,11 @@
context("basic tests for CRAN")
test_that("create DataFrame from
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/19589#discussion_r147545247
--- Diff: R/pkg/vignettes/sparkr-vignettes.Rmd ---
@@ -36,6 +36,12 @@ opts_hooks$set(eval = function(options) {
}
options
})
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/19589#discussion_r147545213
--- Diff: R/pkg/tests/run-all.R ---
@@ -38,6 +38,10 @@ sparkRFilesBefore <- list.files(path = sparkRDir,
all.files = TRUE)
sparkRTestMaster <-
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/19589#discussion_r147545189
--- Diff: R/pkg/vignettes/sparkr-vignettes.Rmd ---
@@ -57,7 +63,7 @@ We use default settings in which it runs in local mode.
It auto downloads Spark
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/19589#discussion_r147545171
--- Diff: R/pkg/tests/run-all.R ---
@@ -38,6 +38,10 @@ sparkRFilesBefore <- list.files(path = sparkRDir,
all.files = TRUE)
sparkRTestMaster <-
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/17648
@ptkool Could you address the comments and we can review it? Thanks!
---
-
To unsubscribe, e-mail:
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/16812
Could you give some systems that have such a feature? Thanks!
---
-
To unsubscribe, e-mail:
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/17883
We might not want such a feature in the current stage of Spark SQL. When we
decide to continue it, maybe we can revisit it? Could you close this PR? Thanks!
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19567
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83145/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19567
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19567
**[Test build #83145 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83145/testReport)**
for PR 19567 at commit
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/17623
cc @ericl @cloud-fan Should we continue this PR?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/18018
@kisimple We are working on the Data Source API v2. Could you close this
PR? Thanks!
---
-
To unsubscribe, e-mail:
Github user LantaoJin commented on the issue:
https://github.com/apache/spark/pull/17953
Sure, please close it as you wish. I will reopen it when it is ready for up
to date.
Sent from Mail Master
On 10/28/2017 07:39, Xiao Li wrote: @LantaoJin Maybe close it now? You can
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/19589
it looked like maybe appveyor is running too long and timed out?
can you kick it off again?
---
-
To unsubscribe,
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19570#discussion_r147544853
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -1753,6 +1753,27 @@ class Dataset[T] private[sql](
*
* Also as
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/17631#discussion_r147544807
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala
---
@@ -119,7 +119,7 @@ object JdbcUtils extends
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/12904
@falaki Should we continue this PR?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19570#discussion_r147544758
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -1753,6 +1753,27 @@ class Dataset[T] private[sql](
*
* Also as
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19570#discussion_r147544733
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -1753,6 +1753,27 @@ class Dataset[T] private[sql](
*
* Also
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/19592
One question is this behavior isn't so much intuitive for end users without
knowledge of Python UDFs internals. I'm just not sure if making it as it is is
a best option, even with document for it.
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/19592
Yeah, it is also an option. It is relatively easy to incorporate the
conditional logic into Python UDFs.
---
-
To unsubscribe,
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/19592
Is this complexity worth it? Can we just document it as a behavior and
users need to be careful with it?
---
-
To unsubscribe,
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/19592
Seems it fails on python3.4, let me check it locally.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19570
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19570
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83143/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18828
**[Test build #83149 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83149/testReport)**
for PR 18828 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19570
**[Test build #83143 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83143/testReport)**
for PR 19570 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18828
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18828
**[Test build #83148 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83148/testReport)**
for PR 18828 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18828
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83148/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19592
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83141/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19592
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19592
**[Test build #83141 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83141/testReport)**
for PR 19592 at commit
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/18828#discussion_r147544081
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/SparkPlanSuite.scala ---
@@ -0,0 +1,36 @@
+/*
+ * Licensed to the Apache Software
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18828
**[Test build #83148 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83148/testReport)**
for PR 18828 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18828
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user wzhfy commented on a diff in the pull request:
https://github.com/apache/spark/pull/19531#discussion_r147544011
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/statsEstimation/JoinEstimation.scala
---
@@ -157,64 +154,100 @@ case class
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18828
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83147/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19592
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83140/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19592
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19592
**[Test build #83140 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83140/testReport)**
for PR 19592 at commit
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/19593
Does the problem not exist on master? Why isn't the PR against master?
---
-
To unsubscribe, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19559
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83138/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19559
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19559
**[Test build #83138 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83138/testReport)**
for PR 19559 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19591
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83137/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19591
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19591
**[Test build #83137 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83137/testReport)**
for PR 19591 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19593
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19593
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83142/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19593
**[Test build #83142 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83142/testReport)**
for PR 19593 at commit
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/19451
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19594
**[Test build #83146 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83146/testReport)**
for PR 19594 at commit
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19451
Thanks for your work!
Merged to master.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
GitHub user wzhfy opened a pull request:
https://github.com/apache/spark/pull/19594
[WIP] [SPARK-21984] Join estimation based on equi-height histogram
## What changes were proposed in this pull request?
This PR depends on other two PRs:
Github user yssharma commented on the issue:
https://github.com/apache/spark/pull/18029
@brkyvz Squashed multiple commits into one for better readability. Please
have a look when you get time. Thanks.
---
-
To
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18029
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18029
**[Test build #83144 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83144/testReport)**
for PR 18029 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18029
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83144/
Test PASSed.
---
Github user WeichenXu123 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19588#discussion_r147542224
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/VectorIndexer.scala ---
@@ -311,22 +342,39 @@ class VectorIndexerModel private[ml] (
Github user jmchung commented on a diff in the pull request:
https://github.com/apache/spark/pull/19567#discussion_r147542014
--- Diff:
external/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/PostgresIntegrationSuite.scala
---
@@ -134,11 +149,28 @@ class
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19567
**[Test build #83145 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83145/testReport)**
for PR 19567 at commit
Github user shaolinliu commented on the issue:
https://github.com/apache/spark/pull/17581
ok.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18029
**[Test build #83144 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83144/testReport)**
for PR 18029 at commit
Github user WeichenXu123 commented on the issue:
https://github.com/apache/spark/pull/19122
@jkbradley Sure I will!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19451
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19451
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83135/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19451
**[Test build #83135 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83135/testReport)**
for PR 19451 at commit
1 - 100 of 391 matches
Mail list logo
