[GitHub] spark pull request #19649: [SPARK-22405][SQL] Add more ExternalCatalogEvent

2017-11-05 Thread jerryshao
Github user jerryshao commented on a diff in the pull request: https://github.com/apache/spark/pull/19649#discussion_r149009631 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/catalog/ExternalCatalogEventSuite.scala --- @@ -104,6 +109,8 @@ class

[GitHub] spark issue #19662: [SPARK-22446][SQL][ML] Declare StringIndexerModel indexe...

2017-11-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19662 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83471/ Test PASSed. ---

[GitHub] spark issue #19662: [SPARK-22446][SQL][ML] Declare StringIndexerModel indexe...

2017-11-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19662 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19662: [SPARK-22446][SQL][ML] Declare StringIndexerModel indexe...

2017-11-05 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19662 **[Test build #83471 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83471/testReport)** for PR 19662 at commit

[GitHub] spark issue #18717: [SPARK-21510] [SQL] Add isMaterialized() and eager persi...

2017-11-05 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/18717 Time : ) --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #19602: [SPARK-22384][SQL] Refine partition pruning when attribu...

2017-11-05 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/19602 The direction is right, but we need to restrict it to Cast (string_typed_attr as integral types) and the operator types must be either equal or not equal ---

[GitHub] spark issue #19607: [WIP][SPARK-22395][SQL][PYTHON] Fix the behavior of time...

2017-11-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19607 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83472/ Test FAILed. ---

[GitHub] spark issue #19607: [WIP][SPARK-22395][SQL][PYTHON] Fix the behavior of time...

2017-11-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19607 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19607: [WIP][SPARK-22395][SQL][PYTHON] Fix the behavior of time...

2017-11-05 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19607 **[Test build #83472 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83472/testReport)** for PR 19607 at commit

[GitHub] spark issue #19607: [WIP][SPARK-22395][SQL][PYTHON] Fix the behavior of time...

2017-11-05 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19607 **[Test build #83474 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83474/testReport)** for PR 19607 at commit

[GitHub] spark pull request #19607: [WIP][SPARK-22395][SQL][PYTHON] Fix the behavior ...

2017-11-05 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/19607#discussion_r149005432 --- Diff: python/pyspark/sql/types.py --- @@ -1629,35 +1629,112 @@ def to_arrow_type(dt): return arrow_type -def

[GitHub] spark pull request #19607: [WIP][SPARK-22395][SQL][PYTHON] Fix the behavior ...

2017-11-05 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/19607#discussion_r149005429 --- Diff: python/pyspark/sql/types.py --- @@ -1629,35 +1629,112 @@ def to_arrow_type(dt): return arrow_type -def

[GitHub] spark issue #18801: SPARK-10878 Fix race condition when multiple clients res...

2017-11-05 Thread kiszk
Github user kiszk commented on the issue: https://github.com/apache/spark/pull/18801 gentle ping @Victsm --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #19649: [SPARK-22405][SQL] Add more ExternalCatalogEvent

2017-11-05 Thread jerryshao
Github user jerryshao commented on a diff in the pull request: https://github.com/apache/spark/pull/19649#discussion_r149004933 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/ExternalCatalog.scala --- @@ -158,7 +173,13 @@ abstract class

[GitHub] spark issue #19607: [WIP][SPARK-22395][SQL][PYTHON] Fix the behavior of time...

2017-11-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19607 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19607: [WIP][SPARK-22395][SQL][PYTHON] Fix the behavior of time...

2017-11-05 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19607 **[Test build #83473 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83473/testReport)** for PR 19607 at commit

[GitHub] spark issue #19607: [WIP][SPARK-22395][SQL][PYTHON] Fix the behavior of time...

2017-11-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19607 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83473/ Test FAILed. ---

[GitHub] spark issue #19607: [WIP][SPARK-22395][SQL][PYTHON] Fix the behavior of time...

2017-11-05 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19607 **[Test build #83473 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83473/testReport)** for PR 19607 at commit

[GitHub] spark pull request #19649: [SPARK-22405][SQL] Add more ExternalCatalogEvent

2017-11-05 Thread jerryshao
Github user jerryshao commented on a diff in the pull request: https://github.com/apache/spark/pull/19649#discussion_r149003803 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/ExternalCatalog.scala --- @@ -147,7 +154,15 @@ abstract class

[GitHub] spark pull request #19607: [WIP][SPARK-22395][SQL][PYTHON] Fix the behavior ...

2017-11-05 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/19607#discussion_r149002542 --- Diff: python/pyspark/sql/types.py --- @@ -1629,35 +1629,112 @@ def to_arrow_type(dt): return arrow_type -def

[GitHub] spark pull request #19607: [WIP][SPARK-22395][SQL][PYTHON] Fix the behavior ...

2017-11-05 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/19607#discussion_r149001569 --- Diff: python/pyspark/sql/types.py --- @@ -1629,35 +1629,112 @@ def to_arrow_type(dt): return arrow_type -def

[GitHub] spark issue #19663: [SPARK-21888][Hive]add hadoop/hive/hdfs configuration fi...

2017-11-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19663 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19272: [Spark-21842][Mesos] Support Kerberos ticket renewal and...

2017-11-05 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19272 **[Test build #83468 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83468/testReport)** for PR 19272 at commit

[GitHub] spark pull request #19663: [SPARK-21888][Hive]add hadoop/hive/hdfs configura...

2017-11-05 Thread yaooqinn
GitHub user yaooqinn opened a pull request: https://github.com/apache/spark/pull/19663 [SPARK-21888][Hive]add hadoop/hive/hdfs configuration files in SPARK_CONF_DIR to distribute archive ## What changes were proposed in this pull request? When I ran self contained sql apps,

[GitHub] spark issue #19272: [Spark-21842][Mesos] Support Kerberos ticket renewal and...

2017-11-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19272 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19272: [Spark-21842][Mesos] Support Kerberos ticket renewal and...

2017-11-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19272 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83468/ Test PASSed. ---

[GitHub] spark pull request #18699: [SPARK-7146][ML] Expose the common params as a De...

2017-11-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/18699 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #18717: [SPARK-21510] [SQL] Add isMaterialized() and eager persi...

2017-11-05 Thread kiszk
Github user kiszk commented on the issue: https://github.com/apache/spark/pull/18717 @gatorsmile what will we need to go forward? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #18699: [SPARK-7146][ML] Expose the common params as a Developer...

2017-11-05 Thread holdenk
Github user holdenk commented on the issue: https://github.com/apache/spark/pull/18699 Merged into master --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #19607: [WIP][SPARK-22395][SQL][PYTHON] Fix the behavior of time...

2017-11-05 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19607 **[Test build #83472 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83472/testReport)** for PR 19607 at commit

[GitHub] spark issue #18118: [SPARK-20199][ML] : Provided featureSubsetStrategy to GB...

2017-11-05 Thread pralabhkumar
Github user pralabhkumar commented on the issue: https://github.com/apache/spark/pull/18118 @MLnick @jkbradley Please find some time to review it . @sethah has given LGTM --- - To unsubscribe, e-mail:

[GitHub] spark issue #19662: [SPARK-22446] Declare StringIndexerModel indexer udf as ...

2017-11-05 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19662 **[Test build #83471 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83471/testReport)** for PR 19662 at commit

[GitHub] spark issue #19662: [SPARK-22446] Declare StringIndexerModel indexer udf as ...

2017-11-05 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/19662 We may have other udfs in other ml models that have the same issue. If this approach is ok for the reviewers, we can make those udfs as non-deterministic then. ---

[GitHub] spark pull request #19662: [SPARK-22446] Declare StringIndexerModel indexer ...

2017-11-05 Thread viirya
GitHub user viirya opened a pull request: https://github.com/apache/spark/pull/19662 [SPARK-22446] Declare StringIndexerModel indexer udf as nondeterministic ## What changes were proposed in this pull request? UDFs that can cause runtime exception on invalid data are not

[GitHub] spark issue #18699: [SPARK-7146][ML] Expose the common params as a Developer...

2017-11-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18699 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83470/ Test PASSed. ---

[GitHub] spark issue #18699: [SPARK-7146][ML] Expose the common params as a Developer...

2017-11-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18699 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #18699: [SPARK-7146][ML] Expose the common params as a Developer...

2017-11-05 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18699 **[Test build #83470 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83470/testReport)** for PR 18699 at commit

[GitHub] spark issue #19208: [SPARK-21087] [ML] CrossValidator, TrainValidationSplit ...

2017-11-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19208 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19208: [SPARK-21087] [ML] CrossValidator, TrainValidationSplit ...

2017-11-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19208 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83469/ Test PASSed. ---

[GitHub] spark issue #19208: [SPARK-21087] [ML] CrossValidator, TrainValidationSplit ...

2017-11-05 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19208 **[Test build #83469 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83469/testReport)** for PR 19208 at commit

[GitHub] spark pull request #18833: [SPARK-21625][DOC] Add incompatible Hive UDF desc...

2017-11-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/18833 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #18833: [SPARK-21625][DOC] Add incompatible Hive UDF describe to...

2017-11-05 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/18833 Thanks! Merged to master. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #19661: [SPARK-22450][Core][Mllib]safely register class for mlli...

2017-11-05 Thread ConeyLiu
Github user ConeyLiu commented on the issue: https://github.com/apache/spark/pull/19661 >So why don't you include some classes such as org.apache.spark.ml.feature.Instance ? I'm not family with those algorithm, I can add them such as `org.apache.spark.ml.feature.Instance` .

[GitHub] spark issue #18699: [SPARK-7146][ML] Expose the common params as a Developer...

2017-11-05 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18699 **[Test build #83470 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83470/testReport)** for PR 18699 at commit

[GitHub] spark issue #19661: [SPARK-22450][Core][Mllib]safely register class for mlli...

2017-11-05 Thread WeichenXu123
Github user WeichenXu123 commented on the issue: https://github.com/apache/spark/pull/19661 And I don't know whether these class dependency injection into spark-core lib is reasonable ... --- - To unsubscribe,

[GitHub] spark issue #19661: [SPARK-22450][Core][Mllib]safely register class for mlli...

2017-11-05 Thread WeichenXu123
Github user WeichenXu123 commented on the issue: https://github.com/apache/spark/pull/19661 So why do you include the class such as `org.apache.spark.ml.feature.Instance`. You can look into a lot of algos, in `ml` package (not `mllib`), still use something like `RDD[Instance]`

[GitHub] spark issue #18699: [SPARK-7146][ML] Expose the common params as a Developer...

2017-11-05 Thread holdenk
Github user holdenk commented on the issue: https://github.com/apache/spark/pull/18699 Jenkins retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #19208: [SPARK-21087] [ML] CrossValidator, TrainValidationSplit ...

2017-11-05 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19208 **[Test build #83469 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83469/testReport)** for PR 19208 at commit

[GitHub] spark issue #19586: [SPARK-22367][WIP][CORE] Separate the serialization of c...

2017-11-05 Thread ConeyLiu
Github user ConeyLiu commented on the issue: https://github.com/apache/spark/pull/19586 Thanks for the suggestion, I re-raised a pr to solve this problem. Close it now. --- - To unsubscribe, e-mail:

[GitHub] spark pull request #19586: [SPARK-22367][WIP][CORE] Separate the serializati...

2017-11-05 Thread ConeyLiu
Github user ConeyLiu closed the pull request at: https://github.com/apache/spark/pull/19586 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #19661: [SPARK-22450][Core][Mllib]safely register class for mlli...

2017-11-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19661 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19661: [SPARK-22450][Core][Mllib]safely register class for mlli...

2017-11-05 Thread ConeyLiu
Github user ConeyLiu commented on the issue: https://github.com/apache/spark/pull/19661 #19586 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #19661: [SPARK-22450][Core][Mllib]safely register class f...

2017-11-05 Thread ConeyLiu
GitHub user ConeyLiu opened a pull request: https://github.com/apache/spark/pull/19661 [SPARK-22450][Core][Mllib]safely register class for mllib ## What changes were proposed in this pull request? There are still some algorithms based on mllib, such as KMeans. For now,

[GitHub] spark pull request #19643: [SPARK-11421][CORE][PYTHON][R] Added ability for ...

2017-11-05 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/19643#discussion_r148983980 --- Diff: R/pkg/R/context.R --- @@ -319,6 +319,27 @@ spark.addFile <- function(path, recursive = FALSE) { invisible(callJMethod(sc, "addFile",

[GitHub] spark pull request #19643: [SPARK-11421][CORE][PYTHON][R] Added ability for ...

2017-11-05 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/19643#discussion_r148983977 --- Diff: R/pkg/R/context.R --- @@ -319,6 +319,27 @@ spark.addFile <- function(path, recursive = FALSE) { invisible(callJMethod(sc, "addFile",

[GitHub] spark issue #19624: [SPARKR][SPARK-22315] Warn if SparkR package version doe...

2017-11-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19624 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83467/ Test PASSed. ---

[GitHub] spark issue #19624: [SPARKR][SPARK-22315] Warn if SparkR package version doe...

2017-11-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19624 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19624: [SPARKR][SPARK-22315] Warn if SparkR package version doe...

2017-11-05 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19624 **[Test build #83467 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83467/testReport)** for PR 19624 at commit

[GitHub] spark pull request #19272: [Spark-21842][Mesos] Support Kerberos ticket rene...

2017-11-05 Thread ArtRand
Github user ArtRand commented on a diff in the pull request: https://github.com/apache/spark/pull/19272#discussion_r148982457 --- Diff: resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosCoarseGrainedSchedulerBackend.scala --- @@ -58,8 +62,9 @@

[GitHub] spark pull request #19272: [Spark-21842][Mesos] Support Kerberos ticket rene...

2017-11-05 Thread ArtRand
Github user ArtRand commented on a diff in the pull request: https://github.com/apache/spark/pull/19272#discussion_r148982255 --- Diff: core/src/main/scala/org/apache/spark/scheduler/cluster/CoarseGrainedSchedulerBackend.scala --- @@ -686,18 +687,7 @@ class

[GitHub] spark pull request #19272: [Spark-21842][Mesos] Support Kerberos ticket rene...

2017-11-05 Thread ArtRand
Github user ArtRand commented on a diff in the pull request: https://github.com/apache/spark/pull/19272#discussion_r148982165 --- Diff: core/src/main/scala/org/apache/spark/scheduler/cluster/CoarseGrainedSchedulerBackend.scala --- @@ -99,11 +96,8 @@ class

[GitHub] spark issue #19272: [Spark-21842][Mesos] Support Kerberos ticket renewal and...

2017-11-05 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19272 **[Test build #83468 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83468/testReport)** for PR 19272 at commit

[GitHub] spark issue #19624: [SPARKR][SPARK-22315] Warn if SparkR package version doe...

2017-11-05 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19624 **[Test build #83467 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83467/testReport)** for PR 19624 at commit

[GitHub] spark pull request #19657: [SPARK-22344][SPARKR] clean up install dir if run...

2017-11-05 Thread shivaram
Github user shivaram commented on a diff in the pull request: https://github.com/apache/spark/pull/19657#discussion_r148979368 --- Diff: R/pkg/R/install.R --- @@ -152,6 +152,9 @@ install.spark <- function(hadoopVersion = "2.7", mirrorUrl = NULL, })

[GitHub] spark pull request #19657: [SPARK-22344][SPARKR] clean up install dir if run...

2017-11-05 Thread shivaram
Github user shivaram commented on a diff in the pull request: https://github.com/apache/spark/pull/19657#discussion_r148979827 --- Diff: R/pkg/vignettes/sparkr-vignettes.Rmd --- @@ -1183,3 +1183,24 @@ env | map ```{r, echo=FALSE} sparkR.session.stop() ``` +

[GitHub] spark pull request #19657: [SPARK-22344][SPARKR] clean up install dir if run...

2017-11-05 Thread shivaram
Github user shivaram commented on a diff in the pull request: https://github.com/apache/spark/pull/19657#discussion_r148979924 --- Diff: R/pkg/tests/run-all.R --- @@ -60,3 +60,22 @@ if (identical(Sys.getenv("NOT_CRAN"), "true")) { NULL,

[GitHub] spark issue #19601: [SPARK-22383][SQL] Generate code to directly get value o...

2017-11-05 Thread kiszk
Github user kiszk commented on the issue: https://github.com/apache/spark/pull/19601 @cloud-fan could you please review this again since this version avoids to override `ColumnVector.getArray` as you suggested? cc @ueshin ---

[GitHub] spark issue #18833: [SPARK-21625][DOC] Add incompatible Hive UDF describe to...

2017-11-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18833 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #18833: [SPARK-21625][DOC] Add incompatible Hive UDF describe to...

2017-11-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18833 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83466/ Test PASSed. ---

[GitHub] spark issue #18833: [SPARK-21625][DOC] Add incompatible Hive UDF describe to...

2017-11-05 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18833 **[Test build #83466 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83466/testReport)** for PR 18833 at commit

[GitHub] spark issue #18833: [SPARK-21625][DOC] Add incompatible Hive UDF describe to...

2017-11-05 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18833 **[Test build #83466 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83466/testReport)** for PR 18833 at commit

[GitHub] spark issue #19660: [SPARK-18755][WIP][ML] Add Randomized Grid Search to Spa...

2017-11-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19660 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #19660: [SPARK-18755][WIP][ML] Add Randomized Grid Search...

2017-11-05 Thread tengpeng
GitHub user tengpeng opened a pull request: https://github.com/apache/spark/pull/19660 [SPARK-18755][WIP][ML] Add Randomized Grid Search to Spark ML ## What changes were proposed in this pull request? Python sklearn has a randomized grid search for reducing the time for

[GitHub] spark issue #19601: [SPARK-22383][SQL] Generate code to directly get value o...

2017-11-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19601 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19601: [SPARK-22383][SQL] Generate code to directly get value o...

2017-11-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19601 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83465/ Test PASSed. ---

[GitHub] spark issue #19601: [SPARK-22383][SQL] Generate code to directly get value o...

2017-11-05 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19601 **[Test build #83465 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83465/testReport)** for PR 19601 at commit

[GitHub] spark issue #19657: [SPARK-22344][SPARKR] clean up install dir if running te...

2017-11-05 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/19657 @shivaram could you take a look? I think this would do it --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

[GitHub] spark pull request #17673: [SPARK-20372] [ML] Word2Vec Continuous Bag of Wor...

2017-11-05 Thread hhbyyh
Github user hhbyyh commented on a diff in the pull request: https://github.com/apache/spark/pull/17673#discussion_r148968172 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/Word2Vec.scala --- @@ -105,6 +106,56 @@ private[feature] trait Word2VecBase extends Params

[GitHub] spark pull request #17673: [SPARK-20372] [ML] Word2Vec Continuous Bag of Wor...

2017-11-05 Thread hhbyyh
Github user hhbyyh commented on a diff in the pull request: https://github.com/apache/spark/pull/17673#discussion_r148968255 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/Word2Vec.scala --- @@ -105,6 +106,56 @@ private[feature] trait Word2VecBase extends Params

[GitHub] spark pull request #17673: [SPARK-20372] [ML] Word2Vec Continuous Bag of Wor...

2017-11-05 Thread hhbyyh
Github user hhbyyh commented on a diff in the pull request: https://github.com/apache/spark/pull/17673#discussion_r148967559 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/Word2Vec.scala --- @@ -105,6 +106,56 @@ private[feature] trait Word2VecBase extends Params

[GitHub] spark pull request #17673: [SPARK-20372] [ML] Word2Vec Continuous Bag of Wor...

2017-11-05 Thread hhbyyh
Github user hhbyyh commented on a diff in the pull request: https://github.com/apache/spark/pull/17673#discussion_r148967956 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/Word2Vec.scala --- @@ -105,6 +106,56 @@ private[feature] trait Word2VecBase extends Params

[GitHub] spark pull request #17673: [SPARK-20372] [ML] Word2Vec Continuous Bag of Wor...

2017-11-05 Thread hhbyyh
Github user hhbyyh commented on a diff in the pull request: https://github.com/apache/spark/pull/17673#discussion_r148967766 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/Word2Vec.scala --- @@ -105,6 +106,56 @@ private[feature] trait Word2VecBase extends Params

[GitHub] spark pull request #17673: [SPARK-20372] [ML] Word2Vec Continuous Bag of Wor...

2017-11-05 Thread hhbyyh
Github user hhbyyh commented on a diff in the pull request: https://github.com/apache/spark/pull/17673#discussion_r148967853 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/Word2Vec.scala --- @@ -105,6 +106,56 @@ private[feature] trait Word2VecBase extends Params

[GitHub] spark pull request #17673: [SPARK-20372] [ML] Word2Vec Continuous Bag of Wor...

2017-11-05 Thread hhbyyh
Github user hhbyyh commented on a diff in the pull request: https://github.com/apache/spark/pull/17673#discussion_r148966706 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/Word2Vec.scala --- @@ -105,6 +106,56 @@ private[feature] trait Word2VecBase extends Params

[GitHub] spark pull request #17673: [SPARK-20372] [ML] Word2Vec Continuous Bag of Wor...

2017-11-05 Thread hhbyyh
Github user hhbyyh commented on a diff in the pull request: https://github.com/apache/spark/pull/17673#discussion_r148968530 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/impl/Word2VecCBOWSolver.scala --- @@ -0,0 +1,371 @@ +/* + * Licensed to the Apache

[GitHub] spark issue #19635: [SPARK-22413][SQL] Type coercion for IN is not coherent ...

2017-11-05 Thread mgaido91
Github user mgaido91 commented on the issue: https://github.com/apache/spark/pull/19635 Oracle behaves like Spark after the patch: ``` select 'a' from dual where 1 in ('01'); // returns 'a' select 'a' from dual where 1 in (select '01' from dual); // returns 'a'

[GitHub] spark issue #19635: [SPARK-22413][SQL] Type coercion for IN is not coherent ...

2017-11-05 Thread mgaido91
Github user mgaido91 commented on the issue: https://github.com/apache/spark/pull/19635 yes, of course. Which ones should I try? Hive and Oracle? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

[GitHub] spark issue #19635: [SPARK-22413][SQL] Type coercion for IN is not coherent ...

2017-11-05 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/19635 Since we are trying to introduce a new behavior, could you try the other systems and see how they behave in this scenario? ---

[GitHub] spark pull request #18833: [SPARK-21625][DOC] Add incompatible Hive UDF desc...

2017-11-05 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/18833#discussion_r148965438 --- Diff: docs/sql-programming-guide.md --- @@ -1957,6 +1957,14 @@ Not all the APIs of the Hive UDF/UDTF/UDAF are supported by Spark SQL. Below are

[GitHub] spark issue #19433: [SPARK-3162] [MLlib] Add local tree training for decisio...

2017-11-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19433 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19433: [SPARK-3162] [MLlib] Add local tree training for decisio...

2017-11-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19433 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83464/ Test FAILed. ---

[GitHub] spark issue #19433: [SPARK-3162] [MLlib] Add local tree training for decisio...

2017-11-05 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19433 **[Test build #83464 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83464/testReport)** for PR 19433 at commit

[GitHub] spark issue #19601: [SPARK-22383][SQL] Generate code to directly get value o...

2017-11-05 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19601 **[Test build #83465 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83465/testReport)** for PR 19601 at commit

[GitHub] spark issue #19601: [SPARK-22383][SQL] Generate code to directly get value o...

2017-11-05 Thread kiszk
Github user kiszk commented on the issue: https://github.com/apache/spark/pull/19601 Jenkins, retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #19656: [SPARK-22445][SQL] move CodegenContext.copyResult to Cod...

2017-11-05 Thread kiszk
Github user kiszk commented on the issue: https://github.com/apache/spark/pull/19656 I will look at this on Monday. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #19433: [SPARK-3162] [MLlib] Add local tree training for decisio...

2017-11-05 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19433 **[Test build #83464 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83464/testReport)** for PR 19433 at commit

[GitHub] spark issue #19433: [SPARK-3162] [MLlib] Add local tree training for decisio...

2017-11-05 Thread JoshRosen
Github user JoshRosen commented on the issue: https://github.com/apache/spark/pull/19433 jenkins retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #19601: [SPARK-22383][SQL] Generate code to directly get value o...

2017-11-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19601 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19601: [SPARK-22383][SQL] Generate code to directly get value o...

2017-11-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19601 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83463/ Test FAILed. ---

[GitHub] spark issue #19656: [SPARK-22445][SQL] move CodegenContext.copyResult to Cod...

2017-11-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19656 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

  1   2   >