[GitHub] spark pull request #20462: [SPARK-23020][core] Fix another race in the in-pr...

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/20462#discussion_r165248266 --- Diff: launcher/src/main/java/org/apache/spark/launcher/InProcessAppHandle.java --- @@ -66,7 +66,7 @@ synchronized void start(String appName, Method

[GitHub] spark pull request #20462: [SPARK-23020][core] Fix another race in the in-pr...

Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/20462#discussion_r165248236 --- Diff: launcher/src/main/java/org/apache/spark/launcher/LauncherServer.java --- @@ -363,17 +362,28 @@ public void close() throws IOException {

[GitHub] spark pull request #20462: [SPARK-23020][core] Fix another race in the in-pr...

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/20462#discussion_r165247921 --- Diff: launcher/src/main/java/org/apache/spark/launcher/LauncherServer.java --- @@ -363,17 +362,28 @@ public void close() throws IOException {

[GitHub] spark pull request #20437: [SPARK-23270][Streaming][WEB-UI]FileInputDStream ...

Github user guoxiaolongzte commented on a diff in the pull request: https://github.com/apache/spark/pull/20437#discussion_r165247567 --- Diff: streaming/src/main/scala/org/apache/spark/streaming/dstream/FileInputDStream.scala --- @@ -157,7 +157,7 @@ class FileInputDStream[K, V, F

[GitHub] spark issue #20459: [SPARK-23107][ML] ML 2.3 QA: New Scala APIs, docs.

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20459 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86903/ Test PASSed. ---

[GitHub] spark issue #20459: [SPARK-23107][ML] ML 2.3 QA: New Scala APIs, docs.

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20459 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20459: [SPARK-23107][ML] ML 2.3 QA: New Scala APIs, docs.

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20459 **[Test build #86903 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86903/testReport)** for PR 20459 at commit

[GitHub] spark issue #20455: [SPARK-23284][SQL] Document the behavior of several Colu...

Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/20455 LGTM so far, one thing I wanna add is to also document the behavior of accessing null primitive values, e.g. `getInt`. We can say that the return value is undefined and can be anything, if that

[GitHub] spark issue #20462: [SPARK-23020][core] Fix another race in the in-process l...

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20462 **[Test build #86904 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86904/testReport)** for PR 20462 at commit

[GitHub] spark issue #20462: [SPARK-23020][core] Fix another race in the in-process l...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20462 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20462: [SPARK-23020][core] Fix another race in the in-process l...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20462 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/455/

[GitHub] spark issue #20461: [SPARK-23289][CORE]OneForOneBlockFetcher.DownloadCallbac...

Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/20461 LGTM, also cc @jinxing64 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #20461: [SPARK-23289][CORE]OneForOneBlockFetcher.Download...

Github user ConeyLiu commented on a diff in the pull request: https://github.com/apache/spark/pull/20461#discussion_r165246022 --- Diff: common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/OneForOneBlockFetcher.java --- @@ -171,7 +171,9 @@ private void

[GitHub] spark pull request #20462: [SPARK-23020][core] Fix another race in the in-pr...

Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/20462#discussion_r165245941 --- Diff: launcher/src/main/java/org/apache/spark/launcher/ChildProcAppHandle.java --- @@ -112,7 +112,7 @@ void monitorChild() { } }

[GitHub] spark pull request #20462: [SPARK-23020][core] Fix another race in the in-pr...

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/20462#discussion_r165245861 --- Diff: launcher/src/main/java/org/apache/spark/launcher/ChildProcAppHandle.java --- @@ -112,7 +112,7 @@ void monitorChild() { }

[GitHub] spark pull request #20454: [SPARK-23202][SQL] Add new API in DataSourceWrite...

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/20454#discussion_r165245483 --- Diff: sql/core/src/main/java/org/apache/spark/sql/sources/v2/writer/DataSourceWriter.java --- @@ -62,6 +62,15 @@ */ DataWriterFactory

[GitHub] spark pull request #20462: [SPARK-23020][core] Fix another race in the in-pr...

Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/20462#discussion_r165245465 --- Diff: launcher/src/main/java/org/apache/spark/launcher/ChildProcAppHandle.java --- @@ -112,7 +112,7 @@ void monitorChild() { } }

[GitHub] spark pull request #20462: [SPARK-23020][core] Fix another race in the in-pr...

Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/20462#discussion_r165245388 --- Diff: launcher/src/main/java/org/apache/spark/launcher/AbstractAppHandle.java --- @@ -42,9 +42,9 @@ protected AbstractAppHandle(LauncherServer server) {

[GitHub] spark pull request #20450: [SPARK-23280][SQL] add map type support to Column...

Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/20450#discussion_r165245334 --- Diff: sql/core/src/main/java/org/apache/spark/sql/vectorized/ColumnVector.java --- @@ -215,10 +215,18 @@ public final ColumnarRow getStruct(int rowId) {

[GitHub] spark issue #20461: [SPARK-23289][CORE]OneForOneBlockFetcher.DownloadCallbac...

Github user squito commented on the issue: https://github.com/apache/spark/pull/20461 lgtm --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #20443: [SPARK-23157][SQL][FOLLOW-UP] DataFrame -> SparkD...

Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/20443 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #20462: [SPARK-23020][core] Fix another race in the in-pr...

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/20462#discussion_r165244212 --- Diff: launcher/src/main/java/org/apache/spark/launcher/ChildProcAppHandle.java --- @@ -112,7 +112,7 @@ void monitorChild() { }

[GitHub] spark issue #20443: [SPARK-23157][SQL][FOLLOW-UP] DataFrame -> SparkDataFram...

Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/20443 Merged to master and branch-2.3. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark pull request #20462: [SPARK-23020][core] Fix another race in the in-pr...

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/20462#discussion_r165243779 --- Diff: launcher/src/main/java/org/apache/spark/launcher/AbstractAppHandle.java --- @@ -42,9 +42,9 @@ protected AbstractAppHandle(LauncherServer

[GitHub] spark issue #20443: [SPARK-23157][SQL][FOLLOW-UP] DataFrame -> SparkDataFram...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20443 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20443: [SPARK-23157][SQL][FOLLOW-UP] DataFrame -> SparkDataFram...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20443 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86900/ Test PASSed. ---

[GitHub] spark issue #20361: [SPARK-23188][SQL] Make vectorized columar reader batch ...

Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/20361 LGTM, pending jenkins --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #20443: [SPARK-23157][SQL][FOLLOW-UP] DataFrame -> SparkDataFram...

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20443 **[Test build #86900 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86900/testReport)** for PR 20443 at commit

[GitHub] spark pull request #20361: [SPARK-23188][SQL] Make vectorized columar reader...

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/20361#discussion_r165242969 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetEncodingSuite.scala --- @@ -40,7 +40,9 @@ class

[GitHub] spark pull request #20450: [SPARK-23280][SQL] add map type support to Column...

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/20450#discussion_r165242689 --- Diff: sql/core/src/main/java/org/apache/spark/sql/vectorized/ColumnVector.java --- @@ -215,10 +215,18 @@ public final ColumnarRow getStruct(int

[GitHub] spark pull request #20450: [SPARK-23280][SQL] add map type support to Column...

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/20450#discussion_r165242471 --- Diff: sql/core/src/main/java/org/apache/spark/sql/vectorized/ColumnVector.java --- @@ -215,10 +215,18 @@ public final ColumnarRow getStruct(int

[GitHub] spark pull request #20450: [SPARK-23280][SQL] add map type support to Column...

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/20450#discussion_r165242508 --- Diff: sql/core/src/main/java/org/apache/spark/sql/vectorized/ColumnarMap.java --- @@ -0,0 +1,53 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request #20450: [SPARK-23280][SQL] add map type support to Column...

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/20450#discussion_r165242401 --- Diff: sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/OffHeapColumnVector.java --- @@ -530,7 +530,7 @@ public int putByteArray(int

[GitHub] spark issue #20455: [SPARK-23284][SQL] Document the behavior of several Colu...

Github user ueshin commented on the issue: https://github.com/apache/spark/pull/20455 LGTM so far. Let's wait for map type support. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20462: [SPARK-23020][core] Fix another race in the in-process l...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20462 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86893/ Test PASSed. ---

[GitHub] spark issue #20462: [SPARK-23020][core] Fix another race in the in-process l...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20462 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20462: [SPARK-23020][core] Fix another race in the in-process l...

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20462 **[Test build #86893 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86893/testReport)** for PR 20462 at commit

[GitHub] spark issue #20461: [SPARK-23289][CORE]OneForOneBlockFetcher.DownloadCallbac...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20461 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86892/ Test PASSed. ---

[GitHub] spark issue #20461: [SPARK-23289][CORE]OneForOneBlockFetcher.DownloadCallbac...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20461 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20455: [SPARK-23284][SQL] Document the behavior of several Colu...

Github user viirya commented on the issue: https://github.com/apache/spark/pull/20455 cc @cloud-fan @ueshin @kiszk --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #20461: [SPARK-23289][CORE]OneForOneBlockFetcher.DownloadCallbac...

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20461 **[Test build #86892 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86892/testReport)** for PR 20461 at commit

[GitHub] spark pull request #20437: [SPARK-23270][Streaming][WEB-UI]FileInputDStream ...

Github user jerryshao commented on a diff in the pull request: https://github.com/apache/spark/pull/20437#discussion_r165240426 --- Diff: streaming/src/main/scala/org/apache/spark/streaming/dstream/FileInputDStream.scala --- @@ -157,7 +157,7 @@ class FileInputDStream[K, V, F <:

[GitHub] spark issue #20459: [SPARK-23107][ML] ML 2.3 QA: New Scala APIs, docs.

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20459 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/454/

[GitHub] spark issue #20459: [SPARK-23107][ML] ML 2.3 QA: New Scala APIs, docs.

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20459 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #20437: [SPARK-23270][Streaming][WEB-UI]FileInputDStream ...

Github user guoxiaolongzte commented on a diff in the pull request: https://github.com/apache/spark/pull/20437#discussion_r165239860 --- Diff: streaming/src/main/scala/org/apache/spark/streaming/dstream/FileInputDStream.scala --- @@ -157,7 +157,7 @@ class FileInputDStream[K, V, F

[GitHub] spark pull request #20450: [SPARK-23280][SQL] add map type support to Column...

Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/20450#discussion_r165067849 --- Diff: sql/core/src/main/java/org/apache/spark/sql/vectorized/ColumnVector.java --- @@ -215,10 +215,18 @@ public final ColumnarRow getStruct(int rowId) {

[GitHub] spark issue #20459: [SPARK-23107][ML] ML 2.3 QA: New Scala APIs, docs.

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20459 **[Test build #86903 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86903/testReport)** for PR 20459 at commit

[GitHub] spark issue #20463: [SQL][MINOR] Inline SpecifiedWindowFrame.defaultWindowFr...

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20463 **[Test build #86902 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86902/testReport)** for PR 20463 at commit

[GitHub] spark pull request #20459: [SPARK-23107][ML] ML 2.3 QA: New Scala APIs, docs...

Github user yanboliang commented on a diff in the pull request: https://github.com/apache/spark/pull/20459#discussion_r165239367 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/QuantileDiscretizer.scala --- @@ -93,7 +93,7 @@ private[feature] trait

[GitHub] spark issue #20463: [SQL][MINOR] Inline SpecifiedWindowFrame.defaultWindowFr...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20463 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/453/

[GitHub] spark issue #20463: [SQL][MINOR] Inline SpecifiedWindowFrame.defaultWindowFr...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20463 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #20463: [SQL][MINOR] Inline SpecifiedWindowFrame.defaultW...

GitHub user jiangxb1987 opened a pull request: https://github.com/apache/spark/pull/20463 [SQL][MINOR] Inline SpecifiedWindowFrame.defaultWindowFrame(). ## What changes were proposed in this pull request? SpecifiedWindowFrame.defaultWindowFrame(hasOrderSpecification,

[GitHub] spark issue #20361: [SPARK-23188][SQL] Make vectorized columar reader batch ...

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20361 **[Test build #86901 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86901/testReport)** for PR 20361 at commit

[GitHub] spark issue #20361: [SPARK-23188][SQL] Make vectorized columar reader batch ...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20361 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20361: [SPARK-23188][SQL] Make vectorized columar reader batch ...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20361 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/452/

[GitHub] spark issue #20383: [SPARK-23200] Reset Kubernetes-specific config on Checkp...

Github user jerryshao commented on the issue: https://github.com/apache/spark/pull/20383 @ssaavedra Do you mean the your current patch doesn't work even for master branch? In case of that do we need to revert the current patch? CC @felixcheung @foxish . ---

[GitHub] spark issue #20459: [SPARK-23107][ML] ML 2.3 QA: New Scala APIs, docs.

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20459 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86891/ Test PASSed. ---

[GitHub] spark issue #20459: [SPARK-23107][ML] ML 2.3 QA: New Scala APIs, docs.

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20459 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20459: [SPARK-23107][ML] ML 2.3 QA: New Scala APIs, docs.

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20459 **[Test build #86891 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86891/testReport)** for PR 20459 at commit

[GitHub] spark pull request #20424: [Spark-23240][python] Better error message when e...

Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/20424#discussion_r165236983 --- Diff: core/src/main/scala/org/apache/spark/api/python/PythonWorkerFactory.scala --- @@ -191,7 +191,20 @@ private[spark] class

[GitHub] spark issue #20460: [SPARK-23285][K8S] Allow fractional values for spark.exe...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20460 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86890/ Test PASSed. ---

[GitHub] spark issue #20460: [SPARK-23285][K8S] Allow fractional values for spark.exe...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20460 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20460: [SPARK-23285][K8S] Allow fractional values for spark.exe...

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20460 **[Test build #86890 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86890/testReport)** for PR 20460 at commit

[GitHub] spark issue #20415: [SPARK-23247][SQL]combines Unsafe operations and statist...

Github user heary-cao commented on the issue: https://github.com/apache/spark/pull/20415 @mgaido91 thanks. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #20419: [SPARK-23032][SQL][FOLLOW-UP]Add codegenStageId in comme...

Github user rednaxelafx commented on the issue: https://github.com/apache/spark/pull/20419 I gave it a bit more thought. Here's an alternative proposal: instead of using a "force comment" mechanism in the current form (which still gets a `ctx.freshName("c")` that the caller has no

[GitHub] spark issue #20443: [SPARK-23157][SQL][FOLLOW-UP] DataFrame -> SparkDataFram...

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20443 **[Test build #86900 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86900/testReport)** for PR 20443 at commit

[GitHub] spark issue #20443: [SPARK-23157][SQL][FOLLOW-UP] DataFrame -> SparkDataFram...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20443 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20443: [SPARK-23157][SQL][FOLLOW-UP] DataFrame -> SparkDataFram...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20443 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/451/

[GitHub] spark issue #20400: [SPARK-23084][PYTHON]Add unboundedPreceding(), unbounded...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20400 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20400: [SPARK-23084][PYTHON]Add unboundedPreceding(), unbounded...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20400 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86897/ Test PASSed. ---

[GitHub] spark issue #20400: [SPARK-23084][PYTHON]Add unboundedPreceding(), unbounded...

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20400 **[Test build #86897 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86897/testReport)** for PR 20400 at commit

[GitHub] spark pull request #20361: [SPARK-23188][SQL] Make vectorized columar reader...

Github user jiangxb1987 commented on a diff in the pull request: https://github.com/apache/spark/pull/20361#discussion_r165234841 --- Diff: sql/core/src/main/java/org/apache/spark/sql/execution/datasources/orc/OrcColumnarBatchReader.java --- @@ -49,8 +49,9 @@ * After

[GitHub] spark issue #20415: [SPARK-23247][SQL]combines Unsafe operations and statist...

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20415 **[Test build #86898 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86898/testReport)** for PR 20415 at commit

[GitHub] spark issue #17185: [SPARK-19602][SQL] Support column resolution of fully qu...

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17185 **[Test build #86899 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86899/testReport)** for PR 17185 at commit

[GitHub] spark issue #17185: [SPARK-19602][SQL] Support column resolution of fully qu...

Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/17185 ok to test --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #20433: [SPARK-23264][SQL] Support interval values withou...

Github user jiangxb1987 commented on a diff in the pull request: https://github.com/apache/spark/pull/20433#discussion_r165233944 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/ExpressionParserSuite.scala --- @@ -561,8 +561,11 @@ class

[GitHub] spark issue #20450: [SPARK-23280][SQL] add map type support to ColumnVector

Github user jiangxb1987 commented on the issue: https://github.com/apache/spark/pull/20450 LGTM only some nits and naming issues. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #20450: [SPARK-23280][SQL] add map type support to Column...

Github user jiangxb1987 commented on a diff in the pull request: https://github.com/apache/spark/pull/20450#discussion_r165231647 --- Diff: sql/core/src/main/java/org/apache/spark/sql/vectorized/ColumnarMap.java --- @@ -0,0 +1,53 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request #20450: [SPARK-23280][SQL] add map type support to Column...

Github user jiangxb1987 commented on a diff in the pull request: https://github.com/apache/spark/pull/20450#discussion_r165231132 --- Diff: sql/core/src/main/java/org/apache/spark/sql/vectorized/ColumnVector.java --- @@ -215,10 +215,18 @@ public final ColumnarRow getStruct(int

[GitHub] spark pull request #20450: [SPARK-23280][SQL] add map type support to Column...

Github user jiangxb1987 commented on a diff in the pull request: https://github.com/apache/spark/pull/20450#discussion_r165230542 --- Diff: sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/OffHeapColumnVector.java --- @@ -530,7 +530,7 @@ public int

[GitHub] spark pull request #17185: [SPARK-19602][SQL] Support column resolution of f...

Github user skambha commented on a diff in the pull request: https://github.com/apache/spark/pull/17185#discussion_r165230391 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/unresolved.scala --- @@ -88,12 +88,12 @@ case class

[GitHub] spark issue #20400: [SPARK-23084][PYTHON]Add unboundedPreceding(), unbounded...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20400 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/450/

[GitHub] spark issue #20450: [SPARK-23280][SQL] add map type support to ColumnVector

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20450 **[Test build #86896 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86896/testReport)** for PR 20450 at commit

[GitHub] spark issue #20450: [SPARK-23280][SQL] add map type support to ColumnVector

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20450 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/449/

[GitHub] spark issue #20400: [SPARK-23084][PYTHON]Add unboundedPreceding(), unbounded...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20400 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20400: [SPARK-23084][PYTHON]Add unboundedPreceding(), unbounded...

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20400 **[Test build #86897 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86897/testReport)** for PR 20400 at commit

[GitHub] spark issue #20450: [SPARK-23280][SQL] add map type support to ColumnVector

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20450 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20450: [SPARK-23280][SQL] add map type support to ColumnVector

Github user jiangxb1987 commented on the issue: https://github.com/apache/spark/pull/20450 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #20400: [SPARK-23084][PYTHON]Add unboundedPreceding(), un...

Github user huaxingao commented on a diff in the pull request: https://github.com/apache/spark/pull/20400#discussion_r165229664 --- Diff: python/pyspark/sql/window.py --- @@ -124,16 +126,20 @@ def rangeBetween(start, end): values directly. :param

[GitHub] spark pull request #20400: [SPARK-23084][PYTHON]Add unboundedPreceding(), un...

Github user huaxingao commented on a diff in the pull request: https://github.com/apache/spark/pull/20400#discussion_r165229511 --- Diff: python/pyspark/sql/window.py --- @@ -212,16 +218,20 @@ def rangeBetween(self, start, end): values directly.

[GitHub] spark issue #17185: [SPARK-19602][SQL] Support column resolution of fully qu...

Github user skambha commented on the issue: https://github.com/apache/spark/pull/17185 I have rebased and pushed the changes. I ran the unit tests ( sql, catalyst and hive). Earlier, I was having issues running the hive test suite locally but that is resolved with the fix from

[GitHub] spark pull request #20459: [SPARK-23107][ML] ML 2.3 QA: New Scala APIs, docs...

Github user WeichenXu123 commented on a diff in the pull request: https://github.com/apache/spark/pull/20459#discussion_r165229102 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/QuantileDiscretizer.scala --- @@ -93,7 +93,7 @@ private[feature] trait

[GitHub] spark issue #20458: changed scala example from java "style" to scala

Github user mantovani commented on the issue: https://github.com/apache/spark/pull/20458 Sean, I already tested. Can you please be more specific how should be the tests ? I just tested on Spark 2.1.1 and Scala 2.11 and 2.10. On Wed, Jan 31, 2018 at 19:19 Sean Owen

[GitHub] spark issue #20458: changed scala example from java "style" to scala

Github user srowen commented on the issue: https://github.com/apache/spark/pull/20458 The point is that it won't always work in Spark, so, certainly not unless you test them. I just don't think it's worth it, especially as it's setting an expectation as an example that it is the best

[GitHub] spark issue #20460: [SPARK-23285][K8S] Allow fractional values for spark.exe...

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20460 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-spark-integration/446/ ---

[GitHub] spark issue #20460: [SPARK-23285][K8S] Allow fractional values for spark.exe...

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20460 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-spark-integration/446/ ---

[GitHub] spark issue #20460: [SPARK-23285][K8S] Allow fractional values for spark.exe...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20460 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/448/

[GitHub] spark issue #20460: [SPARK-23285][K8S] Allow fractional values for spark.exe...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20460 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20458: changed scala example from java "style" to scala

Github user mantovani commented on the issue: https://github.com/apache/spark/pull/20458 If I change all examples of the documentation will be accept ? On Wed, Jan 31, 2018 at 6:41 PM, Sean Owen wrote: > Yeah, that's what I was thinking of.

[GitHub] spark pull request #20422: [SPARK-23253][Core][Shuffle]Only write shuffle te...

Github user jiangxb1987 commented on a diff in the pull request: https://github.com/apache/spark/pull/20422#discussion_r165226127 --- Diff: core/src/test/scala/org/apache/spark/shuffle/sort/IndexShuffleBlockResolverSuite.scala --- @@ -133,4 +133,65 @@ class

<    1   2   3   4   5   6   7   >