Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/21882
Thank you @pwoody, @mgaido91 and @cloud-fan.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/21807#discussion_r206019502
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
---
@@ -68,9 +68,18 @@ trait CheckAnalysis extends
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21807
**[Test build #93773 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93773/testReport)**
for PR 21807 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/21807
ok to test
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/21732
@cloud-fan Makes sense. Updated change now enables top-level Option of
Product encoder.
---
-
To unsubscribe, e-mail:
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/21882
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/21882
thanks, merging to master/2.3!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21896
**[Test build #93772 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93772/testReport)**
for PR 21896 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21896
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21896
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/21886
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21732
**[Test build #93770 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93770/testReport)**
for PR 21732 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16677
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21896
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21886
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21732
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16677
**[Test build #93771 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93771/testReport)**
for PR 16677 at commit
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/21886
@gatorsmile Ok Sean..
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16677
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21886
**[Test build #93769 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93769/testReport)**
for PR 21886 at commit
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21886
@dilipbiswal The merged PR does not pick up your last commit.
---
-
To unsubscribe, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21732
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21886
Build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21886
Thanks! Merged to master.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21886
@dilipbiswal Please address the style issues in your other PRs.
---
-
To unsubscribe, e-mail:
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/16677
retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21732
**[Test build #93768 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93768/testReport)**
for PR 21732 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21732
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21732
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21732
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21732
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93765/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21732
**[Test build #93765 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93765/testReport)**
for PR 21732 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21882
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user gatorsmile closed the pull request at:
https://github.com/apache/spark/pull/20331
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21882
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93761/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21882
**[Test build #93761 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93761/testReport)**
for PR 21882 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21886
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21886
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93760/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21886
**[Test build #93760 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93760/testReport)**
for PR 21886 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19449
Seems okay to me.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user HeartSaVioR commented on the issue:
https://github.com/apache/spark/pull/20675
Looks like the patch is outdated, and when continuous query supports
shuffled stateful operators, implementing task level retry is not that trivial.
To get correct result of aggregation, when
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21732
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21732
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93764/
Test FAILed.
---
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/21886#discussion_r206013525
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala ---
@@ -529,9 +529,13 @@ abstract class SparkStrategies extends
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21732
**[Test build #93764 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93764/testReport)**
for PR 21732 at commit
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/21886#discussion_r206013205
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
---
@@ -164,7 +164,12 @@ object
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/spark/pull/21721#discussion_r206010782
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/sources/v2/writer/streaming/SupportsCustomWriterMetrics.java
---
@@ -0,0 +1,45 @@
+/*
+
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/spark/pull/21721#discussion_r206010370
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/ProgressReporter.scala
---
@@ -143,18 +150,50 @@ trait ProgressReporter
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/spark/pull/21721#discussion_r206009928
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/ProgressReporter.scala
---
@@ -143,18 +150,50 @@ trait ProgressReporter
Github user httfighter commented on the issue:
https://github.com/apache/spark/pull/21826
Thank you very much! @viirya
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21732
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21732
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93762/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21732
**[Test build #93762 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93762/testReport)**
for PR 21732 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21103
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21103
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93759/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21103
**[Test build #93759 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93759/testReport)**
for PR 21103 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21732
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93763/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21732
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21732
**[Test build #93763 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93763/testReport)**
for PR 21732 at commit
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21761
LGTM pending Jenkins
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21103#discussion_r206008046
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -3968,3 +3964,267 @@ object ArrayUnion {
Github user hhbyyh commented on the issue:
https://github.com/apache/spark/pull/16158
gentle ping @MLnick, Thanks for the review. Appreciate if you have some
time for further comments.
---
-
To unsubscribe, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21761
**[Test build #93767 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93767/testReport)**
for PR 21761 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21826
**[Test build #93766 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93766/testReport)**
for PR 21826 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21761
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21761
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21761
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/21826
retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user httfighter commented on the issue:
https://github.com/apache/spark/pull/21826
The last test bulid failed, but all the test cases passed. I don't know
what the problem is. Could you help me trigger it again? @HyukjinKwon
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21733
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21733
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93757/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21733
**[Test build #93757 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93757/testReport)**
for PR 21733 at commit
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/21103#discussion_r206004228
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -3968,3 +3964,267 @@ object ArrayUnion
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21913
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93756/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21913
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21913
**[Test build #93756 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93756/testReport)**
for PR 21913 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21732
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21103#discussion_r206002948
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -3968,3 +3964,267 @@ object ArrayUnion {
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21732
**[Test build #93765 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93765/testReport)**
for PR 21732 at commit
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21886
LGTM pending Jenkins
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21732
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21732
**[Test build #93764 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93764/testReport)**
for PR 21732 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21732
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21732
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/19449
cc @gatorsmile
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/21103#discussion_r206001326
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -3968,3 +3964,267 @@ object ArrayUnion
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21852#discussion_r206000924
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala
---
@@ -416,6 +416,23 @@ object SimplifyConditionals
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/21852#discussion_r206000777
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala
---
@@ -416,6 +416,23 @@ object SimplifyConditionals
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/21902#discussion_r206000635
--- Diff:
external/avro/src/main/scala/org/apache/spark/sql/avro/AvroFileFormat.scala ---
@@ -117,28 +117,19 @@ private[avro] class AvroFileFormat
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/21852#discussion_r206000642
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala
---
@@ -416,6 +416,23 @@ object SimplifyConditionals
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21103#discussion_r206000549
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -3968,3 +3964,267 @@ object ArrayUnion {
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/21103#discussion_r20525
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -3968,3 +3964,267 @@ object ArrayUnion
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/21103#discussion_r205999733
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -3968,3 +3964,267 @@ object ArrayUnion
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/21894
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21103#discussion_r205999688
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -3968,3 +3964,267 @@ object ArrayUnion {
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/21907
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21732
**[Test build #93763 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93763/testReport)**
for PR 21732 at commit
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/21103#discussion_r205999519
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -3968,3 +3964,267 @@ object ArrayUnion
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21732
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/21907
Merged to master.
Thank you @felixcheung.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
1 - 100 of 272 matches
Mail list logo
