Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22407#discussion_r217266743
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DataFrameFunctionsSuite.scala ---
@@ -1045,6 +1045,31 @@ class DataFrameFunctionsSuite extends
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22407#discussion_r217263871
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -2062,18 +2062,23 @@ case class
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/22403#discussion_r217265214
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/BooleanSimplificationSuite.scala
---
@@ -37,6 +38,7 @@ class
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22410
**[Test build #96023 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96023/testReport)**
for PR 22410 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22410
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22410
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
GitHub user ueshin opened a pull request:
https://github.com/apache/spark/pull/22410
[SPARK-25418][SQL] The metadata of DataSource table should not include
Hive-generated storage properties.
## What changes were proposed in this pull request?
When Hive support enabled,
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/22410
cc @gatorsmile
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22409
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22409
**[Test build #96022 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96022/testReport)**
for PR 22409 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22409
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/22409
cc @hvanhovell @dbtsai @cloud-fan
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
GitHub user viirya opened a pull request:
https://github.com/apache/spark/pull/22409
[SPARK-25352][SQL][Followup] Add helper method and address style issue
## What changes were proposed in this pull request?
This patch address [the review
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/7
**[Test build #96021 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96021/testReport)**
for PR 7 at commit
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/22405
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/7
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22231
shall we fix them here? Looks not many instances
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/22406
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/22407
cc @ueshin
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user cclauss commented on the issue:
https://github.com/apache/spark/pull/22231
@srowen Following the merge of #22400 there are just three W605s at the
bottom of
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96020/console
Should we __# noqa__ those lines
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22231
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22231
**[Test build #96020 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96020/testReport)**
for PR 22231 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22231
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96020/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22231
**[Test build #96020 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96020/testReport)**
for PR 22231 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22365
Seems fine but I or someone else should take a closer look before getting
this in.
---
-
To unsubscribe, e-mail:
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/22365#discussion_r217257137
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/DataFrameStatFunctions.scala ---
@@ -370,29 +370,76 @@ final class DataFrameStatFunctions
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22365#discussion_r217256279
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/DataFrameStatFunctions.scala ---
@@ -370,29 +370,76 @@ final class DataFrameStatFunctions
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/20521#discussion_r217255531
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/CreateHiveTableAsSelectCommand.scala
---
@@ -56,34 +57,36 @@ case class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20521#discussion_r217255313
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/CreateHiveTableAsSelectCommand.scala
---
@@ -56,34 +57,36 @@ case class
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/20521#discussion_r217254812
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/CreateHiveTableAsSelectCommand.scala
---
@@ -56,34 +57,36 @@ case class
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/20521#discussion_r217254430
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/CreateHiveTableAsSelectCommand.scala
---
@@ -56,34 +57,36 @@ case class
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22407
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96014/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22407
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22407
**[Test build #96014 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96014/testReport)**
for PR 22407 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/7
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/7
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96015/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/7
**[Test build #96015 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96015/testReport)**
for PR 7 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22402
**[Test build #96019 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96019/testReport)**
for PR 22402 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22402
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22402
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22402
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22394
**[Test build #96018 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96018/testReport)**
for PR 22394 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22394
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22394
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22394
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/22365#discussion_r217252035
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/DataFrameStatFunctions.scala ---
@@ -370,29 +370,76 @@ final class DataFrameStatFunctions
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22316
LGTM otherwise
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/22316#discussion_r217251795
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/RelationalGroupedDataset.scala ---
@@ -416,7 +426,7 @@ class RelationalGroupedDataset
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/22400
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user gengliangwang commented on a diff in the pull request:
https://github.com/apache/spark/pull/22406#discussion_r217249962
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -171,6 +171,26 @@ object SQLConf {
.intConf
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22400
Merged to master and branch-2.4.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22402
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22402
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96016/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22402
**[Test build #96016 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96016/testReport)**
for PR 22402 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22408
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22408
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22408
**[Test build #96017 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96017/testReport)**
for PR 22408 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22400
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22400
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96006/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22400
**[Test build #96006 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96006/testReport)**
for PR 22400 at commit
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/22374#discussion_r217242713
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/CSVDataSource.scala
---
@@ -240,23 +240,25 @@ object
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/22355#discussion_r217242015
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/CodeGeneratorWithInterpretedFallback.scala
---
@@ -37,19 +37,22 @@ object
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21904
Build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22355#discussion_r217241810
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/CodeGeneratorWithInterpretedFallback.scala
---
@@ -37,19 +37,22 @@
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21904
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/22353
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22353
thanks, merging to master/2.4/2.3!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/22374
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22374
thanks, merging to master/2.4!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21950
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96007/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21950
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21950
**[Test build #96007 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96007/testReport)**
for PR 21950 at commit
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/22398
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22398
since the original PR was reverted from 2.4, I'm merging it back.
Thanks, merging to master/2.4!
---
-
To
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22401
According to the PR introduced the `+ 10` behavior, it said this follows
Hive.
Whatever we want to propose, let's clearly write down the tradeoffs. e.g.
maybe too keep larger precision,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22408
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96009/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22408
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22408
**[Test build #96009 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96009/testReport)**
for PR 22408 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22406
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22406
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96005/
Test PASSed.
---
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22355#discussion_r217233868
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/CodeGeneratorWithInterpretedFallback.scala
---
@@ -37,19 +37,22 @@
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22406
**[Test build #96005 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96005/testReport)**
for PR 22406 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22398
**[Test build #4339 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4339/testReport)**
for PR 22398 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22402
**[Test build #96016 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96016/testReport)**
for PR 22402 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22402
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22402
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22395#discussion_r217233033
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala
---
@@ -314,6 +314,27 @@ case class Divide(left:
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22398
LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22388
As we discussed in the dev list, we only want to revert it from 2.4. I'm
closing it now.
---
-
To unsubscribe, e-mail:
Github user cloud-fan closed the pull request at:
https://github.com/apache/spark/pull/22388
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user LantaoJin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22353#discussion_r217229063
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkPlanInfo.scala ---
@@ -59,6 +57,12 @@ private[execution] object SparkPlanInfo {
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22407
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22407
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22405
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22405
Kubernetes integration test status success
URL:
https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/3066/
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22405
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/19773#discussion_r217226856
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ---
@@ -350,16 +366,11 @@ case class AlterTableChangeColumnCommand(
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22407
**[Test build #96014 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96014/testReport)**
for PR 22407 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/7
**[Test build #96015 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96015/testReport)**
for PR 7 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22405
Kubernetes integration test starting
URL:
https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/3066/
---
1 - 100 of 484 matches
Mail list logo
