[GitHub] spark issue #22484: [SPARK-25476][TEST] Refactor AggregateBenchmark to use m...

2018-09-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22484 **[Test build #96500 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96500/testReport)** for PR 22484 at commit

[GitHub] spark issue #22484: [SPARK-25476][TEST] Refactor AggregateBenchmark to use m...

2018-09-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22484 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #22484: [SPARK-25476][TEST] Refactor AggregateBenchmark to use m...

2018-09-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22484 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #22526: [SPARK-25502][WEBUI]Empty Page when page number e...

2018-09-23 Thread shahidki31
Github user shahidki31 commented on a diff in the pull request: https://github.com/apache/spark/pull/22526#discussion_r219732766 --- Diff: core/src/main/scala/org/apache/spark/ui/jobs/StagePage.scala --- @@ -685,7 +685,15 @@ private[ui] class TaskDataSource( private

[GitHub] spark pull request #22495: [SPARK-25486][TEST] Refactor SortBenchmark to use...

2018-09-23 Thread yucai
Github user yucai commented on a diff in the pull request: https://github.com/apache/spark/pull/22495#discussion_r219731873 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/SortBenchmark.scala --- @@ -28,12 +28,15 @@ import

[GitHub] spark issue #22524: [WIP][SPARK-25497][SQL] Limit operation within whole sta...

2018-09-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22524 **[Test build #96499 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96499/testReport)** for PR 22524 at commit

[GitHub] spark issue #22524: [WIP][SPARK-25497][SQL] Limit operation within whole sta...

2018-09-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22524 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22524: [WIP][SPARK-25497][SQL] Limit operation within whole sta...

2018-09-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22524 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request #22524: [WIP][SPARK-25497][SQL] Limit operation within wh...

2018-09-23 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/22524#discussion_r219731695 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameAggregateSuite.scala --- @@ -556,7 +556,7 @@ class DataFrameAggregateSuite extends QueryTest

[GitHub] spark issue #22466: [SPARK-25464][SQL]On dropping the Database it will drop ...

2018-09-23 Thread sandeep-katta
Github user sandeep-katta commented on the issue: https://github.com/apache/spark/pull/22466 > See JIRA, I don't think this should be merged. I have referred Databricks doc https://docs.databricks.com/spark/latest/spark-sql/language-manual/create-database.html and

[GitHub] spark issue #22511: [SPARK-25422][CORE] Don't memory map blocks streamed to ...

2018-09-23 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/22511 Also cc @zsxwing @JoshRosen --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark pull request #22429: [SPARK-25440][SQL] Dumping query execution info t...

2018-09-23 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/22429#discussion_r219729921 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/QueryExecution.scala --- @@ -250,5 +265,22 @@ class QueryExecution(val sparkSession:

[GitHub] spark pull request #22429: [SPARK-25440][SQL] Dumping query execution info t...

2018-09-23 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/22429#discussion_r219729889 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/QueryExecution.scala --- @@ -250,5 +265,22 @@ class QueryExecution(val sparkSession:

[GitHub] spark issue #22525: [SPARK-25503][CORE][WEBUI]Total task message in stage pa...

2018-09-23 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/22525 ok to test. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #22488: [SPARK-25479][TEST] Refactor DatasetBenchmark to ...

2018-09-23 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/22488#discussion_r219729655 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DatasetBenchmark.scala --- @@ -242,75 +248,20 @@ object DatasetBenchmark { benchmark

[GitHub] spark issue #22453: [SPARK-20937][DOCS] Describe spark.sql.parquet.writeLega...

2018-09-23 Thread seancxmao
Github user seancxmao commented on the issue: https://github.com/apache/spark/pull/22453 FYI. I had a brief survey on Parquet decimal support of computing engines at the time of writing. Hive * [HIVE-19069](https://jira.apache.org/jira/browse/HIVE-19069) Hive can't read

[GitHub] spark pull request #22429: [SPARK-25440][SQL] Dumping query execution info t...

2018-09-23 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/22429#discussion_r219729210 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala --- @@ -668,11 +670,19 @@ case class

[GitHub] spark pull request #22453: [SPARK-20937][DOCS] Describe spark.sql.parquet.wr...

2018-09-23 Thread seancxmao
Github user seancxmao commented on a diff in the pull request: https://github.com/apache/spark/pull/22453#discussion_r219729166 --- Diff: docs/sql-programming-guide.md --- @@ -1002,6 +1002,15 @@ Configuration of Parquet can be done using the `setConf` method on `SparkSession

[GitHub] spark issue #22521: [SPARK-24519] Compute SHUFFLE_MIN_NUM_PARTS_TO_HIGHLY_CO...

2018-09-23 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/22521 Jenkins, retest this please. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #22433: [SPARK-25442][SQL][K8S] Support STS to run in k8s...

2018-09-23 Thread liyinan926
Github user liyinan926 commented on a diff in the pull request: https://github.com/apache/spark/pull/22433#discussion_r219728772 --- Diff: docs/running-on-kubernetes.md --- @@ -340,6 +340,43 @@ RBAC authorization and how to configure Kubernetes service accounts for pods, pl

[GitHub] spark issue #22521: [SPARK-24519] Compute SHUFFLE_MIN_NUM_PARTS_TO_HIGHLY_CO...

2018-09-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22521 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22521: [SPARK-24519] Compute SHUFFLE_MIN_NUM_PARTS_TO_HIGHLY_CO...

2018-09-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22521 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96495/ Test FAILed. ---

[GitHub] spark issue #22521: [SPARK-24519] Compute SHUFFLE_MIN_NUM_PARTS_TO_HIGHLY_CO...

2018-09-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22521 **[Test build #96495 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96495/testReport)** for PR 22521 at commit

[GitHub] spark issue #22466: [SPARK-25464][SQL]On dropping the Database it will drop ...

2018-09-23 Thread sandeep-katta
Github user sandeep-katta commented on the issue: https://github.com/apache/spark/pull/22466 Yes I agree 2 database should not point to same path,**currently this is the loop hole in spark which is required to fix**.If this solution is not okay ,then we can append the dbname.db to

[GitHub] spark pull request #22458: [SPARK-25459] Add viewOriginalText back to Catalo...

2018-09-23 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/22458#discussion_r219727730 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala --- @@ -2348,4 +2348,17 @@ class HiveDDLSuite }

[GitHub] spark issue #22524: [WIP][SPARK-25497][SQL] Limit operation within whole sta...

2018-09-23 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/22524 @xuanyuanking Thanks. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #22326: [SPARK-25314][SQL] Fix Python UDF accessing attributes f...

2018-09-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22326 **[Test build #96498 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96498/testReport)** for PR 22326 at commit

[GitHub] spark issue #22326: [SPARK-25314][SQL] Fix Python UDF accessing attributes f...

2018-09-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22326 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #22326: [SPARK-25314][SQL] Fix Python UDF accessing attributes f...

2018-09-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22326 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21999: [WIP][SQL] Flattening nested structures

2018-09-23 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/21999 Thanks! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #22326: [SPARK-25314][SQL] Fix Python UDF accessing attributes f...

2018-09-23 Thread xuanyuanking
Github user xuanyuanking commented on the issue: https://github.com/apache/spark/pull/22326 retest this please. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #22524: [WIP][SPARK-25497][SQL] Limit operation within whole sta...

2018-09-23 Thread xuanyuanking
Github user xuanyuanking commented on the issue: https://github.com/apache/spark/pull/22524 @viirya As @shaneknapp reply in mail-list, you can try https://hadrian.ist.berkeley.edu/jenkins/. Thanks @shaneknapp :) ---

[GitHub] spark pull request #22525: [SPARK-25503][CORE][WEBUI]Total task message in s...

2018-09-23 Thread shahidki31
Github user shahidki31 commented on a diff in the pull request: https://github.com/apache/spark/pull/22525#discussion_r219726139 --- Diff: core/src/main/scala/org/apache/spark/ui/jobs/StagePage.scala --- @@ -132,7 +132,7 @@ private[ui] class StagePage(parent: StagesTab, store:

[GitHub] spark pull request #22486: [SPARK-25478][SQL][TEST] Refactor CompressionSche...

2018-09-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/22486 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #22488: [SPARK-25479][TEST] Refactor DatasetBenchmark to use mai...

2018-09-23 Thread wangyum
Github user wangyum commented on the issue: https://github.com/apache/spark/pull/22488 @dongjoon-hyun I think this refactor is ready to go. Thanks. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

[GitHub] spark pull request #22484: [SPARK-25476][TEST] Refactor AggregateBenchmark t...

2018-09-23 Thread wangyum
Github user wangyum commented on a diff in the pull request: https://github.com/apache/spark/pull/22484#discussion_r219725643 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/RunBenchmarkWithCodegen.scala --- @@ -0,0 +1,58 @@ +/* + * Licensed to

[GitHub] spark pull request #22501: [SPARK-25492][TEST] Refactor WideSchemaBenchmark ...

2018-09-23 Thread wangyum
Github user wangyum commented on a diff in the pull request: https://github.com/apache/spark/pull/22501#discussion_r219725654 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/WideSchemaBenchmark.scala --- @@ -17,22 +17,19 @@ package

[GitHub] spark pull request #22484: [SPARK-25476][TEST] Refactor AggregateBenchmark t...

2018-09-23 Thread wangyum
Github user wangyum commented on a diff in the pull request: https://github.com/apache/spark/pull/22484#discussion_r219725606 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/RunBenchmarkWithCodegen.scala --- @@ -0,0 +1,58 @@ +/* + * Licensed to

[GitHub] spark issue #22486: [SPARK-25478][SQL][TEST] Refactor CompressionSchemeBench...

2018-09-23 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/22486 Merged to master. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #22486: [SPARK-25478][SQL][TEST] Refactor CompressionSchemeBench...

2018-09-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22486 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22486: [SPARK-25478][SQL][TEST] Refactor CompressionSchemeBench...

2018-09-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22486 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96494/ Test PASSed. ---

[GitHub] spark pull request #22495: [SPARK-25486][TEST] Refactor SortBenchmark to use...

2018-09-23 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/22495#discussion_r219725464 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/SortBenchmark.scala --- @@ -28,12 +28,15 @@ import

[GitHub] spark issue #22486: [SPARK-25478][SQL][TEST] Refactor CompressionSchemeBench...

2018-09-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22486 **[Test build #96494 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96494/testReport)** for PR 22486 at commit

[GitHub] spark issue #22511: [SPARK-25422][CORE] Don't memory map blocks streamed to ...

2018-09-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22511 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #22501: [SPARK-25492][TEST] Refactor WideSchemaBenchmark ...

2018-09-23 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/22501#discussion_r219724989 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/WideSchemaBenchmark.scala --- @@ -17,22 +17,19 @@ package

[GitHub] spark issue #22511: [SPARK-25422][CORE] Don't memory map blocks streamed to ...

2018-09-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22511 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #22511: [SPARK-25422][CORE] Don't memory map blocks streamed to ...

2018-09-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22511 **[Test build #96497 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96497/testReport)** for PR 22511 at commit

[GitHub] spark issue #22511: [SPARK-25422][CORE] Don't memory map blocks streamed to ...

2018-09-23 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/22511 Retest this please. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #22453: [SPARK-20937][DOCS] Describe spark.sql.parquet.writeLega...

2018-09-23 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/22453 cc @jaceklaskowski FYI --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #22453: [SPARK-20937][DOCS] Describe spark.sql.parquet.wr...

2018-09-23 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/22453#discussion_r219722950 --- Diff: docs/sql-programming-guide.md --- @@ -1002,6 +1002,15 @@ Configuration of Parquet can be done using the `setConf` method on `SparkSession

[GitHub] spark issue #21524: [SPARK-24212][ML][doc] Add the example and user guide fo...

2018-09-23 Thread tengpeng
Github user tengpeng commented on the issue: https://github.com/apache/spark/pull/21524 Yes, but may not be recently. Is there a "deadline" (e.g. branch cut) coming? On Tue, Sep 18, 2018 at 4:23 PM Sean Owen wrote: > @tengpeng would

[GitHub] spark pull request #22453: [SPARK-20937][DOCS] Describe spark.sql.parquet.wr...

2018-09-23 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/22453#discussion_r219722694 --- Diff: docs/sql-programming-guide.md --- @@ -1002,6 +1002,15 @@ Configuration of Parquet can be done using the `setConf` method on `SparkSession

[GitHub] spark issue #22491: [SPARK-25483][TEST] Refactor UnsafeArrayDataBenchmark to...

2018-09-23 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/22491 Thank you for pinging me, @wangyum . --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22530: [SPARK-24869][SQL] Fix SaveIntoDataSourceCommand's input...

2018-09-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22530 **[Test build #96496 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96496/testReport)** for PR 22530 at commit

[GitHub] spark issue #22530: [SPARK-24869][SQL] Fix SaveIntoDataSourceCommand's input...

2018-09-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22530 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #22530: [SPARK-24869][SQL] Fix SaveIntoDataSourceCommand's input...

2018-09-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22530 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22491: [SPARK-25483][TEST] Refactor UnsafeArrayDataBenchmark to...

2018-09-23 Thread wangyum
Github user wangyum commented on the issue: https://github.com/apache/spark/pull/22491 @dongjoon-hyun This refactor is ready to go. Thanks. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For

[GitHub] spark issue #22530: [SPARK-24869][SQL] Fix SaveIntoDataSourceCommand's input...

2018-09-23 Thread wangyum
Github user wangyum commented on the issue: https://github.com/apache/spark/pull/22530 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #22529: [SPARK-25460][BRANCH-2.4][SS] DataSourceV2: SS so...

2018-09-23 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/22529#discussion_r219722208 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/streaming/DataStreamReader.scala --- @@ -173,12 +173,16 @@ final class DataStreamReader

[GitHub] spark pull request #22453: [SPARK-20937][DOCS] Describe spark.sql.parquet.wr...

2018-09-23 Thread seancxmao
Github user seancxmao commented on a diff in the pull request: https://github.com/apache/spark/pull/22453#discussion_r219721110 --- Diff: docs/sql-programming-guide.md --- @@ -1002,6 +1002,15 @@ Configuration of Parquet can be done using the `setConf` method on `SparkSession

[GitHub] spark pull request #22531: [SPARK-25415][SQL][FOLLOW-UP] Add Locale.ROOT whe...

2018-09-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/22531 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #22531: [SPARK-25415][SQL][FOLLOW-UP] Add Locale.ROOT when toUpp...

2018-09-23 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/22531 Merged to master. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #22453: [SPARK-20937][DOCS] Describe spark.sql.parquet.wr...

2018-09-23 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/22453#discussion_r219719299 --- Diff: docs/sql-programming-guide.md --- @@ -1002,6 +1002,15 @@ Configuration of Parquet can be done using the `setConf` method on `SparkSession

[GitHub] spark issue #22531: [SPARK-25415][SQL][FOLLOW-UP] Add Locale.ROOT when toUpp...

2018-09-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22531 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96493/ Test PASSed. ---

[GitHub] spark issue #22531: [SPARK-25415][SQL][FOLLOW-UP] Add Locale.ROOT when toUpp...

2018-09-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22531 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #22453: [SPARK-20937][DOCS] Describe spark.sql.parquet.wr...

2018-09-23 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/22453#discussion_r219719166 --- Diff: docs/sql-programming-guide.md --- @@ -1002,6 +1002,15 @@ Configuration of Parquet can be done using the `setConf` method on `SparkSession

[GitHub] spark issue #22531: [SPARK-25415][SQL][FOLLOW-UP] Add Locale.ROOT when toUpp...

2018-09-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22531 **[Test build #96493 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96493/testReport)** for PR 22531 at commit

[GitHub] spark pull request #22453: [SPARK-20937][DOCS] Describe spark.sql.parquet.wr...

2018-09-23 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/22453#discussion_r219717918 --- Diff: docs/sql-programming-guide.md --- @@ -1002,6 +1002,15 @@ Configuration of Parquet can be done using the `setConf` method on `SparkSession

[GitHub] spark issue #22463: remove annotation @Experimental

2018-09-23 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/22463 Yeah, I think Experimental is over-used in the APIs. They just never get un-marked and lots of pretty old stuff, that de facto is just not changeable now, is still labeled this way. This seems to be

[GitHub] spark pull request #22473: [SPARK-25449][CORE] Heartbeat shouldn't include a...

2018-09-23 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/22473#discussion_r219717779 --- Diff: core/src/main/scala/org/apache/spark/internal/config/package.scala --- @@ -83,6 +83,17 @@ package object config { private[spark] val

[GitHub] spark pull request #22520: [SPARK-25509][Core]Windows doesn't support POSIX ...

2018-09-23 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/22520#discussion_r219717720 --- Diff: core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala --- @@ -133,9 +133,15 @@ private[history] class

[GitHub] spark issue #22516: [SPARK-25468]Highlight current page index in the history...

2018-09-23 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/22516 Rather than modify jquery, can we override this in Spark-specific CSS? otherwise we might lose customizations when updating jquery. ---

[GitHub] spark issue #22521: [SPARK-24519] Compute SHUFFLE_MIN_NUM_PARTS_TO_HIGHLY_CO...

2018-09-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22521 **[Test build #96495 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96495/testReport)** for PR 22521 at commit

[GitHub] spark issue #22521: [SPARK-24519] Compute SHUFFLE_MIN_NUM_PARTS_TO_HIGHLY_CO...

2018-09-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22521 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22521: [SPARK-24519] Compute SHUFFLE_MIN_NUM_PARTS_TO_HIGHLY_CO...

2018-09-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22521 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #22486: [SPARK-25478][SQL][TEST] Refactor CompressionSchemeBench...

2018-09-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22486 **[Test build #96494 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96494/testReport)** for PR 22486 at commit

[GitHub] spark issue #22486: [SPARK-25478][SQL][TEST] Refactor CompressionSchemeBench...

2018-09-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22486 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22486: [SPARK-25478][SQL][TEST] Refactor CompressionSchemeBench...

2018-09-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22486 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #22486: [SPARK-25478][SQL][TEST] Refactor CompressionSchemeBench...

2018-09-23 Thread wangyum
Github user wangyum commented on the issue: https://github.com/apache/spark/pull/22486 @dongjoon-hyun Thanks a lot. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #22526: [SPARK-25502][WEBUI]Empty Page when page number e...

2018-09-23 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/22526#discussion_r219715489 --- Diff: core/src/main/scala/org/apache/spark/ui/jobs/StagePage.scala --- @@ -685,7 +685,15 @@ private[ui] class TaskDataSource( private var

[GitHub] spark issue #22525: [SPARK-25503][WEBUI] Total task message in stage page is...

2018-09-23 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/22525 Retest this please. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #22525: [SPARK-25503][WEBUI] Total task message in stage ...

2018-09-23 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/22525#discussion_r219715130 --- Diff: core/src/main/scala/org/apache/spark/ui/jobs/StagePage.scala --- @@ -132,7 +132,7 @@ private[ui] class StagePage(parent: StagesTab, store:

[GitHub] spark issue #21747: [SPARK-24165][SQL][branch-2.3] Fixing conditional expres...

2018-09-23 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/21747 Hi, @mn-mikke and @cloud-fan and @maropu . 2.3.2 vote passed today and 2.4.0-rc1 doesn't have this issue. Given that Spark 2.4.0 will come faster than Spark 2.3.3, are we heading to (1) or

[GitHub] spark pull request #22227: [SPARK-25202] [SQL] Implements split with limit s...

2018-09-23 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/7#discussion_r219714851 --- Diff: R/pkg/R/functions.R --- @@ -3404,19 +3404,27 @@ setMethod("collect_set", #' Equivalent to \code{split} SQL function. #' #'

[GitHub] spark issue #22529: [SPARK-25460][BRANCH-2.4][SS] DataSourceV2: SS sources d...

2018-09-23 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/22529 cc @cloud-fan and @gatorsmile --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark pull request #22529: [SPARK-25460][BRANCH-2.4][SS] DataSourceV2: SS so...

2018-09-23 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/22529#discussion_r219714244 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/streaming/DataStreamReader.scala --- @@ -173,12 +173,16 @@ final class DataStreamReader

[GitHub] spark issue #22486: [SPARK-25478][TEST] Refactor CompressionSchemeBenchmark ...

2018-09-23 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/22486 Hi, @wangyum . If you don't mind, could you review and merge [my PR](https://github.com/wangyum/spark/pull/10) to your branch? The BM title is updated and latest OpenJDK on AWS is used. ---

[GitHub] spark issue #22486: [SPARK-25478][TEST] Refactor CompressionSchemeBenchmark ...

2018-09-23 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/22486 Could you add `[SQL]` at the title? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21688: [SPARK-21809] : Change Stage Page to use datatables to s...

2018-09-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21688 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96492/ Test FAILed. ---

[GitHub] spark issue #21688: [SPARK-21809] : Change Stage Page to use datatables to s...

2018-09-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21688 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22531: [SPARK-25415][SQL][FOLLOW-UP] Add Locale.ROOT when toUpp...

2018-09-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22531 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #22531: [SPARK-25415][SQL][FOLLOW-UP] Add Locale.ROOT when toUpp...

2018-09-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22531 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21688: [SPARK-21809] : Change Stage Page to use datatables to s...

2018-09-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21688 **[Test build #96492 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96492/testReport)** for PR 21688 at commit

[GitHub] spark issue #22531: [SPARK-25415][SQL][FOLLOW-UP] Add Locale.ROOT when toUpp...

2018-09-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22531 **[Test build #96493 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96493/testReport)** for PR 22531 at commit

[GitHub] spark issue #22531: [SPARK-25415][SQL][FOLLOW-UP] Add Locale.ROOT when toUpp...

2018-09-23 Thread wangyum
Github user wangyum commented on the issue: https://github.com/apache/spark/pull/22531 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #22532: [SPARK-20845][SQL] Support specification of column names...

2018-09-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22532 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22532: [SPARK-20845][SQL] Support specification of column names...

2018-09-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22532 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22532: [SPARK-20845][SQL] Support specification of column names...

2018-09-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22532 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #22532: [SPARK-20845][SQL] Support specification of colum...

2018-09-23 Thread misutoth
GitHub user misutoth opened a pull request: https://github.com/apache/spark/pull/22532 [SPARK-20845][SQL] Support specification of column names in INSERT INTO command. ## What changes were proposed in this pull request? One can specify a list of columns for an INSERT INTO

[GitHub] spark pull request #22486: [SPARK-25478][TEST] Refactor CompressionSchemeBen...

2018-09-23 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/22486#discussion_r219711018 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/columnar/compression/CompressionSchemeBenchmark.scala --- @@ -318,28 +229,17 @@

  1   2   >