[GitHub] spark issue #22847: [SPARK-25850][SQL] Make the split threshold for the code...

2018-10-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22847 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22847: [SPARK-25850][SQL] Make the split threshold for the code...

2018-10-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22847 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98129/ Test PASSed. ---

[GitHub] spark issue #22847: [SPARK-25850][SQL] Make the split threshold for the code...

2018-10-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22847 **[Test build #98129 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98129/testReport)** for PR 22847 at commit

[GitHub] spark issue #22784: [SPARK-25790][MLLIB] PCA: Support more than 65535 column...

2018-10-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22784 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98134/ Test PASSed. ---

[GitHub] spark issue #22784: [SPARK-25790][MLLIB] PCA: Support more than 65535 column...

2018-10-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22784 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22784: [SPARK-25790][MLLIB] PCA: Support more than 65535 column...

2018-10-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22784 **[Test build #98134 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98134/testReport)** for PR 22784 at commit

[GitHub] spark issue #22784: [SPARK-25790][MLLIB] PCA: Support more than 65535 column...

2018-10-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22784 **[Test build #98135 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98135/testReport)** for PR 22784 at commit

[GitHub] spark issue #22784: [SPARK-25790][MLLIB] PCA: Support more than 65535 column...

2018-10-27 Thread shahidki31
Github user shahidki31 commented on the issue: https://github.com/apache/spark/pull/22784 Thank you @srowen for the review. I have addressed the comments. > I wonder if the SVD should be used at even smaller scales? as you point out, it's pretty hard to compute a gramian on

[GitHub] spark pull request #22862: Spark 24207 2.4.0

2018-10-27 Thread kevinyu98
Github user kevinyu98 closed the pull request at: https://github.com/apache/spark/pull/22862 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #22862: Spark 24207 2.4.0

2018-10-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22862 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22862: Spark 24207 2.4.0

2018-10-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22862 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22862: Spark 24207 2.4.0

2018-10-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22862 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #22862: Spark 24207 2.4.0

2018-10-27 Thread kevinyu98
GitHub user kevinyu98 opened a pull request: https://github.com/apache/spark/pull/22862 Spark 24207 2.4.0 ## What changes were proposed in this pull request? (Please fill in changes proposed in this fix) ## How was this patch tested? (Please explain how

[GitHub] spark pull request #22784: [SPARK-25790][MLLIB] PCA: Support more than 65535...

2018-10-27 Thread shahidki31
Github user shahidki31 commented on a diff in the pull request: https://github.com/apache/spark/pull/22784#discussion_r228719122 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/distributed/RowMatrix.scala --- @@ -384,18 +384,28 @@ class RowMatrix @Since("1.0.0") (

[GitHub] spark issue #22784: [SPARK-25790][MLLIB] PCA: Support more than 65535 column...

2018-10-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22784 **[Test build #98134 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98134/testReport)** for PR 22784 at commit

[GitHub] spark pull request #22784: [SPARK-25790][MLLIB] PCA: Support more than 65535...

2018-10-27 Thread shahidki31
Github user shahidki31 commented on a diff in the pull request: https://github.com/apache/spark/pull/22784#discussion_r228719009 --- Diff: mllib/src/test/scala/org/apache/spark/mllib/feature/PCASuite.scala --- @@ -54,4 +55,14 @@ class PCASuite extends SparkFunSuite with

[GitHub] spark pull request #22784: [SPARK-25790][MLLIB] PCA: Support more than 65535...

2018-10-27 Thread shahidki31
Github user shahidki31 commented on a diff in the pull request: https://github.com/apache/spark/pull/22784#discussion_r228718969 --- Diff: mllib/src/test/scala/org/apache/spark/mllib/feature/PCASuite.scala --- @@ -54,4 +55,14 @@ class PCASuite extends SparkFunSuite with

[GitHub] spark issue #22861: [SPARK-25663][SPARK-25661][SQL][TEST] Refactor BuiltInDa...

2018-10-27 Thread yucai
Github user yucai commented on the issue: https://github.com/apache/spark/pull/22861 @gengliangwang @wangyum @dongjoon-hyun help review. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For

[GitHub] spark issue #22861: [SPARK-25663][SPARK-25661][SQL][TEST] Refactor BuiltInDa...

2018-10-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22861 **[Test build #98133 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98133/testReport)** for PR 22861 at commit

[GitHub] spark issue #22861: [SPARK-25663][SPARK-25661][SQL][TEST] Refactor BuiltInDa...

2018-10-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22861 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22861: [SPARK-25663][SPARK-25661][SQL][TEST] Refactor BuiltInDa...

2018-10-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22861 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #22861: [SPARK-25663][SPARK-25661][SQL][TEST] Refactor Bu...

2018-10-27 Thread yucai
GitHub user yucai opened a pull request: https://github.com/apache/spark/pull/22861 [SPARK-25663][SPARK-25661][SQL][TEST] Refactor BuiltInDataSourceWriteBenchmark, DataSourceWriteBenchmark and AvroWriteBenchmark to use main method ## What changes were proposed in this pull

[GitHub] spark issue #21348: [SPARK-22739][Catalyst] Additional Expression Support fo...

2018-10-27 Thread xuanyuanking
Github user xuanyuanking commented on the issue: https://github.com/apache/spark/pull/21348 @bdrillard Thanks for our reply, of cause I'll request your review and make sure I understand your implement correctly. ``` Should we go ahead and re-open it and follow through with

[GitHub] spark pull request #22855: [SPARK-25839] [Core] Implement use of KryoPool in...

2018-10-27 Thread xuanyuanking
Github user xuanyuanking commented on a diff in the pull request: https://github.com/apache/spark/pull/22855#discussion_r228716995 --- Diff: core/src/main/scala/org/apache/spark/serializer/KryoSerializer.scala --- @@ -298,30 +312,40 @@ class KryoDeserializationStream( }

[GitHub] spark pull request #22855: [SPARK-25839] [Core] Implement use of KryoPool in...

2018-10-27 Thread xuanyuanking
Github user xuanyuanking commented on a diff in the pull request: https://github.com/apache/spark/pull/22855#discussion_r228716497 --- Diff: core/src/main/scala/org/apache/spark/serializer/KryoSerializer.scala --- @@ -92,6 +94,18 @@ class KryoSerializer(conf: SparkConf)

[GitHub] spark pull request #22855: [SPARK-25839] [Core] Implement use of KryoPool in...

2018-10-27 Thread xuanyuanking
Github user xuanyuanking commented on a diff in the pull request: https://github.com/apache/spark/pull/22855#discussion_r228716824 --- Diff: core/src/test/scala/org/apache/spark/serializer/KryoSerializerBenchmark.scala --- @@ -0,0 +1,90 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request #22855: [SPARK-25839] [Core] Implement use of KryoPool in...

2018-10-27 Thread xuanyuanking
Github user xuanyuanking commented on a diff in the pull request: https://github.com/apache/spark/pull/22855#discussion_r228716844 --- Diff: core/src/test/scala/org/apache/spark/serializer/KryoSerializerSuite.scala --- @@ -33,6 +33,7 @@ import

[GitHub] spark pull request #22309: [SPARK-20384][SQL] Support value class in schema ...

2018-10-27 Thread mt40
Github user mt40 commented on a diff in the pull request: https://github.com/apache/spark/pull/22309#discussion_r228716352 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala --- @@ -635,13 +675,17 @@ object ScalaReflection extends

[GitHub] spark issue #22857: [SPARK-25860][SQL] Replace Literal(null, _) with FalseLi...

2018-10-27 Thread aokolnychyi
Github user aokolnychyi commented on the issue: https://github.com/apache/spark/pull/22857 @dbtsai @gatorsmile @cloud-fan could you guys, please, take a look? --- - To unsubscribe, e-mail:

[GitHub] spark issue #22847: [SPARK-25850][SQL] Make the split threshold for the code...

2018-10-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22847 **[Test build #98132 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98132/testReport)** for PR 22847 at commit

[GitHub] spark pull request #22823: [SPARK-25676][SQL][TEST] Improve BenchmarkWideTab...

2018-10-27 Thread yucai
Github user yucai commented on a diff in the pull request: https://github.com/apache/spark/pull/22823#discussion_r228715829 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/BenchmarkWideTable.scala --- @@ -1,52 +0,0 @@ -/* - * Licensed to the

[GitHub] spark issue #22857: [SPARK-25860][SQL] Replace Literal(null, _) with FalseLi...

2018-10-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22857 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98127/ Test PASSed. ---

[GitHub] spark issue #22857: [SPARK-25860][SQL] Replace Literal(null, _) with FalseLi...

2018-10-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22857 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21732: [SPARK-24762][SQL] Enable Option of Product encoders

2018-10-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21732 **[Test build #98131 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98131/testReport)** for PR 21732 at commit

[GitHub] spark issue #22857: [SPARK-25860][SQL] Replace Literal(null, _) with FalseLi...

2018-10-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22857 **[Test build #98127 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98127/testReport)** for PR 22857 at commit

[GitHub] spark issue #21732: [SPARK-24762][SQL] Enable Option of Product encoders

2018-10-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21732 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #21732: [SPARK-24762][SQL] Enable Option of Product encoders

2018-10-27 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/21732 Rebased this after refactoring ExpressionEncoder. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For

[GitHub] spark issue #21732: [SPARK-24762][SQL] Enable Option of Product encoders

2018-10-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21732 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22847: [SPARK-25850][SQL] Make the split threshold for the code...

2018-10-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22847 **[Test build #98130 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98130/testReport)** for PR 22847 at commit

[GitHub] spark issue #22847: [SPARK-25850][SQL] Make the split threshold for the code...

2018-10-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22847 **[Test build #98129 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98129/testReport)** for PR 22847 at commit

[GitHub] spark pull request #22784: [SPARK-25790][MLLIB] PCA: Support more than 65535...

2018-10-27 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/22784#discussion_r228714200 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/distributed/RowMatrix.scala --- @@ -384,18 +384,28 @@ class RowMatrix @Since("1.0.0") (

[GitHub] spark pull request #22784: [SPARK-25790][MLLIB] PCA: Support more than 65535...

2018-10-27 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/22784#discussion_r228713925 --- Diff: mllib/src/test/scala/org/apache/spark/mllib/feature/PCASuite.scala --- @@ -54,4 +55,14 @@ class PCASuite extends SparkFunSuite with

[GitHub] spark pull request #22784: [SPARK-25790][MLLIB] PCA: Support more than 65535...

2018-10-27 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/22784#discussion_r228713878 --- Diff: mllib/src/test/scala/org/apache/spark/mllib/feature/PCASuite.scala --- @@ -54,4 +55,14 @@ class PCASuite extends SparkFunSuite with

[GitHub] spark pull request #22849: [SPARK-25852][Core] we should filter the workOffe...

2018-10-27 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/22849#discussion_r228713414 --- Diff: core/src/main/scala/org/apache/spark/scheduler/cluster/CoarseGrainedSchedulerBackend.scala --- @@ -240,7 +240,7 @@ class

[GitHub] spark issue #22813: [SPARK-25818][CORE] WorkDirCleanup should only remove th...

2018-10-27 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/22813 I don't think that's a reasonable usage scenario. That said is there any harm to this change? would it ever miss cleaning something up that it should? ---

[GitHub] spark issue #22309: [SPARK-20384][SQL] Support value class in schema of Data...

2018-10-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22309 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22309: [SPARK-20384][SQL] Support value class in schema of Data...

2018-10-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22309 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98128/ Test FAILed. ---

[GitHub] spark issue #22309: [SPARK-20384][SQL] Support value class in schema of Data...

2018-10-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22309 **[Test build #98128 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98128/testReport)** for PR 22309 at commit

[GitHub] spark issue #22309: [SPARK-20384][SQL] Support value class in schema of Data...

2018-10-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22309 **[Test build #98128 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98128/testReport)** for PR 22309 at commit

[GitHub] spark issue #22860: Branch 2.4

2018-10-27 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/22860 @sarojchand close this --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #22859: Branch 2.2

2018-10-27 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/22859 @sarojchand close this --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #22858: [SPARK-24709][SQL][2.4] use str instead of basest...

2018-10-27 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/22858#discussion_r228713086 --- Diff: python/pyspark/sql/functions.py --- @@ -2326,7 +2326,7 @@ def schema_of_json(json): >>> df.select(schema_of_json('{"a":

[GitHub] spark issue #22858: [SPARK-24709][SQL][2.4] use str instead of basestring in...

2018-10-27 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/22858 Wenchen, this is because ```python if sys.version >= '3': basestring = str ``` Is missing. Python 3 does not have `basestring`. ---

[GitHub] spark pull request #22309: [SPARK-20384][SQL] Support value class in schema ...

2018-10-27 Thread mt40
Github user mt40 commented on a diff in the pull request: https://github.com/apache/spark/pull/22309#discussion_r228713038 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala --- @@ -622,6 +654,14 @@ object ScalaReflection extends

[GitHub] spark pull request #22309: [SPARK-20384][SQL] Support value class in schema ...

2018-10-27 Thread mt40
Github user mt40 commented on a diff in the pull request: https://github.com/apache/spark/pull/22309#discussion_r228713022 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala --- @@ -128,6 +128,16 @@ object ScalaReflection extends

[GitHub] spark issue #22666: [SPARK-25672][SQL] schema_of_csv() - schema inference fr...

2018-10-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22666 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22666: [SPARK-25672][SQL] schema_of_csv() - schema inference fr...

2018-10-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22666 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98125/ Test PASSed. ---

[GitHub] spark issue #22666: [SPARK-25672][SQL] schema_of_csv() - schema inference fr...

2018-10-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22666 **[Test build #98125 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98125/testReport)** for PR 22666 at commit

[GitHub] spark pull request #22425: [SPARK-23367][Build] Include python document styl...

2018-10-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/22425 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #22425: [SPARK-23367][Build] Include python document style check...

2018-10-27 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/22425 Merged to master. Anyone who feels like then addressing the style warnings, some that may be easy to address, go ahead. --- - To

[GitHub] spark pull request #22425: [SPARK-23367][Build] Include python document styl...

2018-10-27 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/22425#discussion_r228712794 --- Diff: dev/lint-python --- @@ -99,6 +104,29 @@ else echo "flake8 checks passed." fi +# Check python document style, skip check if

[GitHub] spark pull request #22850: [MINOR][DOC] Fix comment error of HiveUtils

2018-10-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/22850 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #22850: [MINOR][DOC] Fix comment error of HiveUtils

2018-10-27 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/22850 Merged to master --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #22853: [SPARK-25845][SQL] Fix MatchError for calendar interval ...

2018-10-27 Thread jiangxb1987
Github user jiangxb1987 commented on the issue: https://github.com/apache/spark/pull/22853 Also cc @gatorsmile @cloud-fan @hvanhovell --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For

[GitHub] spark issue #22860: Branch 2.4

2018-10-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22860 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22860: Branch 2.4

2018-10-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22860 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22860: Branch 2.4

2018-10-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22860 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #22860: Branch 2.4

2018-10-27 Thread sarojchand
GitHub user sarojchand opened a pull request: https://github.com/apache/spark/pull/22860 Branch 2.4 ## What changes were proposed in this pull request? (Please fill in changes proposed in this fix) ## How was this patch tested? (Please explain how this

[GitHub] spark issue #22859: Branch 2.2

2018-10-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22859 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22859: Branch 2.2

2018-10-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22859 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22859: Branch 2.2

2018-10-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22859 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #22859: Branch 2.2

2018-10-27 Thread sarojchand
GitHub user sarojchand opened a pull request: https://github.com/apache/spark/pull/22859 Branch 2.2 ## What changes were proposed in this pull request? (Please fill in changes proposed in this fix) ## How was this patch tested? (Please explain how this

[GitHub] spark issue #22845: [SPARK-25848][SQL][TEST] Refactor CSVBenchmarks to use m...

2018-10-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22845 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22845: [SPARK-25848][SQL][TEST] Refactor CSVBenchmarks to use m...

2018-10-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22845 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98124/ Test PASSed. ---

[GitHub] spark issue #22845: [SPARK-25848][SQL][TEST] Refactor CSVBenchmarks to use m...

2018-10-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22845 **[Test build #98124 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98124/testReport)** for PR 22845 at commit

[GitHub] spark issue #22844: [SPARK-25847][SQL][TEST] Refactor JSONBenchmarks to use ...

2018-10-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22844 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22844: [SPARK-25847][SQL][TEST] Refactor JSONBenchmarks to use ...

2018-10-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22844 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98123/ Test PASSed. ---

[GitHub] spark issue #22844: [SPARK-25847][SQL][TEST] Refactor JSONBenchmarks to use ...

2018-10-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22844 **[Test build #98123 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98123/testReport)** for PR 22844 at commit

[GitHub] spark issue #22755: [SPARK-25755][SQL][Test] Supplementation of non-CodeGen ...

2018-10-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22755 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98122/ Test PASSed. ---

[GitHub] spark issue #22858: [SPARK-24709][SQL][2.4] use str instead of basestring in...

2018-10-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22858 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22755: [SPARK-25755][SQL][Test] Supplementation of non-CodeGen ...

2018-10-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22755 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22858: [SPARK-24709][SQL][2.4] use str instead of basestring in...

2018-10-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22858 **[Test build #98126 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98126/testReport)** for PR 22858 at commit

[GitHub] spark issue #22858: [SPARK-24709][SQL][2.4] use str instead of basestring in...

2018-10-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22858 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98126/ Test PASSed. ---

[GitHub] spark issue #22755: [SPARK-25755][SQL][Test] Supplementation of non-CodeGen ...

2018-10-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22755 **[Test build #98122 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98122/testReport)** for PR 22755 at commit

[GitHub] spark issue #22858: [SPARK-24709][SQL][2.4] use str instead of basestring in...

2018-10-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22858 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22858: [SPARK-24709][SQL][2.4] use str instead of basestring in...

2018-10-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22858 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #22858: [SPARK-24709][SQL][2.4] use str instead of basestring in...

2018-10-27 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/22858 BTW the `from_csv` added in 3.0 also use `basestring`, maybe we should update it as well in master branch. --- - To

[GitHub] spark issue #22857: [SPARK-25860][SQL] Replace Literal(null, _) with FalseLi...

2018-10-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22857 **[Test build #98127 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98127/testReport)** for PR 22857 at commit

[GitHub] spark issue #22858: [SPARK-24709][SQL][2.4] use str instead of basestring in...

2018-10-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22858 **[Test build #98126 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98126/testReport)** for PR 22858 at commit

[GitHub] spark issue #22857: [SPARK-25860][SQL] Replace Literal(null, _) with FalseLi...

2018-10-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22857 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22857: [SPARK-25860][SQL] Replace Literal(null, _) with FalseLi...

2018-10-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22857 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #22858: [SPARK-24709][SQL][2.4] use str instead of basestring in...

2018-10-27 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/22858 cc @HyukjinKwon @gatorsmile --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark pull request #22858: [SPARK-24709][SQL][2.4] use str instead of basest...

2018-10-27 Thread cloud-fan
GitHub user cloud-fan opened a pull request: https://github.com/apache/spark/pull/22858 [SPARK-24709][SQL][2.4] use str instead of basestring ## What changes were proposed in this pull request? after backport https://github.com/apache/spark/pull/22775 to 2.4, the 2.4 sbt

[GitHub] spark pull request #22857: [SPARK-25860][SQL] Replace Literal(null, _) with ...

2018-10-27 Thread aokolnychyi
GitHub user aokolnychyi opened a pull request: https://github.com/apache/spark/pull/22857 [SPARK-25860][SQL] Replace Literal(null, _) with FalseLiteral whenever possible ## What changes were proposed in this pull request? This PR proposes a new optimization rule that

[GitHub] spark pull request #22809: [SPARK-19851][SQL] Add support for EVERY and ANY ...

2018-10-27 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/22809#discussion_r228709483 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/UnevaluableAggs.scala --- @@ -0,0 +1,62 @@ +/* + *

[GitHub] spark issue #21157: [SPARK-22674][PYTHON] Removed the namedtuple pickling pa...

2018-10-27 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/21157 Adding @gatorsmile and @cloud-fan as well since this might be potentially breaking changes for 3.0 release (it affects RDD operation only with namedtuple in certain case tho) ---

[GitHub] spark issue #21157: [SPARK-22674][PYTHON] Removed the namedtuple pickling pa...

2018-10-27 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/21157 And you can also run profiler to show the performance effect. See https://github.com/apache/spark/pull/19246#discussion_r139874732 to run the profile ---

[GitHub] spark issue #21157: [SPARK-22674][PYTHON] Removed the namedtuple pickling pa...

2018-10-27 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/21157 You can just replace it to CloudPickler, remove changes at tests, and push that commit here to show no case is broken --- -

[GitHub] spark issue #22666: [SPARK-25672][SQL] schema_of_csv() - schema inference fr...

2018-10-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22666 **[Test build #98125 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98125/testReport)** for PR 22666 at commit

[GitHub] spark issue #22666: [SPARK-25672][SQL] schema_of_csv() - schema inference fr...

2018-10-27 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/22666 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

<    1   2   3   4   >