GitHub user mgaido91 opened a pull request:
https://github.com/apache/spark/pull/23234
[SPARK-26233][SQL][BACKPORT-2.2] CheckOverflow when encoding a decimal value
## What changes were proposed in this pull request?
When we encode a Decimal from external source we don't
Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/23234
cc @cloud-fan @dongjoon-hyun
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23232
**[Test build #99716 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99716/testReport)**
for PR 23232 at commit
Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/23233
cc @cloud-fan @dongjoon-hyun
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
GitHub user mgaido91 opened a pull request:
https://github.com/apache/spark/pull/23233
[SPARK-26233][SQL][BACKPORT-2.3] CheckOverflow when encoding a decimal value
## What changes were proposed in this pull request?
When we encode a Decimal from external source we
Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/23232
cc @cloud-fan @dongjoon-hyun
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
GitHub user mgaido91 opened a pull request:
https://github.com/apache/spark/pull/23232
[SPARK-26233][SQL][BACKPORT-2.4] CheckOverflow when encoding a decimal value
When we encode a Decimal from external source we don't check for overflow.
That method is useful not only in order to
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/23229
I don't think it's worth to change naming the variable in a single PR.
Let's do that when we fix some codes around here, or let other people try to
fix later.
---
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/23224
Can we file a JIRA? I think it's not minor.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/23230
Oh, the original one was 3.0. Although this doc change can go to branch-2.4
alone as well, let me revert it in branch-2.4 for management simplicity.
---
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/23230
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23159
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23159
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/23230
Merged to master and branch-2.4.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23196
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23196
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23159
**[Test build #99715 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99715/testReport)**
for PR 23159 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23196
**[Test build #99714 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99714/testReport)**
for PR 23196 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22957
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22957
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22957
**[Test build #99713 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99713/testReport)**
for PR 22957 at commit
Github user heary-cao commented on the issue:
https://github.com/apache/spark/pull/23229
ok to test
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23231
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23231
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/23213
how about `wholeStage=false, factoryMode=CODE_ONLY`? I think it's different
from `wholeStage=false, factoryMode=NO_CODEGEN`.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23231
**[Test build #99712 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99712/testReport)**
for PR 23231 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23230
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23230
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99710/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23230
**[Test build #99710 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99710/testReport)**
for PR 23230 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23224
**[Test build #99711 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99711/testReport)**
for PR 23224 at commit
Github user heary-cao commented on the issue:
https://github.com/apache/spark/pull/23224
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23230
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99706/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23230
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23230
**[Test build #99706 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99706/testReport)**
for PR 23230 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23230
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23230
**[Test build #99710 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99710/testReport)**
for PR 23230 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23231
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23230
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23231
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23231
**[Test build #99709 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99709/testReport)**
for PR 23231 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23231
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99709/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23231
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user heary-cao commented on the issue:
https://github.com/apache/spark/pull/23229
ok to test
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23230
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99705/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23230
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/23231#discussion_r239011539
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/OneHotEncoderEstimator.scala
---
@@ -0,0 +1,91 @@
+/*
+ * Licensed to the Apache
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23231
**[Test build #99709 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99709/testReport)**
for PR 23231 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23230
**[Test build #99705 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99705/testReport)**
for PR 23230 at commit
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/23231
cc @srowen @dbtsai
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user MaxGekk commented on a diff in the pull request:
https://github.com/apache/spark/pull/23196#discussion_r239010321
--- Diff:
sql/hive/compatibility/src/test/scala/org/apache/spark/sql/hive/execution/HiveCompatibilitySuite.scala
---
@@ -49,8 +49,8 @@ class
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23231
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23231
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23163
Build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23231
**[Test build #99707 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99707/testReport)**
for PR 23231 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23163
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23163
**[Test build #99708 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99708/testReport)**
for PR 23163 at commit
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/23231#discussion_r239008438
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/feature/OneHotEncoderEstimatorSuite.scala
---
@@ -0,0 +1,423 @@
+/*
+ * Licensed to the Apache
Github user heary-cao commented on the issue:
https://github.com/apache/spark/pull/23163
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
GitHub user viirya opened a pull request:
https://github.com/apache/spark/pull/23231
[SPARK-26273][ML] Add OneHotEncoderEstimator as alias to OneHotEncoder
## What changes were proposed in this pull request?
SPARK-26133 removed deprecated OneHotEncoder and renamed
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23230
**[Test build #99706 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99706/testReport)**
for PR 23230 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23230
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/23213
Yes, I am wondering too: which is the difference between:
`spark.sql.codegen.wholeStage=false,spark.sql.codegen.factoryMode=NO_CODEGEN`
and
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23230
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23230
**[Test build #99705 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99705/testReport)**
for PR 23230 at commit
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/23230
cc @HyukjinKwon @srowen
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
GitHub user viirya opened a pull request:
https://github.com/apache/spark/pull/23230
[SPARK-26133][ML][Followup] Fix doc for OneHotEncoder
## What changes were proposed in this pull request?
This fixes doc of renamed OneHotEncoder in PySpark.
## How was this patch
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/23213
Sorry, my bad; it was longer than the current master by ~2 times. That's
because the current master has already run two config set patterns
(`wholeStage=true,factoryMode=CODEGEN_ONLY` and
Github user gaborgsomogyi commented on a diff in the pull request:
https://github.com/apache/spark/pull/23195#discussion_r238995809
--- Diff: docs/structured-streaming-kafka-integration.md ---
@@ -624,3 +624,57 @@ For experimenting on `spark-shell`, you can also use
`--packages`
Github user gaborgsomogyi commented on a diff in the pull request:
https://github.com/apache/spark/pull/23195#discussion_r238995441
--- Diff: docs/structured-streaming-kafka-integration.md ---
@@ -624,3 +624,57 @@ For experimenting on `spark-shell`, you can also use
`--packages`
Github user gaborgsomogyi commented on a diff in the pull request:
https://github.com/apache/spark/pull/23195#discussion_r238995312
--- Diff: docs/structured-streaming-kafka-integration.md ---
@@ -624,3 +624,57 @@ For experimenting on `spark-shell`, you can also use
`--packages`
Github user gaborgsomogyi commented on a diff in the pull request:
https://github.com/apache/spark/pull/23195#discussion_r238994314
--- Diff: docs/structured-streaming-kafka-integration.md ---
@@ -624,3 +624,56 @@ For experimenting on `spark-shell`, you can also use
`--packages`
Github user gaborgsomogyi commented on the issue:
https://github.com/apache/spark/pull/22952
@HeartSaVioR @steveloughran
As I see not only `*` and `?` missing but `[]` also.
* Having glob parser in spark and supporting it I think it's too heavy and
brittle.
*
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23229
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23229
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23229
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
GitHub user wangjiaochun opened a pull request:
https://github.com/apache/spark/pull/23229
[MINOR][CORE] Modify some field name because it may be cause confusion
## What changes were proposed in this pull request?
There is different field name style for tracking allocated data
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23227
**[Test build #99704 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99704/testReport)**
for PR 23227 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23227
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23227
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23228
**[Test build #99703 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99703/testReport)**
for PR 23228 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23228
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23228
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
GitHub user 10110346 opened a pull request:
https://github.com/apache/spark/pull/23228
[MINOR][DOC]The condition description of serialized shuffle is not very
accurate
## What changes were proposed in this pull request?
`1. The shuffle dependency specifies no aggregation or
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/23227
ok to test
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23227
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23227
**[Test build #99702 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99702/testReport)**
for PR 23227 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23227
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/23226#discussion_r238977650
--- Diff:
core/src/test/java/org/apache/spark/unsafe/map/AbstractBytesToBytesMapSuite.java
---
@@ -622,6 +622,17 @@ public void
Github user heary-cao commented on the issue:
https://github.com/apache/spark/pull/23227
cc @cloud-fan, @gatorsmile, @hvanhovell ,@davies
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/23225
Also, it needs a JIRA. it's not minor one.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23227
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/23225
How come existing tests cover if the empty file is created or not?
---
-
To unsubscribe, e-mail:
GitHub user heary-cao opened a pull request:
https://github.com/apache/spark/pull/23227
[SPARK-16958][FOLLOW-UP][SQL] remove unuse object SparkPlan
## What changes were proposed in this pull request?
this code come from PR: https://github.com/apache/spark/pull/11190,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23222
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23222
**[Test build #99701 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99701/testReport)**
for PR 23222 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23222
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/23222
Retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22683
**[Test build #99700 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99700/testReport)**
for PR 22683 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23226
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23226
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
501 - 600 of 614 matches
Mail list logo