[GitHub] spark pull request #21526: [SPARK-24515][CORE] No need to warning when outpu...

2018-11-14 Thread caneGuy
Github user caneGuy closed the pull request at: https://github.com/apache/spark/pull/21526 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #21790: [SPARK-24544][SQL] Print actual failure cause when look ...

2018-10-22 Thread caneGuy
Github user caneGuy commented on the issue: https://github.com/apache/spark/pull/21790 I will fix the test and add unit test as soon as possible @maropu I am too busy last month,sorry for the late reply. Thanks for your comments and your precious time again

[GitHub] spark issue #21790: [SPARK-24544][SQL] Print actual failure cause when look ...

2018-08-28 Thread caneGuy
Github user caneGuy commented on the issue: https://github.com/apache/spark/pull/21790 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h

[GitHub] spark issue #21790: [SPARK-24544][SQL] Print actual failure cause when look ...

2018-07-17 Thread caneGuy
Github user caneGuy commented on the issue: https://github.com/apache/spark/pull/21790 @maropu Could you help review this?Thanks since https://github.com/apache/spark/pull/21552 i used `git merge` so reopen

[GitHub] spark pull request #21790: [SPARK-24544][SQL] Print actual failure cause whe...

2018-07-17 Thread caneGuy
GitHub user caneGuy opened a pull request: https://github.com/apache/spark/pull/21790 [SPARK-24544][SQL] Print actual failure cause when look up function f… ## What changes were proposed in this pull request? When we operate as below: ` 0: jdbc:hive2://xxx

[GitHub] spark pull request #21552: [SPARK-24544][SQL] Print actual failure cause whe...

2018-07-17 Thread caneGuy
Github user caneGuy closed the pull request at: https://github.com/apache/spark/pull/21552 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #21664: [SPARK-24687][CORE] NoClassDefFoundError will not be cat...

2018-07-17 Thread caneGuy
Github user caneGuy commented on the issue: https://github.com/apache/spark/pull/21664 I think this patch will fix 'job hanging' problem @jerryshao @jiangxb1987 --- - To unsubscribe, e-mail: reviews-unsubscr

[GitHub] spark pull request #21263: [SPARK-24084][ThriftServer] Add job group id for ...

2018-07-12 Thread caneGuy
Github user caneGuy closed the pull request at: https://github.com/apache/spark/pull/21263 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #21526: [SPARK-24515][CORE] No need to warning when outpu...

2018-07-12 Thread caneGuy
Github user caneGuy commented on a diff in the pull request: https://github.com/apache/spark/pull/21526#discussion_r202006002 --- Diff: core/src/main/scala/org/apache/spark/internal/config/package.scala --- @@ -357,6 +357,11 @@ package object config { .intConf

[GitHub] spark pull request #21526: [SPARK-24515][CORE] No need to warning when outpu...

2018-07-12 Thread caneGuy
Github user caneGuy commented on a diff in the pull request: https://github.com/apache/spark/pull/21526#discussion_r202005902 --- Diff: core/src/main/scala/org/apache/spark/internal/config/package.scala --- @@ -357,6 +357,11 @@ package object config { .intConf

[GitHub] spark issue #21664: [SPARK-24687][CORE] NoClassDefFoundError will not be cat...

2018-07-12 Thread caneGuy
Github user caneGuy commented on the issue: https://github.com/apache/spark/pull/21664 The problem is that the job hanging,and user will be misleading since no more information print. --- - To unsubscribe, e-mail

[GitHub] spark pull request #21552: [SPARK-24544][SQL] Print actual failure cause whe...

2018-07-12 Thread caneGuy
Github user caneGuy commented on a diff in the pull request: https://github.com/apache/spark/pull/21552#discussion_r201970972 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveSessionCatalog.scala --- @@ -131,6 +132,8 @@ private[sql] class HiveSessionCatalog

[GitHub] spark issue #21664: [SPARK-24687][CORE] NoClassDefFoundError will not be cat...

2018-07-12 Thread caneGuy
Github user caneGuy commented on the issue: https://github.com/apache/spark/pull/21664 @jerryshao I think at least we should print a warning,not let job hanging?Thanks --- - To unsubscribe, e-mail: reviews-unsubscr

[GitHub] spark pull request #21526: [SPARK-24515][CORE] No need to warning when outpu...

2018-07-12 Thread caneGuy
Github user caneGuy commented on a diff in the pull request: https://github.com/apache/spark/pull/21526#discussion_r201963160 --- Diff: core/src/main/scala/org/apache/spark/rdd/PairRDDFunctions.scala --- @@ -1053,7 +1053,10 @@ class PairRDDFunctions[K, V](self: RDD[(K, V

[GitHub] spark pull request #21526: [SPARK-24515][CORE] No need to warning when outpu...

2018-07-12 Thread caneGuy
Github user caneGuy commented on a diff in the pull request: https://github.com/apache/spark/pull/21526#discussion_r201962635 --- Diff: core/src/main/scala/org/apache/spark/rdd/PairRDDFunctions.scala --- @@ -1053,7 +1053,10 @@ class PairRDDFunctions[K, V](self: RDD[(K, V

[GitHub] spark issue #21664: [SPARK-24687][CORE] NoClassDefFoundError will not be cat...

2018-07-12 Thread caneGuy
Github user caneGuy commented on the issue: https://github.com/apache/spark/pull/21664 @jiangxb1987 Thanks, i update the description of this pr.Stage 33 never be scheduled.and job not abort --- - To unsubscribe, e

[GitHub] spark issue #21664: [SPARK-24687][CORE] NoClassDefFoundError will not be cat...

2018-07-10 Thread caneGuy
Github user caneGuy commented on the issue: https://github.com/apache/spark/pull/21664 I have post an image on the jira @jiangxb1987 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #21664: [SPARK-24678][CORE] NoClassDefFoundError will not...

2018-07-07 Thread caneGuy
Github user caneGuy commented on a diff in the pull request: https://github.com/apache/spark/pull/21664#discussion_r200828384 --- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala --- @@ -1049,6 +1049,13 @@ class DAGScheduler( abortStage(stage, s

[GitHub] spark issue #21552: [SPARK-24544][SQL] Print actual failure cause when look ...

2018-07-07 Thread caneGuy
Github user caneGuy commented on the issue: https://github.com/apache/spark/pull/21552 @maropu May be i will do this check?As @cloud-fan mentioned. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

[GitHub] spark pull request #21552: [SPARK-24544][SQL] Print actual failure cause whe...

2018-07-07 Thread caneGuy
Github user caneGuy commented on a diff in the pull request: https://github.com/apache/spark/pull/21552#discussion_r200828333 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveSessionCatalog.scala --- @@ -131,6 +132,8 @@ private[sql] class HiveSessionCatalog

[GitHub] spark issue #21664: [SPARK-24678][CORE] NoClassDefFoundError will not be cat...

2018-07-04 Thread caneGuy
Github user caneGuy commented on the issue: https://github.com/apache/spark/pull/21664 It was caused by shading and jar missing.I will post an example later. Thanks @jerryshao --- - To unsubscribe, e-mail

[GitHub] spark pull request #21552: [SPARK-24544][SQL] Print actual failure cause whe...

2018-07-04 Thread caneGuy
Github user caneGuy commented on a diff in the pull request: https://github.com/apache/spark/pull/21552#discussion_r200157051 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveSessionCatalog.scala --- @@ -131,6 +132,8 @@ private[sql] class HiveSessionCatalog

[GitHub] spark issue #21664: [SPARK-24678][CORE] NoClassDefFoundError will not be cat...

2018-06-29 Thread caneGuy
Github user caneGuy commented on the issue: https://github.com/apache/spark/pull/21664 cc @jiangxb1987 @jerryshao Could you help review this?Thanks --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

[GitHub] spark pull request #21664: [SPARK-24678][CORE] NoClassDefFoundError will not...

2018-06-28 Thread caneGuy
GitHub user caneGuy opened a pull request: https://github.com/apache/spark/pull/21664 [SPARK-24678][CORE] NoClassDefFoundError will not be catch up which will ca… …use job hang ## What changes were proposed in this pull request? When NoClassDefFoundError thrown

[GitHub] spark pull request #21552: [SPARK-24544][SQL] Print actual failure cause whe...

2018-06-19 Thread caneGuy
Github user caneGuy commented on a diff in the pull request: https://github.com/apache/spark/pull/21552#discussion_r196378408 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveSessionCatalog.scala --- @@ -131,6 +132,8 @@ private[sql] class HiveSessionCatalog

[GitHub] spark issue #21552: [SPARK-24544][SQL] Print actual failure cause when look ...

2018-06-14 Thread caneGuy
Github user caneGuy commented on the issue: https://github.com/apache/spark/pull/21552 cc @cloud-fan Could help review this?Thanks --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #21552: [SPARK-24544][SQL] Print actual failure cause whe...

2018-06-13 Thread caneGuy
GitHub user caneGuy opened a pull request: https://github.com/apache/spark/pull/21552 [SPARK-24544][SQL] Print actual failure cause when look up function failed ## What changes were proposed in this pull request? When we operate as below: ` 0: jdbc:hive2://xxx

[GitHub] spark pull request #21526: [SPARK-24515][CORE] No need to warning when outpu...

2018-06-11 Thread caneGuy
GitHub user caneGuy opened a pull request: https://github.com/apache/spark/pull/21526 [SPARK-24515][CORE] No need to warning when output commit coordination enabled ## What changes were proposed in this pull request? No need to warning user when output commit coordination

[GitHub] spark pull request #21263: [SPARK-24084][ThriftServer] Add job group id for ...

2018-05-07 Thread caneGuy
GitHub user caneGuy opened a pull request: https://github.com/apache/spark/pull/21263 [SPARK-24084][ThriftServer] Add job group id for sql statement through spark-sql ## What changes were proposed in this pull request? Add job group id for spark-sql mode ## How

[GitHub] spark pull request #21151: [SPARK-24083][YARN] Log stacktrace for uncaught e...

2018-04-25 Thread caneGuy
GitHub user caneGuy opened a pull request: https://github.com/apache/spark/pull/21151 [SPARK-24083][YARN] Log stacktrace for uncaught exception ## What changes were proposed in this pull request? Log stacktrace for uncaught exception ## How was this patch tested

[GitHub] spark pull request #21127: [SPARK-24052][CORE][UI] Add spark version informa...

2018-04-23 Thread caneGuy
Github user caneGuy closed the pull request at: https://github.com/apache/spark/pull/21127 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #21127: [SPARK-24052][CORE][UI] Add spark version information on...

2018-04-23 Thread caneGuy
Github user caneGuy commented on the issue: https://github.com/apache/spark/pull/21127 Ok i will close this pr. Thanks for your time @srowen @vanzin --- - To unsubscribe, e-mail: reviews-unsubscr

[GitHub] spark issue #21127: [SPARK-24052][CORE][UI] Add spark version information on...

2018-04-23 Thread caneGuy
Github user caneGuy commented on the issue: https://github.com/apache/spark/pull/21127 How about the other information? As mentioned,the build info @vanzin --- - To unsubscribe, e-mail: reviews-unsubscr

[GitHub] spark pull request #21128: [SPARK-24053][CORE] Support add subdirectory name...

2018-04-23 Thread caneGuy
Github user caneGuy closed the pull request at: https://github.com/apache/spark/pull/21128 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #21128: [SPARK-24053][CORE] Support add subdirectory named as us...

2018-04-23 Thread caneGuy
Github user caneGuy commented on the issue: https://github.com/apache/spark/pull/21128 Got it,thanks @vanzin --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail

[GitHub] spark issue #21127: [SPARK-24052][CORE][UI] Add spark version information on...

2018-04-23 Thread caneGuy
Github user caneGuy commented on the issue: https://github.com/apache/spark/pull/21127 It is version for the historyserver @vanzin May be i can reuse SparkBuildInfo? @srowen @vanzin Thanks

[GitHub] spark issue #21128: [SPARK-24053][CORE] Support add subdirectory named as us...

2018-04-23 Thread caneGuy
Github user caneGuy commented on the issue: https://github.com/apache/spark/pull/21128 @vanzin Thanks! Since we set the common staging dir as ``` hdfs://xxx/spark/xxx/staging ``` This patch will give us a directory for given user like: ``` hdfs://xxx/spark

[GitHub] spark pull request #21128: [SPARK-24053][CORE] Support add subdirectory name...

2018-04-23 Thread caneGuy
GitHub user caneGuy opened a pull request: https://github.com/apache/spark/pull/21128 [SPARK-24053][CORE] Support add subdirectory named as user name on staging directory ## What changes were proposed in this pull request? When we have multiple users on the same cluster,we

[GitHub] spark pull request #21127: [SPARK-24052][CORE][UI] Add spark version informa...

2018-04-23 Thread caneGuy
GitHub user caneGuy opened a pull request: https://github.com/apache/spark/pull/21127 [SPARK-24052][CORE][UI] Add spark version information on environment page ## What changes were proposed in this pull request? Since we may have multiple version in production cluster,we

[GitHub] spark pull request #20833: [SPARK-23692][SQL]Print metadata of files when in...

2018-03-19 Thread caneGuy
Github user caneGuy closed the pull request at: https://github.com/apache/spark/pull/20833 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #20845: [SPARK-23708][CORE] Correct comment for function addShut...

2018-03-19 Thread caneGuy
Github user caneGuy commented on the issue: https://github.com/apache/spark/pull/20845 Get it! @jerryshao Thanks! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail

[GitHub] spark issue #20845: [SPARK-23708][CORE] Correct comment for function addShut...

2018-03-18 Thread caneGuy
Github user caneGuy commented on the issue: https://github.com/apache/spark/pull/20845 @jiangxb1987 @Ngone51 Thanks! Any more comments? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

[GitHub] spark issue #20845: [SPARK-23708][CORE] Correct comment for function addShut...

2018-03-17 Thread caneGuy
Github user caneGuy commented on the issue: https://github.com/apache/spark/pull/20845 cc @cloud-fan @jerryshao --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail

[GitHub] spark pull request #20845: [SPARK-23708][CORE] Correct comment for function ...

2018-03-16 Thread caneGuy
GitHub user caneGuy opened a pull request: https://github.com/apache/spark/pull/20845 [SPARK-23708][CORE] Correct comment for function addShutDownHook in ShutdownHookManager ## What changes were proposed in this pull request? Comment below is not right

[GitHub] spark pull request #20833: [SPARK-23692][SQL]Print metadata of files when in...

2018-03-15 Thread caneGuy
GitHub user caneGuy opened a pull request: https://github.com/apache/spark/pull/20833 [SPARK-23692][SQL]Print metadata of files when infer schema failed ## What changes were proposed in this pull request? A trivial modify. Currently, when we had no input files to infer

[GitHub] spark pull request #20508: [SPARK-23335][SQL] Should not convert to double w...

2018-03-01 Thread caneGuy
Github user caneGuy closed the pull request at: https://github.com/apache/spark/pull/20508 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #20667: [SPARK-23508][CORE] Fix BlockmanagerId in case blockMana...

2018-02-28 Thread caneGuy
Github user caneGuy commented on the issue: https://github.com/apache/spark/pull/20667 Thanks @cloud-fan @jiangxb1987 @kiszk @Ngone51 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

[GitHub] spark pull request #20667: [SPARK-23508][CORE] Fix BlockmanagerId in case bl...

2018-02-27 Thread caneGuy
Github user caneGuy commented on a diff in the pull request: https://github.com/apache/spark/pull/20667#discussion_r171121778 --- Diff: core/src/main/scala/org/apache/spark/storage/BlockManagerId.scala --- @@ -132,10 +133,15 @@ private[spark] object BlockManagerId

[GitHub] spark pull request #20667: [SPARK-23508][CORE] Fix BlockmanagerId in case bl...

2018-02-27 Thread caneGuy
Github user caneGuy commented on a diff in the pull request: https://github.com/apache/spark/pull/20667#discussion_r170881808 --- Diff: core/src/main/scala/org/apache/spark/storage/BlockManagerId.scala --- @@ -132,10 +133,15 @@ private[spark] object BlockManagerId

[GitHub] spark pull request #20667: [SPARK-23508][CORE] Fix BlockmanagerId in case bl...

2018-02-27 Thread caneGuy
Github user caneGuy commented on a diff in the pull request: https://github.com/apache/spark/pull/20667#discussion_r170864215 --- Diff: core/src/main/scala/org/apache/spark/storage/BlockManagerId.scala --- @@ -132,10 +133,15 @@ private[spark] object BlockManagerId

[GitHub] spark pull request #20667: [SPARK-23508][CORE] Fix BlockmanagerId in case bl...

2018-02-26 Thread caneGuy
Github user caneGuy commented on a diff in the pull request: https://github.com/apache/spark/pull/20667#discussion_r170817107 --- Diff: core/src/main/scala/org/apache/spark/storage/BlockManagerId.scala --- @@ -132,10 +133,15 @@ private[spark] object BlockManagerId

[GitHub] spark issue #20667: [SPARK-23508][CORE] Fix BlockmanagerId in case blockMana...

2018-02-26 Thread caneGuy
Github user caneGuy commented on the issue: https://github.com/apache/spark/pull/20667 Update @jiangxb1987 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews

[GitHub] spark issue #20667: [SPARK-23508][CORE] Use softreference for BlockmanagerId...

2018-02-26 Thread caneGuy
Github user caneGuy commented on the issue: https://github.com/apache/spark/pull/20667 Nice @jiangxb1987 @cloud-fan I will modify later.Thanks! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

[GitHub] spark pull request #20667: [SPARK-23508][CORE] Use timeStampedHashMap for Bl...

2018-02-26 Thread caneGuy
Github user caneGuy commented on a diff in the pull request: https://github.com/apache/spark/pull/20667#discussion_r170516775 --- Diff: core/src/main/scala/org/apache/spark/storage/BlockManagerId.scala --- @@ -132,10 +133,15 @@ private[spark] object BlockManagerId

[GitHub] spark issue #20667: [SPARK-23508][CORE] Use timeStampedHashMap for Blockmana...

2018-02-26 Thread caneGuy
Github user caneGuy commented on the issue: https://github.com/apache/spark/pull/20667 @cloud-fan I just find commit log below `Modified StorageLevel and BlockManagerId to cache common objects and use cached object while deserializing.` I can't figure out why we need cache

[GitHub] spark pull request #20667: [SPARK-23508][CORE] Use timeStampedHashMap for Bl...

2018-02-24 Thread caneGuy
GitHub user caneGuy opened a pull request: https://github.com/apache/spark/pull/20667 [SPARK-23508][CORE] Use timeStampedHashMap for BlockmanagerId in case blockManagerIdCache… … cause oom ## What changes were proposed in this pull request? blockManagerIdCache

[GitHub] spark pull request #20508: [SPARK-23335][SQL] Should not convert to double w...

2018-02-07 Thread caneGuy
Github user caneGuy commented on a diff in the pull request: https://github.com/apache/spark/pull/20508#discussion_r166839312 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala --- @@ -327,6 +327,14 @@ object TypeCoercion

[GitHub] spark pull request #20508: [SPARK-23335][SQL] Should not convert to double w...

2018-02-05 Thread caneGuy
Github user caneGuy commented on a diff in the pull request: https://github.com/apache/spark/pull/20508#discussion_r166182782 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala --- @@ -327,6 +327,14 @@ object TypeCoercion

[GitHub] spark pull request #20508: [SPARK-23335][SQL] Should not convert to double w...

2018-02-05 Thread caneGuy
GitHub user caneGuy opened a pull request: https://github.com/apache/spark/pull/20508 [SPARK-23335][SQL] Should not convert to double when there is an Integra… …l value in BinaryArithmetic which will loss precison ## What changes were proposed in this pull request

[GitHub] spark issue #20292: [SPARK-23129][CORE] Make deserializeStream of DiskMapIte...

2018-01-25 Thread caneGuy
Github user caneGuy commented on the issue: https://github.com/apache/spark/pull/20292 Thanks for your time! @cloud-fan @jerryshao @jiangxb1987 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

[GitHub] spark pull request #20292: [SPARK-23129][CORE] Make deserializeStream of Dis...

2018-01-22 Thread caneGuy
Github user caneGuy commented on a diff in the pull request: https://github.com/apache/spark/pull/20292#discussion_r163160055 --- Diff: core/src/main/scala/org/apache/spark/util/collection/ExternalAppendOnlyMap.scala --- @@ -463,21 +463,21 @@ class ExternalAppendOnlyMap[K, V, C

[GitHub] spark pull request #20292: [SPARK-23129][CORE] Make deserializeStream of Dis...

2018-01-22 Thread caneGuy
Github user caneGuy commented on a diff in the pull request: https://github.com/apache/spark/pull/20292#discussion_r163146577 --- Diff: core/src/main/scala/org/apache/spark/util/collection/ExternalAppendOnlyMap.scala --- @@ -463,21 +463,21 @@ class ExternalAppendOnlyMap[K, V, C

[GitHub] spark issue #20292: [SPARK-23129][CORE] Make deserializeStream of DiskMapIte...

2018-01-21 Thread caneGuy
Github user caneGuy commented on the issue: https://github.com/apache/spark/pull/20292 Ping @jiangxb1987 could you help review this?thanks too much! --- - To unsubscribe, e-mail: reviews-unsubscr

[GitHub] spark pull request #20292: [SPARK-23129][CORE] Make deserializeStream of Dis...

2018-01-17 Thread caneGuy
Github user caneGuy commented on a diff in the pull request: https://github.com/apache/spark/pull/20292#discussion_r162235896 --- Diff: core/src/main/scala/org/apache/spark/util/collection/ExternalAppendOnlyMap.scala --- @@ -509,8 +509,8 @@ class ExternalAppendOnlyMap[K, V, C

[GitHub] spark pull request #20292: [SPARK-23129][CORE] Make deserializeStream of Dis...

2018-01-17 Thread caneGuy
Github user caneGuy commented on a diff in the pull request: https://github.com/apache/spark/pull/20292#discussion_r162235297 --- Diff: core/src/main/scala/org/apache/spark/util/collection/ExternalAppendOnlyMap.scala --- @@ -509,8 +509,8 @@ class ExternalAppendOnlyMap[K, V, C

[GitHub] spark pull request #20292: [SPARK-23129][CORE] Make deserializeStream of Dis...

2018-01-17 Thread caneGuy
GitHub user caneGuy opened a pull request: https://github.com/apache/spark/pull/20292 [SPARK-23129][CORE] Make deserializeStream of DiskMapIterator init lazily ## What changes were proposed in this pull request? Currently,the deserializeStream in ExternalAppendOnlyMap

[GitHub] spark pull request #19764: [SPARK-22539][SQL] Add second order for rangepart...

2018-01-15 Thread caneGuy
Github user caneGuy closed the pull request at: https://github.com/apache/spark/pull/19764 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #19764: [SPARK-22539][SQL] Add second order for rangepartitioner...

2018-01-03 Thread caneGuy
Github user caneGuy commented on the issue: https://github.com/apache/spark/pull/19764 Thanks @hvanhovell .IIUC, you mean that adding second order will break the contract of the range partitioner generated by `ShuffleExchange` ?If that, i agree with the opinion。 And sorry

[GitHub] spark issue #19764: [SPARK-22539][SQL] Add second order for rangepartitioner...

2018-01-02 Thread caneGuy
Github user caneGuy commented on the issue: https://github.com/apache/spark/pull/19764 Ping @srowen can you help review this?Thanks too much --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

[GitHub] spark pull request #19942: [SPARK-22754][DEPLOY] Check whether spark.executo...

2017-12-13 Thread caneGuy
Github user caneGuy commented on a diff in the pull request: https://github.com/apache/spark/pull/19942#discussion_r156697267 --- Diff: core/src/main/scala/org/apache/spark/SparkConf.scala --- @@ -564,6 +564,14 @@ class SparkConf(loadDefaults: Boolean) extends Cloneable

[GitHub] spark pull request #19942: [SPARK-22754][DEPLOY] Check whether spark.executo...

2017-12-13 Thread caneGuy
Github user caneGuy commented on a diff in the pull request: https://github.com/apache/spark/pull/19942#discussion_r156627509 --- Diff: core/src/main/scala/org/apache/spark/SparkConf.scala --- @@ -564,6 +564,15 @@ class SparkConf(loadDefaults: Boolean) extends Cloneable

[GitHub] spark pull request #19942: [SPARK-22754][DEPLOY] Check whether spark.executo...

2017-12-13 Thread caneGuy
Github user caneGuy commented on a diff in the pull request: https://github.com/apache/spark/pull/19942#discussion_r156627486 --- Diff: core/src/main/scala/org/apache/spark/SparkConf.scala --- @@ -564,6 +564,15 @@ class SparkConf(loadDefaults: Boolean) extends Cloneable

[GitHub] spark pull request #19942: [SPARK-22754][DEPLOY] Check whether spark.executo...

2017-12-11 Thread caneGuy
Github user caneGuy commented on a diff in the pull request: https://github.com/apache/spark/pull/19942#discussion_r156272847 --- Diff: core/src/main/scala/org/apache/spark/SparkConf.scala --- @@ -564,6 +564,13 @@ class SparkConf(loadDefaults: Boolean) extends Cloneable

[GitHub] spark pull request #19942: [SPARK-22754][DEPLOY] Check whether spark.executo...

2017-12-11 Thread caneGuy
Github user caneGuy commented on a diff in the pull request: https://github.com/apache/spark/pull/19942#discussion_r156272829 --- Diff: core/src/main/scala/org/apache/spark/SparkConf.scala --- @@ -564,6 +564,13 @@ class SparkConf(loadDefaults: Boolean) extends Cloneable

[GitHub] spark pull request #19942: [SPARK-22754][DEPLOY] Check whether spark.executo...

2017-12-11 Thread caneGuy
Github user caneGuy commented on a diff in the pull request: https://github.com/apache/spark/pull/19942#discussion_r156272812 --- Diff: core/src/main/scala/org/apache/spark/SparkConf.scala --- @@ -564,6 +564,13 @@ class SparkConf(loadDefaults: Boolean) extends Cloneable

[GitHub] spark pull request #19942: [SPARK-22754][DEPLOY] Check whether spark.executo...

2017-12-11 Thread caneGuy
Github user caneGuy commented on a diff in the pull request: https://github.com/apache/spark/pull/19942#discussion_r156270767 --- Diff: core/src/main/scala/org/apache/spark/SparkConf.scala --- @@ -564,6 +564,13 @@ class SparkConf(loadDefaults: Boolean) extends Cloneable

[GitHub] spark pull request #19942: [SPARK-22754][DEPLOY] Check whether spark.executo...

2017-12-11 Thread caneGuy
Github user caneGuy commented on a diff in the pull request: https://github.com/apache/spark/pull/19942#discussion_r156268382 --- Diff: core/src/main/scala/org/apache/spark/SparkConf.scala --- @@ -564,6 +564,18 @@ class SparkConf(loadDefaults: Boolean) extends Cloneable

[GitHub] spark pull request #19942: [SPARK-22754][DEPLOY] Check whether spark.executo...

2017-12-11 Thread caneGuy
Github user caneGuy commented on a diff in the pull request: https://github.com/apache/spark/pull/19942#discussion_r156264833 --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmitArguments.scala --- @@ -291,6 +291,18 @@ private[deploy] class SparkSubmitArguments(args

[GitHub] spark pull request #19942: [SPARK-22754][DEPLOY] Check whether spark.executo...

2017-12-11 Thread caneGuy
Github user caneGuy commented on a diff in the pull request: https://github.com/apache/spark/pull/19942#discussion_r156250974 --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmitArguments.scala --- @@ -291,6 +291,18 @@ private[deploy] class SparkSubmitArguments(args

[GitHub] spark pull request #19942: [SPARK-22754][DEPLOY] Check whether spark.executo...

2017-12-11 Thread caneGuy
Github user caneGuy commented on a diff in the pull request: https://github.com/apache/spark/pull/19942#discussion_r156105135 --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmitArguments.scala --- @@ -291,6 +291,18 @@ private[deploy] class SparkSubmitArguments(args

[GitHub] spark pull request #19942: [SPARK-22754][DEPLOY] Check whether spark.executo...

2017-12-11 Thread caneGuy
GitHub user caneGuy opened a pull request: https://github.com/apache/spark/pull/19942 [SPARK-22754][DEPLOY] Check whether spark.executor.heartbeatInterval bigger… … than spark.network.timeout or not ## What changes were proposed in this pull request

[GitHub] spark issue #19764: [SPARK-22539][SQL] Add second order for rangepartitioner...

2017-12-09 Thread caneGuy
Github user caneGuy commented on the issue: https://github.com/apache/spark/pull/19764 Ping --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h

[GitHub] spark issue #19764: [SPARK-22539][SQL] Add second order for rangepartitioner...

2017-11-30 Thread caneGuy
Github user caneGuy commented on the issue: https://github.com/apache/spark/pull/19764 @gczsjdy Added a simple example. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e

[GitHub] spark issue #19764: [SPARK-22539][SQL] Add second order for rangepartitioner...

2017-11-29 Thread caneGuy
Github user caneGuy commented on the issue: https://github.com/apache/spark/pull/19764 @gczsjdy Ok,i will post later. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e

[GitHub] spark issue #19764: [SPARK-22539][SQL] Add second order for rangepartitioner...

2017-11-26 Thread caneGuy
Github user caneGuy commented on the issue: https://github.com/apache/spark/pull/19764 Ping any admin help review this?Thanks --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19764: [SPARK-22539][SQL] Add second order for rangepartitioner...

2017-11-23 Thread caneGuy
Github user caneGuy commented on the issue: https://github.com/apache/spark/pull/19764 Firstly , thanks too much @hvanhovell . And sorry for replying so late since i have some other things to handle during these time. For the question, i think the ordering will not be broken.I

[GitHub] spark pull request #19764: [SPARK-22539][SQL] Add second order for rangepart...

2017-11-16 Thread caneGuy
Github user caneGuy commented on a diff in the pull request: https://github.com/apache/spark/pull/19764#discussion_r151375208 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateOrdering.scala --- @@ -193,14 +193,30 @@ object

[GitHub] spark pull request #19764: [SPARK-22539][SQL] Add second order for rangepart...

2017-11-16 Thread caneGuy
Github user caneGuy commented on a diff in the pull request: https://github.com/apache/spark/pull/19764#discussion_r151356810 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateOrdering.scala --- @@ -193,14 +193,30 @@ object

[GitHub] spark pull request #19764: [SPARK-22539][SQL] Add second order for rangepart...

2017-11-15 Thread caneGuy
GitHub user caneGuy opened a pull request: https://github.com/apache/spark/pull/19764 [SPARK-22539][SQL] Add second order for rangepartitioner since partition nu… …mber may be small if the specified key is skewed ## What changes were proposed in this pull request

[GitHub] spark issue #19625: [SPARK-22407][WEB-UI] Add rdd id column on storage page ...

2017-11-02 Thread caneGuy
Github user caneGuy commented on the issue: https://github.com/apache/spark/pull/19625 @HyukjinKwon @jiangxb1987 @srowen Any more problem?Thanks. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

[GitHub] spark pull request #19625: [SPARK-22407][WEB-UI] Add rdd id column on storag...

2017-11-01 Thread caneGuy
Github user caneGuy commented on a diff in the pull request: https://github.com/apache/spark/pull/19625#discussion_r148427237 --- Diff: core/src/main/scala/org/apache/spark/ui/storage/StoragePage.scala --- @@ -49,6 +49,7 @@ private[ui] class StoragePage(parent: StorageTab) extends

[GitHub] spark pull request #19625: [SPARK-22407][WEB-UI] Add rdd id column on storag...

2017-11-01 Thread caneGuy
GitHub user caneGuy opened a pull request: https://github.com/apache/spark/pull/19625 [SPARK-22407][WEB-UI] Add rdd id column on storage page to speed up navigating ## What changes were proposed in this pull request? Add rdd id column on storage page to speed up navigating

[GitHub] spark issue #19482: [SPARK-22264][DEPLOY] Add timeout for eventlog replaying...

2017-10-16 Thread caneGuy
Github user caneGuy commented on the issue: https://github.com/apache/spark/pull/19482 Ok,thanks @vanzin --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews

[GitHub] spark pull request #19482: [SPARK-22264][DEPLOY] Add timeout for eventlog re...

2017-10-16 Thread caneGuy
Github user caneGuy closed the pull request at: https://github.com/apache/spark/pull/19482 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #19482: [SPARK-22264][DEPLOY] Add timeout for eventlog replaying...

2017-10-15 Thread caneGuy
Github user caneGuy commented on the issue: https://github.com/apache/spark/pull/19482 Cloud you help review this? @vanzin Thanks. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #19482: [SPARK-22264][DEPLOY] Add timeout for eventlog re...

2017-10-12 Thread caneGuy
GitHub user caneGuy opened a pull request: https://github.com/apache/spark/pull/19482 [SPARK-22264][DEPLOY] Add timeout for eventlog replaying to avoid time-cons… …uming replaying which will cause historyserver unavailable ## What changes were proposed in this pull

[GitHub] spark pull request #19399: [SPARK-22175][WEB-UI] Add status column to histor...

2017-10-12 Thread caneGuy
Github user caneGuy closed the pull request at: https://github.com/apache/spark/pull/19399 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #19399: [SPARK-22175][WEB-UI] Add status column to history page

2017-10-12 Thread caneGuy
Github user caneGuy commented on the issue: https://github.com/apache/spark/pull/19399 All right, thanks for the comments and i agree with you.I will close this one. @jerryshao @ajbozarth @vanzin And try other solutions

[GitHub] spark issue #19399: [SPARK-22175][WEB-UI] Add status column to history page

2017-10-06 Thread caneGuy
Github user caneGuy commented on the issue: https://github.com/apache/spark/pull/19399 Ok i will wait for SPARK-18085 and think about log status more accurately @squito @ajbozarth Thanks. --- - To unsubscribe, e

[GitHub] spark pull request #19399: [SPARK-22175][WEB-UI] Add status column to histor...

2017-10-06 Thread caneGuy
Github user caneGuy commented on a diff in the pull request: https://github.com/apache/spark/pull/19399#discussion_r143114938 --- Diff: core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala --- @@ -850,6 +869,18 @@ private[history] class AppListingListener

  1   2   3   >