Github user cclauss commented on the issue:
https://github.com/apache/spark/pull/22231
@holdenk Can you please do me a big favor and create a separate PR that
makes sure that we are doing at least __flake8 . --count
--select=E901,E999,F821,F822,F823 --show-source --statistics__
Github user cclauss commented on the issue:
https://github.com/apache/spark/pull/22231
Removed the escaped backticks.
@HyukjinKwon Undefined names (F821) is a flake8 error, not a PyCodeStyle
error. That means that PyCodeStyle on its own (this PR) is unable to detect
Github user cclauss commented on the issue:
https://github.com/apache/spark/pull/22231
OK... Removed backticks and we are once again testing
./dev/run-tests-jenkins.py
---
-
To unsubscribe, e-mail: reviews
Github user cclauss commented on the issue:
https://github.com/apache/spark/pull/22231
OK... __# noqa__ works within the flake8 wrapper around PyFlakes but does
not work when PyFlakes is called outside of flake8. Also added r"comment" as
you
Github user cclauss commented on the issue:
https://github.com/apache/spark/pull/22231
@srowen Following the merge of #22400 there are just three W605s at the
bottom of
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96020/console
Should we __# noqa__ those lines
Github user cclauss commented on the issue:
https://github.com/apache/spark/pull/22231
Let's wait until #22400 is merged before proceeding with this PR.
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user cclauss commented on a diff in the pull request:
https://github.com/apache/spark/pull/22400#discussion_r216926889
--- Diff: dev/create-release/generate-contributors.py ---
@@ -88,7 +88,7 @@ def print_indented(_list):
def is_release(commit_title
Github user cclauss commented on the issue:
https://github.com/apache/spark/pull/22231
@srowen Could you please provide some test cases in Python 2 and Python 3
to prove that the changes that you propose will be properly interpreted without
side effects in both
Github user cclauss commented on a diff in the pull request:
https://github.com/apache/spark/pull/22266#discussion_r214201610
--- Diff: dev/lint-python ---
@@ -82,6 +82,25 @@ else
rm "$PYCODESTYLE_REPORT_PATH"
fi
+# stop the build if there are Pyt
Github user cclauss commented on a diff in the pull request:
https://github.com/apache/spark/pull/22266#discussion_r214196909
--- Diff: dev/lint-python ---
@@ -82,6 +82,26 @@ else
rm "$PYCODESTYLE_REPORT_PATH"
fi
+python -m pip install flake8
Github user cclauss commented on the issue:
https://github.com/apache/spark/pull/22266
@HyukjinKwon Done.
@viirya Done.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands
Github user cclauss commented on the issue:
https://github.com/apache/spark/pull/22266
These tests should fail until #22265 or similar is merged.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
GitHub user cclauss opened a pull request:
https://github.com/apache/spark/pull/22266
lint-python: Add flake8 tests to find Python syntax errors and undefiâ¦
â¦ned names
Add [flake8](http://flake8.pycqa.org) tests to find Python syntax errors
and undefined names
GitHub user cclauss opened a pull request:
https://github.com/apache/spark/pull/22265
Undefined name: from pyspark.util import _exception_message
[flake8](http://flake8.pycqa.org) testing of
https://github.com/apache/spark on Python 3.7.0
$ __flake8 . --count --select=E901
Github user cclauss commented on the issue:
https://github.com/apache/spark/pull/22231
https://issues.apache.org/jira/browse/SPARK-25238
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
GitHub user cclauss opened a pull request:
https://github.com/apache/spark/pull/22231
[MINOR][PYTHON] lint-python: Upgrade pycodestyle to v2.4.0
See https://pycodestyle.readthedocs.io/en/latest/developer.html#changes for
changes made in this release.
## What changes were
Github user cclauss closed the pull request at:
https://github.com/apache/spark/pull/22214
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
GitHub user cclauss opened a pull request:
https://github.com/apache/spark/pull/22214
[SPARK-23698][Python] Avoid 'undefined name' by defining __version__
## What changes were proposed in this pull request?
Prevent linters from raising __undefined name '\_\_version
Github user cclauss closed the pull request at:
https://github.com/apache/spark/pull/22128
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user cclauss commented on the issue:
https://github.com/apache/spark/pull/20838
Thanks massively for this. I doubt that I _ever_ would have gotten to that
on my own. This is a test so my proposal would be that _you create a separate
PR_ so that we are all assured
Github user cclauss commented on the issue:
https://github.com/apache/spark/pull/20838
This is not working at all... I am wasting way too much time. 5+ months
and 80+ comments for 12 lines of code is
I do not have the skills to solve the following undefined name 'long
Github user cclauss commented on the issue:
https://github.com/apache/spark/pull/20838
It was reverted because [__slice_test()__](#22128) was causing the build to
fail.
---
-
To unsubscribe, e-mail: reviews
GitHub user cclauss opened a pull request:
https://github.com/apache/spark/pull/22128
Add test_slice() to streaming BasicOperations
As suggested in
https://github.com/apache/spark/pull/20838#pullrequestreview-139118618
## What changes were proposed in this pull request
Github user cclauss commented on the issue:
https://github.com/apache/spark/pull/20838
jenkins, retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user cclauss commented on the issue:
https://github.com/apache/spark/pull/20838
@HyukjinKwon Your advise on next steps?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user cclauss commented on the issue:
https://github.com/apache/spark/pull/20838
jenkins, retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user cclauss commented on the issue:
https://github.com/apache/spark/pull/20838
May I please break this PR into pieces as I did in #21959 and #21960 so
that we can isolate why tests keep failing? These issues were all discovered
using the same (flake8 F821) technique
Github user cclauss commented on the issue:
https://github.com/apache/spark/pull/20838
Several are fixed it this PR. Some others are not fixable without
resorting to using __#noqa__.
---
-
To unsubscribe, e-mail
Github user cclauss closed the pull request at:
https://github.com/apache/spark/pull/21960
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user cclauss closed the pull request at:
https://github.com/apache/spark/pull/21959
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
GitHub user cclauss opened a pull request:
https://github.com/apache/spark/pull/21960
[SPARK-23698] Remove unused definitions of long and unicode
__intlike__ and __unicode__ were defined but not used in the existing code.
__basestring()__was removed in Python 3 in favor of __str
Github user cclauss commented on the issue:
https://github.com/apache/spark/pull/21959
As it says in the commit message, these changes are already in #20838 but
that PR has been open for 139 days and has 50+ comments. The only way that I
seem to make progress is by opening separate
GitHub user cclauss opened a pull request:
https://github.com/apache/spark/pull/21959
[SPARK-23698] Define xrange() for Python 3 in dumpdata_script.py
__xrange()__ was removed in Python 3 in favor of __range()__. This simple
change removes three Undefined Names was originally
Github user cclauss commented on the issue:
https://github.com/apache/spark/pull/20838
@holdenk Did we miss the window? I still count 10 undefined names in this
repo.
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user cclauss commented on a diff in the pull request:
https://github.com/apache/spark/pull/20838#discussion_r205933934
--- Diff: python/pyspark/streaming/tests.py ---
@@ -206,6 +207,22 @@ def func(dstream):
expected = [[len(x)] for x in input]
self
Github user cclauss commented on a diff in the pull request:
https://github.com/apache/spark/pull/20838#discussion_r205870627
--- Diff: dev/create-release/releaseutils.py ---
@@ -149,7 +152,11 @@ def get_commits(tag):
if not is_valid_author(author
Github user cclauss commented on a diff in the pull request:
https://github.com/apache/spark/pull/20838#discussion_r204094593
--- Diff: dev/create-release/releaseutils.py ---
@@ -149,7 +152,11 @@ def get_commits(tag):
if not is_valid_author(author
Github user cclauss commented on the issue:
https://github.com/apache/spark/pull/20838
Three (different) failures in a row. Should I break this PR into separate
PRs?
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user cclauss commented on the issue:
https://github.com/apache/spark/pull/21702
Tested data entry...
In __./dev/merge_spark_pr.py__ just after __clean_up()__, I added the lines:
```
while not continue_maybe('y to conntinue'):
print('loop')
sys.exit
Github user cclauss commented on a diff in the pull request:
https://github.com/apache/spark/pull/21702#discussion_r199723478
--- Diff: dev/create-release/releaseutils.py ---
@@ -49,13 +49,16 @@
print("Install using 'sudo pip install unidecode'")
s
GitHub user cclauss opened a pull request:
https://github.com/apache/spark/pull/21702
[SPARK-23698] Remove raw_input() from Python 2
Signed-off-by: cclauss
## What changes were proposed in this pull request?
Humans will be able to enter text in Python 3 prompts
Github user cclauss commented on a diff in the pull request:
https://github.com/apache/spark/pull/20838#discussion_r199701965
--- Diff: dev/merge_spark_pr.py ---
@@ -39,6 +39,9 @@
except ImportError:
JIRA_IMPORTED = False
+if sys.version_info[0] >
Github user cclauss commented on a diff in the pull request:
https://github.com/apache/spark/pull/20838#discussion_r199701953
--- Diff: python/pyspark/sql/conf.py ---
@@ -59,7 +62,7 @@ def unset(self, key):
def _checkType(self, obj, identifier
Github user cclauss commented on a diff in the pull request:
https://github.com/apache/spark/pull/20838#discussion_r199702001
--- Diff: dev/create-release/releaseutils.py ---
@@ -49,6 +49,9 @@
print("Install using 'sudo pip install unidecode'")
s
Github user cclauss commented on a diff in the pull request:
https://github.com/apache/spark/pull/20838#discussion_r181192109
--- Diff: python/pyspark/cloudpickle.py ---
@@ -802,9 +802,8 @@ def save_not_implemented(self, obj):
self.save_reduce(_gen_not_implemented
Github user cclauss commented on the issue:
https://github.com/apache/spark/pull/20838
Other issues / suggestions?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user cclauss commented on the issue:
https://github.com/apache/spark/pull/20838
The cloudpickle change is now merged upstream. I would like to avoid
@BryanCutler suggestion above because Unicode is really touchy in Python 2 and
a lot can change based
Github user cclauss commented on the issue:
https://github.com/apache/spark/pull/20838
@HyukjinKwon Was there something more to do on this one?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user cclauss commented on a diff in the pull request:
https://github.com/apache/spark/pull/20838#discussion_r175000559
--- Diff: dev/create-release/releaseutils.py ---
@@ -49,6 +49,11 @@
print("Install using 'sudo pip install unidecode'")
s
GitHub user cclauss opened a pull request:
https://github.com/apache/spark/pull/20838
[SPARK-23698] Resolve undefined names in Python 3
## What changes were proposed in this pull request?
Fix issues arising from the fact that __file__, __long__, __raw_input
50 matches
Mail list logo
