[GitHub] spark issue #22473: [SPARK-25449][CORE] Heartbeat shouldn't include accumula...

2018-09-27 Thread mukulmurthy
Github user mukulmurthy commented on the issue: https://github.com/apache/spark/pull/22473 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail

[GitHub] spark pull request #22473: [SPARK-25449][CORE] Heartbeat shouldn't include a...

2018-09-27 Thread mukulmurthy
Github user mukulmurthy commented on a diff in the pull request: https://github.com/apache/spark/pull/22473#discussion_r221026721 --- Diff: core/src/main/scala/org/apache/spark/SparkConf.scala --- @@ -609,13 +609,13 @@ class SparkConf(loadDefaults: Boolean) extends Cloneable

[GitHub] spark issue #22473: [SPARK-25449][CORE] Heartbeat shouldn't include accumula...

2018-09-27 Thread mukulmurthy
Github user mukulmurthy commented on the issue: https://github.com/apache/spark/pull/22473 Pushed updates. @zsxwing , I can add refactor Executor.scala so testing is easier, but I had hoped that doing it this way would allow more testing for reportHeartbeat in the future. We have

[GitHub] spark issue #22473: [SPARK-25449][CORE] Heartbeat shouldn't include accumula...

2018-09-19 Thread mukulmurthy
Github user mukulmurthy commented on the issue: https://github.com/apache/spark/pull/22473 @zsxwing for review --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail

[GitHub] spark pull request #22473: [SPARK-25449][CORE] Heartbeat shouldn't include a...

2018-09-19 Thread mukulmurthy
GitHub user mukulmurthy opened a pull request: https://github.com/apache/spark/pull/22473 [SPARK-25449][CORE] Heartbeat shouldn't include accumulators for zero metrics ## What changes were proposed in this pull request? Heartbeat shouldn't include accumulators for zero

[GitHub] spark pull request #22386: [SPARK-25399] Continuous processing state should ...

2018-09-11 Thread mukulmurthy
Github user mukulmurthy commented on a diff in the pull request: https://github.com/apache/spark/pull/22386#discussion_r216750746 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/StateStoreRDD.scala --- @@ -74,9 +74,14 @@ class StateStoreRDD[T

[GitHub] spark issue #22386: [SPARK-25399] Continuous processing state should not aff...

2018-09-11 Thread mukulmurthy
Github user mukulmurthy commented on the issue: https://github.com/apache/spark/pull/22386 > ``` > If a continuous processing job runs and the same thread gets reused for a microbatch execution job in the same environment > ``` > Little confuse about this sce

[GitHub] spark issue #22386: [SPARK-25399] Continuous processing state should not aff...

2018-09-10 Thread mukulmurthy
Github user mukulmurthy commented on the issue: https://github.com/apache/spark/pull/22386 @tdas and @jose-torres for review --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands

[GitHub] spark pull request #22386: [SPARK-25399] Continuous processing state should ...

2018-09-10 Thread mukulmurthy
GitHub user mukulmurthy opened a pull request: https://github.com/apache/spark/pull/22386 [SPARK-25399] Continuous processing state should not affect microbatch execution jobs ## What changes were proposed in this pull request? The leftover state from running a continuous

[GitHub] spark issue #22176: [SPARK-25181][CORE] Limit Thread Pool size in BlockManag...

2018-08-22 Thread mukulmurthy
Github user mukulmurthy commented on the issue: https://github.com/apache/spark/pull/22176 @zsxwing , @JoshRosen , @marmbrus for review and merge. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

[GitHub] spark issue #22176: [SPARK-25181][CORE] Limit Thread Pool size in BlockManag...

2018-08-21 Thread mukulmurthy
Github user mukulmurthy commented on the issue: https://github.com/apache/spark/pull/22176 Jenkins, retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e

[GitHub] spark issue #22176: [SPARK-25181][CORE] Limit Thread Pool size in BlockManag...

2018-08-21 Thread mukulmurthy
Github user mukulmurthy commented on the issue: https://github.com/apache/spark/pull/22176 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail

[GitHub] spark issue #22176: [SPARK-25181][CORE] Limit Thread Pool size in BlockManag...

2018-08-21 Thread mukulmurthy
Github user mukulmurthy commented on the issue: https://github.com/apache/spark/pull/22176 @JoshRosen @zsxwing @marmbrus to merge. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #22176: [SPARK-25181][CORE] Limit Thread Pool size in Blo...

2018-08-21 Thread mukulmurthy
GitHub user mukulmurthy opened a pull request: https://github.com/apache/spark/pull/22176 [SPARK-25181][CORE] Limit Thread Pool size in BlockManager Master and Slave endpoints ## What changes were proposed in this pull request? Limit Thread Pool size in BlockManager Master

[GitHub] spark issue #21662: [SPARK-24662][SQL][SS] Support limit in structured strea...

2018-07-09 Thread mukulmurthy
Github user mukulmurthy commented on the issue: https://github.com/apache/spark/pull/21662 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail

[GitHub] spark issue #21662: [SPARK-24662][SQL][SS] Support limit in structured strea...

2018-07-09 Thread mukulmurthy
Github user mukulmurthy commented on the issue: https://github.com/apache/spark/pull/21662 Jenkins, retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e

[GitHub] spark pull request #21662: [SPARK-24662][SQL][SS] Support limit in structure...

2018-07-02 Thread mukulmurthy
Github user mukulmurthy commented on a diff in the pull request: https://github.com/apache/spark/pull/21662#discussion_r199606669 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingLimitExec.scala --- @@ -0,0 +1,96 @@ +/* + * Licensed

[GitHub] spark pull request #21662: [SPARK-24662][SQL][SS] Support limit in structure...

2018-07-02 Thread mukulmurthy
Github user mukulmurthy commented on a diff in the pull request: https://github.com/apache/spark/pull/21662#discussion_r199582352 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingLimitExec.scala --- @@ -0,0 +1,96 @@ +/* + * Licensed

[GitHub] spark pull request #21662: [SPARK-24662][SQL][SS] Support limit in structure...

2018-06-29 Thread mukulmurthy
Github user mukulmurthy commented on a diff in the pull request: https://github.com/apache/spark/pull/21662#discussion_r199300670 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/MemorySinkSuite.scala --- @@ -70,35 +68,9 @@ class MemorySinkSuite extends

[GitHub] spark issue #21662: [SPARK-24662][SQL][SS] Support limit in structured strea...

2018-06-28 Thread mukulmurthy
Github user mukulmurthy commented on the issue: https://github.com/apache/spark/pull/21662 @tdas @marmbrus @jose-torres for review --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #21662: [SPARK-24662][SQL][SS] Support limit in structure...

2018-06-28 Thread mukulmurthy
Github user mukulmurthy commented on a diff in the pull request: https://github.com/apache/spark/pull/21662#discussion_r199006704 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala --- @@ -72,6 +72,8 @@ abstract class SparkStrategies extends

[GitHub] spark pull request #21662: [SPARK-24662][SQL][SS] Support limit in structure...

2018-06-28 Thread mukulmurthy
Github user mukulmurthy commented on a diff in the pull request: https://github.com/apache/spark/pull/21662#discussion_r199006582 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/UnsupportedOperationChecker.scala --- @@ -315,8 +315,10 @@ object

[GitHub] spark pull request #21662: [SPARK-24662][SQL][SS] Support limit in structure...

2018-06-28 Thread mukulmurthy
GitHub user mukulmurthy opened a pull request: https://github.com/apache/spark/pull/21662 [SPARK-24662][SQL][SS] Support limit in structured streaming ## What changes were proposed in this pull request? Support the LIMIT operator in structured streaming

[GitHub] spark pull request #21559: [SPARK-24525][SS] Provide an option to limit numb...

2018-06-15 Thread mukulmurthy
Github user mukulmurthy commented on a diff in the pull request: https://github.com/apache/spark/pull/21559#discussion_r195809395 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/memory.scala --- @@ -221,26 +222,72 @@ class MemoryStreamInputPartition

[GitHub] spark pull request #21559: [SPARK-24525][SS] Provide an option to limit numb...

2018-06-13 Thread mukulmurthy
Github user mukulmurthy commented on a diff in the pull request: https://github.com/apache/spark/pull/21559#discussion_r195268130 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/memory.scala --- @@ -294,6 +333,16 @@ class MemorySink(val schema

[GitHub] spark issue #21559: [SPARK-24525][SS] Provide an option to limit number of r...

2018-06-13 Thread mukulmurthy
Github user mukulmurthy commented on the issue: https://github.com/apache/spark/pull/21559 @jose-torres @brkyvz for review --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands

[GitHub] spark pull request #21559: [SPARK-24525][SS] Provide an option to limit numb...

2018-06-13 Thread mukulmurthy
GitHub user mukulmurthy opened a pull request: https://github.com/apache/spark/pull/21559 [SPARK-24525][SS] Provide an option to limit number of rows in a MemorySink ## What changes were proposed in this pull request? Provide an option to limit number of rows