Github user wangjiaochun commented on a diff in the pull request:
https://github.com/apache/spark/pull/23225#discussion_r239990587
--- Diff:
core/src/main/java/org/apache/spark/shuffle/sort/ShuffleExternalSorter.java ---
@@ -161,6 +161,10 @@ private void writeSortedFile(boolean
Github user wangjiaochun commented on a diff in the pull request:
https://github.com/apache/spark/pull/23225#discussion_r239990083
--- Diff:
core/src/test/java/org/apache/spark/shuffle/sort/UnsafeShuffleWriterSuite.java
---
@@ -235,6 +235,7 @@ public void writeEmptyIterator
Github user wangjiaochun commented on the issue:
https://github.com/apache/spark/pull/23225
Okey.@dongjoon-hyun
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user wangjiaochun commented on a diff in the pull request:
https://github.com/apache/spark/pull/23225#discussion_r239989805
--- Diff:
core/src/main/java/org/apache/spark/shuffle/sort/ShuffleExternalSorter.java ---
@@ -161,6 +161,10 @@ private void writeSortedFile(boolean
Github user wangjiaochun commented on a diff in the pull request:
https://github.com/apache/spark/pull/23225#discussion_r239711919
--- Diff:
core/src/test/java/org/apache/spark/shuffle/sort/UnsafeShuffleWriterSuite.java
---
@@ -562,4 +562,18 @@ public void testPeakMemoryUsed
Github user wangjiaochun commented on a diff in the pull request:
https://github.com/apache/spark/pull/23225#discussion_r239704796
--- Diff:
core/src/test/java/org/apache/spark/shuffle/sort/UnsafeShuffleWriterSuite.java
---
@@ -562,4 +562,18 @@ public void testPeakMemoryUsed
Github user wangjiaochun commented on a diff in the pull request:
https://github.com/apache/spark/pull/23225#discussion_r239700999
--- Diff:
core/src/test/java/org/apache/spark/shuffle/sort/UnsafeShuffleWriterSuite.java
---
@@ -562,4 +562,18 @@ public void testPeakMemoryUsed
Github user wangjiaochun commented on the issue:
https://github.com/apache/spark/pull/23247
ok! thanks, I will focus on commit bug later.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user wangjiaochun commented on the issue:
https://github.com/apache/spark/pull/23247
> @wangjiaochun, I think you better stop fixing trivial stuff in each PR.
Those stuff can be fixed when the codes around here is fixed, or let other
people fix it later.
ok! thanks
Github user wangjiaochun closed the pull request at:
https://github.com/apache/spark/pull/23246
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
GitHub user wangjiaochun opened a pull request:
https://github.com/apache/spark/pull/23247
[SPARK-26294][CORE]Delete Unnecessary If statement
## What changes were proposed in this pull request?
Delete unnecessary If statement, because it Impossible execution when
records
GitHub user wangjiaochun opened a pull request:
https://github.com/apache/spark/pull/23246
[SPARK-26292][CORE]Assert statement of currentPage may be not in right place
## What changes were proposed in this pull request?
The assert statement of currentPage is not in right placeï
Github user wangjiaochun commented on the issue:
https://github.com/apache/spark/pull/23229
ok,close this PR.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user wangjiaochun closed the pull request at:
https://github.com/apache/spark/pull/23229
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user wangjiaochun commented on the issue:
https://github.com/apache/spark/pull/23225
1. I think test case writeEmptyIterator in UnsafeShuffleWriterSuite.java
cover this scenes
2. I will propose a JIRA soon
Github user wangjiaochun commented on a diff in the pull request:
https://github.com/apache/spark/pull/23226#discussion_r239066440
--- Diff:
core/src/test/java/org/apache/spark/unsafe/map/AbstractBytesToBytesMapSuite.java
---
@@ -622,6 +622,17 @@ public void
GitHub user wangjiaochun opened a pull request:
https://github.com/apache/spark/pull/23229
[MINOR][CORE] Modify some field name because it may be cause confusion
## What changes were proposed in this pull request?
There is different field name style for tracking allocated data
GitHub user wangjiaochun opened a pull request:
https://github.com/apache/spark/pull/23226
[MINOR][TEST] Add MAXIMUM_PAGE_SIZE_BYTES Exception test
## What changes were proposed in this pull request?
Add MAXIMUM_PAGE_SIZE_BYTES Exception test
## How was this patch
GitHub user wangjiaochun opened a pull request:
https://github.com/apache/spark/pull/23225
[MINOR][CORE]Don't need to create an empty spill file when memory has no
records
## What changes were proposed in this pull request?
If there are no records in memory, then we don't need
Github user wangjiaochun commented on the issue:
https://github.com/apache/spark/pull/18474
Thanks,I will resolve all problems. @kiszk
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user wangjiaochun commented on the issue:
https://github.com/apache/spark/pull/18867
ok,I will update the PR title. @cloud-fan
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user wangjiaochun opened a pull request:
https://github.com/apache/spark/pull/18867
MapOutputTrackerSuite Utest
Signed-off-by: 10087686 <wang.jiaoc...@zte.com.cn>
## What changes were proposed in this pull request?
After Unit tests endï¼there should b
Github user wangjiaochun commented on the issue:
https://github.com/apache/spark/pull/18474
Yes, Running this on Windows7.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user wangjiaochun commented on the issue:
https://github.com/apache/spark/pull/18475
ok!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user wangjiaochun closed the pull request at:
https://github.com/apache/spark/pull/18475
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user wangjiaochun commented on the issue:
https://github.com/apache/spark/pull/18474
1. Test environment and test methodï¼IDEA project direct Run
BlockManagerSuite.scala.
2. I test this case again use step through,find this case
encryptionTest("on-disk storage&q
Github user wangjiaochun commented on the issue:
https://github.com/apache/spark/pull/18474
I have run this case many times,the memoryStore temp file will be
cleared,but the disk blocks is really not clear.
---
If your project is set up for it, you can reply to this email and have
GitHub user wangjiaochun opened a pull request:
https://github.com/apache/spark/pull/18475
[SPARK][Tests] assert messager not right
Signed-off-by: 10087686 <wang.jiaoc...@zte.com.cn>
## What changes were proposed in this pull request?
Modify the assert m
GitHub user wangjiaochun opened a pull request:
https://github.com/apache/spark/pull/18474
[SPARK-21235][SPARKR] UTest should clear temp results when run case
Signed-off-by: 10087686 <wang.jiaoc...@zte.com.cn>
## What changes were proposed in this pull request?
Github user wangjiaochun commented on the issue:
https://github.com/apache/spark/pull/18226
ok, I have re submit, Thanks for reviewing @srowen
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
GitHub user wangjiaochun opened a pull request:
https://github.com/apache/spark/pull/18226
[SPARK-21006][TESTS] Create rpcEnv and run later needs shutdown and
awaitTermination
Signed-off-by: 10087686 <wang.jiaoc...@zte.com.cn>
## What changes were proposed in thi
31 matches
Mail list logo
