Github user wmellouli commented on the issue:
https://github.com/apache/spark/pull/22332
PR closed: we can use select to add new columns in a user-defined position.
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user wmellouli closed the pull request at:
https://github.com/apache/spark/pull/22332
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user wmellouli commented on the issue:
https://github.com/apache/spark/pull/22332
@HyukjinKwon even instead of using the actual method `withColumn(colName:
String, col: Column)` we can just add a column and select. The idea from this
PR is to add more power/flexibility
Github user wmellouli commented on the issue:
https://github.com/apache/spark/pull/22332
@HyukjinKwon Thank you for your review. To answer to your question about
using `select`, take a look at my explaination
[here](https://github.com/apache/spark/pull/22332#issuecomment-418526562
Github user wmellouli commented on the issue:
https://github.com/apache/spark/pull/22332
@jaceklaskowski I refactored with what you suggested in your review. Let me
know what you think.
---
-
To unsubscribe, e-mail
Github user wmellouli commented on a diff in the pull request:
https://github.com/apache/spark/pull/22332#discussion_r215185048
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -2226,16 +2226,18 @@ class Dataset[T] private[sql](
* `column`'s
Github user wmellouli commented on a diff in the pull request:
https://github.com/apache/spark/pull/22332#discussion_r215184928
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala
---
@@ -831,13 +831,21 @@ class DataFrameSuite extends QueryTest
Github user wmellouli commented on a diff in the pull request:
https://github.com/apache/spark/pull/22332#discussion_r215179856
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -2226,16 +2226,18 @@ class Dataset[T] private[sql](
* `column`'s
Github user wmellouli commented on the issue:
https://github.com/apache/spark/pull/22332
@mgaido91 Thank you for your suggestion, I updated the PR name, description
and sources with a new version using a parameter `atPosition` instead of a flag
`atTheEnd`. Let me know what you think
GitHub user wmellouli opened a pull request:
https://github.com/apache/spark/pull/22332
[SPARK-25333][SQL] Ability add new columns in the beginning of Dataset
## What changes were proposed in this pull request?
When we add new columns in a Dataset, they are added
10 matches
Mail list logo
