Github user wmellouli commented on the issue:

    https://github.com/apache/spark/pull/22332
  
    @mgaido91 Thank you for your suggestion, I updated the PR name, description 
and sources with a new version using a parameter `atPosition` instead of a flag 
`atTheEnd`. Let me know what you think about this new implementation.
    
    @jaceklaskowski Thank your for your review. But here I'm discussing about 
the `withColumn` method  that allows **adding and/or replacing** existing 
columns with new column content. What you suggested does not manage replacing 
existing column content. The idea is to make the `withColumn` method more 
flexible with keeping the backward compatibility. Actually the `withColumn` 
method is useful only for one use case: add (maybe replace) column at the end. 
I changed the implementation with @mgaido91 suggestion to make `withColumn` 
useful for more use cases. Let me know what you think about this new 
implementation.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to