[GitHub] [spark] cloud-fan commented on a diff in pull request #43010: [SPARK-41086][SQL] Use DataFrame ID to semantically validate CollectMetrics

cloud-fan commented on code in PR #43010: URL: https://github.com/apache/spark/pull/43010#discussion_r1333740482 ## python/pyspark/sql/connect/plan.py: ## @@ -1192,6 +1192,7 @@ def plan(self, session: "SparkConnectClient") -> proto.Relation: assert self._child is not

[GitHub] [spark] cloud-fan commented on a diff in pull request #43010: [SPARK-41086][SQL] Use DataFrame ID to semantically validate CollectMetrics

cloud-fan commented on code in PR #43010: URL: https://github.com/apache/spark/pull/43010#discussion_r1333739719 ## python/pyspark/sql/connect/plan.py: ## @@ -1192,6 +1192,7 @@ def plan(self, session: "SparkConnectClient") -> proto.Relation: assert self._child is not

[GitHub] [spark] cloud-fan commented on a diff in pull request #43010: [SPARK-41086][SQL] Use DataFrame ID to semantically validate CollectMetrics

cloud-fan commented on code in PR #43010: URL: https://github.com/apache/spark/pull/43010#discussion_r1333739719 ## python/pyspark/sql/connect/plan.py: ## @@ -1192,6 +1192,7 @@ def plan(self, session: "SparkConnectClient") -> proto.Relation: assert self._child is not

[GitHub] [spark] cloud-fan commented on a diff in pull request #43010: [SPARK-41086][SQL] Use DataFrame ID to semantically validate CollectMetrics

cloud-fan commented on code in PR #43010: URL: https://github.com/apache/spark/pull/43010#discussion_r1332484719 ## sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/AnalysisSuite.scala: ## @@ -779,34 +779,35 @@ class AnalysisSuite extends AnalysisTest with

[GitHub] [spark] cloud-fan commented on a diff in pull request #43010: [SPARK-41086][SQL] Use DataFrame ID to semantically validate CollectMetrics

cloud-fan commented on code in PR #43010: URL: https://github.com/apache/spark/pull/43010#discussion_r1332484719 ## sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/AnalysisSuite.scala: ## @@ -779,34 +779,35 @@ class AnalysisSuite extends AnalysisTest with

[GitHub] [spark] cloud-fan commented on a diff in pull request #43010: [SPARK-41086][SQL] Use DataFrame ID to semantically validate CollectMetrics

cloud-fan commented on code in PR #43010: URL: https://github.com/apache/spark/pull/43010#discussion_r1332484136 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala: ## @@ -1097,17 +1097,15 @@ trait CheckAnalysis extends PredicateHelper

[GitHub] [spark] cloud-fan commented on a diff in pull request #43010: [SPARK-41086][SQL] Use DataFrame ID to semantically validate CollectMetrics

cloud-fan commented on code in PR #43010: URL: https://github.com/apache/spark/pull/43010#discussion_r1332483781 ## python/pyspark/sql/connect/plan.py: ## @@ -1197,6 +1197,7 @@ def plan(self, session: "SparkConnectClient") -> proto.Relation: