[GitHub] [spark] ulysses-you commented on a change in pull request #30368: [SPARK-33442][SQL] Change Combine Limit to Eliminate limit using max row

2020-11-16 Thread GitBox
ulysses-you commented on a change in pull request #30368: URL: https://github.com/apache/spark/pull/30368#discussion_r524888701 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala ## @@ -1452,11 +1452,27 @@ object

[GitHub] [spark] ulysses-you commented on a change in pull request #30368: [SPARK-33442][SQL] Change Combine Limit to Eliminate limit using max row

2020-11-16 Thread GitBox
ulysses-you commented on a change in pull request #30368: URL: https://github.com/apache/spark/pull/30368#discussion_r524803284 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala ## @@ -1452,11 +1452,27 @@ object

[GitHub] [spark] ulysses-you commented on a change in pull request #30368: [SPARK-33442][SQL] Change Combine Limit to Eliminate limit using max row

2020-11-16 Thread GitBox
ulysses-you commented on a change in pull request #30368: URL: https://github.com/apache/spark/pull/30368#discussion_r524804089 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala ## @@ -1452,11 +1452,27 @@ object

[GitHub] [spark] ulysses-you commented on a change in pull request #30368: [SPARK-33442][SQL] Change Combine Limit to Eliminate limit using max row

2020-11-16 Thread GitBox
ulysses-you commented on a change in pull request #30368: URL: https://github.com/apache/spark/pull/30368#discussion_r524803284 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala ## @@ -1452,11 +1452,27 @@ object

[GitHub] [spark] ulysses-you commented on a change in pull request #30368: [SPARK-33442][SQL] Change Combine Limit to Eliminate limit using max row

2020-11-16 Thread GitBox
ulysses-you commented on a change in pull request #30368: URL: https://github.com/apache/spark/pull/30368#discussion_r524038654 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala ## @@ -1452,11 +1452,27 @@ object

[GitHub] [spark] ulysses-you commented on a change in pull request #30368: [SPARK-33442][SQL] Change Combine Limit to Eliminate limit using max row

2020-11-16 Thread GitBox
ulysses-you commented on a change in pull request #30368: URL: https://github.com/apache/spark/pull/30368#discussion_r524034982 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala ## @@ -1452,11 +1452,27 @@ object

[GitHub] [spark] ulysses-you commented on a change in pull request #30368: [SPARK-33442][SQL] Change Combine Limit to Eliminate limit using max row

2020-11-15 Thread GitBox
ulysses-you commented on a change in pull request #30368: URL: https://github.com/apache/spark/pull/30368#discussion_r523851039 ## File path: sql/core/src/test/resources/tpcds-plan-stability/approved-plans-v1_4/q92/explain.txt ## @@ -1,5 +1,5 @@ == Physical Plan ==

[GitHub] [spark] ulysses-you commented on a change in pull request #30368: [SPARK-33442][SQL] Change Combine Limit to Eliminate limit using max row

2020-11-14 Thread GitBox
ulysses-you commented on a change in pull request #30368: URL: https://github.com/apache/spark/pull/30368#discussion_r523666452 ## File path: sql/core/src/test/resources/tpcds-plan-stability/approved-plans-v1_4/q92/explain.txt ## @@ -1,5 +1,5 @@ == Physical Plan ==

[GitHub] [spark] ulysses-you commented on a change in pull request #30368: [SPARK-33442][SQL] Change Combine Limit to Eliminate limit using max row

2020-11-14 Thread GitBox
ulysses-you commented on a change in pull request #30368: URL: https://github.com/apache/spark/pull/30368#discussion_r523666452 ## File path: sql/core/src/test/resources/tpcds-plan-stability/approved-plans-v1_4/q92/explain.txt ## @@ -1,5 +1,5 @@ == Physical Plan ==

[GitHub] [spark] ulysses-you commented on a change in pull request #30368: [SPARK-33442][SQL] Change Combine Limit to Eliminate limit using max row

2020-11-14 Thread GitBox
ulysses-you commented on a change in pull request #30368: URL: https://github.com/apache/spark/pull/30368#discussion_r523656874 ## File path: sql/core/src/test/resources/tpcds-plan-stability/approved-plans-v1_4/q92/explain.txt ## @@ -1,5 +1,5 @@ == Physical Plan ==

[GitHub] [spark] ulysses-you commented on a change in pull request #30368: [SPARK-33442][SQL] Change Combine Limit to Eliminate limit using max row

2020-11-14 Thread GitBox
ulysses-you commented on a change in pull request #30368: URL: https://github.com/apache/spark/pull/30368#discussion_r523596769 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala ## @@ -1452,11 +1452,21 @@ object

[GitHub] [spark] ulysses-you commented on a change in pull request #30368: [SPARK-33442][SQL] Change Combine Limit to Eliminate limit using max row

2020-11-14 Thread GitBox
ulysses-you commented on a change in pull request #30368: URL: https://github.com/apache/spark/pull/30368#discussion_r523422082 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala ## @@ -1452,11 +1452,21 @@ object

[GitHub] [spark] ulysses-you commented on a change in pull request #30368: [SPARK-33442][SQL] Change Combine Limit to Eliminate limit using max row

2020-11-13 Thread GitBox
ulysses-you commented on a change in pull request #30368: URL: https://github.com/apache/spark/pull/30368#discussion_r522975396 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala ## @@ -1452,11 +1452,23 @@ object

[GitHub] [spark] ulysses-you commented on a change in pull request #30368: [SPARK-33442][SQL] Change Combine Limit to Eliminate limit using max row

2020-11-13 Thread GitBox
ulysses-you commented on a change in pull request #30368: URL: https://github.com/apache/spark/pull/30368#discussion_r522960572 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala ## @@ -1452,11 +1452,23 @@ object

[GitHub] [spark] ulysses-you commented on a change in pull request #30368: [SPARK-33442][SQL] Change Combine Limit to Eliminate limit using max row

2020-11-13 Thread GitBox
ulysses-you commented on a change in pull request #30368: URL: https://github.com/apache/spark/pull/30368#discussion_r522958258 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala ## @@ -1452,11 +1452,23 @@ object

[GitHub] [spark] ulysses-you commented on a change in pull request #30368: [SPARK-33442][SQL] Change Combine Limit to Eliminate limit using max row

2020-11-13 Thread GitBox
ulysses-you commented on a change in pull request #30368: URL: https://github.com/apache/spark/pull/30368#discussion_r522826329 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala ## @@ -1452,11 +1452,23 @@ object