Github user rxin commented on the issue:
https://github.com/apache/spark/pull/15758
Mind closing this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15758
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68081/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15758
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15758
**[Test build #68081 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68081/consoleFull)**
for PR 15758 at commit
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/15758
ah you meant the assert in save itself.
I don't think we should remove it, since it is largely noop and might be
useful once we allow bucket in save...
---
If your project is set up for it,
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/15758
where's the assert?
```
private def getBucketSpec: Option[BucketSpec] = {
if (sortColumnNames.isDefined) {
require(numBuckets.isDefined, "sortBy must be used
Github user jaceklaskowski commented on the issue:
https://github.com/apache/spark/pull/15758
Thanks @rxin for looking into it. While reviewing that code I noticed the
call and thought I'd push it for review here since...`getBucketSpec` is
superfluous given
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/15758
Why is this the right thing to do?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15758
**[Test build #68081 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68081/consoleFull)**
for PR 15758 at commit
