Github user srowen commented on the issue:
https://github.com/apache/spark/pull/16250
The question is not whether there are downsides; there almost always some.
It's whether the upsides are bigger. We typically can't evaluate either of them
perfectly, but can take good guesses. The
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/16250
You missed the fact that people don't even think this is a big improvement
in usability.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user jaceklaskowski commented on the issue:
https://github.com/apache/spark/pull/16250
Just to have the list of the reasons not to accept the changes:
1. @rxin "just fyi this is going to be slower than the original code."
2. @shivaram "Its hard to profile these
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/16250
@jaceklaskowski please close it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user JoshRosen commented on the issue:
https://github.com/apache/spark/pull/16250
I agree with above comments and would be +1 to not performing further
review on this set of cosmetic changes. The reason why the DAGScheduler is
complicated isn't due to surface-level code issues
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/16250
+1 to what @srowen said.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/16250
I don't think these superficial changes meaningfully affect readability at
all, and I don't perceive that this is any significant barrier to anyone
modifying the code anyway. It's both an argument
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16250
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16250
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/69991/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16250
**[Test build #69991 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69991/consoleFull)**
for PR 16250 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16250
**[Test build #69991 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69991/consoleFull)**
for PR 16250 at commit
Github user jaceklaskowski commented on the issue:
https://github.com/apache/spark/pull/16250
Thanks @srowen for the review! I do understand your point and remember you
and @rxin have always been telling me that I should not touch code unless
there's a need for a change.
But
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16250
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16250
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/69988/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16250
**[Test build #69988 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69988/consoleFull)**
for PR 16250 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16250
**[Test build #69988 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69988/consoleFull)**
for PR 16250 at commit
16 matches
Mail list logo
