Github user jaceklaskowski commented on the issue:
https://github.com/apache/spark/pull/16475
Closed as per @rxin's request.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/16475
Can we please close this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user jaceklaskowski commented on the issue:
https://github.com/apache/spark/pull/16475
Partially agree @srowen. The reason for the change was `blockId.isShuffle`
condition that both methods use to do their shuffle-specific handling. The
change might not be the most correct one
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/16475
I'm not sure about this. The `getBlockData` method handles both the
shuffle/non-shuffle case separately too -- and will actually call back to
`getLocalBytes`. It is probably OK now, and won't result
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16475
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16475
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70914/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16475
**[Test build #70914 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70914/testReport)**
for PR 16475 at commit
Github user jaceklaskowski commented on the issue:
https://github.com/apache/spark/pull/16475
Proposed the changes since it made easier to understand the role of
`getBlockData` vs `getLocalBytes` and in the end `ShuffleBlockResolver`. I'm
not saying it should be accepted, but I'd
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16475
**[Test build #70914 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70914/testReport)**
for PR 16475 at commit
