Github user caneGuy commented on the issue:
https://github.com/apache/spark/pull/19168
Thanks @cloud-fan i will close this pr.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/19168
Technically speaking, `maxBytesInFlight` controls how many bytes are being
transferred in network, so we should decrease `bytesInFlight` once we get data
from the result queue. The actual memory
Github user caneGuy commented on the issue:
https://github.com/apache/spark/pull/19168
@cloud-fan Sorry for bothering you.Could you help review this?Thanks
---
-
To unsubscribe, e-mail:
Github user caneGuy commented on the issue:
https://github.com/apache/spark/pull/19168
Sorry for replying so late.
I add some benchmark testing for this pr @kiszk .
And @jerryshao could you help review this pr?Thanks
```
Running benchmark: Benchmark fetch before vs
Github user caneGuy commented on the issue:
https://github.com/apache/spark/pull/19168
Yes you are right @kiszk Benchmark on the way.I will put here later.Thanks
for your time @kiszk
---
-
To unsubscribe, e-mail:
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/19168
IIUC, this change defers sending requests to remote notes until
`releaseCurrentResultBuffer()` will be called.
Do you have any benchmark results to confirm no performance degradation?
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19168
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
