Github user jkbradley commented on the issue:
https://github.com/apache/spark/pull/19278
LGTM
Merging with master
Thanks @WeichenXu123 for the fix and for testing for backwards
compatibility!
---
-
To
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19278
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19278
**[Test build #82057 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82057/testReport)**
for PR 19278 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19278
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82057/
Test PASSed.
---
Github user WeichenXu123 commented on the issue:
https://github.com/apache/spark/pull/19278
@jkbradley Sure I tested the backwards compatibility. Part of the reason I
changed into `DefaultParamReader.getAndSetParams` is for backwards
compatibility.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19278
**[Test build #82057 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82057/testReport)**
for PR 19278 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19278
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81959/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19278
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19278
**[Test build #81959 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81959/testReport)**
for PR 19278 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19278
**[Test build #81959 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81959/testReport)**
for PR 19278 at commit
Github user WeichenXu123 commented on the issue:
https://github.com/apache/spark/pull/19278
@BryanCutler The reason I add `skipParams` is that, if we don't use
`DefaultParamReader.getAndSetParams`, we have to hardcoding all params which
are very troublesome. And every time we add new
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19278
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81927/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19278
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19278
**[Test build #81927 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81927/testReport)**
for PR 19278 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19278
**[Test build #81927 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81927/testReport)**
for PR 19278 at commit
Github user WeichenXu123 commented on the issue:
https://github.com/apache/spark/pull/19278
cc @BryanCutler Thanks!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
16 matches
Mail list logo
