Github user WeichenXu123 commented on the issue:
https://github.com/apache/spark/pull/19278
@BryanCutler The reason I add `skipParams` is that, if we don't use
`DefaultParamReader.getAndSetParams`, we have to hardcoding all params which
are very troublesome. And every time we add new params, we have to also update
the hardcoding params, it is very easy to forget and cause bug. But if use
`DefaultParamReader.getAndSetParams` but do not support `skipParams`, the
`estimatorParamMaps` is difficult to handle.
So this design is a balance of this concerns, although it makes the code a
little weird.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
