Github user mpjlu commented on the issue:
https://github.com/apache/spark/pull/19337
Because I don't have the environment to continue this work, I will close
it. Thanks.
---
-
To unsubscribe, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19337
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83012/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19337
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19337
**[Test build #83012 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83012/testReport)**
for PR 19337 at commit
Github user mpjlu commented on the issue:
https://github.com/apache/spark/pull/19337
Any comments for this?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19337
**[Test build #83012 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83012/testReport)**
for PR 19337 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19337
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82657/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19337
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19337
**[Test build #82657 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82657/testReport)**
for PR 19337 at commit
Github user mpjlu commented on the issue:
https://github.com/apache/spark/pull/19337
For the comments about change the name of epsilon and add setter in
localLADModel, we have agreed not to change it now after some offline
discussion.
Because epsilon doesn't control model
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19337
**[Test build #82657 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82657/testReport)**
for PR 19337 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19337
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82582/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19337
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19337
**[Test build #82582 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82582/testReport)**
for PR 19337 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19337
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19337
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82581/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19337
**[Test build #82581 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82581/testReport)**
for PR 19337 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19337
**[Test build #82582 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82582/testReport)**
for PR 19337 at commit
Github user mpjlu commented on the issue:
https://github.com/apache/spark/pull/19337
Thanks, @hhbyyh.
I will create a JIRA for python API
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19337
**[Test build #82581 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82581/testReport)**
for PR 19337 at commit
Github user WeichenXu123 commented on the issue:
https://github.com/apache/spark/pull/19337
+1 for updating ML API.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19337
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19337
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82219/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19337
**[Test build #82219 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82219/testReport)**
for PR 19337 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19337
**[Test build #82219 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82219/testReport)**
for PR 19337 at commit
Github user mpjlu commented on the issue:
https://github.com/apache/spark/pull/19337
Thanks @mgaido91 , I will update the ML api, maybe also python and java API.
---
-
To unsubscribe, e-mail:
Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/19337
I know, but you should add the parameter to the ml API, otherwise the
change is pointless.
---
-
To unsubscribe, e-mail:
Github user mpjlu commented on the issue:
https://github.com/apache/spark/pull/19337
For LDA, the implementation is in mllib, ml calls mllib.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/19337
As far as I know, mllib is not maintained anymore. You should add the
`epsilon` parameter to the new ml API.
---
-
To
Github user mpjlu commented on the issue:
https://github.com/apache/spark/pull/19337
Ok, thanks. we don't need to change the code here.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user WeichenXu123 commented on the issue:
https://github.com/apache/spark/pull/19337
`require` is better i think
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user mpjlu commented on the issue:
https://github.com/apache/spark/pull/19337
Sorry, I got wrong.
So you think assert is better here? now we use require.
---
-
To unsubscribe, e-mail:
Github user WeichenXu123 commented on the issue:
https://github.com/apache/spark/pull/19337
Why not possible ? `meanGammaChange` is always positive. The loop will
become `while (true) {...}`
and should use `require` instead of `assert`
---
Github user mpjlu commented on the issue:
https://github.com/apache/spark/pull/19337
Because epsilon is Double, negative value should not cause the code run
into dead loop. All other setting in LDA using require for check or no check.
Should we use assert only for this change?
---
Github user mpjlu commented on the issue:
https://github.com/apache/spark/pull/19337
OK, I will change it to assert.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user WeichenXu123 commented on the issue:
https://github.com/apache/spark/pull/19337
OK. But I'm afraid accidently negative value cause the code run into dead
loop. Maybe adding `assert` is better.
---
-
To
Github user mpjlu commented on the issue:
https://github.com/apache/spark/pull/19337
Not check is also ok, user should know epsilon > 0
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19337
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19337
**[Test build #82147 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82147/testReport)**
for PR 19337 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19337
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82147/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19337
**[Test build #82147 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82147/testReport)**
for PR 19337 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19337
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19337
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82144/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19337
**[Test build #82144 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82144/testReport)**
for PR 19337 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19337
**[Test build #82144 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82144/testReport)**
for PR 19337 at commit
45 matches
Mail list logo
