Github user srowen commented on the issue:
https://github.com/apache/spark/pull/19529
Maven is the build of reference... YMMV but I also have a bunch of trouble
with SBT whereas not with Maven. I'd honestly prefer we not support an SBT
build explicitly for reasons like this, though
Github user nkronenfeld commented on the issue:
https://github.com/apache/spark/pull/19529
hm... I was always testing with sbt, because maven was so slow to do
anything.
Will do
---
-
To unsubscribe,
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19529
I just reverted this PR. @nkronenfeld Could you submit another PR and
update the title to
`[SPARK-22308][test-maven] Support alternative unit testing styles in
external applications`?
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/19529
@nkronenfeld @gatorsmile I think this has been failing the master build
(Maven only) for a few days:
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19529
Thanks! Merged to master.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19529
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19529
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83074/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19529
**[Test build #83074 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83074/testReport)**
for PR 19529 at commit
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19529
LGTM pending Jenkins
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19529
**[Test build #83074 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83074/testReport)**
for PR 19529 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19529
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19529
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83046/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19529
**[Test build #83046 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83046/testReport)**
for PR 19529 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19529
**[Test build #83046 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83046/testReport)**
for PR 19529 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19529
**[Test build #3960 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3960/testReport)**
for PR 19529 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19529
**[Test build #3960 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3960/testReport)**
for PR 19529 at commit
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/19529
The Jenkins jobs get killed not-infrequently for various reasons. You can
ignore that and retest.
---
-
To unsubscribe, e-mail:
Github user nkronenfeld commented on the issue:
https://github.com/apache/spark/pull/19529
I assume the "unknown error code, -9" is:
[error] running
/home/jenkins/workspace/SparkPullRequestBuilder/build/sbt -Phadoop-2.6 -Pflume
-Phive-thriftserver -Pyarn -Pkafka-0-8
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19529
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83006/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19529
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19529
**[Test build #83006 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83006/testReport)**
for PR 19529 at commit
Github user nkronenfeld commented on the issue:
https://github.com/apache/spark/pull/19529
Yeah, as predicted, that made PlanTest very easy to review, but didn't do
as well with SQLTestUtils. I suspect I reordered functions and what-not when I
was moving stuff around.
If
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19529
**[Test build #83006 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83006/testReport)**
for PR 19529 at commit
Github user nkronenfeld commented on the issue:
https://github.com/apache/spark/pull/19529
@gatorsmile sounds good, giving that a try now... assuming tests pass,
I'll check it in and see if it's any better.
I've so far done this for PlanTest and SQLTestUtils
PlanTest I
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19529
I found a very simple way to reduce the line of changes.
Could you put the PlanTest and PlanTestBase in the same file? We can
refactor it later, if necessary. For example, in
Github user nkronenfeld commented on the issue:
https://github.com/apache/spark/pull/19529
@gatorsmile the code changes aren't huge - there's almost no new code here,
it's all just moving code around from one file to another in order to expose a
SharedSparkSession with no dependence
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19529
Generally, it makes sense to me. Since the code changes are pretty large
here, it is not very straightforward for us to review it. Do you mind if I
taking over some of them? Or could you split
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19529
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82969/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19529
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19529
**[Test build #82969 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82969/testReport)**
for PR 19529 at commit
Github user nkronenfeld commented on the issue:
https://github.com/apache/spark/pull/19529
Documentation removed as per @srowen 's request in the associated JIRA
issue [SPARK-22308]
---
-
To unsubscribe, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19529
**[Test build #82969 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82969/testReport)**
for PR 19529 at commit
Github user nkronenfeld commented on the issue:
https://github.com/apache/spark/pull/19529
nope, using lazy val initialization won't work - at the very least,
UnsafeKryoSerializerSuite modifies conf before context construction
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19529
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82895/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19529
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19529
**[Test build #82895 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82895/testReport)**
for PR 19529 at commit
36 matches
Mail list logo
